)]}'
{"integration/scripts/functions_qemu":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"2410fe5dddab8aef6ef3bf0650f2efa0853ddb17","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    ARCH\u003damd64"},{"line_number":35,"context_line":"    if [ $DISTRO \u003d\u003d \u0027ubuntu\u0027 ]; then"},{"line_number":36,"context_line":"        export DIB_RELEASE\u003d$RELEASE"},{"line_number":37,"context_line":"        export DIB_CLOUD_IMAGES\u003dcloud-images.ubuntu.com/$DIB_RELEASE/current"},{"line_number":38,"context_line":"        export DIB_USE_HWE_KERNEL"},{"line_number":39,"context_line":"        ARCH\u003d$(dpkg --print-architecture)"},{"line_number":40,"context_line":"    elif [ $DISTRO \u003d\u003d \u0027fedora\u0027 ]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5f7c97a3_870156b2","line":37,"updated":"2018-06-07 12:20:10.000000000","message":"according to the change in DIB, it looks like we could simply remove DIB_CLOUD_IMAGES and fix the problem.","commit_id":"ceab2f2e0090245724187dbe213f3a0e1337c124"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"6d67759e8e3f7ef7a7565df98c731fbf16524815","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    ARCH\u003damd64"},{"line_number":35,"context_line":"    if [ $DISTRO \u003d\u003d \u0027ubuntu\u0027 ]; then"},{"line_number":36,"context_line":"        export DIB_RELEASE\u003d$RELEASE"},{"line_number":37,"context_line":"        export DIB_CLOUD_IMAGES\u003dcloud-images.ubuntu.com/$DIB_RELEASE/current"},{"line_number":38,"context_line":"        export DIB_USE_HWE_KERNEL"},{"line_number":39,"context_line":"        ARCH\u003d$(dpkg --print-architecture)"},{"line_number":40,"context_line":"    elif [ $DISTRO \u003d\u003d \u0027fedora\u0027 ]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5f7c97a3_2a9b6766","line":37,"in_reply_to":"5f7c97a3_67c0bae1","updated":"2018-06-07 12:53:56.000000000","message":"OK, then this is fine to me(and leaving a comment here for what you though about it should be greate), thanks.\n\nAnd I think we have many things to do for improving trove integration. The current codebase of trove integration have not been well maintained for a long time, :( , I hope we could do some cleanup or refactoring in the future.","commit_id":"ceab2f2e0090245724187dbe213f3a0e1337c124"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"d085f4032b41215dc951d515711c6e9ac869b327","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    ARCH\u003damd64"},{"line_number":35,"context_line":"    if [ $DISTRO \u003d\u003d \u0027ubuntu\u0027 ]; then"},{"line_number":36,"context_line":"        export DIB_RELEASE\u003d$RELEASE"},{"line_number":37,"context_line":"        export DIB_CLOUD_IMAGES\u003dcloud-images.ubuntu.com/$DIB_RELEASE/current"},{"line_number":38,"context_line":"        export DIB_USE_HWE_KERNEL"},{"line_number":39,"context_line":"        ARCH\u003d$(dpkg --print-architecture)"},{"line_number":40,"context_line":"    elif [ $DISTRO \u003d\u003d \u0027fedora\u0027 ]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5f7c97a3_67c0bae1","line":37,"in_reply_to":"5f7c97a3_870156b2","updated":"2018-06-07 12:36:35.000000000","message":"yes，since the value set here is the default value defined in 10-cache-ubuntu-tarball, we can just remove this line. But concern about the origin code and we maybe change the default value someday in the future, so I prefer to keep this line. :)","commit_id":"ceab2f2e0090245724187dbe213f3a0e1337c124"}],"trove/tests/unittests/guestagent/test_backups.py":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"2410fe5dddab8aef6ef3bf0650f2efa0853ddb17","unresolved":false,"context_lines":[{"line_number":1136,"context_line":"        self.restore_runner.post_restore \u003d mock.Mock()"},{"line_number":1137,"context_line":"        self.assertRaises(exception.ProcessExecutionError,"},{"line_number":1138,"context_line":"                          self.restore_runner.restore)"},{"line_number":1139,"context_line":""},{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"class MySQLRestoreTests(trove_testtools.TestCase):"},{"line_number":1142,"context_line":""},{"line_number":1143,"context_line":"    def setUp(self):"},{"line_number":1144,"context_line":"        super(MySQLRestoreTests, self).setUp()"},{"line_number":1145,"context_line":""},{"line_number":1146,"context_line":"        self.restore_runner \u003d utils.import_class("},{"line_number":1147,"context_line":"            RESTORE_XTRA_CLS)("},{"line_number":1148,"context_line":"                \u0027swift\u0027, location\u003d\u0027http://some.where\u0027,"},{"line_number":1149,"context_line":"                checksum\u003d\u0027True_checksum\u0027,"},{"line_number":1150,"context_line":"                restore_location\u003d\u0027/tmp/somewhere\u0027)"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"    def tearDown(self):"},{"line_number":1153,"context_line":"        super(MySQLRestoreTests, self).tearDown()"},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"    def test_restore_success(self):"},{"line_number":1156,"context_line":"        expected_content_length \u003d 123"},{"line_number":1157,"context_line":"        self.restore_runner._run_restore \u003d mock.Mock("},{"line_number":1158,"context_line":"            return_value\u003dexpected_content_length)"},{"line_number":1159,"context_line":"        self.restore_runner.pre_restore \u003d mock.Mock()"},{"line_number":1160,"context_line":"        self.restore_runner.post_restore \u003d mock.Mock()"},{"line_number":1161,"context_line":"        actual_content_length \u003d self.restore_runner.restore()"},{"line_number":1162,"context_line":"        self.assertEqual("},{"line_number":1163,"context_line":"            expected_content_length, actual_content_length)"},{"line_number":1164,"context_line":""},{"line_number":1165,"context_line":"    def test_restore_failed_due_to_run_restore(self):"},{"line_number":1166,"context_line":"        self.restore_runner.pre_restore \u003d mock.Mock()"},{"line_number":1167,"context_line":"        self.restore_runner._run_restore \u003d mock.Mock("},{"line_number":1168,"context_line":"            side_effect\u003drestoreBase.RestoreError(\u0027Error\u0027))"},{"line_number":1169,"context_line":"        self.restore_runner.post_restore \u003d mock.Mock()"},{"line_number":1170,"context_line":"        self.assertRaises(restoreBase.RestoreError,"},{"line_number":1171,"context_line":"                          self.restore_runner.restore)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a771f246","line":1171,"range":{"start_line":1139,"start_character":0,"end_line":1171,"end_character":54},"updated":"2018-06-07 12:20:10.000000000","message":"I was thinking to add unittests just for check_process, there\u0027s some testcases in trove/tests/unittests/backup/test_backupagent.py, but those ones only fix to a return value of \u0027False\u0027.","commit_id":"ceab2f2e0090245724187dbe213f3a0e1337c124"}]}
