)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"13fcb278e16ae3589943c540832d4373e69f04f0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"   unable/disable insecure/secure query logging,"},{"line_number":16,"context_line":"   default value for insecure logging - False;"},{"line_number":17,"context_line":" - engine init parameter echo depends on config value"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I2e0e5970a981f16ce1abe96f012ed7618f57287a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2BxtI%3D","line":18,"updated":"2013-11-20 10:44:20.000000000","message":"I see, that patch\u0027s topic is \"bug/1224700\". Is this patch fixes this bug? If yes - please  add this information to commit message","commit_id":"4b7a4b63514a061879ea0c60f5c15f4b61f40f7c"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"541fb1f4e5863fff497ef61442aad0e37cbbee5e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"   default value for insecure logging - False;"},{"line_number":17,"context_line":" - engine init parameter echo depends on config value"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Fixes: bug #1224700"},{"line_number":20,"context_line":"Change-Id: I2e0e5970a981f16ce1abe96f012ed7618f57287a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2BxMw%3D","line":19,"updated":"2013-11-20 13:08:26.000000000","message":"nit: Closes-Bug: #123456\nsee - https://wiki.openstack.org/wiki/Gerrit_Workflow#Committing_Changes","commit_id":"122ea80a57268da7f9778d2e2a6603f76bff8ded"}],"etc/trove/trove-guestagent.conf.sample":[{"author":{"_account_id":8188,"name":"Ilya Sviridov","email":"sviridov.ilya@gmail.com","username":"isviridov"},"change_message_id":"aa9a15f0102a4368477eb448b24bfb082e6cc672","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#sql_connection \u003d postgresql://trove:trove@10.0.0.1/trove"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"#Allow SQLAlchemy to log all queries"},{"line_number":25,"context_line":"insecure_query_logging \u003d True"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Period in seconds after which SQLAlchemy should reestablish its connection"},{"line_number":28,"context_line":"# to the database."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAATn%2F%2BxGc%3D","line":25,"updated":"2013-11-20 13:48:29.000000000","message":"I would suggest more specific parameter name, as far as value is specific for SQLAlchemy and can be True, False or debug.\nIn trove we just transparently passing it. \nF.e. sqlalchemy_echo","commit_id":"122ea80a57268da7f9778d2e2a6603f76bff8ded"}],"trove/common/cfg.py":[{"author":{"_account_id":8188,"name":"Ilya Sviridov","email":"sviridov.ilya@gmail.com","username":"isviridov"},"change_message_id":"aa9a15f0102a4368477eb448b24bfb082e6cc672","unresolved":false,"context_lines":[{"line_number":223,"context_line":"               default\u003d\u0027/etc/trove/templates/\u0027,"},{"line_number":224,"context_line":"               help\u003d\u0027Path which leads to datastore templates\u0027),"},{"line_number":225,"context_line":"    cfg.BoolOpt(\u0027insecure_query_logging\u0027, default\u003dFalse,"},{"line_number":226,"context_line":"                help\u003d\u0027Allow insecure logging while while \u0027"},{"line_number":227,"context_line":"                     \u0027executing queries through sqlalchemy\u0027),"},{"line_number":228,"context_line":"]"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BxF8%3D","line":226,"updated":"2013-11-20 13:48:29.000000000","message":"Actually it sets \u0027echo\u0027 parameter in SQLAlchemy and not connected to any security IMHO.","commit_id":"122ea80a57268da7f9778d2e2a6603f76bff8ded"}]}