)]}'
{"trove/guestagent/datastore/experimental/redis/service.py":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"da82350dcdf4e6bf576c931e21547856bd725c17","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":"    Handles all of the status updating for the redis guest agent."},{"line_number":48,"context_line":"    \"\"\""},{"line_number":49,"context_line":"    # TODO(songjian):Our redis cluster does not yet support mounting"},{"line_number":50,"context_line":"    # configuration. This leads to the fact that when we need to"},{"line_number":51,"context_line":"    # manually add requirepass to redis.conf for security reasons,"},{"line_number":52,"context_line":"    # this action will not be perceived by the trove-guestagent."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_63b9e177","line":49,"updated":"2018-06-15 07:10:19.000000000","message":"This breaks many unitests, and I think it\u0027s not correct to duplicate codes in RedisApp, admin client is initialized there and passed to RedisAppStatus, when things like \u0027requirepass\u0027 changed and admin client needs to be updated, the action also need to be taken inside RedisApp, not in RedisApp.\n\nAs we\u0027re using enable/disable_root interface for this purpose in Redis guestagent, I was thinking \u0027requirepass\u0027 have been removed from Redis configuration validation-rules, and is surprised the parameter is still there.For further changes, I think we should add support enable/disable_root support for Redis cluster strategy.\n\nI also think Redis configuration support is a good feature, after reading the current cluster configuration implementations:\nhttps://review.openstack.org/#/c/417487/\nIt seems maybe we could simple enable these interfaces for Redis and Mongo(though not fully investigated yet). I have no idea why the previous patch only made it available in galera and cassandra.","commit_id":"207f2727efc189f15114bb8958ed32dc5e1b6384"}]}