)]}'
{"trove/tests/api/instances_actions.py":[{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"d1dcc96bf1acd7b7301a09fc964dee0226f4a12a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    default_value \u003d cfg.CONF.resize_time_out"},{"line_number":95,"context_line":"    value_from_env \u003d os.environ.get(\"TROVE_RESIZE_TIME_OUT\", None)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    if value_from_env is not None:"},{"line_number":98,"context_line":"        return int(value_from_env)"},{"line_number":99,"context_line":"    else:"},{"line_number":100,"context_line":"        return default_value"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_9f4ba826","line":97,"range":{"start_line":97,"start_character":33,"end_line":97,"end_character":34},"updated":"2018-07-05 01:39:38.000000000","message":"Is it better to use \"if value_from_env\" or just use \"return int(value_from_env) if value_from_env else CONF.resize_time_out\" directly. :)","commit_id":"c60249de0fff0deb8cb1297f40a33d1c455ab712"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"28ada01f8a6099a9e047309fc66fc71d7f17a098","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    default_value \u003d cfg.CONF.resize_time_out"},{"line_number":95,"context_line":"    value_from_env \u003d os.environ.get(\"TROVE_RESIZE_TIME_OUT\", None)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    if value_from_env is not None:"},{"line_number":98,"context_line":"        return int(value_from_env)"},{"line_number":99,"context_line":"    else:"},{"line_number":100,"context_line":"        return default_value"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_bde18cd1","line":97,"range":{"start_line":97,"start_character":33,"end_line":97,"end_character":34},"in_reply_to":"5f7c97a3_9f4ba826","updated":"2018-07-09 15:08:14.000000000","message":"Right, that looks much more compact, thanks, :)","commit_id":"c60249de0fff0deb8cb1297f40a33d1c455ab712"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"dcd774df4ea2d158167a7f13b24343ec1407dd39","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    default_value \u003d cfg.CONF.resize_time_out"},{"line_number":95,"context_line":"    value_from_env \u003d os.environ.get(\"TROVE_RESIZE_TIME_OUT\", None)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    if value_from_env is not None:"},{"line_number":98,"context_line":"        return int(value_from_env)"},{"line_number":99,"context_line":"    else:"},{"line_number":100,"context_line":"        return default_value"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_7db0d48b","line":97,"range":{"start_line":97,"start_character":33,"end_line":97,"end_character":34},"in_reply_to":"5f7c97a3_bde18cd1","updated":"2018-07-09 15:17:45.000000000","message":"I found it\u0027s a bit long line if the one-liner is used, so I still use a two-line if clause with all extra lines are removed.","commit_id":"c60249de0fff0deb8cb1297f40a33d1c455ab712"}]}