)]}'
{"trove/common/template.py":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"7429c1c7787b8e9ee798219f100d630e38d31d41","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                       pattern\u003dtemplate_filename)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def load_guest_info(datastore_manager):"},{"line_number":76,"context_line":"    template_filename \u003d \"%s/guest_info.config\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    return load_entity(datastore_manager,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BXqU%3D","line":75,"updated":"2013-11-26 20:41:15.000000000","message":"I think this should be more like the database config, IE this should use the power of Jinja for rendering the template with params. So the render on the guest info should take kwargs.","commit_id":"e8ba9755686f6772484ea80836423f3f62d4c518"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"63565b4b5f5a272770e5a0341aea61b61ae4e8d3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                       pattern\u003dtemplate_filename)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def load_guest_info(datastore_manager):"},{"line_number":76,"context_line":"    template_filename \u003d \"%s/guest_info.config\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    return load_entity(datastore_manager,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BXjg%3D","line":75,"in_reply_to":"AAAATn%2F%2BXqU%3D","updated":"2013-11-26 20:46:13.000000000","message":"it\u0027s not database config - it\u0027s trove instance additional config, short version - guest_info","commit_id":"e8ba9755686f6772484ea80836423f3f62d4c518"}],"trove/taskmanager/models.py":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"7429c1c7787b8e9ee798219f100d630e38d31d41","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            guest_info \u003d template.load_guest_info(datastore_manager)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"            files \u003d {\"/etc/guest_info\": guest_info"},{"line_number":296,"context_line":"                     % {\u0027guest_id\u0027: self.id,"},{"line_number":297,"context_line":"                        \u0027tenant_id\u0027: self.tenant_id}}"},{"line_number":298,"context_line":"            if os.path.isfile(CONF.get(\u0027guest_config\u0027)):"},{"line_number":299,"context_line":"                with open(CONF.get(\u0027guest_config\u0027), \"r\") as f:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BXm0%3D","line":296,"updated":"2013-11-26 20:41:15.000000000","message":"This info should be passed as kwargs to the load template","commit_id":"e8ba9755686f6772484ea80836423f3f62d4c518"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"63565b4b5f5a272770e5a0341aea61b61ae4e8d3","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            guest_info \u003d template.load_guest_info(datastore_manager)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"            files \u003d {\"/etc/guest_info\": guest_info"},{"line_number":296,"context_line":"                     % {\u0027guest_id\u0027: self.id,"},{"line_number":297,"context_line":"                        \u0027tenant_id\u0027: self.tenant_id}}"},{"line_number":298,"context_line":"            if os.path.isfile(CONF.get(\u0027guest_config\u0027)):"},{"line_number":299,"context_line":"                with open(CONF.get(\u0027guest_config\u0027), \"r\") as f:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BXkU%3D","line":296,"in_reply_to":"AAAATn%2F%2BXm0%3D","updated":"2013-11-26 20:46:13.000000000","message":"thanks","commit_id":"e8ba9755686f6772484ea80836423f3f62d4c518"}],"trove/templates/mysql/guest_info.config":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"7429c1c7787b8e9ee798219f100d630e38d31d41","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"guest_id \u003d %(guest_id)s"},{"line_number":3,"context_line":"tenant_id \u003d %(tenant_id)s"},{"line_number":4,"context_line":"datastore_manager \u003d mysql"},{"line_number":5,"context_line":"backup_strategy \u003d InnoBackupEx"}],"source_content_type":"text/x-ini","patch_set":2,"id":"AAAATn%2F%2BXmY%3D","line":2,"updated":"2013-11-26 20:41:15.000000000","message":"guest_id \u003d {{ guest_id }}\ntenant_id \u003d {{ tenant_id }}","commit_id":"e8ba9755686f6772484ea80836423f3f62d4c518"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"63565b4b5f5a272770e5a0341aea61b61ae4e8d3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"guest_id \u003d %(guest_id)s"},{"line_number":3,"context_line":"tenant_id \u003d %(tenant_id)s"},{"line_number":4,"context_line":"datastore_manager \u003d mysql"},{"line_number":5,"context_line":"backup_strategy \u003d InnoBackupEx"}],"source_content_type":"text/x-ini","patch_set":2,"id":"AAAATn%2F%2BXkY%3D","line":2,"in_reply_to":"AAAATn%2F%2BXmY%3D","updated":"2013-11-26 20:46:13.000000000","message":"yeah, i thought about that.","commit_id":"e8ba9755686f6772484ea80836423f3f62d4c518"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"a4314881b6728f9cf263f292380f1cdedbf52249","unresolved":false,"context_lines":[{"line_number":4,"context_line":"datastore_manager \u003d mysql"},{"line_number":5,"context_line":"backup_strategy \u003d InnoBackupEx"},{"line_number":6,"context_line":"mount_point \u003d /var/lib/mysql"},{"line_number":7,"context_line":"service_registry_ext \u003d mysql:trove.guestagent.datastore.mysql.manager.Manager"}],"source_content_type":"text/x-ini","patch_set":2,"id":"AAAATn%2F%2BVlE%3D","line":7,"updated":"2013-11-27 08:30:28.000000000","message":"Having a guest_info per datastore you don\u0027t ever need the registry on the GA side, coz we can just pass the Manager\u0027s class. Of course, we\u0027ll still need the registry on server-side","commit_id":"e8ba9755686f6772484ea80836423f3f62d4c518"}]}