)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"446ed0ad27c0d29695b1e96d398e5025ece03d0b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When I config the volume-support\u003dFalse and device_path \u003d"},{"line_number":10,"context_line":"and then creating an instance successfully. But when I"},{"line_number":11,"context_line":"resize the instance flavor, it faied with"},{"line_number":12,"context_line":"\"LocalStorageNotSpecified: Local storage not specified"},{"line_number":13,"context_line":" in flavor ID\""},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_2d3198ef","line":11,"range":{"start_line":11,"start_character":31,"end_line":11,"end_character":36},"updated":"2018-08-02 21:34:59.000000000","message":"Typo: faied -\u003e failed.","commit_id":"3a369440460e6f191e3c5f9529b8263a4647f33f"},{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"446ed0ad27c0d29695b1e96d398e5025ece03d0b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"In the code, when volume-support is False, it will check"},{"line_number":16,"context_line":"the device_path is None or not, but if config the"},{"line_number":17,"context_line":"device_path\u003d  , it be regarded as not None."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #1783244"},{"line_number":20,"context_line":"Change-Id: I6b191da2b54999e5410146e2be8d93f0ca530473"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_ad81284f","line":17,"updated":"2018-08-02 21:34:59.000000000","message":"Please, add note that oslo.config parses the value of \"device_path\u003d\" into an empty string and this is the reason why it passes the \"is not None\" condition.","commit_id":"3a369440460e6f191e3c5f9529b8263a4647f33f"}],"trove/instance/models.py":[{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"446ed0ad27c0d29695b1e96d398e5025ece03d0b","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"        if self.volume_support:"},{"line_number":1145,"context_line":"            if new_flavor.ephemeral !\u003d 0:"},{"line_number":1146,"context_line":"                raise exception.LocalStorageNotSupported()"},{"line_number":1147,"context_line":"        elif self.device_path:"},{"line_number":1148,"context_line":"            # ephemeral support enabled"},{"line_number":1149,"context_line":"            if new_flavor.ephemeral \u003d\u003d 0:"},{"line_number":1150,"context_line":"                raise exception.LocalStorageNotSpecified(flavor\u003dnew_flavor_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a8fcb60b","line":1147,"updated":"2018-08-02 21:34:59.000000000","message":"The change should fix the issue.\n\nI\u0027m wondering, however, how allowing empty value for \"device_path\" impacts other places in the code. In my opinion, putting \"device_path \u003d\" without value into configuration is invalid and should be reported to the user - by putting a key user expressed an intent, but empty value is invalid as device path.\n\nWe should consider enforcing value by adding \"required\" flag to some options in the configuration or enhance definitions by regex.","commit_id":"3a369440460e6f191e3c5f9529b8263a4647f33f"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"862a5555e01f2b5d028e43c8fc92e60773e2fbf2","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"        if self.volume_support:"},{"line_number":1145,"context_line":"            if new_flavor.ephemeral !\u003d 0:"},{"line_number":1146,"context_line":"                raise exception.LocalStorageNotSupported()"},{"line_number":1147,"context_line":"        elif self.device_path:"},{"line_number":1148,"context_line":"            # ephemeral support enabled"},{"line_number":1149,"context_line":"            if new_flavor.ephemeral \u003d\u003d 0:"},{"line_number":1150,"context_line":"                raise exception.LocalStorageNotSpecified(flavor\u003dnew_flavor_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_13f3780c","line":1147,"in_reply_to":"5f7c97a3_88b45af6","updated":"2018-08-07 13:07:05.000000000","message":"By design, we have:\n* while volume_support is disabled\n  * if device_path is set, nova local disks are used;\n  * otherwise, nova ephmeral disks are used.\n\nHowever:\n* checking device_path is not consistent in different code path;\n* the actual device path is in fact controller by the underly hypervisor and the guest OS.\n\nIt may not easy to get a correct regex matching the actual device path, so for now the solution may be add some helper methods or logic to determine whether local or ephemeral disks are used, and use them consistently.","commit_id":"3a369440460e6f191e3c5f9529b8263a4647f33f"},{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"5371602c51c217f22812377084d993cfc2921016","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"        if self.volume_support:"},{"line_number":1145,"context_line":"            if new_flavor.ephemeral !\u003d 0:"},{"line_number":1146,"context_line":"                raise exception.LocalStorageNotSupported()"},{"line_number":1147,"context_line":"        elif self.device_path:"},{"line_number":1148,"context_line":"            # ephemeral support enabled"},{"line_number":1149,"context_line":"            if new_flavor.ephemeral \u003d\u003d 0:"},{"line_number":1150,"context_line":"                raise exception.LocalStorageNotSpecified(flavor\u003dnew_flavor_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_88b45af6","line":1147,"in_reply_to":"5f7c97a3_a8fcb60b","updated":"2018-08-02 21:38:30.000000000","message":"Of course, this is an idea that should be developed in a separate change.","commit_id":"3a369440460e6f191e3c5f9529b8263a4647f33f"}]}
