)]}'
{"trove/guestagent/strategies/backup/mysql_impl.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"bb6583dca8b5c0ccf1679e6b123e88040ea31c79","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @property"},{"line_number":30,"context_line":"    def cmd(self):"},{"line_number":31,"context_line":"        cmd \u003d (\u0027/usr/bin/mysqldump\u0027"},{"line_number":32,"context_line":"               \u0027 --all-databases\u0027"},{"line_number":33,"context_line":"               \u0027 %(extra_opts)s\u0027"},{"line_number":34,"context_line":"               \u0027 --opt\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9Zpk%3D","side":"PARENT","line":31,"updated":"2013-12-11 23:40:33.000000000","message":"maybe it should stay, because paths could be dropped, or not even initialized, that is why better to keep full path to executable.","commit_id":"4790ba1f04b95d888154ed3652a350c01cd3be77"}],"trove/guestagent/strategies/restore/mysql_impl.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"bb6583dca8b5c0ccf1679e6b123e88040ea31c79","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class MySQLRestoreMixin(object):"},{"line_number":32,"context_line":"    \"\"\"Common utils for restoring MySQL databases\"\"\""},{"line_number":33,"context_line":"    RESET_ROOT_RETRY_TIMEOUT \u003d 100"},{"line_number":34,"context_line":"    RESET_ROOT_SLEEP_INTERVAL \u003d 10"},{"line_number":35,"context_line":"    RESET_ROOT_MYSQL_COMMAND \u003d (\"SET PASSWORD FOR\""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9Zo0%3D","line":32,"updated":"2013-12-11 23:40:33.000000000","message":"missing dot","commit_id":"c11bcd50acfb66fc31a1523e853c1e515885a79c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"bb6583dca8b5c0ccf1679e6b123e88040ea31c79","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    def post_restore(self):"},{"line_number":131,"context_line":"        self._run_prepare()"},{"line_number":132,"context_line":"        utils.execute_with_timeout(\"sudo\", \"chown\", \"-R\", \"-f\","},{"line_number":133,"context_line":"                                   \"mysql\", self.restore_location)"},{"line_number":134,"context_line":"        self._delete_old_binlogs()"},{"line_number":135,"context_line":"        self.reset_root_password()"},{"line_number":136,"context_line":"        app \u003d dbaas.MySqlApp(dbaas.MySqlAppStatus.get())"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9ZpE%3D","line":133,"updated":"2013-12-11 23:40:33.000000000","message":"i\u0027d like, also, return origin rights to restore location, as it done at line #121","commit_id":"c11bcd50acfb66fc31a1523e853c1e515885a79c"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"e2374c8407379ada3abcfe6dff4b7aa321a7ec55","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    def post_restore(self):"},{"line_number":131,"context_line":"        self._run_prepare()"},{"line_number":132,"context_line":"        utils.execute_with_timeout(\"sudo\", \"chown\", \"-R\", \"-f\","},{"line_number":133,"context_line":"                                   \"mysql\", self.restore_location)"},{"line_number":134,"context_line":"        self._delete_old_binlogs()"},{"line_number":135,"context_line":"        self.reset_root_password()"},{"line_number":136,"context_line":"        app \u003d dbaas.MySqlApp(dbaas.MySqlAppStatus.get())"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9T2c%3D","line":133,"in_reply_to":"AAAATn%2F9UeE%3D","updated":"2013-12-12 19:38:40.000000000","message":"Agreed, if there is some issue with the mode of the restored files, then we should fix that as part of a separate bug.\n\n(Also, I think innobackupex preserves the mod of the files on restore, so I think we should be good. Would be a good idea to to double-check, thought).","commit_id":"c11bcd50acfb66fc31a1523e853c1e515885a79c"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"567f579cc30391ef1a7aa75a63f9f925bb78e135","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    def post_restore(self):"},{"line_number":131,"context_line":"        self._run_prepare()"},{"line_number":132,"context_line":"        utils.execute_with_timeout(\"sudo\", \"chown\", \"-R\", \"-f\","},{"line_number":133,"context_line":"                                   \"mysql\", self.restore_location)"},{"line_number":134,"context_line":"        self._delete_old_binlogs()"},{"line_number":135,"context_line":"        self.reset_root_password()"},{"line_number":136,"context_line":"        app \u003d dbaas.MySqlApp(dbaas.MySqlAppStatus.get())"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9UeE%3D","line":133,"in_reply_to":"AAAATn%2F9VG0%3D","updated":"2013-12-12 17:38:45.000000000","message":"This pull request is just moving the code around, not changing it, so why should it be -1\u0027d?","commit_id":"c11bcd50acfb66fc31a1523e853c1e515885a79c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"3db3d57425e0297178ac5a6cd9d3018d8ae90612","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    def post_restore(self):"},{"line_number":131,"context_line":"        self._run_prepare()"},{"line_number":132,"context_line":"        utils.execute_with_timeout(\"sudo\", \"chown\", \"-R\", \"-f\","},{"line_number":133,"context_line":"                                   \"mysql\", self.restore_location)"},{"line_number":134,"context_line":"        self._delete_old_binlogs()"},{"line_number":135,"context_line":"        self.reset_root_password()"},{"line_number":136,"context_line":"        app \u003d dbaas.MySqlApp(dbaas.MySqlAppStatus.get())"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9VG0%3D","line":133,"in_reply_to":"AAAATn%2F9VJk%3D","updated":"2013-12-12 15:51:54.000000000","message":"I mean that before restore restore_location had some kind of  rules, suppose (xxx), then rules are changed to 0777. I suggest return rules (xxx)  back when restore was finished.","commit_id":"c11bcd50acfb66fc31a1523e853c1e515885a79c"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"f08ff27a99b5a8ddc643c0ac36941644e3a30f13","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    def post_restore(self):"},{"line_number":131,"context_line":"        self._run_prepare()"},{"line_number":132,"context_line":"        utils.execute_with_timeout(\"sudo\", \"chown\", \"-R\", \"-f\","},{"line_number":133,"context_line":"                                   \"mysql\", self.restore_location)"},{"line_number":134,"context_line":"        self._delete_old_binlogs()"},{"line_number":135,"context_line":"        self.reset_root_password()"},{"line_number":136,"context_line":"        app \u003d dbaas.MySqlApp(dbaas.MySqlAppStatus.get())"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9VJk%3D","line":133,"in_reply_to":"AAAATn%2F9ZpE%3D","updated":"2013-12-12 15:48:08.000000000","message":"I\u0027m not changing the logic of the restore, only moving the logic from the base into this subclass. There is no reason to change the permissions to 0777 that is way too wide open. The pre_restore only does that so that it can use utils.clean_out() which uses python shutils.rmtree(). This should be fixed in another review to not use chmod and instead just do a sudo rm.","commit_id":"c11bcd50acfb66fc31a1523e853c1e515885a79c"}],"trove/tests/unittests/backup/test_backupagent.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"bb6583dca8b5c0ccf1679e6b123e88040ea31c79","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                                          user\u003d\u0027123\u0027,"},{"line_number":162,"context_line":"                                          extra_opts\u003d\u0027\u0027)"},{"line_number":163,"context_line":"        self.assertIsNotNone(mysql_dump.cmd)"},{"line_number":164,"context_line":"        str_mysql_dump_cmd \u003d (\u0027/usr/bin/mysqldump\u0027"},{"line_number":165,"context_line":"                              \u0027 --all-databases\u0027"},{"line_number":166,"context_line":"                              \u0027 %(extra_opts)s\u0027"},{"line_number":167,"context_line":"                              \u0027 --opt\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9ZHU%3D","side":"PARENT","line":164,"updated":"2013-12-11 23:40:33.000000000","message":"please take a look at previous comments for same change","commit_id":"4790ba1f04b95d888154ed3652a350c01cd3be77"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"e2374c8407379ada3abcfe6dff4b7aa321a7ec55","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                                          user\u003d\u0027123\u0027,"},{"line_number":162,"context_line":"                                          extra_opts\u003d\u0027\u0027)"},{"line_number":163,"context_line":"        self.assertIsNotNone(mysql_dump.cmd)"},{"line_number":164,"context_line":"        str_mysql_dump_cmd \u003d (\u0027/usr/bin/mysqldump\u0027"},{"line_number":165,"context_line":"                              \u0027 --all-databases\u0027"},{"line_number":166,"context_line":"                              \u0027 %(extra_opts)s\u0027"},{"line_number":167,"context_line":"                              \u0027 --opt\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9T2M%3D","side":"PARENT","line":164,"in_reply_to":"AAAATn%2F9VIU%3D","updated":"2013-12-12 19:38:40.000000000","message":"Agree with Robert.","commit_id":"4790ba1f04b95d888154ed3652a350c01cd3be77"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"f08ff27a99b5a8ddc643c0ac36941644e3a30f13","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                                          user\u003d\u0027123\u0027,"},{"line_number":162,"context_line":"                                          extra_opts\u003d\u0027\u0027)"},{"line_number":163,"context_line":"        self.assertIsNotNone(mysql_dump.cmd)"},{"line_number":164,"context_line":"        str_mysql_dump_cmd \u003d (\u0027/usr/bin/mysqldump\u0027"},{"line_number":165,"context_line":"                              \u0027 --all-databases\u0027"},{"line_number":166,"context_line":"                              \u0027 %(extra_opts)s\u0027"},{"line_number":167,"context_line":"                              \u0027 --opt\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9VIU%3D","side":"PARENT","line":164,"in_reply_to":"AAAATn%2F9ZHU%3D","updated":"2013-12-12 15:48:08.000000000","message":"using just the command is better as each platform could put this in a different path /usr/sbin/ or /usr/local/bin or /usr/bin/ this is the generic backup for trove and you can create your own it you need anything special.","commit_id":"4790ba1f04b95d888154ed3652a350c01cd3be77"}]}
