)]}'
{".zuul.yaml":[{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"29f7e79ef8a7201540a0a9ee89fc7e87c43dabd7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      - release-notes-jobs-python3"},{"line_number":12,"context_line":"    check:"},{"line_number":13,"context_line":"      jobs:"},{"line_number":14,"context_line":"        # Non-voting until job is fixed, remove it if it works,"},{"line_number":15,"context_line":"        # it\u0027s part of openstack-cover-jobs template."},{"line_number":16,"context_line":"        - openstack-tox-cover:"},{"line_number":17,"context_line":"            voting: false"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_cfcc028c","line":14,"updated":"2018-10-01 10:11:42.000000000","message":"I don\u0027t like the fact that we mark this job as non-voting, even temporarily.\n\nCorrect order would be to firstly fix coverage env in tox and secondly apply changes in Zuul.\n\nI propose to rebase this change onto [1] and mark coverage job as voting again. There shouldn\u0027t be much work on fixing the coverage env. We will provide you with support on this.\n\n[1] https://review.openstack.org/#/c/604854","commit_id":"947d4b5dab04a919d442fc2216093f634469e76b"}],"tox.ini":[{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"a72b8e4b7f92f01c6e9017db4c2de707206b43a5","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"[testenv:cover]"},{"line_number":50,"context_line":"basepython \u003d python3"},{"line_number":51,"context_line":"  {[testenv]setenv}"},{"line_number":52,"context_line":"  PYTHON\u003dcoverage run --source trove --parallel-mode"},{"line_number":53,"context_line":"commands \u003d"},{"line_number":54,"context_line":"     {[testenv]commands}"}],"source_content_type":"text/x-properties","patch_set":5,"id":"3f79a3b5_ba4cf79d","line":51,"updated":"2018-09-24 12:23:53.000000000","message":"Missing \"setenv\" statement before:\n\n setenv \u003d\n   {[testenv]setenv}\n   PYTHON\u003dcoverage run --source trove --parallel-mode","commit_id":"946c7c53833e26665ae0c3ef1b3887fdc266251e"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"0668b787f211149fe850981ad36302a6f3609a2e","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"[testenv:cover]"},{"line_number":50,"context_line":"basepython \u003d python3"},{"line_number":51,"context_line":"  {[testenv]setenv}"},{"line_number":52,"context_line":"  PYTHON\u003dcoverage run --source trove --parallel-mode"},{"line_number":53,"context_line":"commands \u003d"},{"line_number":54,"context_line":"     {[testenv]commands}"}],"source_content_type":"text/x-properties","patch_set":5,"id":"3f79a3b5_15aa9cd2","line":51,"in_reply_to":"3f79a3b5_ba4cf79d","updated":"2018-09-24 12:34:40.000000000","message":"Done","commit_id":"946c7c53833e26665ae0c3ef1b3887fdc266251e"},{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"a72b8e4b7f92f01c6e9017db4c2de707206b43a5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"[testenv:cover]"},{"line_number":50,"context_line":"basepython \u003d python3"},{"line_number":51,"context_line":"  {[testenv]setenv}"},{"line_number":52,"context_line":"  PYTHON\u003dcoverage run --source trove --parallel-mode"},{"line_number":53,"context_line":"commands \u003d"},{"line_number":54,"context_line":"     {[testenv]commands}"},{"line_number":55,"context_line":"     coverage erase"}],"source_content_type":"text/x-properties","patch_set":5,"id":"3f79a3b5_fadcafe2","line":52,"updated":"2018-09-24 12:23:53.000000000","message":"Could you explain this line. Is it related to a hack described in Nova [1]? Maybe we should add similar comment somewhere around?\n\n[1] https://github.com/openstack/nova/blob/master/tox.ini#L135","commit_id":"946c7c53833e26665ae0c3ef1b3887fdc266251e"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"0668b787f211149fe850981ad36302a6f3609a2e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"[testenv:cover]"},{"line_number":50,"context_line":"basepython \u003d python3"},{"line_number":51,"context_line":"  {[testenv]setenv}"},{"line_number":52,"context_line":"  PYTHON\u003dcoverage run --source trove --parallel-mode"},{"line_number":53,"context_line":"commands \u003d"},{"line_number":54,"context_line":"     {[testenv]commands}"},{"line_number":55,"context_line":"     coverage erase"}],"source_content_type":"text/x-properties","patch_set":5,"id":"3f79a3b5_356238db","line":52,"in_reply_to":"3f79a3b5_fadcafe2","updated":"2018-09-24 12:34:40.000000000","message":"That comes from cookiecutter repo. But I can add a comment...","commit_id":"946c7c53833e26665ae0c3ef1b3887fdc266251e"},{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"a72b8e4b7f92f01c6e9017db4c2de707206b43a5","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  {[testenv]setenv}"},{"line_number":52,"context_line":"  PYTHON\u003dcoverage run --source trove --parallel-mode"},{"line_number":53,"context_line":"commands \u003d"},{"line_number":54,"context_line":"     {[testenv]commands}"},{"line_number":55,"context_line":"     coverage erase"},{"line_number":56,"context_line":"     stestr run {posargs}"},{"line_number":57,"context_line":"     coverage run -a run_tests.py"}],"source_content_type":"text/x-properties","patch_set":5,"id":"3f79a3b5_dadf73d5","line":54,"updated":"2018-09-24 12:23:53.000000000","message":"This statement can be removed. Otherwise we run stestr twice. Similar improvement was introduced by [1].\n\n[1] https://review.openstack.org/#/c/575230/","commit_id":"946c7c53833e26665ae0c3ef1b3887fdc266251e"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"0668b787f211149fe850981ad36302a6f3609a2e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  {[testenv]setenv}"},{"line_number":52,"context_line":"  PYTHON\u003dcoverage run --source trove --parallel-mode"},{"line_number":53,"context_line":"commands \u003d"},{"line_number":54,"context_line":"     {[testenv]commands}"},{"line_number":55,"context_line":"     coverage erase"},{"line_number":56,"context_line":"     stestr run {posargs}"},{"line_number":57,"context_line":"     coverage run -a run_tests.py"}],"source_content_type":"text/x-properties","patch_set":5,"id":"3f79a3b5_75a51003","line":54,"in_reply_to":"3f79a3b5_dadf73d5","updated":"2018-09-24 12:34:40.000000000","message":"Done","commit_id":"946c7c53833e26665ae0c3ef1b3887fdc266251e"},{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"1134c283af3f36093f1f06aa375e34e72ce44804","unresolved":false,"context_lines":[{"line_number":52,"context_line":"     {[testenv]commands}"},{"line_number":53,"context_line":"     coverage erase"},{"line_number":54,"context_line":"     python setup.py testr --coverage --testr-args\u003d\"--concurrency\u003d1\""},{"line_number":55,"context_line":"     coverage run -a run_tests.py"},{"line_number":56,"context_line":"     coverage html"},{"line_number":57,"context_line":"     coverage xml"},{"line_number":58,"context_line":"     coverage report"}],"source_content_type":"text/x-properties","patch_set":6,"id":"3f79a3b5_e68f3520","side":"PARENT","line":55,"updated":"2018-09-24 16:40:41.000000000","message":"We should keep this one since it\u0027s being executed in the CI pipeline (fakemodetests) and as such should be counted into coverage stats.","commit_id":"23278b1fdddc64a5f53a23a9a111a8c5e8ac4fb0"},{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"1134c283af3f36093f1f06aa375e34e72ce44804","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# TODO(AJaeger): Remove the PYTHON hack below in favour of a [coverage]"},{"line_number":51,"context_line":"# section once we rely on coverage 4.3+"},{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":"# https://bitbucket.org/ned/coveragepy/issues/519/"},{"line_number":54,"context_line":"basepython \u003d python3"},{"line_number":55,"context_line":"setenv \u003d"},{"line_number":56,"context_line":"  {[testenv]setenv}"}],"source_content_type":"text/x-properties","patch_set":6,"id":"3f79a3b5_4672a9e6","line":53,"updated":"2018-09-24 16:40:41.000000000","message":"You\u0027re right. It seems that all other projects are using the same hack without explanation (except Nova). Let\u0027s skip the comment since we both cannot understand how it relates to the hack.","commit_id":"0f40cabc5620faa2fd03177ecc2286515776b158"}]}