)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"67ce39aca1d686660a8df740b63be63a00dc78ff","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Andreas Jaeger \u003caj@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-24 19:27:02 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Start fixing cover job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The job is currently broken, add some first fixes to get it run"},{"line_number":10,"context_line":"with stestr."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_72011104","line":7,"updated":"2018-10-01 10:35:10.000000000","message":"Let\u0027s add title and description that better reflect current situation. This change seems to fix the coverage env - it is passing now. Please, include reason why the job failed before and how it was fixed.","commit_id":"2860739c6ef40da853c18685b9a6968c371922f9"}],"tox.ini":[{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"67ce39aca1d686660a8df740b63be63a00dc78ff","unresolved":false,"context_lines":[{"line_number":50,"context_line":"basepython \u003d python3"},{"line_number":51,"context_line":"commands \u003d"},{"line_number":52,"context_line":"     {[testenv]commands}"},{"line_number":53,"context_line":"     coverage erase"},{"line_number":54,"context_line":"     python setup.py testr --coverage --testr-args\u003d\"--concurrency\u003d1\""},{"line_number":55,"context_line":"     coverage run -a run_tests.py"},{"line_number":56,"context_line":"     coverage html"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f79a3b5_121bfd6e","side":"PARENT","line":53,"updated":"2018-10-01 10:35:10.000000000","message":"Why do we skip this step? Shouldn\u0027t we clear the coverage env before rendering a new coverage report?","commit_id":"947d4b5dab04a919d442fc2216093f634469e76b"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"39a9498270d2c0f4fc85b59a544e6af4f94b2469","unresolved":false,"context_lines":[{"line_number":50,"context_line":"basepython \u003d python3"},{"line_number":51,"context_line":"commands \u003d"},{"line_number":52,"context_line":"     {[testenv]commands}"},{"line_number":53,"context_line":"     coverage erase"},{"line_number":54,"context_line":"     python setup.py testr --coverage --testr-args\u003d\"--concurrency\u003d1\""},{"line_number":55,"context_line":"     coverage run -a run_tests.py"},{"line_number":56,"context_line":"     coverage html"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f79a3b5_2307cd72","side":"PARENT","line":53,"in_reply_to":"3f79a3b5_121bfd6e","updated":"2018-10-01 13:31:44.000000000","message":"This is not needed for CI... Should I add it back in? I can do that...","commit_id":"947d4b5dab04a919d442fc2216093f634469e76b"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"ccd4407ca09242e6af0cc5dfdd375148e8e283d0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"basepython \u003d python3"},{"line_number":51,"context_line":"commands \u003d"},{"line_number":52,"context_line":"     {[testenv]commands}"},{"line_number":53,"context_line":"     coverage erase"},{"line_number":54,"context_line":"     python setup.py testr --coverage --testr-args\u003d\"--concurrency\u003d1\""},{"line_number":55,"context_line":"     coverage run -a run_tests.py"},{"line_number":56,"context_line":"     coverage html"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f79a3b5_7868ee86","side":"PARENT","line":53,"in_reply_to":"3f79a3b5_2307cd72","updated":"2018-10-02 20:29:50.000000000","message":"I would prefer leave it as it was previously. It is not intended only for CI.\n\nMoreover, changing this behavior is unrelated for change topic.","commit_id":"947d4b5dab04a919d442fc2216093f634469e76b"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"45426baa0be9356ebea19f52051bf565ef1372a7","unresolved":false,"context_lines":[{"line_number":50,"context_line":"basepython \u003d python3"},{"line_number":51,"context_line":"commands \u003d"},{"line_number":52,"context_line":"     {[testenv]commands}"},{"line_number":53,"context_line":"     coverage erase"},{"line_number":54,"context_line":"     python setup.py testr --coverage --testr-args\u003d\"--concurrency\u003d1\""},{"line_number":55,"context_line":"     coverage run -a run_tests.py"},{"line_number":56,"context_line":"     coverage html"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f79a3b5_78f307a0","side":"PARENT","line":53,"in_reply_to":"3f79a3b5_7868ee86","updated":"2018-10-03 04:08:56.000000000","message":"This is what I did - see patchset 4.","commit_id":"947d4b5dab04a919d442fc2216093f634469e76b"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"412ca9f772753ea74b7f8024563e62b189380ec4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"basepython \u003d python3"},{"line_number":51,"context_line":"commands \u003d"},{"line_number":52,"context_line":"     {[testenv]commands}"},{"line_number":53,"context_line":"     coverage erase"},{"line_number":54,"context_line":"     python setup.py testr --coverage --testr-args\u003d\"--concurrency\u003d1\""},{"line_number":55,"context_line":"     coverage run -a run_tests.py"},{"line_number":56,"context_line":"     coverage html"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f79a3b5_b3e460e0","side":"PARENT","line":53,"in_reply_to":"3f79a3b5_78f307a0","updated":"2018-10-03 05:52:00.000000000","message":"Oh, that\u0027s fine. I missed it.","commit_id":"947d4b5dab04a919d442fc2216093f634469e76b"},{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"67ce39aca1d686660a8df740b63be63a00dc78ff","unresolved":false,"context_lines":[{"line_number":51,"context_line":"commands \u003d"},{"line_number":52,"context_line":"     {[testenv]commands}"},{"line_number":53,"context_line":"     coverage erase"},{"line_number":54,"context_line":"     python setup.py testr --coverage --testr-args\u003d\"--concurrency\u003d1\""},{"line_number":55,"context_line":"     coverage run -a run_tests.py"},{"line_number":56,"context_line":"     coverage html"},{"line_number":57,"context_line":"     coverage xml"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f79a3b5_32f15901","side":"PARENT","line":54,"updated":"2018-10-01 10:35:10.000000000","message":"By default, stestr runs tests in parallel [1]. I\u0027m wondering whether removing concurrency setting (concurrency\u003d1) will impact the testing behaviour.\n\nIn Zuul cleanup [2] change this env failed with errors indicating implications regarding concurrency:\n\n {7} trove.tests.unittests.backup.test_backup_models.BackupCreateTest.test_create_backup_creation_error [0.088416s] ... FAILED\n ...\n sqlite3.OperationalError: table usage_events already exists\u0027\n\n\n {7} trove.tests.unittests.backup.test_backup_models.BackupCreateTest.test_create_instance_not_found [0.070961s] ... FAILED\n ...\n sqlite3.OperationalError: table security_groups already exists\u0027\n\nWe need to ensure that the env runs deterministically and that we don\u0027t have false positives.\n\nCan you proviude more feedback on how you managed to fix it?\n\n[1] https://stestr.readthedocs.io/en/latest/MANUAL.html#parallel-testing\n[2] https://review.openstack.org/#/c/601586/","commit_id":"947d4b5dab04a919d442fc2216093f634469e76b"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"39a9498270d2c0f4fc85b59a544e6af4f94b2469","unresolved":false,"context_lines":[{"line_number":51,"context_line":"commands \u003d"},{"line_number":52,"context_line":"     {[testenv]commands}"},{"line_number":53,"context_line":"     coverage erase"},{"line_number":54,"context_line":"     python setup.py testr --coverage --testr-args\u003d\"--concurrency\u003d1\""},{"line_number":55,"context_line":"     coverage run -a run_tests.py"},{"line_number":56,"context_line":"     coverage html"},{"line_number":57,"context_line":"     coverage xml"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f79a3b5_a36f5d27","side":"PARENT","line":54,"range":{"start_line":54,"start_character":21,"end_line":54,"end_character":26},"updated":"2018-10-01 13:31:44.000000000","message":"That\u0027s the problem testr !\u003d stestr. This changes it - following what we do in other repos.","commit_id":"947d4b5dab04a919d442fc2216093f634469e76b"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"39a9498270d2c0f4fc85b59a544e6af4f94b2469","unresolved":false,"context_lines":[{"line_number":51,"context_line":"commands \u003d"},{"line_number":52,"context_line":"     {[testenv]commands}"},{"line_number":53,"context_line":"     coverage erase"},{"line_number":54,"context_line":"     python setup.py testr --coverage --testr-args\u003d\"--concurrency\u003d1\""},{"line_number":55,"context_line":"     coverage run -a run_tests.py"},{"line_number":56,"context_line":"     coverage html"},{"line_number":57,"context_line":"     coverage xml"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f79a3b5_e369d525","side":"PARENT","line":54,"in_reply_to":"3f79a3b5_32f15901","updated":"2018-10-01 13:31:44.000000000","message":"I can change to concurrency\u003d1","commit_id":"947d4b5dab04a919d442fc2216093f634469e76b"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"45426baa0be9356ebea19f52051bf565ef1372a7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"commands \u003d"},{"line_number":52,"context_line":"     {[testenv]commands}"},{"line_number":53,"context_line":"     coverage erase"},{"line_number":54,"context_line":"     python setup.py testr --coverage --testr-args\u003d\"--concurrency\u003d1\""},{"line_number":55,"context_line":"     coverage run -a run_tests.py"},{"line_number":56,"context_line":"     coverage html"},{"line_number":57,"context_line":"     coverage xml"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f79a3b5_18ee93b4","side":"PARENT","line":54,"in_reply_to":"3f79a3b5_38bb56e5","updated":"2018-10-03 04:08:56.000000000","message":"Done in current patcset","commit_id":"947d4b5dab04a919d442fc2216093f634469e76b"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"ccd4407ca09242e6af0cc5dfdd375148e8e283d0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"commands \u003d"},{"line_number":52,"context_line":"     {[testenv]commands}"},{"line_number":53,"context_line":"     coverage erase"},{"line_number":54,"context_line":"     python setup.py testr --coverage --testr-args\u003d\"--concurrency\u003d1\""},{"line_number":55,"context_line":"     coverage run -a run_tests.py"},{"line_number":56,"context_line":"     coverage html"},{"line_number":57,"context_line":"     coverage xml"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f79a3b5_38bb56e5","side":"PARENT","line":54,"in_reply_to":"3f79a3b5_e369d525","updated":"2018-10-02 20:29:50.000000000","message":"+1. Lets use serial more. It can save a lot of heartache.","commit_id":"947d4b5dab04a919d442fc2216093f634469e76b"}]}