)]}'
{"trove/extensions/mysql/models.py":[{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"1aefcc756fbe81a8b2fae78d607465f4296f49fc","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        validate \u003d guest_models.MySQLUser()"},{"line_number":150,"context_line":"        if host_name:"},{"line_number":151,"context_line":"            validate.host \u003d host_name"},{"line_number":152,"context_line":"        if user_name:"},{"line_number":153,"context_line":"            validate.name \u003d user_name"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        user \u003d user_name or username"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9bFA%3D","line":152,"updated":"2013-12-11 17:19:54.000000000","message":"is it possible to _not_ pass in user_name?","commit_id":"cb49047ca0fc7ddaf119ccce107b20ba0ae3a7b3"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"457454c3fb9bd04577d2b73d73fa1825844fae7f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        validate \u003d guest_models.MySQLUser()"},{"line_number":150,"context_line":"        if host_name:"},{"line_number":151,"context_line":"            validate.host \u003d host_name"},{"line_number":152,"context_line":"        if user_name:"},{"line_number":153,"context_line":"            validate.name \u003d user_name"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        user \u003d user_name or username"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9bBc%3D","line":152,"in_reply_to":"AAAATn%2F9bC8%3D","updated":"2013-12-11 17:29:27.000000000","message":"er in this case i suppose you could change the user and not the host, maybe to transfer permissions if you already have the host right. apischema may keep this from happening anyway, i haven\u0027t checked recently","commit_id":"cb49047ca0fc7ddaf119ccce107b20ba0ae3a7b3"},{"author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"change_message_id":"6f52ffbe9dfc77971aeea36987154ee13fa8a501","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        validate \u003d guest_models.MySQLUser()"},{"line_number":150,"context_line":"        if host_name:"},{"line_number":151,"context_line":"            validate.host \u003d host_name"},{"line_number":152,"context_line":"        if user_name:"},{"line_number":153,"context_line":"            validate.name \u003d user_name"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        user \u003d user_name or username"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9atg%3D","line":152,"in_reply_to":"AAAATn%2F9bFA%3D","updated":"2013-12-11 19:09:04.000000000","message":"Yes, it seems to be supported by the method, hence the lines below defaulting it back to the original value if it wasn\u0027t passed in as a change.  Whether that\u0027s a legitimate use-case or not is beyond my knowledge of the project, but since the code supports it I felt it pertinent to deal with that situation.","commit_id":"cb49047ca0fc7ddaf119ccce107b20ba0ae3a7b3"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a5f3ad46633915ef78ed61bdfcfb072aba8fbb8e","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        validate \u003d guest_models.MySQLUser()"},{"line_number":150,"context_line":"        if host_name:"},{"line_number":151,"context_line":"            validate.host \u003d host_name"},{"line_number":152,"context_line":"        if user_name:"},{"line_number":153,"context_line":"            validate.name \u003d user_name"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        user \u003d user_name or username"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9bD0%3D","line":152,"in_reply_to":"AAAATn%2F9bFA%3D","updated":"2013-12-11 17:21:20.000000000","message":"agreed","commit_id":"cb49047ca0fc7ddaf119ccce107b20ba0ae3a7b3"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"8271e5fe6116cd7cfa8e520e1311fb9ef02d9145","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        validate \u003d guest_models.MySQLUser()"},{"line_number":150,"context_line":"        if host_name:"},{"line_number":151,"context_line":"            validate.host \u003d host_name"},{"line_number":152,"context_line":"        if user_name:"},{"line_number":153,"context_line":"            validate.name \u003d user_name"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        user \u003d user_name or username"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9bC8%3D","line":152,"in_reply_to":"AAAATn%2F9bFA%3D","updated":"2013-12-11 17:22:55.000000000","message":"this isn\u0027t username in the function call, this is the body of the request. the use case for changing host and not name would be to restrict the hosts whence an extant user can access the db from","commit_id":"cb49047ca0fc7ddaf119ccce107b20ba0ae3a7b3"}],"trove/tests/api/users.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"92225670669f0b55d0e41bcdf6557598aeeb0369","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                      \"host\": hostname1, \"databases\": []})"},{"line_number":281,"context_line":"        self.dbaas.users.create(instance_info.id, users)"},{"line_number":282,"context_line":"        hostname1 \u003d hostname1.replace(\u0027.\u0027, \u0027%2e\u0027)"},{"line_number":283,"context_line":"        assert_raises(exceptions.BadRequest,"},{"line_number":284,"context_line":"                      self.dbaas.users.update_attributes, instance_info.id,"},{"line_number":285,"context_line":"                      username, {\"host\": \"badjuju\"}, hostname1)"},{"line_number":286,"context_line":"        assert_equal(400, self.dbaas.last_http_code)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9bFM%3D","line":283,"updated":"2013-12-11 17:18:57.000000000","message":"i suggest you to check exception messages it assertRaises","commit_id":"cb49047ca0fc7ddaf119ccce107b20ba0ae3a7b3"},{"author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"change_message_id":"6f52ffbe9dfc77971aeea36987154ee13fa8a501","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                      \"host\": hostname1, \"databases\": []})"},{"line_number":281,"context_line":"        self.dbaas.users.create(instance_info.id, users)"},{"line_number":282,"context_line":"        hostname1 \u003d hostname1.replace(\u0027.\u0027, \u0027%2e\u0027)"},{"line_number":283,"context_line":"        assert_raises(exceptions.BadRequest,"},{"line_number":284,"context_line":"                      self.dbaas.users.update_attributes, instance_info.id,"},{"line_number":285,"context_line":"                      username, {\"host\": \"badjuju\"}, hostname1)"},{"line_number":286,"context_line":"        assert_equal(400, self.dbaas.last_http_code)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9as4%3D","line":283,"in_reply_to":"AAAATn%2F9bFM%3D","updated":"2013-12-11 19:09:04.000000000","message":"None of the other tests in this module do this, and I\u0027ve found by past experience that hardcoding error messages in tests becomes a maintenance pain requiring a test change any time wording on an error message is adjusted or improved.  I\u0027m willing to do it, but I think it\u0027s a bad idea.","commit_id":"cb49047ca0fc7ddaf119ccce107b20ba0ae3a7b3"}]}