)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b7afa3791ff8843dcdcaefc28468f8e5bbd408d1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Leon \u003csteve.leon@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-11 16:14:46 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make use of IP filtering when creating DNS records"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I4ce7c65e24f6d105f555e6c36d788558daa25f12"},{"line_number":10,"context_line":"Closes-Bug: 1260089"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAT3%2F%2F41Q%3D","line":7,"updated":"2013-12-31 14:04:48.000000000","message":"Poor commin description","commit_id":"487a2ba51316a222e97d6156a49b6abd1eea8aac"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"cd4a8a4f88201a18b98d655d3798152ac997ecb5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Leon \u003csteve.leon@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-11 16:14:46 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make use of IP filtering when creating DNS records"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I4ce7c65e24f6d105f555e6c36d788558daa25f12"},{"line_number":10,"context_line":"Closes-Bug: 1260089"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAT3%2F%2FuHc%3D","line":7,"in_reply_to":"AAAAT3%2F%2F41Q%3D","updated":"2014-01-02 22:35:43.000000000","message":"Assuming Denis meant commit description.\n\nYour commit message title is good, but you probably want to add a sentence or two describing the IP filtering. Thanks!","commit_id":"487a2ba51316a222e97d6156a49b6abd1eea8aac"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"7d4ad4c16a3b9c8d4a7661e36f89d1fcf1cb9d03","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Leon \u003csteve.leon@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-11 16:14:46 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make use of IP filtering when creating DNS records"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I4ce7c65e24f6d105f555e6c36d788558daa25f12"},{"line_number":10,"context_line":"Closes-Bug: 1260089"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2F7cc%3D","line":7,"in_reply_to":"AAAAT3%2F%2FuHc%3D","updated":"2014-01-06 17:02:50.000000000","message":"Thanks guys, Ill write a better description","commit_id":"487a2ba51316a222e97d6156a49b6abd1eea8aac"}],"trove/taskmanager/models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ac81b8f97b06802bee4c36a5840a0677d47b1e66","unresolved":false,"context_lines":[{"line_number":559,"context_line":"            server \u003d self.nova_client.servers.get("},{"line_number":560,"context_line":"                self.db_info.compute_instance_id)"},{"line_number":561,"context_line":"            LOG.info(_(\"Creating dns entry...\"))"},{"line_number":562,"context_line":"            ip \u003d get_ip_address(server.addresses)[0]"},{"line_number":563,"context_line":"            dns_client.create_instance_entry(self.id, ip)"},{"line_number":564,"context_line":"        else:"},{"line_number":565,"context_line":"            LOG.debug(_(\"%(gt)s: DNS not enabled for instance: %(id)s\") %"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9ZGI%3D","line":562,"updated":"2013-12-11 23:43:08.000000000","message":"please use method pop instead of direct unpacking","commit_id":"c1f0f925a8e1c0364fa8437a3eb3cce02eb79028"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"cd4a8a4f88201a18b98d655d3798152ac997ecb5","unresolved":false,"context_lines":[{"line_number":559,"context_line":"            server \u003d self.nova_client.servers.get("},{"line_number":560,"context_line":"                self.db_info.compute_instance_id)"},{"line_number":561,"context_line":"            LOG.info(_(\"Creating dns entry...\"))"},{"line_number":562,"context_line":"            ip \u003d get_ip_address(server.addresses).pop()"},{"line_number":563,"context_line":"            dns_client.create_instance_entry(self.id, ip)"},{"line_number":564,"context_line":"        else:"},{"line_number":565,"context_line":"            LOG.debug(_(\"%(gt)s: DNS not enabled for instance: %(id)s\") %"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2FuFA%3D","line":562,"updated":"2014-01-02 22:35:43.000000000","message":"It\u0027s possible for get_ip_address to return None, or an empty list. In that case, you will get an \"IndexError: pop from empty list\", or a \"\u0027NoneType\u0027 object has no attribute \u0027pop\u0027\" which is not currently being handled.","commit_id":"487a2ba51316a222e97d6156a49b6abd1eea8aac"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"7d4ad4c16a3b9c8d4a7661e36f89d1fcf1cb9d03","unresolved":false,"context_lines":[{"line_number":559,"context_line":"            server \u003d self.nova_client.servers.get("},{"line_number":560,"context_line":"                self.db_info.compute_instance_id)"},{"line_number":561,"context_line":"            LOG.info(_(\"Creating dns entry...\"))"},{"line_number":562,"context_line":"            ip \u003d get_ip_address(server.addresses).pop()"},{"line_number":563,"context_line":"            dns_client.create_instance_entry(self.id, ip)"},{"line_number":564,"context_line":"        else:"},{"line_number":565,"context_line":"            LOG.debug(_(\"%(gt)s: DNS not enabled for instance: %(id)s\") %"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F7cs%3D","line":562,"in_reply_to":"AAAAT3%2F%2FuFA%3D","updated":"2014-01-06 17:02:50.000000000","message":"The care where the get_ip_address returns None is already handle by the logic above it. However this does not handle if the return IP list is empty. Thank you.","commit_id":"487a2ba51316a222e97d6156a49b6abd1eea8aac"}]}