)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d98f24b28ccfedc4ebe25d974a842781eb6bdfe8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"I propose to simplify the view by showing hostname if it is set or"},{"line_number":15,"context_line":"show the IP if it is not set."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-bug 1260567"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ia1fd47cbee89b10d53b0821e104a34eb31543846"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9BUY%3D","line":17,"updated":"2013-12-17 16:09:09.000000000","message":"Closes-bug: 1260567","commit_id":"a0e81b0c93c6dccc4ef49418d10a3cf5d8b0b9eb"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"760f4dba6b1159f7a30ab83825b3e94f94ea54e5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"I propose to simplify the view by showing hostname if it is set or"},{"line_number":15,"context_line":"show the IP if it is not set."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-bug: 1260567"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ia1fd47cbee89b10d53b0821e104a34eb31543846"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAT3%2F%2F41A%3D","line":17,"updated":"2013-12-27 23:32:10.000000000","message":"Closes-bug: #1260567","commit_id":"1b217390ec2f1c153b0fc1c50c6d2588bdab29e8"}],"trove/instance/views.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"ea95fd0c205dc7693559de3f6d41e7bf00730c51","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        result[\u0027instance\u0027][\u0027datastore\u0027][\u0027version\u0027] \u003d (self.instance."},{"line_number":93,"context_line":"                                                      datastore_version.name)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if self.instance.hostname:"},{"line_number":96,"context_line":"            result[\u0027instance\u0027][\u0027hostname\u0027] \u003d self.instance.hostname"},{"line_number":97,"context_line":"        else:"},{"line_number":98,"context_line":"            ip \u003d get_ip_address(self.instance.addresses)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2FuGs%3D","line":95,"updated":"2014-01-02 22:32:49.000000000","message":"I\u0027m not sure of the use case behind this but what if you wanted to be able to display both the hostname and ip address? \n\nYou might want this in the mgmt instance list api? The mgmt view extends this view so maybe? \n\nAny one have an opinion on this?","commit_id":"1b217390ec2f1c153b0fc1c50c6d2588bdab29e8"}],"trove/tests/unittests/instance/test_instance_views.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"65e5b96101ecbdfe4eab05df6edf6859ca9d32b1","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                         result[\u0027instance\u0027][\u0027datastore\u0027][\u0027version\u0027])"},{"line_number":107,"context_line":"        self.assertEqual(self.instance.hostname,"},{"line_number":108,"context_line":"                         result[\u0027instance\u0027][\u0027hostname\u0027])"},{"line_number":109,"context_line":"        self.assertFalse(\u0027ip\u0027 in result[\u0027instance\u0027])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_data_ip(self):"},{"line_number":112,"context_line":"        self.instance.hostname \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9Rn0%3D","line":109,"updated":"2013-12-13 07:08:14.000000000","message":"could you please use assertNotIn(a, b)","commit_id":"948cec0236c7884b3b92e92008835e393a66ab32"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"65e5b96101ecbdfe4eab05df6edf6859ca9d32b1","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        self.assertEqual(self.instance.updated, result[\u0027instance\u0027][\u0027updated\u0027])"},{"line_number":117,"context_line":"        self.assertEqual(self.instance.datastore_version.name,"},{"line_number":118,"context_line":"                         result[\u0027instance\u0027][\u0027datastore\u0027][\u0027version\u0027])"},{"line_number":119,"context_line":"        self.assertFalse(\u0027hostname\u0027 in result[\u0027instance\u0027])"},{"line_number":120,"context_line":"        self.assertEqual([self.ip], result[\u0027instance\u0027][\u0027ip\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9Rnw%3D","line":119,"updated":"2013-12-13 07:08:14.000000000","message":"could you please use assertNotIn(a, b)","commit_id":"948cec0236c7884b3b92e92008835e393a66ab32"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"760f4dba6b1159f7a30ab83825b3e94f94ea54e5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from trove.instance.views import filter_ips"},{"line_number":20,"context_line":"from trove.instance.views import InstanceView"},{"line_number":21,"context_line":"from trove.instance.views import InstanceDetailView"},{"line_number":22,"context_line":"from mock import Mock"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d cfg.CONF"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F41E%3D","line":22,"updated":"2013-12-27 23:32:10.000000000","message":"test imports should come first","commit_id":"1b217390ec2f1c153b0fc1c50c6d2588bdab29e8"}]}
