)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"0a64412612151e590edea5de4c6653758a4801e4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Denis Makogon \u003cdmakogon@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-13 15:16:44 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Block delete instance while buckup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reason:"},{"line_number":10,"context_line":" - trove don\u0027t allow delet instance while its in BUILDING status,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9PYs%3D","line":7,"updated":"2013-12-13 16:14:16.000000000","message":"bukup \u003d\u003e backup","commit_id":"d22dbf85c18cbbc4eae900a6c1379e8dfeca2638"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"0a64412612151e590edea5de4c6653758a4801e4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Block delete instance while buckup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reason:"},{"line_number":10,"context_line":" - trove don\u0027t allow delet instance while its in BUILDING status,"},{"line_number":11,"context_line":"   but instance could be deleted"},{"line_number":12,"context_line":"   when its in ACTIVE state and backup is running."},{"line_number":13,"context_line":"Changes:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9PYg%3D","line":10,"updated":"2013-12-13 16:14:16.000000000","message":"delet \u003d\u003e delete","commit_id":"d22dbf85c18cbbc4eae900a6c1379e8dfeca2638"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"0a64412612151e590edea5de4c6653758a4801e4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"   but instance could be deleted"},{"line_number":12,"context_line":"   when its in ACTIVE state and backup is running."},{"line_number":13,"context_line":"Changes:"},{"line_number":14,"context_line":" - delete method checks if instance in BUILDING and BUCKUP state;"},{"line_number":15,"context_line":" - create_backup method sets task status to BACKUP_IN_PROGRESS;"},{"line_number":16,"context_line":" - conductors update_backup method sets task status to NONE;"},{"line_number":17,"context_line":" - tests;"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9PYc%3D","line":14,"updated":"2013-12-13 16:14:16.000000000","message":"bukcup \u003d\u003e backup","commit_id":"d22dbf85c18cbbc4eae900a6c1379e8dfeca2638"}],"trove/conductor/manager.py":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"0322c9558e503eabe4f84bb3668156fe43bd8cd1","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        backup \u003d bkup_models.DBBackup.find_by(id\u003dbackup_id)"},{"line_number":69,"context_line":"        db_info \u003d DBInstance.find_by(id\u003dinstance_id, deleted\u003dFalse)"},{"line_number":70,"context_line":"        # Updating DBInstance model"},{"line_number":71,"context_line":"        self.update_model(db_info, task_status\u003dInstanceTasks.NONE)"},{"line_number":72,"context_line":"        # TODO(datsun180b): use context to verify tenant matches"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Some verification based on IDs"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2F0Xc%3D","line":71,"updated":"2013-12-30 21:40:59.000000000","message":"This be after the checks below to make sure we are updating the correct instance.","commit_id":"ffcb3fa89e661686f4eaf7bc8974d7f69af1e375"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"23f91c9b9da797004829be2b131330d093521ff5","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        backup \u003d bkup_models.DBBackup.find_by(id\u003dbackup_id)"},{"line_number":69,"context_line":"        db_info \u003d DBInstance.find_by(id\u003dinstance_id, deleted\u003dFalse)"},{"line_number":70,"context_line":"        # Updating DBInstance model"},{"line_number":71,"context_line":"        self.update_model(db_info, task_status\u003dInstanceTasks.NONE)"},{"line_number":72,"context_line":"        # TODO(datsun180b): use context to verify tenant matches"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Some verification based on IDs"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2Fve8%3D","line":71,"in_reply_to":"AAAAT3%2F%2F0VA%3D","updated":"2014-01-02 15:46:59.000000000","message":"I\u0027m talking about the check \u0027instance_id !\u003d backup.instance_id\u0027 if that check fails for what ever reason, this is not the correct instance to update. I\u0027d have to dig into this further, but probably what should happen is that this update_backup rpc message should *not* pass the instance_id and we load the instance from the backup.instance_id, removing the need to check if they are correct.","commit_id":"ffcb3fa89e661686f4eaf7bc8974d7f69af1e375"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c74dc156b2e197386e8567372c9d1094deb149cd","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        backup \u003d bkup_models.DBBackup.find_by(id\u003dbackup_id)"},{"line_number":69,"context_line":"        db_info \u003d DBInstance.find_by(id\u003dinstance_id, deleted\u003dFalse)"},{"line_number":70,"context_line":"        # Updating DBInstance model"},{"line_number":71,"context_line":"        self.update_model(db_info, task_status\u003dInstanceTasks.NONE)"},{"line_number":72,"context_line":"        # TODO(datsun180b): use context to verify tenant matches"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Some verification based on IDs"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2F0VA%3D","line":71,"in_reply_to":"AAAAT3%2F%2F0Xc%3D","updated":"2013-12-30 21:48:05.000000000","message":"checks below are responsible for correct backup model updating, but since db_info is loaded we already know that we load needed correct instance, because instance uuid is uniq for instance. So there\u0027s no need to move it lower.","commit_id":"ffcb3fa89e661686f4eaf7bc8974d7f69af1e375"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c955ce6928d5f0253669cff2cb9138a63addd058","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        backup \u003d bkup_models.DBBackup.find_by(id\u003dbackup_id)"},{"line_number":69,"context_line":"        db_info \u003d DBInstance.find_by(id\u003dinstance_id, deleted\u003dFalse)"},{"line_number":70,"context_line":"        # Updating DBInstance model"},{"line_number":71,"context_line":"        self.update_model(db_info, task_status\u003dInstanceTasks.NONE)"},{"line_number":72,"context_line":"        # TODO(datsun180b): use context to verify tenant matches"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Some verification based on IDs"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2FvXg%3D","line":71,"in_reply_to":"AAAAT3%2F%2Fve8%3D","updated":"2014-01-02 16:11:32.000000000","message":"Idea of removing instance_id from method parameters is good idea, maybe i\u0027ll submit patch which would change flow a bit and than we\u0027ll see what other guys think","commit_id":"ffcb3fa89e661686f4eaf7bc8974d7f69af1e375"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"188f29d0d0e7e08fd7dc8f0f452855a00267f378","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        status \u003d t_models.InstanceServiceStatus.find_by("},{"line_number":35,"context_line":"            instance_id\u003dinstance_id)"},{"line_number":36,"context_line":"        status.set_status(ServiceStatus.from_description("},{"line_number":37,"context_line":"            payload.get(\u0027service_status\u0027)))"},{"line_number":38,"context_line":"        status.save()"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def update_model(self, model, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2Bsfs%3D","line":37,"updated":"2014-01-23 03:18:30.000000000","message":"Here is the second .get. Plz see my other comment below.","commit_id":"e89f99260e66db8b4bb634fe7c27ac962af3e81f"},{"author":{"_account_id":7850,"name":"Kevin Conway","email":"kevinjacobconway@gmail.com","username":"kevinconway"},"change_message_id":"f869fd9ff8bd2db483f5dcaada0cdfccc1de56e6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        LOG.debug(_(\"Instance ID: %s\") % str(instance_id))"},{"line_number":60,"context_line":"        LOG.debug(_(\"Payload: %s\") % str(payload))"},{"line_number":61,"context_line":"        if payload.get(\u0027service_status\u0027) is not None:"},{"line_number":62,"context_line":"            self.update_instance_task(instance_id, payload)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def update_backup(self, context, instance_id, backup_id,"},{"line_number":65,"context_line":"                      **backup_fields):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2FMiE%3D","line":62,"updated":"2014-01-16 15:12:09.000000000","message":"I there a reason that this needs to be dynamic?\n\nI would prefer that you actually set the values using their names like \"instance.attribute \u003d payload[\u0027attribute\u0027]\". This makes it clear to a developer what should be updated for the instance.","commit_id":"e89f99260e66db8b4bb634fe7c27ac962af3e81f"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"188f29d0d0e7e08fd7dc8f0f452855a00267f378","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        LOG.debug(_(\"Instance ID: %s\") % str(instance_id))"},{"line_number":60,"context_line":"        LOG.debug(_(\"Payload: %s\") % str(payload))"},{"line_number":61,"context_line":"        if payload.get(\u0027service_status\u0027) is not None:"},{"line_number":62,"context_line":"            self.update_instance_task(instance_id, payload)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def update_backup(self, context, instance_id, backup_id,"},{"line_number":65,"context_line":"                      **backup_fields):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2Bsf4%3D","line":62,"in_reply_to":"AAAAUH%2F%2FMKQ%3D","updated":"2014-01-23 03:18:30.000000000","message":"You are doing two get\u0027s on service_status, instead of just passing it in to the update_instance_task. Why?","commit_id":"e89f99260e66db8b4bb634fe7c27ac962af3e81f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"cc50751c66fa3f8a11ff2181904f6798b601d713","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        LOG.debug(_(\"Instance ID: %s\") % str(instance_id))"},{"line_number":60,"context_line":"        LOG.debug(_(\"Payload: %s\") % str(payload))"},{"line_number":61,"context_line":"        if payload.get(\u0027service_status\u0027) is not None:"},{"line_number":62,"context_line":"            self.update_instance_task(instance_id, payload)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def update_backup(self, context, instance_id, backup_id,"},{"line_number":65,"context_line":"                      **backup_fields):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2FMKQ%3D","line":62,"in_reply_to":"AAAAUH%2F%2FMiE%3D","updated":"2014-01-16 16:07:36.000000000","message":"i don\u0027t see a problem with this method. What kind of problem do you see with this implementation ?","commit_id":"e89f99260e66db8b4bb634fe7c27ac962af3e81f"}],"trove/instance/tasks.py":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"0322c9558e503eabe4f84bb3668156fe43bd8cd1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    BUILDING \u003d InstanceTask(0x05, \u0027BUILDING\u0027, \u0027The instance is building.\u0027)"},{"line_number":72,"context_line":"    MIGRATING \u003d InstanceTask(0x06, \u0027MIGRATING\u0027, \u0027Migrating the instance.\u0027)"},{"line_number":73,"context_line":"    BACKUP_IN_PROGRESS \u003d InstanceTask("},{"line_number":74,"context_line":"        0x55, \u0027BACKUP_IN_PROGRESS\u0027, \u0027Backup in progress\u0027)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    BUILDING_ERROR_DNS \u003d InstanceTask(0x50, \u0027BUILDING\u0027, \u0027Build error: DNS.\u0027,"},{"line_number":77,"context_line":"                                      is_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2F0WU%3D","line":74,"updated":"2013-12-30 21:40:59.000000000","message":"I shouldn\u0027t this be 0x07? since all the 5X are errors?","commit_id":"ffcb3fa89e661686f4eaf7bc8974d7f69af1e375"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"ca0e4308dae90b45fcfcfae0e628a737e56eb691","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    BUILDING \u003d InstanceTask(0x05, \u0027BUILDING\u0027, \u0027The instance is building.\u0027)"},{"line_number":72,"context_line":"    MIGRATING \u003d InstanceTask(0x06, \u0027MIGRATING\u0027, \u0027Migrating the instance.\u0027)"},{"line_number":73,"context_line":"    BACKUP_IN_PROGRESS \u003d InstanceTask("},{"line_number":74,"context_line":"        0x55, \u0027BACKUP_IN_PROGRESS\u0027, \u0027Backup in progress\u0027)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    BUILDING_ERROR_DNS \u003d InstanceTask(0x50, \u0027BUILDING\u0027, \u0027Build error: DNS.\u0027,"},{"line_number":77,"context_line":"                                      is_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2FuC4%3D","line":74,"in_reply_to":"AAAAT3%2F%2F0Us%3D","updated":"2014-01-02 22:45:42.000000000","message":"oh is that the reason for the sorta random numbers? Maybe that should be made a comment here. Denis do you mind adding a comment about that?","commit_id":"ffcb3fa89e661686f4eaf7bc8974d7f69af1e375"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c74dc156b2e197386e8567372c9d1094deb149cd","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    BUILDING \u003d InstanceTask(0x05, \u0027BUILDING\u0027, \u0027The instance is building.\u0027)"},{"line_number":72,"context_line":"    MIGRATING \u003d InstanceTask(0x06, \u0027MIGRATING\u0027, \u0027Migrating the instance.\u0027)"},{"line_number":73,"context_line":"    BACKUP_IN_PROGRESS \u003d InstanceTask("},{"line_number":74,"context_line":"        0x55, \u0027BACKUP_IN_PROGRESS\u0027, \u0027Backup in progress\u0027)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    BUILDING_ERROR_DNS \u003d InstanceTask(0x50, \u0027BUILDING\u0027, \u0027Build error: DNS.\u0027,"},{"line_number":77,"context_line":"                                      is_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2F0Us%3D","line":74,"in_reply_to":"AAAAT3%2F%2F0WU%3D","updated":"2013-12-30 21:48:05.000000000","message":"Ok. Agreed.","commit_id":"ffcb3fa89e661686f4eaf7bc8974d7f69af1e375"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9349a129e62c6e8eee9ebcca6925e7fb4b700ede","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    BUILDING \u003d InstanceTask(0x05, \u0027BUILDING\u0027, \u0027The instance is building.\u0027)"},{"line_number":72,"context_line":"    MIGRATING \u003d InstanceTask(0x06, \u0027MIGRATING\u0027, \u0027Migrating the instance.\u0027)"},{"line_number":73,"context_line":"    BACKUP_IN_PROGRESS \u003d InstanceTask("},{"line_number":74,"context_line":"        0x55, \u0027BACKUP_IN_PROGRESS\u0027, \u0027Backup in progress\u0027)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    BUILDING_ERROR_DNS \u003d InstanceTask(0x50, \u0027BUILDING\u0027, \u0027Build error: DNS.\u0027,"},{"line_number":77,"context_line":"                                      is_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2Ft8o%3D","line":74,"in_reply_to":"AAAAT3%2F%2FuC4%3D","updated":"2014-01-02 23:24:04.000000000","message":"Craig, i would do this asap","commit_id":"ffcb3fa89e661686f4eaf7bc8974d7f69af1e375"}]}
