)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"eddaba76d74539efe37a23b4df6f941d49d3782d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"with those instances."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Iee5c3ad02c36e10a42937500b0252d913d97b708"},{"line_number":15,"context_line":"Closes-Bug: 1259642"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9A4g%3D","line":15,"updated":"2013-12-17 17:35:50.000000000","message":"Closes-Bug: #1259642","commit_id":"2d0eb837d129f9a13f2ab77870ab8d0eeb3213d3"}],"trove/instance/models.py":[{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"eb9031bf0c1e7c7f0c6b58daacd81343bb250211","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                       load(self.ds_version.datastore_id))"},{"line_number":130,"context_line":"        else:"},{"line_number":131,"context_line":"            self.ds_version \u003d None"},{"line_number":132,"context_line":"            self.ds \u003d None"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @property"},{"line_number":135,"context_line":"    def addresses(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F86xU%3D","line":132,"updated":"2013-12-18 19:58:18.000000000","message":"Do we want to load the \"default\" one here if its not in db_info? So we have that done here instead of in the property below?","commit_id":"7a9954f9f6e9f71824e6f89d923b78ef21029812"},{"author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"change_message_id":"774333eb22f250be0c568397f6f8ef9e66030eb7","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                       load(self.ds_version.datastore_id))"},{"line_number":130,"context_line":"        else:"},{"line_number":131,"context_line":"            self.ds_version \u003d None"},{"line_number":132,"context_line":"            self.ds \u003d None"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @property"},{"line_number":135,"context_line":"    def addresses(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F86ww%3D","line":132,"in_reply_to":"AAAATn%2F86xU%3D","updated":"2013-12-18 20:02:09.000000000","message":"These are the related objects, which we can\u0027t really default without more information.  We default the \u0027manager\u0027 value because external code requires it to function (resize and delete instance, for example).","commit_id":"7a9954f9f6e9f71824e6f89d923b78ef21029812"}],"trove/taskmanager/models.py":[{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"25c59aa7b5a902d80558651f7223879e00bf2a34","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            })"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # any instances that predate datastore support are mysql by default"},{"line_number":120,"context_line":"        manager \u003d \u0027mysql\u0027"},{"line_number":121,"context_line":"        if self.datastore:"},{"line_number":122,"context_line":"            manager \u003d self.datastore.manager"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9BMg%3D","line":120,"updated":"2013-12-17 16:30:51.000000000","message":"I dont care particularly about this, but if another group (like hp) is running a different named manager by default (lets say percona or vertica), then having this in a config would be a better option. But i wont -1 this, ill let vipul / slick comment.","commit_id":"2d0eb837d129f9a13f2ab77870ab8d0eeb3213d3"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"7934ecb72f148c211c95e9ca6befbe7df884dfe1","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            })"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # any instances that predate datastore support are mysql by default"},{"line_number":120,"context_line":"        manager \u003d \u0027mysql\u0027"},{"line_number":121,"context_line":"        if self.datastore:"},{"line_number":122,"context_line":"            manager \u003d self.datastore.manager"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9A4E%3D","line":120,"in_reply_to":"AAAATn%2F9BMg%3D","updated":"2013-12-17 17:37:46.000000000","message":"i too agree with this one, we should be going to configs for this manager naming","commit_id":"2d0eb837d129f9a13f2ab77870ab8d0eeb3213d3"}],"trove/tests/api/instances.py":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"a35e245f167a20aab873a8b10c54f8925790e30a","unresolved":false,"context_lines":[{"line_number":968,"context_line":"            check.volume_mgmt()"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"@test"},{"line_number":972,"context_line":"class TestInstanceMissingDatastore(object):"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"    @test"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9Oss%3D","line":971,"updated":"2013-12-13 18:45:06.000000000","message":"This should be in some group, and probably be enabled\u003dFAKE_MODE, or something like that as you are reaching into the DB for the instance. Alternatively you should not query the DB as these are integration tests they may not have access to the database.","commit_id":"11b196a47537f61b3bd00b96a0c11ca0d983cce2"}]}