)]}'
{"trove/guestagent/datastore/mysql/manager.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"65f7a74941bde112f4cb285ec3a92700a08f0400","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        \"\"\"Makes ready DBAAS on a Guest container.\"\"\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # Default Location where mysql puts its data."},{"line_number":112,"context_line":"        default_data_dir \u003d \"/var/lib/mysql\""},{"line_number":113,"context_line":"        MySqlAppStatus.get().begin_install()"},{"line_number":114,"context_line":"        # status end_mysql_install set with secure()"},{"line_number":115,"context_line":"        app \u003d MySqlApp(MySqlAppStatus.get())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F89To%3D","line":112,"updated":"2013-12-18 12:05:26.000000000","message":"This variable has got a better place in code rather than configuration, making way for other datastores not to be confined to usage of this location/variable.","commit_id":"fc99c05925d2afbae1644dcfad10eae9f0baeb5e"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c04eacce0960a315a8b8630dd8034f1b74ec134f","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        \"\"\"Makes ready DBAAS on a Guest container.\"\"\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # Default Location where mysql puts its data."},{"line_number":112,"context_line":"        default_data_dir \u003d \"/var/lib/mysql\""},{"line_number":113,"context_line":"        MySqlAppStatus.get().begin_install()"},{"line_number":114,"context_line":"        # status end_mysql_install set with secure()"},{"line_number":115,"context_line":"        app \u003d MySqlApp(MySqlAppStatus.get())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F802o%3D","line":112,"updated":"2013-12-19 21:42:16.000000000","message":"you could use value from service.py - MYSQL_BASE_DIR","commit_id":"fc99c05925d2afbae1644dcfad10eae9f0baeb5e"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"3bfaf00e928f22afec3e4f03b76b032645c3c99d","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        \"\"\"Makes ready DBAAS on a Guest container.\"\"\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # Default Location where mysql puts its data."},{"line_number":112,"context_line":"        default_data_dir \u003d \"/var/lib/mysql\""},{"line_number":113,"context_line":"        MySqlAppStatus.get().begin_install()"},{"line_number":114,"context_line":"        # status end_mysql_install set with secure()"},{"line_number":115,"context_line":"        app \u003d MySqlApp(MySqlAppStatus.get())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F81Os%3D","line":112,"in_reply_to":"AAAATn%2F81O4%3D","updated":"2013-12-19 20:33:03.000000000","message":"we can read my.cnf\n\nBut for first installation anywhere in linux environment mysql default-installs its database in /var/lib/mysql\n\nAlso, I did not see anywhere storage_dir in current trove code.\n\nAnd, lastly this location is a one time location, it is never reused like the prepare method call in the life of a guest.","commit_id":"fc99c05925d2afbae1644dcfad10eae9f0baeb5e"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"15ad3dd3225b1b3b5f3384a4db1b5182bbcf6b1f","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        \"\"\"Makes ready DBAAS on a Guest container.\"\"\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # Default Location where mysql puts its data."},{"line_number":112,"context_line":"        default_data_dir \u003d \"/var/lib/mysql\""},{"line_number":113,"context_line":"        MySqlAppStatus.get().begin_install()"},{"line_number":114,"context_line":"        # status end_mysql_install set with secure()"},{"line_number":115,"context_line":"        app \u003d MySqlApp(MySqlAppStatus.get())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F81O4%3D","line":112,"in_reply_to":"AAAATn%2F81QA%3D","updated":"2013-12-19 19:42:29.000000000","message":"what about config.template values ?\nthis hardcoded value brings new way to misconfigure storage_dir.\nwe have mount point \u003d /var/lib/mysql\nwe have storage dir \u003d /var/lib/mysql\nand now Sushil proposed to add another one value which us /var/lib/mysql\n\nI suggest to retrieve default_data_dir from my.cnf","commit_id":"fc99c05925d2afbae1644dcfad10eae9f0baeb5e"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"6a760def1949503648a70ade8224ba1f5ed4fc58","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        \"\"\"Makes ready DBAAS on a Guest container.\"\"\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # Default Location where mysql puts its data."},{"line_number":112,"context_line":"        default_data_dir \u003d \"/var/lib/mysql\""},{"line_number":113,"context_line":"        MySqlAppStatus.get().begin_install()"},{"line_number":114,"context_line":"        # status end_mysql_install set with secure()"},{"line_number":115,"context_line":"        app \u003d MySqlApp(MySqlAppStatus.get())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F81QA%3D","line":112,"in_reply_to":"AAAATn%2F88Zc%3D","updated":"2013-12-19 19:37:34.000000000","message":"im honestly not sure why we are \"migrating\" old data in the first place :) But i think its fine to have it here in the code of 1) it doesnt change across installations 2) its only used in this bit of code.","commit_id":"fc99c05925d2afbae1644dcfad10eae9f0baeb5e"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"805c95e36c4b44f405e33f226dcdc9ba441a4942","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        \"\"\"Makes ready DBAAS on a Guest container.\"\"\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # Default Location where mysql puts its data."},{"line_number":112,"context_line":"        default_data_dir \u003d \"/var/lib/mysql\""},{"line_number":113,"context_line":"        MySqlAppStatus.get().begin_install()"},{"line_number":114,"context_line":"        # status end_mysql_install set with secure()"},{"line_number":115,"context_line":"        app \u003d MySqlApp(MySqlAppStatus.get())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F88Zc%3D","line":112,"in_reply_to":"AAAATn%2F89KQ%3D","updated":"2013-12-18 14:41:47.000000000","message":"I\u0027d like to keep this question opened.","commit_id":"fc99c05925d2afbae1644dcfad10eae9f0baeb5e"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"7e06cd0890b154da568412426c788ed0cb286e44","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        \"\"\"Makes ready DBAAS on a Guest container.\"\"\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # Default Location where mysql puts its data."},{"line_number":112,"context_line":"        default_data_dir \u003d \"/var/lib/mysql\""},{"line_number":113,"context_line":"        MySqlAppStatus.get().begin_install()"},{"line_number":114,"context_line":"        # status end_mysql_install set with secure()"},{"line_number":115,"context_line":"        app \u003d MySqlApp(MySqlAppStatus.get())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F89KQ%3D","line":112,"in_reply_to":"AAAATn%2F89LQ%3D","updated":"2013-12-18 12:28:40.000000000","message":"a.) When I kept in configurations, you had -1 there also.\n\nb.) Also, if we use this in configuration, we would be needed to have similar parameters for all new datastores.\n\nc.) If people prefer this in configurations I am open to that.","commit_id":"fc99c05925d2afbae1644dcfad10eae9f0baeb5e"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"343e4fe2971ab34dd3d5c3266caff82c6665722c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        \"\"\"Makes ready DBAAS on a Guest container.\"\"\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # Default Location where mysql puts its data."},{"line_number":112,"context_line":"        default_data_dir \u003d \"/var/lib/mysql\""},{"line_number":113,"context_line":"        MySqlAppStatus.get().begin_install()"},{"line_number":114,"context_line":"        # status end_mysql_install set with secure()"},{"line_number":115,"context_line":"        app \u003d MySqlApp(MySqlAppStatus.get())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F89LQ%3D","line":112,"in_reply_to":"AAAATn%2F89To%3D","updated":"2013-12-18 12:25:27.000000000","message":"Disagree, you still have one in config.template.\nI don\u0027t like the idea of hardcoded values which could be configured!","commit_id":"fc99c05925d2afbae1644dcfad10eae9f0baeb5e"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"48e964d4c129d203b3a714e64ff82b802c6cc591","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            self._perform_restore(backup_info, context,"},{"line_number":131,"context_line":"                                  CONF.mount_point, app)"},{"line_number":132,"context_line":"        LOG.info(_(\"Securing mysql now.\"))"},{"line_number":133,"context_line":"        app.secure(config_contents)"},{"line_number":134,"context_line":"        enable_root_on_restore \u003d (backup_info and"},{"line_number":135,"context_line":"                                  MySqlAdmin().is_root_enabled())"},{"line_number":136,"context_line":"        if root_password and not backup_info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F800Y%3D","line":133,"updated":"2013-12-19 21:52:15.000000000","message":"Also, you should take into account possible misconfiguration of values default_data_dir and datadir inside of config_contents.","commit_id":"fc99c05925d2afbae1644dcfad10eae9f0baeb5e"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"e5daa75fde189f606a81e5fddf1fb2443e5c7ad5","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            self._perform_restore(backup_info, context,"},{"line_number":131,"context_line":"                                  CONF.mount_point, app)"},{"line_number":132,"context_line":"        LOG.info(_(\"Securing mysql now.\"))"},{"line_number":133,"context_line":"        app.secure(config_contents)"},{"line_number":134,"context_line":"        enable_root_on_restore \u003d (backup_info and"},{"line_number":135,"context_line":"                                  MySqlAdmin().is_root_enabled())"},{"line_number":136,"context_line":"        if root_password and not backup_info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8zLU%3D","line":133,"in_reply_to":"AAAATn%2F800Y%3D","updated":"2013-12-20 07:34:49.000000000","message":"default_data_dir is nothing in config_contents config_contents only has datadir","commit_id":"fc99c05925d2afbae1644dcfad10eae9f0baeb5e"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"f9d7ae85c2c1db07355ef032cddef09feab138ab","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        \"\"\"Makes ready DBAAS on a Guest container.\"\"\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # Default Location where mysql puts its data."},{"line_number":112,"context_line":"        default_data_dir \u003d \"/var/lib/mysql\""},{"line_number":113,"context_line":"        MySqlAppStatus.get().begin_install()"},{"line_number":114,"context_line":"        # status end_mysql_install set with secure()"},{"line_number":115,"context_line":"        app \u003d MySqlApp(MySqlAppStatus.get())"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8zAY%3D","line":112,"updated":"2013-12-20 08:18:28.000000000","message":"i\u0027d not suggest to hardcode such significant parameters.\nYou should retrieve path for data migration from config_contents","commit_id":"a2b0752ffc32ddcb0783366e09facd0b4b7dc4ed"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"f9d7ae85c2c1db07355ef032cddef09feab138ab","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            self._perform_restore(backup_info, context,"},{"line_number":131,"context_line":"                                  CONF.mount_point, app)"},{"line_number":132,"context_line":"        LOG.info(_(\"Securing mysql now.\"))"},{"line_number":133,"context_line":"        app.secure(config_contents)"},{"line_number":134,"context_line":"        enable_root_on_restore \u003d (backup_info and"},{"line_number":135,"context_line":"                                  MySqlAdmin().is_root_enabled())"},{"line_number":136,"context_line":"        if root_password and not backup_info:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8y%2BU%3D","line":133,"updated":"2013-12-20 08:18:28.000000000","message":"it should be moved right after installing packages","commit_id":"a2b0752ffc32ddcb0783366e09facd0b4b7dc4ed"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"1c9fe5b4c0b927ce7b2198b13d7430e0dad9da15","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            self._perform_restore(backup_info, context,"},{"line_number":131,"context_line":"                                  CONF.mount_point, app)"},{"line_number":132,"context_line":"        LOG.info(_(\"Securing mysql now.\"))"},{"line_number":133,"context_line":"        app.secure(config_contents)"},{"line_number":134,"context_line":"        enable_root_on_restore \u003d (backup_info and"},{"line_number":135,"context_line":"                                  MySqlAdmin().is_root_enabled())"},{"line_number":136,"context_line":"        if root_password and not backup_info:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8y04%3D","line":133,"in_reply_to":"AAAATn%2F8y%2BU%3D","updated":"2013-12-20 08:46:55.000000000","message":"that could create problems if we are following backup-restore path.","commit_id":"a2b0752ffc32ddcb0783366e09facd0b4b7dc4ed"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"61a2b3d4bae1fa0d110aeab72662c161563ed9bd","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            self._perform_restore(backup_info, context,"},{"line_number":131,"context_line":"                                  CONF.mount_point, app)"},{"line_number":132,"context_line":"        LOG.info(_(\"Securing mysql now.\"))"},{"line_number":133,"context_line":"        app.secure(config_contents)"},{"line_number":134,"context_line":"        enable_root_on_restore \u003d (backup_info and"},{"line_number":135,"context_line":"                                  MySqlAdmin().is_root_enabled())"},{"line_number":136,"context_line":"        if root_password and not backup_info:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8yiY%3D","line":133,"in_reply_to":"AAAATn%2F8y04%3D","updated":"2013-12-20 09:34:45.000000000","message":"i see no problems with backup/restore","commit_id":"a2b0752ffc32ddcb0783366e09facd0b4b7dc4ed"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"8d619d15ab214b1e0e2c4b4f5e1408be915be16d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            self._perform_restore(backup_info, context,"},{"line_number":131,"context_line":"                                  CONF.mount_point, app)"},{"line_number":132,"context_line":"        LOG.info(_(\"Securing mysql now.\"))"},{"line_number":133,"context_line":"        app.secure(config_contents)"},{"line_number":134,"context_line":"        enable_root_on_restore \u003d (backup_info and"},{"line_number":135,"context_line":"                                  MySqlAdmin().is_root_enabled())"},{"line_number":136,"context_line":"        if root_password and not backup_info:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8yhM%3D","line":133,"in_reply_to":"AAAATn%2F8yiY%3D","updated":"2013-12-20 09:37:47.000000000","message":"currently this statement executes for both backup restore and installation and if we move it above we have to repeat it in backup and restore, if we are good to repeat the call we can do that","commit_id":"a2b0752ffc32ddcb0783366e09facd0b4b7dc4ed"}]}
