)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"5a5a97c7ef9ed877aafb47c73c229b421337fda4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reasons:"},{"line_number":10,"context_line":"- os.makedirs since running under normal user access"},{"line_number":11,"context_line":"  will not be able to create the directory at root locations like /var/lib."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Changes:"},{"line_number":14,"context_line":"- Used utils.execute like used at other places"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9DDA%3D","line":11,"updated":"2013-12-17 10:19:47.000000000","message":"Please wrap commit message lines at 72 chars.\n\n(Refer to https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_GIT_commit_message_structure)","commit_id":"a4be031b0dad6bbd230ccaff836d19c9d17daaa8"}],"trove/guestagent/volume.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"67239d83324f2d56b4d9eef235820e48f58e26a4","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def mount(self):"},{"line_number":134,"context_line":"        if not os.path.exists(self.mount_point):"},{"line_number":135,"context_line":"            os.makedirs(self.mount_point)"},{"line_number":136,"context_line":"        LOG.debug(\"Adding volume. Device path:%s, mount_point:%s, \""},{"line_number":137,"context_line":"                  \"volume_type:%s, mount options:%s\" %"},{"line_number":138,"context_line":"                  (self.device_path, self.mount_point, self.volume_fstype,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9GpQ%3D","side":"PARENT","line":135,"updated":"2013-12-16 19:02:29.000000000","message":"you are not allowed to create dirs in /var/lib (for example) without being super-user","commit_id":"59a778b8573361066b478772b753e208c572f5b4"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"dfc39c684290b9c23de4ae12c693a0654cdb34fa","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def mount(self):"},{"line_number":134,"context_line":"        if not os.path.exists(self.mount_point):"},{"line_number":135,"context_line":"            os.makedirs(self.mount_point)"},{"line_number":136,"context_line":"        LOG.debug(\"Adding volume. Device path:%s, mount_point:%s, \""},{"line_number":137,"context_line":"                  \"volume_type:%s, mount options:%s\" %"},{"line_number":138,"context_line":"                  (self.device_path, self.mount_point, self.volume_fstype,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9Gio%3D","side":"PARENT","line":135,"in_reply_to":"AAAATn%2F9GjI%3D","updated":"2013-12-16 19:20:41.000000000","message":"i though, i am addressing the same issue as my bug.\nwhich we do not want to fail alike other admin commands.","commit_id":"59a778b8573361066b478772b753e208c572f5b4"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"977537c4a51bfef1a0f1391309abbd9f831bc8bc","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def mount(self):"},{"line_number":134,"context_line":"        if not os.path.exists(self.mount_point):"},{"line_number":135,"context_line":"            os.makedirs(self.mount_point)"},{"line_number":136,"context_line":"        LOG.debug(\"Adding volume. Device path:%s, mount_point:%s, \""},{"line_number":137,"context_line":"                  \"volume_type:%s, mount options:%s\" %"},{"line_number":138,"context_line":"                  (self.device_path, self.mount_point, self.volume_fstype,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9GjI%3D","side":"PARENT","line":135,"in_reply_to":"AAAATn%2F9Gjs%3D","updated":"2013-12-16 19:19:15.000000000","message":"if guest would be launched from simple user, this step would fail","commit_id":"59a778b8573361066b478772b753e208c572f5b4"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"9d4ffd5874064783f5ab96525d23bb3215588fcb","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def mount(self):"},{"line_number":134,"context_line":"        if not os.path.exists(self.mount_point):"},{"line_number":135,"context_line":"            os.makedirs(self.mount_point)"},{"line_number":136,"context_line":"        LOG.debug(\"Adding volume. Device path:%s, mount_point:%s, \""},{"line_number":137,"context_line":"                  \"volume_type:%s, mount options:%s\" %"},{"line_number":138,"context_line":"                  (self.device_path, self.mount_point, self.volume_fstype,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9GjY%3D","side":"PARENT","line":135,"in_reply_to":"AAAATn%2F9Gkk%3D","updated":"2013-12-16 19:18:13.000000000","message":"yeah, and we obviously are running the guestagen code as a simple user, that is why other statements have sudo written in them, like mounting","commit_id":"59a778b8573361066b478772b753e208c572f5b4"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ea9a7795a2aa6bed1529c8fb6c83b1c3515186e7","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def mount(self):"},{"line_number":134,"context_line":"        if not os.path.exists(self.mount_point):"},{"line_number":135,"context_line":"            os.makedirs(self.mount_point)"},{"line_number":136,"context_line":"        LOG.debug(\"Adding volume. Device path:%s, mount_point:%s, \""},{"line_number":137,"context_line":"                  \"volume_type:%s, mount options:%s\" %"},{"line_number":138,"context_line":"                  (self.device_path, self.mount_point, self.volume_fstype,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9Gkk%3D","side":"PARENT","line":135,"in_reply_to":"AAAATn%2F9Glc%3D","updated":"2013-12-16 19:16:05.000000000","message":"you\u0027ve error: Permission denied.\nIf guestagent would be launched from simple user you would get error on this step.","commit_id":"59a778b8573361066b478772b753e208c572f5b4"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"9ada2eba1e42c9eba96b6afe02d6e356fa97f94f","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def mount(self):"},{"line_number":134,"context_line":"        if not os.path.exists(self.mount_point):"},{"line_number":135,"context_line":"            os.makedirs(self.mount_point)"},{"line_number":136,"context_line":"        LOG.debug(\"Adding volume. Device path:%s, mount_point:%s, \""},{"line_number":137,"context_line":"                  \"volume_type:%s, mount options:%s\" %"},{"line_number":138,"context_line":"                  (self.device_path, self.mount_point, self.volume_fstype,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9Gjs%3D","side":"PARENT","line":135,"in_reply_to":"AAAATn%2F9Gmg%3D","updated":"2013-12-16 19:17:20.000000000","message":"Denis I\u0027m not sure what you are arguing about, it seems obvious that this change is making it possible to create directories anywhere. I\u0027m fairly certain that this is a bug in the existing code, if /var/lib/mysql is not there this will fail without sudo. And if it is there this line will not be reached.","commit_id":"59a778b8573361066b478772b753e208c572f5b4"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"c0823c099f2cfa783d53dac65718888050e50a93","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def mount(self):"},{"line_number":134,"context_line":"        if not os.path.exists(self.mount_point):"},{"line_number":135,"context_line":"            os.makedirs(self.mount_point)"},{"line_number":136,"context_line":"        LOG.debug(\"Adding volume. Device path:%s, mount_point:%s, \""},{"line_number":137,"context_line":"                  \"volume_type:%s, mount options:%s\" %"},{"line_number":138,"context_line":"                  (self.device_path, self.mount_point, self.volume_fstype,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9Glc%3D","side":"PARENT","line":135,"in_reply_to":"AAAATn%2F9Gmg%3D","updated":"2013-12-16 19:14:05.000000000","message":"ubuntu@newtst:~$ mkdir -p /tml/1/2/3/4\nmkdir: cannot create directory `/tml\u0027: Permission denied\nubuntu@newtst:~$ sudo mkdir -p /tml/1/2/3/4\nubuntu@newtst:~$ sudo mkdir -p /tml/1/2/3/4\nubuntu@newtst:~$ ls -ltr /tml/1/2/3/\ntotal 4\ndrwxr-xr-x 2 root root 4096 Dec 16 19:13 4\nubuntu@newtst:~$ ls -ltr\n\n\nsharing the log. but cannot understand your point","commit_id":"59a778b8573361066b478772b753e208c572f5b4"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a077155bde15796d90bc8a2e9f419c1f69bd2055","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def mount(self):"},{"line_number":134,"context_line":"        if not os.path.exists(self.mount_point):"},{"line_number":135,"context_line":"            os.makedirs(self.mount_point)"},{"line_number":136,"context_line":"        LOG.debug(\"Adding volume. Device path:%s, mount_point:%s, \""},{"line_number":137,"context_line":"                  \"volume_type:%s, mount options:%s\" %"},{"line_number":138,"context_line":"                  (self.device_path, self.mount_point, self.volume_fstype,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9Gmg%3D","side":"PARENT","line":135,"in_reply_to":"AAAATn%2F9GoU%3D","updated":"2013-12-16 19:10:09.000000000","message":"try next case in terminal:\nmkdir -p /tml/1/2/3/4\nand then again\nmkdir -p /tml/1/2/3/4\nand you would see, why it\u0027s not \"obviously going to fail\".","commit_id":"59a778b8573361066b478772b753e208c572f5b4"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"5c7a913d70d9cb13872faa95efa25ea022a80dde","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def mount(self):"},{"line_number":134,"context_line":"        if not os.path.exists(self.mount_point):"},{"line_number":135,"context_line":"            os.makedirs(self.mount_point)"},{"line_number":136,"context_line":"        LOG.debug(\"Adding volume. Device path:%s, mount_point:%s, \""},{"line_number":137,"context_line":"                  \"volume_type:%s, mount options:%s\" %"},{"line_number":138,"context_line":"                  (self.device_path, self.mount_point, self.volume_fstype,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9GoU%3D","side":"PARENT","line":135,"in_reply_to":"AAAATn%2F9GpQ%3D","updated":"2013-12-16 19:04:56.000000000","message":"so, that is what I have changed it to, alike the code in next few lines is using sudo access to mount the volume.\nthis line creates the directory if it was non-existent, and is obviously going to fail, which is my bug.","commit_id":"59a778b8573361066b478772b753e208c572f5b4"}]}
