)]}'
{"trove/guestagent/datastore/mysql/manager.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"57b1bcca14c891fff1b278bfdd0904da619848e6","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            #\"/var/lib/mysql\" and we need to take a backup of those datafiles."},{"line_number":121,"context_line":"            if os.path.exists(\"/var/lib/mysql\"):"},{"line_number":122,"context_line":"                #copy data from suggested path to temporary location."},{"line_number":123,"context_line":"                device.migrate_data(\"/var/lib/mysql\")"},{"line_number":124,"context_line":"                # If CONF.mount_point is not \"/var/lib/mysql\" then we need to"},{"line_number":125,"context_line":"                # update datadir in config_contents followed by my.cnf file."},{"line_number":126,"context_line":"                if CONF.mount_point !\u003d \"/var/lib/mysql\":"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8x9E%3D","line":123,"updated":"2013-12-20 12:04:06.000000000","message":"Make global variable MYSQL_BASE_DIR \u003d /var/lib/mysql, and then reffer to it from each module","commit_id":"545c1c1e86a8d255f1f16d00210e573262351fde"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"18eeb0d1d25ab731ac9532240ddb8adde15dee90","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            #\"/var/lib/mysql\" and we need to take a backup of those datafiles."},{"line_number":121,"context_line":"            if os.path.exists(\"/var/lib/mysql\"):"},{"line_number":122,"context_line":"                #copy data from suggested path to temporary location."},{"line_number":123,"context_line":"                device.migrate_data(\"/var/lib/mysql\")"},{"line_number":124,"context_line":"                # If CONF.mount_point is not \"/var/lib/mysql\" then we need to"},{"line_number":125,"context_line":"                # update datadir in config_contents followed by my.cnf file."},{"line_number":126,"context_line":"                if CONF.mount_point !\u003d \"/var/lib/mysql\":"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8xQQ%3D","line":123,"in_reply_to":"AAAATn%2F8x4U%3D","updated":"2013-12-20 14:19:39.000000000","message":"Prof. https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/mysql/service.py#L709-L742\n\nPutting multiple variables in several places isn\u0027t a good idea. Would be nice to summarize them in one place.","commit_id":"545c1c1e86a8d255f1f16d00210e573262351fde"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"23876bff0e9a7b3b4d6e12ab849d36ca043e13d5","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            #\"/var/lib/mysql\" and we need to take a backup of those datafiles."},{"line_number":121,"context_line":"            if os.path.exists(\"/var/lib/mysql\"):"},{"line_number":122,"context_line":"                #copy data from suggested path to temporary location."},{"line_number":123,"context_line":"                device.migrate_data(\"/var/lib/mysql\")"},{"line_number":124,"context_line":"                # If CONF.mount_point is not \"/var/lib/mysql\" then we need to"},{"line_number":125,"context_line":"                # update datadir in config_contents followed by my.cnf file."},{"line_number":126,"context_line":"                if CONF.mount_point !\u003d \"/var/lib/mysql\":"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8x4U%3D","line":123,"in_reply_to":"AAAATn%2F8x9E%3D","updated":"2013-12-20 12:18:23.000000000","message":"we do not this variable and its values outside of the scope of prepare method.","commit_id":"545c1c1e86a8d255f1f16d00210e573262351fde"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"57b1bcca14c891fff1b278bfdd0904da619848e6","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                                             config_contents.find(\u0027datadir\u0027))]"},{"line_number":132,"context_line":"                    new_data_dir \u003d \u0027datadir \u003d %s\u0027 % CONF.mount_point"},{"line_number":133,"context_line":"                    # datadir replaced with new datadir."},{"line_number":134,"context_line":"                    config_contents \u003d config_contents.replace(old_data_dir,"},{"line_number":135,"context_line":"                                                              new_data_dir)"},{"line_number":136,"context_line":"                    config \u003d {\u0027config_contents\u0027: config_contents}"},{"line_number":137,"context_line":"                    # datadir updated in my.cnf file."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8x98%3D","line":134,"updated":"2013-12-20 12:04:06.000000000","message":"I would not suggest you to do such things. Config_content has top priority over everything, config_content \u003d my.cnf - it\u0027s a config file which mysql picks and works with it. So you should not change anything in it.\nYou should do reverse things - get datadir from config_contents and change mount point according to it.\n\nthis is hidden thing, suppose i want datadir \u003d /home/user/mysql, but unfortunately, my data stored at CONF.mount_point - why is that so? Looks like magic thing or huge bug.\n\nAnyway, we should discuss it, and then write code.","commit_id":"545c1c1e86a8d255f1f16d00210e573262351fde"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"23876bff0e9a7b3b4d6e12ab849d36ca043e13d5","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                                             config_contents.find(\u0027datadir\u0027))]"},{"line_number":132,"context_line":"                    new_data_dir \u003d \u0027datadir \u003d %s\u0027 % CONF.mount_point"},{"line_number":133,"context_line":"                    # datadir replaced with new datadir."},{"line_number":134,"context_line":"                    config_contents \u003d config_contents.replace(old_data_dir,"},{"line_number":135,"context_line":"                                                              new_data_dir)"},{"line_number":136,"context_line":"                    config \u003d {\u0027config_contents\u0027: config_contents}"},{"line_number":137,"context_line":"                    # datadir updated in my.cnf file."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8x4g%3D","line":134,"in_reply_to":"AAAATn%2F8x98%3D","updated":"2013-12-20 12:18:23.000000000","message":"Fine we can discuss this in community.","commit_id":"545c1c1e86a8d255f1f16d00210e573262351fde"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"57b1bcca14c891fff1b278bfdd0904da619848e6","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            self._perform_restore(backup_info, context,"},{"line_number":149,"context_line":"                                  CONF.mount_point, app)"},{"line_number":150,"context_line":"        LOG.info(_(\"Securing mysql now.\"))"},{"line_number":151,"context_line":"        app.secure(config_contents)"},{"line_number":152,"context_line":"        enable_root_on_restore \u003d (backup_info and"},{"line_number":153,"context_line":"                                  MySqlAdmin().is_root_enabled())"},{"line_number":154,"context_line":"        if root_password and not backup_info:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8x84%3D","line":151,"updated":"2013-12-20 12:04:06.000000000","message":"Would be executed anyway. And override your changed config file.","commit_id":"545c1c1e86a8d255f1f16d00210e573262351fde"}],"trove/guestagent/datastore/mysql/service.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"57b1bcca14c891fff1b278bfdd0904da619848e6","unresolved":false,"context_lines":[{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    def _write_temp_mycnf_with_admin_account(self, original_file_path,"},{"line_number":710,"context_line":"                                             temp_file_path, password):"},{"line_number":711,"context_line":"        utils.execute_with_timeout(\"sudo\", \"chmod\", \"0711\", MYSQL_BASE_DIR)"},{"line_number":712,"context_line":"        mycnf_file \u003d open(original_file_path, \u0027r\u0027)"},{"line_number":713,"context_line":"        tmp_file \u003d open(temp_file_path, \u0027w\u0027)"},{"line_number":714,"context_line":"        for line in mycnf_file:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8x8s%3D","side":"PARENT","line":711,"updated":"2013-12-20 12:04:06.000000000","message":"out of scope, you have another review with it","commit_id":"84dbe87c22eb45934e57eef36bd88b350fc141f8"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"23876bff0e9a7b3b4d6e12ab849d36ca043e13d5","unresolved":false,"context_lines":[{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    def _write_temp_mycnf_with_admin_account(self, original_file_path,"},{"line_number":710,"context_line":"                                             temp_file_path, password):"},{"line_number":711,"context_line":"        utils.execute_with_timeout(\"sudo\", \"chmod\", \"0711\", MYSQL_BASE_DIR)"},{"line_number":712,"context_line":"        mycnf_file \u003d open(original_file_path, \u0027r\u0027)"},{"line_number":713,"context_line":"        tmp_file \u003d open(temp_file_path, \u0027w\u0027)"},{"line_number":714,"context_line":"        for line in mycnf_file:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8x4o%3D","side":"PARENT","line":711,"in_reply_to":"AAAATn%2F8x8s%3D","updated":"2013-12-20 12:18:23.000000000","message":"i was not able to make my patch-set dependent.\nobvioursly, if that goes in changes would be reflected in re-basing","commit_id":"84dbe87c22eb45934e57eef36bd88b350fc141f8"}]}
