)]}'
{"trove/taskmanager/models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b9d1993026bc530eaa3ea28327d4b8dcfdeacf96","unresolved":false,"context_lines":[{"line_number":344,"context_line":"        client \u003d create_heat_client(self.context)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        template_obj \u003d template.load_heat_template(datastore_manager)"},{"line_number":347,"context_line":"        if CONF.trove_volume_support:"},{"line_number":348,"context_line":"            heat_template_unicode \u003d template_obj.render(volume_support\u003d\u0027True\u0027)"},{"line_number":349,"context_line":"        else:"},{"line_number":350,"context_line":"            heat_template_unicode \u003d template_obj.render()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F83M0%3D","line":347,"updated":"2013-12-19 13:22:55.000000000","message":"also, it would be better to simply this code\n\nheat_template_unicode \u003d template_obj.render(volume_support\u003dCONF.trove_volume_support\u0027)\ninstead of all those lines","commit_id":"1eb3a7f6a365d89ac207d58e37e812d900926c63"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"6348b73181cbcab03281986d63d06c162a45acff","unresolved":false,"context_lines":[{"line_number":344,"context_line":"        client \u003d create_heat_client(self.context)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        template_obj \u003d template.load_heat_template(datastore_manager)"},{"line_number":347,"context_line":"        if CONF.trove_volume_support:"},{"line_number":348,"context_line":"            heat_template_unicode \u003d template_obj.render(volume_support\u003d\u0027True\u0027)"},{"line_number":349,"context_line":"        else:"},{"line_number":350,"context_line":"            heat_template_unicode \u003d template_obj.render()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F828o%3D","line":347,"in_reply_to":"AAAATn%2F83M0%3D","updated":"2013-12-19 14:52:10.000000000","message":"updating","commit_id":"1eb3a7f6a365d89ac207d58e37e812d900926c63"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b24b4a3e20727e68554cc14ffe9a7fe726ae45ec","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            raise TroveError(\"heat template ascii encode issue\")"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        parameters \u003d {\"Flavor\": flavor[\"name\"],"},{"line_number":359,"context_line":"                      \"VolumeSize\": volume_size,"},{"line_number":360,"context_line":"                      \"InstanceId\": self.id,"},{"line_number":361,"context_line":"                      \"ImageId\": image_id,"},{"line_number":362,"context_line":"                      \"DatastoreManager\": datastore_manager,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F83SI%3D","line":359,"updated":"2013-12-19 13:13:03.000000000","message":"same here","commit_id":"1eb3a7f6a365d89ac207d58e37e812d900926c63"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"6348b73181cbcab03281986d63d06c162a45acff","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            raise TroveError(\"heat template ascii encode issue\")"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        parameters \u003d {\"Flavor\": flavor[\"name\"],"},{"line_number":359,"context_line":"                      \"VolumeSize\": volume_size,"},{"line_number":360,"context_line":"                      \"InstanceId\": self.id,"},{"line_number":361,"context_line":"                      \"ImageId\": image_id,"},{"line_number":362,"context_line":"                      \"DatastoreManager\": datastore_manager,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F82zM%3D","line":359,"in_reply_to":"AAAATn%2F83SI%3D","updated":"2013-12-19 14:52:10.000000000","message":"volumesize poses no threat.","commit_id":"1eb3a7f6a365d89ac207d58e37e812d900926c63"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b24b4a3e20727e68554cc14ffe9a7fe726ae45ec","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        client.stacks.create(stack_name\u003dstack_name,"},{"line_number":366,"context_line":"                             template\u003dheat_template,"},{"line_number":367,"context_line":"                             parameters\u003dparameters)"},{"line_number":368,"context_line":"        stack \u003d client.stacks.get(stack_name)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        utils.poll_until("},{"line_number":371,"context_line":"            lambda: client.stacks.get(stack_name),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F83RE%3D","line":368,"updated":"2013-12-19 13:13:03.000000000","message":"it would fail due to multiple errors","commit_id":"1eb3a7f6a365d89ac207d58e37e812d900926c63"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"6348b73181cbcab03281986d63d06c162a45acff","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        client.stacks.create(stack_name\u003dstack_name,"},{"line_number":366,"context_line":"                             template\u003dheat_template,"},{"line_number":367,"context_line":"                             parameters\u003dparameters)"},{"line_number":368,"context_line":"        stack \u003d client.stacks.get(stack_name)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        utils.poll_until("},{"line_number":371,"context_line":"            lambda: client.stacks.get(stack_name),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F828M%3D","line":368,"in_reply_to":"AAAATn%2F83RE%3D","updated":"2013-12-19 14:52:10.000000000","message":"cannot find any validation errors, irresepective of passing the ignored value while self testing the template.","commit_id":"1eb3a7f6a365d89ac207d58e37e812d900926c63"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b24b4a3e20727e68554cc14ffe9a7fe726ae45ec","unresolved":false,"context_lines":[{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        if CONF.trove_volume_support:"},{"line_number":381,"context_line":"            resource \u003d client.resources.get(stack.id, \u0027DataVolume\u0027)"},{"line_number":382,"context_line":"            self.update_db(compute_instance_id\u003dserver[\u0027id\u0027],"},{"line_number":383,"context_line":"                           volume_id\u003dresource.physical_resource_id)"},{"line_number":384,"context_line":"        else:"},{"line_number":385,"context_line":"            self.update_db(compute_instance_id\u003dserver[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F83Ro%3D","line":382,"updated":"2013-12-19 13:13:03.000000000","message":"why not just pass resource.physical_resource_id ?","commit_id":"1eb3a7f6a365d89ac207d58e37e812d900926c63"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"6348b73181cbcab03281986d63d06c162a45acff","unresolved":false,"context_lines":[{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        if CONF.trove_volume_support:"},{"line_number":381,"context_line":"            resource \u003d client.resources.get(stack.id, \u0027DataVolume\u0027)"},{"line_number":382,"context_line":"            self.update_db(compute_instance_id\u003dserver[\u0027id\u0027],"},{"line_number":383,"context_line":"                           volume_id\u003dresource.physical_resource_id)"},{"line_number":384,"context_line":"        else:"},{"line_number":385,"context_line":"            self.update_db(compute_instance_id\u003dserver[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F828s%3D","line":382,"in_reply_to":"AAAATn%2F83Ro%3D","updated":"2013-12-19 14:52:10.000000000","message":"could be used, one and the same thing.\nIt was smaller in length to write server[\u0027id\u0027]","commit_id":"1eb3a7f6a365d89ac207d58e37e812d900926c63"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"fa799e01e06f26e719a255da7c2ad485b1af7d66","unresolved":false,"context_lines":[{"line_number":353,"context_line":"            raise TroveError(\"heat template ascii encode issue\")"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        parameters \u003d {\"Flavor\": flavor[\"name\"],"},{"line_number":356,"context_line":"                      \"VolumeSize\": volume_size,"},{"line_number":357,"context_line":"                      \"InstanceId\": self.id,"},{"line_number":358,"context_line":"                      \"ImageId\": image_id,"},{"line_number":359,"context_line":"                      \"DatastoreManager\": datastore_manager,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F82o4%3D","line":356,"updated":"2013-12-19 15:10:44.000000000","message":"verification here too","commit_id":"ac1acbb3ea8abef2dc0e3127c83778c76f9b9a11"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"605828c4e8ea33984146b5c40d67df2a46e45fb0","unresolved":false,"context_lines":[{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        if CONF.trove_volume_support:"},{"line_number":378,"context_line":"            resource \u003d client.resources.get(stack.id, \u0027DataVolume\u0027)"},{"line_number":379,"context_line":"            self.update_db(compute_instance_id\u003dserver[\u0027id\u0027],"},{"line_number":380,"context_line":"                           volume_id\u003dresource.physical_resource_id)"},{"line_number":381,"context_line":"        else:"},{"line_number":382,"context_line":"            self.update_db(compute_instance_id\u003dserver[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F82rw%3D","line":379,"updated":"2013-12-19 15:03:50.000000000","message":"you used resource.physical_resource_id for volume, why not just use it for instance ?\ni see no reasons for creating twice used server variable with only one att - id\nplaese, let\u0027s keep less code, if it\u0027s possible.","commit_id":"ac1acbb3ea8abef2dc0e3127c83778c76f9b9a11"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"26ee00f0d15d766f88933fc57ab7fe95b0d48c77","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        volume_info \u003d {\u0027device_path\u0027: device_path, \u0027mount_point\u0027: mount_point}"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        LOG.debug(_(\"end _create_server_volume_heat for id: %s\") % self.id)"},{"line_number":390,"context_line":"        return {\u0027id\u0027: instance_id}, volume_info"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    def _create_server_volume_individually(self, flavor_id, image_id,"},{"line_number":393,"context_line":"                                           security_groups, datastore_manager,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2FsvE%3D","line":390,"updated":"2014-01-03 08:56:04.000000000","message":"Do we even need to return this first value in the tuple? From a quick inspection, it seems that \"server\" doesn\u0027t get used anywhere. If that\u0027s the case, it\u0027s probably best to remove it altogether.","commit_id":"7df4dcd06e79b049f963b2043c822fd281639c0e"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"5649f5f8091d3638695860eb0e8b4100b9440129","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        volume_info \u003d {\u0027device_path\u0027: device_path, \u0027mount_point\u0027: mount_point}"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        LOG.debug(_(\"end _create_server_volume_heat for id: %s\") % self.id)"},{"line_number":390,"context_line":"        return {\u0027id\u0027: instance_id}, volume_info"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    def _create_server_volume_individually(self, flavor_id, image_id,"},{"line_number":393,"context_line":"                                           security_groups, datastore_manager,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2Fqtw%3D","line":390,"in_reply_to":"AAAAT3%2F%2Fq3Y%3D","updated":"2014-01-03 20:18:22.000000000","message":"As discussed, adding separate patchset for removal of server from codebase.\n\nhttps://review.openstack.org/#/c/64896","commit_id":"7df4dcd06e79b049f963b2043c822fd281639c0e"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"68ee93c3b23c537c80c0a491b7878d692e77b1f9","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        volume_info \u003d {\u0027device_path\u0027: device_path, \u0027mount_point\u0027: mount_point}"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        LOG.debug(_(\"end _create_server_volume_heat for id: %s\") % self.id)"},{"line_number":390,"context_line":"        return {\u0027id\u0027: instance_id}, volume_info"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    def _create_server_volume_individually(self, flavor_id, image_id,"},{"line_number":393,"context_line":"                                           security_groups, datastore_manager,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FHeY%3D","line":390,"in_reply_to":"AAAAT3%2F%2Fqtw%3D","updated":"2014-01-17 09:27:47.000000000","message":"Okay, the combined changes look good.","commit_id":"7df4dcd06e79b049f963b2043c822fd281639c0e"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"b98f33430081e8615fb4718590e2c2f014b0559a","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        volume_info \u003d {\u0027device_path\u0027: device_path, \u0027mount_point\u0027: mount_point}"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        LOG.debug(_(\"end _create_server_volume_heat for id: %s\") % self.id)"},{"line_number":390,"context_line":"        return {\u0027id\u0027: instance_id}, volume_info"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    def _create_server_volume_individually(self, flavor_id, image_id,"},{"line_number":393,"context_line":"                                           security_groups, datastore_manager,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2Fq3Y%3D","line":390,"in_reply_to":"AAAAT3%2F%2FsTw%3D","updated":"2014-01-03 19:15:03.000000000","message":"I disagree. We are returning a bogus dict for server here. The only reason we can do this is because the value for server isn\u0027t actually used anywhere (apart from a check for success). In this case, I\u0027d prefer this cleanup patch also clean this server return value up, instead of just constructing and returning returning a somewhat random dict in this case.","commit_id":"7df4dcd06e79b049f963b2043c822fd281639c0e"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"f12b8aeab0efa77193a9f35f3c24196c6051e657","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        volume_info \u003d {\u0027device_path\u0027: device_path, \u0027mount_point\u0027: mount_point}"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        LOG.debug(_(\"end _create_server_volume_heat for id: %s\") % self.id)"},{"line_number":390,"context_line":"        return {\u0027id\u0027: instance_id}, volume_info"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    def _create_server_volume_individually(self, flavor_id, image_id,"},{"line_number":393,"context_line":"                                           security_groups, datastore_manager,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2FsTw%3D","line":390,"in_reply_to":"AAAAT3%2F%2FsZk%3D","updated":"2014-01-03 11:11:38.000000000","message":"Agreed with Sushil, only compute server id attribute are used in _create methods, so, patch scope covers case completely, SlickNik \u0027s suggestion deserves it\u0027s own patchset.","commit_id":"7df4dcd06e79b049f963b2043c822fd281639c0e"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"2f6ad18e44fe73de661bcdcd51265f45eefadb59","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        volume_info \u003d {\u0027device_path\u0027: device_path, \u0027mount_point\u0027: mount_point}"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        LOG.debug(_(\"end _create_server_volume_heat for id: %s\") % self.id)"},{"line_number":390,"context_line":"        return {\u0027id\u0027: instance_id}, volume_info"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    def _create_server_volume_individually(self, flavor_id, image_id,"},{"line_number":393,"context_line":"                                           security_groups, datastore_manager,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2FsZk%3D","line":390,"in_reply_to":"AAAAT3%2F%2FsvE%3D","updated":"2014-01-03 10:39:52.000000000","message":"yeah, I too have seen that, during this activity, server is not getting used anywhere, but working with that part it would be needed to change all other methods also.\n\nI would be putting in that code separately as it touches more than heat like other create server methods and prepare code as well as service methods.","commit_id":"7df4dcd06e79b049f963b2043c822fd281639c0e"}],"trove/templates/mysql/heat.template":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b24b4a3e20727e68554cc14ffe9a7fe726ae45ec","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Description: Instance creation template for mysql"},{"line_number":3,"context_line":"Parameters:"},{"line_number":4,"context_line":"  Flavor:"},{"line_number":5,"context_line":"    Type: String"},{"line_number":6,"context_line":"  VolumeSize:"},{"line_number":7,"context_line":"    Type: Number"},{"line_number":8,"context_line":"    Default : \u00271\u0027"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F83Sc%3D","line":5,"updated":"2013-12-19 13:13:03.000000000","message":"If you are adding verifications below, please, be informed that unused parameter would through StackValidationError.","commit_id":"1eb3a7f6a365d89ac207d58e37e812d900926c63"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b9d1993026bc530eaa3ea28327d4b8dcfdeacf96","unresolved":false,"context_lines":[{"line_number":43,"context_line":"          - [\"#!/bin/bash -v\\n\","},{"line_number":44,"context_line":"              \"/opt/aws/bin/cfn-init\\n\","},{"line_number":45,"context_line":"              \"sudo service trove-guest start\\n\"]"},{"line_number":46,"context_line":"{% if volume_support \u003d\u003d \u0027True\u0027 %}"},{"line_number":47,"context_line":"  DataVolume:"},{"line_number":48,"context_line":"    Type: AWS::EC2::Volume"},{"line_number":49,"context_line":"    Properties:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F83Mk%3D","line":46,"updated":"2013-12-19 13:22:55.000000000","message":"{% if volume_support %}","commit_id":"1eb3a7f6a365d89ac207d58e37e812d900926c63"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"6348b73181cbcab03281986d63d06c162a45acff","unresolved":false,"context_lines":[{"line_number":43,"context_line":"          - [\"#!/bin/bash -v\\n\","},{"line_number":44,"context_line":"              \"/opt/aws/bin/cfn-init\\n\","},{"line_number":45,"context_line":"              \"sudo service trove-guest start\\n\"]"},{"line_number":46,"context_line":"{% if volume_support \u003d\u003d \u0027True\u0027 %}"},{"line_number":47,"context_line":"  DataVolume:"},{"line_number":48,"context_line":"    Type: AWS::EC2::Volume"},{"line_number":49,"context_line":"    Properties:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F82zc%3D","line":46,"in_reply_to":"AAAATn%2F83Mk%3D","updated":"2013-12-19 14:52:10.000000000","message":"updating.","commit_id":"1eb3a7f6a365d89ac207d58e37e812d900926c63"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c931fb7d8f606b6b402548dfcb9c791f0eaf2906","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Parameters:"},{"line_number":4,"context_line":"  Flavor:"},{"line_number":5,"context_line":"    Type: String"},{"line_number":6,"context_line":"  VolumeSize:"},{"line_number":7,"context_line":"    Type: Number"},{"line_number":8,"context_line":"    Default : \u00271\u0027"},{"line_number":9,"context_line":"  InstanceId:"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAATn%2F82vA%3D","line":6,"updated":"2013-12-19 14:54:10.000000000","message":"Nothing changed. Please test your patch!","commit_id":"ac1acbb3ea8abef2dc0e3127c83778c76f9b9a11"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"fa799e01e06f26e719a255da7c2ad485b1af7d66","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Parameters:"},{"line_number":4,"context_line":"  Flavor:"},{"line_number":5,"context_line":"    Type: String"},{"line_number":6,"context_line":"  VolumeSize:"},{"line_number":7,"context_line":"    Type: Number"},{"line_number":8,"context_line":"    Default : \u00271\u0027"},{"line_number":9,"context_line":"  InstanceId:"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAATn%2F82pk%3D","line":6,"in_reply_to":"AAAATn%2F82vA%3D","updated":"2013-12-19 15:10:44.000000000","message":"Let\u0027s add verifications here, to make template less confusing to all other guys which are not familiar with heat at all.","commit_id":"ac1acbb3ea8abef2dc0e3127c83778c76f9b9a11"}]}