)]}'
{"run_tests.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"f3052ce4041e7a54b240cbcf370ba160a3e4bee3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Adds the datastore for mysql (needed to make most calls work)."},{"line_number":75,"context_line":"    from trove.datastore import models"},{"line_number":76,"context_line":"    models.DBDatastore.create(id\u003d\"a00000a0-00a0-0a00-00a0-000a000000aa\","},{"line_number":77,"context_line":"                              name\u003dCONFIG.dbaas_datastore, manager\u003d\u0027mysql\u0027,"},{"line_number":78,"context_line":"                              default_version_id\u003d"},{"line_number":79,"context_line":"                              \"b00000b0-00b0-0b00-00b0-000b000000bb\")"},{"line_number":80,"context_line":"    models.DBDatastore.create(id\u003d\"e00000e0-00e0-0e00-00e0-000e000000ee\","}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F6%2F0%3D","line":77,"updated":"2014-01-06 19:17:13.000000000","message":"manager should be removed here.","commit_id":"7c5fe34d574a0a2b8d261feb2cb2d25b71412028"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"f3052ce4041e7a54b240cbcf370ba160a3e4bee3","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                              default_version_id\u003d"},{"line_number":79,"context_line":"                              \"b00000b0-00b0-0b00-00b0-000b000000bb\")"},{"line_number":80,"context_line":"    models.DBDatastore.create(id\u003d\"e00000e0-00e0-0e00-00e0-000e000000ee\","},{"line_number":81,"context_line":"                              name\u003d\u0027Test_Datastore_1\u0027, manager\u003d\u0027manager1\u0027,"},{"line_number":82,"context_line":"                              default_version_id\u003dNone)"},{"line_number":83,"context_line":"    models.DBDatastoreVersion.create(id\u003d\"b00000b0-00b0-0b00-00b0-000b000000bb\","},{"line_number":84,"context_line":"                                     datastore_id\u003d"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F6%2Fw%3D","line":81,"updated":"2014-01-06 19:17:13.000000000","message":"manager should be removed here.","commit_id":"7c5fe34d574a0a2b8d261feb2cb2d25b71412028"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"62ea33a4734b8c0754212aa4980e32988cf9a9ef","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                              default_version_id\u003d"},{"line_number":79,"context_line":"                              \"b00000b0-00b0-0b00-00b0-000b000000bb\")"},{"line_number":80,"context_line":"    models.DBDatastore.create(id\u003d\"e00000e0-00e0-0e00-00e0-000e000000ee\","},{"line_number":81,"context_line":"                              name\u003d\u0027Test_Datastore_1\u0027, manager\u003d\u0027manager1\u0027,"},{"line_number":82,"context_line":"                              default_version_id\u003dNone)"},{"line_number":83,"context_line":"    models.DBDatastoreVersion.create(id\u003d\"b00000b0-00b0-0b00-00b0-000b000000bb\","},{"line_number":84,"context_line":"                                     datastore_id\u003d"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F6zk%3D","line":81,"in_reply_to":"AAAAUH%2F%2F6%2Fw%3D","updated":"2014-01-06 19:55:39.000000000","message":"doh....","commit_id":"7c5fe34d574a0a2b8d261feb2cb2d25b71412028"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"eb0027e4b49311ef62a7090883ae6bf2cfd8cc74","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Adds the datastore for mysql (needed to make most calls work)."},{"line_number":75,"context_line":"    from trove.datastore import models"},{"line_number":76,"context_line":"    models.DBDatastore.create(id\u003d\"a00000a0-00a0-0a00-00a0-000a000000aa\","},{"line_number":77,"context_line":"                              name\u003dCONFIG.dbaas_datastore, manager\u003d\u0027mysql\u0027,"},{"line_number":78,"context_line":"                              default_version_id\u003d"},{"line_number":79,"context_line":"                              \"b00000b0-00b0-0b00-00b0-000b000000bb\")"},{"line_number":80,"context_line":"    models.DBDatastore.create(id\u003d\"e00000e0-00e0-0e00-00e0-000e000000ee\","}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F6cU%3D","line":77,"updated":"2014-01-06 21:21:09.000000000","message":"need to remove manager here.","commit_id":"06e5b2a13e8e194dd60828dc277c6e3290ff850f"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"eb0027e4b49311ef62a7090883ae6bf2cfd8cc74","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                              default_version_id\u003d"},{"line_number":79,"context_line":"                              \"b00000b0-00b0-0b00-00b0-000b000000bb\")"},{"line_number":80,"context_line":"    models.DBDatastore.create(id\u003d\"e00000e0-00e0-0e00-00e0-000e000000ee\","},{"line_number":81,"context_line":"                              name\u003d\u0027Test_Datastore_1\u0027, manager\u003d\u0027manager1\u0027,"},{"line_number":82,"context_line":"                              default_version_id\u003dNone)"},{"line_number":83,"context_line":"    models.DBDatastoreVersion.create(id\u003d\"b00000b0-00b0-0b00-00b0-000b000000bb\","},{"line_number":84,"context_line":"                                     datastore_id\u003d"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F6cQ%3D","line":81,"updated":"2014-01-06 21:21:09.000000000","message":"need to remove manager here.","commit_id":"06e5b2a13e8e194dd60828dc277c6e3290ff850f"}],"trove/db/sqlalchemy/migrate_repo/versions/017_update_datastores.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"f3052ce4041e7a54b240cbcf370ba160a3e4bee3","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from trove.db.sqlalchemy.migrate_repo.schema import String"},{"line_number":19,"context_line":"from trove.db.sqlalchemy.migrate_repo.schema import Table"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def upgrade(migrate_engine):"},{"line_number":23,"context_line":"    meta \u003d MetaData()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F6%2BY%3D","line":20,"updated":"2014-01-06 19:17:13.000000000","message":"Using https://review.openstack.org/#/c/63523/3/trove/db/sqlalchemy/migrate_repo/versions/017_datastore_fix.py as a guide, can you copy the value of datastore.manager to each fk\u0027d datastore_version.manager? This will make the transition seamless for operators and users.\n\nCan others comment on whether such a change should be a new \"version\" vs. updating the existing 017_update_datastores.py?","commit_id":"7c5fe34d574a0a2b8d261feb2cb2d25b71412028"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"19d09baff0c42107f93034b6c19508bd59d82846","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from trove.db.sqlalchemy.migrate_repo.schema import String"},{"line_number":19,"context_line":"from trove.db.sqlalchemy.migrate_repo.schema import Table"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def upgrade(migrate_engine):"},{"line_number":23,"context_line":"    meta \u003d MetaData()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F66U%3D","line":20,"in_reply_to":"AAAAUH%2F%2F6%2BY%3D","updated":"2014-01-06 19:19:12.000000000","message":"I should have been more careful in the way I worded my comment above. By \"copy the value\", I meant copy it if a value does not already exist (given that db_sync can be run multiple times).","commit_id":"7c5fe34d574a0a2b8d261feb2cb2d25b71412028"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"62ea33a4734b8c0754212aa4980e32988cf9a9ef","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from trove.db.sqlalchemy.migrate_repo.schema import String"},{"line_number":19,"context_line":"from trove.db.sqlalchemy.migrate_repo.schema import Table"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def upgrade(migrate_engine):"},{"line_number":23,"context_line":"    meta \u003d MetaData()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F6zM%3D","line":20,"in_reply_to":"AAAAUH%2F%2F66U%3D","updated":"2014-01-06 19:55:39.000000000","message":"Well any change to the db should be a new version because if you attempt a db_sync and version 17 already exists then it will not run on an update.","commit_id":"7c5fe34d574a0a2b8d261feb2cb2d25b71412028"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"f5f322ef9967d7266ddb06d413622a221a5ea9e6","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    # add column to datastore_versions"},{"line_number":30,"context_line":"    manager \u003d Column(\u0027manager\u0027, String(255))"},{"line_number":31,"context_line":"    datastore_versions.create_column(manager)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    # drop column from datastores"},{"line_number":34,"context_line":"    datastores.drop_column(\u0027manager\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F7W8%3D","line":31,"updated":"2014-01-06 17:27:22.000000000","message":"Does this need a default value to be inserted?","commit_id":"7c5fe34d574a0a2b8d261feb2cb2d25b71412028"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"f3052ce4041e7a54b240cbcf370ba160a3e4bee3","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    # add column to datastore_versions"},{"line_number":30,"context_line":"    manager \u003d Column(\u0027manager\u0027, String(255))"},{"line_number":31,"context_line":"    datastore_versions.create_column(manager)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    # drop column from datastores"},{"line_number":34,"context_line":"    datastores.drop_column(\u0027manager\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F6%2BU%3D","line":31,"in_reply_to":"AAAAUH%2F%2F7W8%3D","updated":"2014-01-06 19:17:13.000000000","message":"Robert: Thanks for this comment, it triggered the thought/comment above.","commit_id":"7c5fe34d574a0a2b8d261feb2cb2d25b71412028"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"eb0027e4b49311ef62a7090883ae6bf2cfd8cc74","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from trove.db.sqlalchemy.migrate_repo.schema import String"},{"line_number":19,"context_line":"from trove.db.sqlalchemy.migrate_repo.schema import Table"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def upgrade(migrate_engine):"},{"line_number":23,"context_line":"    meta \u003d MetaData()"},{"line_number":24,"context_line":"    meta.bind \u003d migrate_engine"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F6bA%3D","line":21,"updated":"2014-01-06 21:21:09.000000000","message":"Using https://review.openstack.org/#/c/63523/3/trove/db/sqlalchemy/migrate_repo/versions/017_datastore_fix.py as a guide, can you copy the value of datastore.manager to each fk\u0027d datastore_version.manager? This will make the transition seamless for operators and users.","commit_id":"06e5b2a13e8e194dd60828dc277c6e3290ff850f"}],"trove/taskmanager/api.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"f3052ce4041e7a54b240cbcf370ba160a3e4bee3","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                                              backup_id\u003dbackup_id))"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def create_instance(self, instance_id, name, flavor,"},{"line_number":103,"context_line":"                        image_id, databases, users, datastore_version_manager,"},{"line_number":104,"context_line":"                        packages, volume_size, backup_id\u003dNone,"},{"line_number":105,"context_line":"                        availability_zone\u003dNone, root_password\u003dNone):"},{"line_number":106,"context_line":"        LOG.debug(\"Making async call to create instance %s \" % instance_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F67E%3D","line":103,"updated":"2014-01-06 19:17:13.000000000","message":"I would argue that it should remain named \"datastore_manager\" across the codebase, the reason being is that CONF.datastore_manager is still in-play, plus not all references of \"datastore_manager\" were updated to \"datastore_version_manager\" in this patch-set. By keeping it the same, your patch-set becomes smaller (only datastore.manager to datastore_version.manager), the level of risk is reduced, and consistency of terminology is maintained.","commit_id":"7c5fe34d574a0a2b8d261feb2cb2d25b71412028"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"62ea33a4734b8c0754212aa4980e32988cf9a9ef","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                                              backup_id\u003dbackup_id))"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def create_instance(self, instance_id, name, flavor,"},{"line_number":103,"context_line":"                        image_id, databases, users, datastore_version_manager,"},{"line_number":104,"context_line":"                        packages, volume_size, backup_id\u003dNone,"},{"line_number":105,"context_line":"                        availability_zone\u003dNone, root_password\u003dNone):"},{"line_number":106,"context_line":"        LOG.debug(\"Making async call to create instance %s \" % instance_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F6zE%3D","line":103,"in_reply_to":"AAAAUH%2F%2F67E%3D","updated":"2014-01-06 19:55:39.000000000","message":"ok","commit_id":"7c5fe34d574a0a2b8d261feb2cb2d25b71412028"}]}