)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"77211e1954d69cc17a5ee28d47b2bf73a67350bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9fdfeff1_77799f2d","updated":"2019-02-06 08:35:52.000000000","message":"Could you please say more in the commit message why this change is needed?","commit_id":"068876a24b85c63c2096a0f380e2543b81ec34b7"}],"devstack/plugin.sh":[{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"77211e1954d69cc17a5ee28d47b2bf73a67350bd","unresolved":false,"context_lines":[{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    export TROVE_GUESTAGENT_CONF\u003d${TROVE_GUESTAGENT_CONF:-\u0027/etc/trove/trove-guestagent.conf\u0027}"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    sudo rm -rf ${SSH_DIR}; mkdir -p ${SSH_DIR}"},{"line_number":627,"context_line":"    /usr/bin/ssh-keygen -f ${SSH_DIR}/id_rsa -q -N \"\""},{"line_number":628,"context_line":"    cat ${SSH_DIR}/id_rsa.pub \u003e\u003e ${SSH_DIR}/authorized_keys"},{"line_number":629,"context_line":"    chmod 600 ${SSH_DIR}/authorized_keys"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9fdfeff1_77cbdf71","line":626,"range":{"start_line":626,"start_character":4,"end_line":626,"end_character":8},"updated":"2019-02-06 08:35:52.000000000","message":"Are administration privileges needed for this action?","commit_id":"068876a24b85c63c2096a0f380e2543b81ec34b7"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"77211e1954d69cc17a5ee28d47b2bf73a67350bd","unresolved":false,"context_lines":[{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    export TROVE_GUESTAGENT_CONF\u003d${TROVE_GUESTAGENT_CONF:-\u0027/etc/trove/trove-guestagent.conf\u0027}"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    sudo rm -rf ${SSH_DIR}; mkdir -p ${SSH_DIR}"},{"line_number":627,"context_line":"    /usr/bin/ssh-keygen -f ${SSH_DIR}/id_rsa -q -N \"\""},{"line_number":628,"context_line":"    cat ${SSH_DIR}/id_rsa.pub \u003e\u003e ${SSH_DIR}/authorized_keys"},{"line_number":629,"context_line":"    chmod 600 ${SSH_DIR}/authorized_keys"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9fdfeff1_b7ae2796","line":626,"range":{"start_line":626,"start_character":9,"end_line":626,"end_character":15},"updated":"2019-02-06 08:35:52.000000000","message":"Be careful with using rm with the recursive flag.\nIt would be more secure to pass a full path to the files:\nrm ${SSH_DIR}/id_rsa ${SSH_DIR}/id_rsa.pub","commit_id":"068876a24b85c63c2096a0f380e2543b81ec34b7"},{"author":{"_account_id":29393,"name":"Dariusz Król","email":"dkrol3@gmail.com","username":"d.krol"},"change_message_id":"2ff6bb2b1b3a7b0b1b6121bede024d88f3674984","unresolved":false,"context_lines":[{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    export TROVE_GUESTAGENT_CONF\u003d${TROVE_GUESTAGENT_CONF:-\u0027/etc/trove/trove-guestagent.conf\u0027}"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    sudo rm -rf ${SSH_DIR}; mkdir -p ${SSH_DIR}"},{"line_number":627,"context_line":"    /usr/bin/ssh-keygen -f ${SSH_DIR}/id_rsa -q -N \"\""},{"line_number":628,"context_line":"    cat ${SSH_DIR}/id_rsa.pub \u003e\u003e ${SSH_DIR}/authorized_keys"},{"line_number":629,"context_line":"    chmod 600 ${SSH_DIR}/authorized_keys"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9fdfeff1_9bcf4a7e","line":626,"range":{"start_line":626,"start_character":9,"end_line":626,"end_character":15},"in_reply_to":"9fdfeff1_4d3dec2a","updated":"2019-02-10 21:30:36.000000000","message":"We are creating this directory as a non-sudo user. Maybe we could skip sudo here ?\nAlso I\u0027m worried what will happen if SSH_DIR is not set ?","commit_id":"068876a24b85c63c2096a0f380e2543b81ec34b7"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"36576b5e1d7ea72d2b1e8dc3807e1820ab70d55a","unresolved":false,"context_lines":[{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    export TROVE_GUESTAGENT_CONF\u003d${TROVE_GUESTAGENT_CONF:-\u0027/etc/trove/trove-guestagent.conf\u0027}"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    sudo rm -rf ${SSH_DIR}; mkdir -p ${SSH_DIR}"},{"line_number":627,"context_line":"    /usr/bin/ssh-keygen -f ${SSH_DIR}/id_rsa -q -N \"\""},{"line_number":628,"context_line":"    cat ${SSH_DIR}/id_rsa.pub \u003e\u003e ${SSH_DIR}/authorized_keys"},{"line_number":629,"context_line":"    chmod 600 ${SSH_DIR}/authorized_keys"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9fdfeff1_2d4428b7","line":626,"range":{"start_line":626,"start_character":4,"end_line":626,"end_character":8},"in_reply_to":"9fdfeff1_77cbdf71","updated":"2019-02-06 11:25:28.000000000","message":"Not sure, because we really want to remove the folder.","commit_id":"068876a24b85c63c2096a0f380e2543b81ec34b7"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"0751dc6582a155be5d7ac4470a733eae7b420a68","unresolved":false,"context_lines":[{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    export TROVE_GUESTAGENT_CONF\u003d${TROVE_GUESTAGENT_CONF:-\u0027/etc/trove/trove-guestagent.conf\u0027}"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    sudo rm -rf ${SSH_DIR}; mkdir -p ${SSH_DIR}"},{"line_number":627,"context_line":"    /usr/bin/ssh-keygen -f ${SSH_DIR}/id_rsa -q -N \"\""},{"line_number":628,"context_line":"    cat ${SSH_DIR}/id_rsa.pub \u003e\u003e ${SSH_DIR}/authorized_keys"},{"line_number":629,"context_line":"    chmod 600 ${SSH_DIR}/authorized_keys"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9fdfeff1_fb37764c","line":626,"range":{"start_line":626,"start_character":9,"end_line":626,"end_character":15},"in_reply_to":"9fdfeff1_9bcf4a7e","updated":"2019-02-10 22:48:29.000000000","message":"If not set, `SSH_DIR` is given a default value, see here:\n\n    export SSH_DIR\u003d${SSH_DIR:-\u0027/opt/stack/.ssh\u0027}","commit_id":"068876a24b85c63c2096a0f380e2543b81ec34b7"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"36576b5e1d7ea72d2b1e8dc3807e1820ab70d55a","unresolved":false,"context_lines":[{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    export TROVE_GUESTAGENT_CONF\u003d${TROVE_GUESTAGENT_CONF:-\u0027/etc/trove/trove-guestagent.conf\u0027}"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    sudo rm -rf ${SSH_DIR}; mkdir -p ${SSH_DIR}"},{"line_number":627,"context_line":"    /usr/bin/ssh-keygen -f ${SSH_DIR}/id_rsa -q -N \"\""},{"line_number":628,"context_line":"    cat ${SSH_DIR}/id_rsa.pub \u003e\u003e ${SSH_DIR}/authorized_keys"},{"line_number":629,"context_line":"    chmod 600 ${SSH_DIR}/authorized_keys"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9fdfeff1_4d3dec2a","line":626,"range":{"start_line":626,"start_character":9,"end_line":626,"end_character":15},"in_reply_to":"9fdfeff1_b7ae2796","updated":"2019-02-06 11:25:28.000000000","message":"Yeah, I agree with you that using accurate path is the best practice, but in this case, i think we are safe because the `SSH_DIR` is the actual folder we want to remove.","commit_id":"068876a24b85c63c2096a0f380e2543b81ec34b7"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"437223b60258bfa1e1e2b1f3398d7c502bf211bc","unresolved":false,"context_lines":[{"line_number":627,"context_line":"        cat ${SSH_DIR}/id_rsa.pub \u003e\u003e ${SSH_DIR}/authorized_keys"},{"line_number":628,"context_line":"    else"},{"line_number":629,"context_line":"        mkdir -p ${SSH_DIR}"},{"line_number":630,"context_line":"        /usr/bin/ssh-keygen -f ${SSH_DIR}/id_rsa -q -N \"\""},{"line_number":631,"context_line":"        cat ${SSH_DIR}/id_rsa.pub \u003e\u003e ${SSH_DIR}/authorized_keys"},{"line_number":632,"context_line":"        chmod 600 ${SSH_DIR}/authorized_keys"},{"line_number":633,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"9fdfeff1_aba0a491","line":630,"range":{"start_line":630,"start_character":8,"end_line":630,"end_character":27},"updated":"2019-02-12 09:58:08.000000000","message":"Why absolute path?","commit_id":"73e4419615d87e70049a2261f5c24a982986c53d"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"3fd1811ab131074bbcf2124d1a6dc65260a6150e","unresolved":false,"context_lines":[{"line_number":627,"context_line":"        cat ${SSH_DIR}/id_rsa.pub \u003e\u003e ${SSH_DIR}/authorized_keys"},{"line_number":628,"context_line":"    else"},{"line_number":629,"context_line":"        mkdir -p ${SSH_DIR}"},{"line_number":630,"context_line":"        /usr/bin/ssh-keygen -f ${SSH_DIR}/id_rsa -q -N \"\""},{"line_number":631,"context_line":"        cat ${SSH_DIR}/id_rsa.pub \u003e\u003e ${SSH_DIR}/authorized_keys"},{"line_number":632,"context_line":"        chmod 600 ${SSH_DIR}/authorized_keys"},{"line_number":633,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"9fdfeff1_6bf06f92","line":630,"range":{"start_line":630,"start_character":8,"end_line":630,"end_character":27},"in_reply_to":"9fdfeff1_aba0a491","updated":"2019-02-12 19:21:33.000000000","message":"I just keep the full path not changed in this patch, because it just works before and not related to the problem I want to fix. \n\nIf you think absolute path should not be used here, please consider changing that in a separate patch.","commit_id":"73e4419615d87e70049a2261f5c24a982986c53d"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"437223b60258bfa1e1e2b1f3398d7c502bf211bc","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        mkdir -p ${SSH_DIR}"},{"line_number":630,"context_line":"        /usr/bin/ssh-keygen -f ${SSH_DIR}/id_rsa -q -N \"\""},{"line_number":631,"context_line":"        cat ${SSH_DIR}/id_rsa.pub \u003e\u003e ${SSH_DIR}/authorized_keys"},{"line_number":632,"context_line":"        chmod 600 ${SSH_DIR}/authorized_keys"},{"line_number":633,"context_line":"    fi"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    echo \"Run disk image create to actually create a new image\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"9fdfeff1_0b90d042","line":632,"range":{"start_line":632,"start_character":14,"end_line":632,"end_character":17},"updated":"2019-02-12 09:58:08.000000000","message":"It should be 700.\nWithout executable bit user will be able to list files inside but will not be able to enter to the directory and access to files inside.","commit_id":"73e4419615d87e70049a2261f5c24a982986c53d"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"3fd1811ab131074bbcf2124d1a6dc65260a6150e","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        mkdir -p ${SSH_DIR}"},{"line_number":630,"context_line":"        /usr/bin/ssh-keygen -f ${SSH_DIR}/id_rsa -q -N \"\""},{"line_number":631,"context_line":"        cat ${SSH_DIR}/id_rsa.pub \u003e\u003e ${SSH_DIR}/authorized_keys"},{"line_number":632,"context_line":"        chmod 600 ${SSH_DIR}/authorized_keys"},{"line_number":633,"context_line":"    fi"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    echo \"Run disk image create to actually create a new image\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"9fdfeff1_cbf71b8b","line":632,"range":{"start_line":632,"start_character":14,"end_line":632,"end_character":17},"in_reply_to":"9fdfeff1_0b90d042","updated":"2019-02-12 19:21:33.000000000","message":"The .ssh folder permission should be 700, and authorized_keys file should be 600 or 644. Anyway, it\u0027s not part of this patch, neither.","commit_id":"73e4419615d87e70049a2261f5c24a982986c53d"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"aa938b2751e0b1848f69dafc4c4db6002cfbc5f8","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        mkdir -p ${SSH_DIR}"},{"line_number":630,"context_line":"        /usr/bin/ssh-keygen -f ${SSH_DIR}/id_rsa -q -N \"\""},{"line_number":631,"context_line":"        cat ${SSH_DIR}/id_rsa.pub \u003e\u003e ${SSH_DIR}/authorized_keys"},{"line_number":632,"context_line":"        chmod 600 ${SSH_DIR}/authorized_keys"},{"line_number":633,"context_line":"    fi"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    echo \"Run disk image create to actually create a new image\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"9fdfeff1_da41223b","line":632,"range":{"start_line":632,"start_character":14,"end_line":632,"end_character":17},"in_reply_to":"9fdfeff1_cbf71b8b","updated":"2019-02-12 20:35:54.000000000","message":"Yeah, it\u0027s fine. I thought it is set for .ssh folder.","commit_id":"73e4419615d87e70049a2261f5c24a982986c53d"}]}