)]}'
{"trove/datastore/models.py":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"618df222354025d68542fc6c317230700754d489","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        datastore \u003d DBDatastore.find_by(name\u003dname)"},{"line_number":188,"context_line":"        if default_version:"},{"line_number":189,"context_line":"            version \u003d DatastoreVersion.load(datastore, default_version)"},{"line_number":190,"context_line":"            if not version.active:"},{"line_number":191,"context_line":"                raise exception.DatastoreVersionInactive(version\u003d"},{"line_number":192,"context_line":"                                                         version.name)"},{"line_number":193,"context_line":"            datastore.default_version_id \u003d version.id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F0Ug%3D","line":190,"updated":"2013-12-30 22:03:40.000000000","message":"Is this even possible? The query above filters \u0027active\u003dTrue\u0027 so it could not be False","commit_id":"a8e60494659a72c9cbcbdc017a6390513862c251"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"c11334e8166e8a6a99be6cbe8c9ff1bfc3d4e628","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        datastore \u003d DBDatastore.find_by(name\u003dname)"},{"line_number":188,"context_line":"        if default_version:"},{"line_number":189,"context_line":"            version \u003d DatastoreVersion.load(datastore, default_version)"},{"line_number":190,"context_line":"            if not version.active:"},{"line_number":191,"context_line":"                raise exception.DatastoreVersionInactive(version\u003d"},{"line_number":192,"context_line":"                                                         version.name)"},{"line_number":193,"context_line":"            datastore.default_version_id \u003d version.id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FfxI%3D","line":190,"in_reply_to":"AAAAT3%2F%2F0Ug%3D","updated":"2014-01-13 10:20:36.000000000","message":"that query returns version independent on active field","commit_id":"a8e60494659a72c9cbcbdc017a6390513862c251"}],"trove/datastore/views.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7013994ed3e8b06e6b78083b4fef968a97df33ab","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from trove.common.views import create_links"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F8ouQ%3D","side":"PARENT","line":18,"updated":"2013-12-23 22:31:07.000000000","message":"please return header","commit_id":"84dbe87c22eb45934e57eef36bd88b350fc141f8"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"942dace632fb4479cef80ca8b15eda6c6b9f8f29","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        datastore_version_dict \u003d {"},{"line_number":73,"context_line":"            \"id\": self.datastore_version.id,"},{"line_number":74,"context_line":"            \"name\": self.datastore_version.name,"},{"line_number":75,"context_line":"            \"datastore_id\": self.datastore_version.datastore_id,"},{"line_number":76,"context_line":"            \"links\": self._build_links(),"},{"line_number":77,"context_line":"        }"},{"line_number":78,"context_line":"        if self.context.is_admin:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2B%2BoI%3D","line":75,"updated":"2014-01-20 07:26:15.000000000","message":"every other public occurrence uses \"datastore\" vs. \"datastore_id\". make sure to update trove/tests/api/datastores.py line #100 as well.","commit_id":"ba4cdc2ed8842217d0d84d6384e2770907d9bc3f"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"573648fbf95b93467d5b2b14f8689d4fda418aec","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        datastore_version_dict \u003d {"},{"line_number":73,"context_line":"            \"id\": self.datastore_version.id,"},{"line_number":74,"context_line":"            \"name\": self.datastore_version.name,"},{"line_number":75,"context_line":"            \"datastore_id\": self.datastore_version.datastore_id,"},{"line_number":76,"context_line":"            \"links\": self._build_links(),"},{"line_number":77,"context_line":"        }"},{"line_number":78,"context_line":"        if self.context.is_admin:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2B%2BkA%3D","line":75,"in_reply_to":"AAAAUH%2F%2B%2BoI%3D","updated":"2014-01-20 07:27:42.000000000","message":"correction: line #89 and line #100.","commit_id":"ba4cdc2ed8842217d0d84d6384e2770907d9bc3f"}],"trove/db/sqlalchemy/migrate_repo/versions/016_add_datastore_type.py":[{"author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"change_message_id":"ad3e4152122b09cedf94c1c67a94f3061c4aa453","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    meta,"},{"line_number":43,"context_line":"    Column(\u0027id\u0027, String(36), primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":44,"context_line":"    Column(\u0027datastore_id\u0027, String(36), ForeignKey(\u0027datastores.id\u0027)),"},{"line_number":45,"context_line":"    Column(\u0027name\u0027, String(255)),"},{"line_number":46,"context_line":"    Column(\u0027image_id\u0027, String(36), nullable\u003dFalse),"},{"line_number":47,"context_line":"    Column(\u0027packages\u0027, String(511)),"},{"line_number":48,"context_line":"    Column(\u0027active\u0027, Boolean(), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F8ooY%3D","line":45,"updated":"2013-12-23 23:02:50.000000000","message":"Shouldn\u0027t this be a new file?  Otherwise anyone who has migrated to this version won\u0027t receive this change and the future behavior will be incorrect for their installation.","commit_id":"07980c795f037b4784ed9fdf46e2c168f7f5151e"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"5992d13e833982312016348c35ed2341b6d2ccf5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    meta,"},{"line_number":43,"context_line":"    Column(\u0027id\u0027, String(36), primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":44,"context_line":"    Column(\u0027datastore_id\u0027, String(36), ForeignKey(\u0027datastores.id\u0027)),"},{"line_number":45,"context_line":"    Column(\u0027name\u0027, String(255)),"},{"line_number":46,"context_line":"    Column(\u0027image_id\u0027, String(36), nullable\u003dFalse),"},{"line_number":47,"context_line":"    Column(\u0027packages\u0027, String(511)),"},{"line_number":48,"context_line":"    Column(\u0027active\u0027, Boolean(), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F8nSY%3D","line":45,"in_reply_to":"AAAATn%2F8ooY%3D","updated":"2013-12-24 10:06:11.000000000","message":"yes, this changes should be in next version file\n\nthis review is not ready","commit_id":"07980c795f037b4784ed9fdf46e2c168f7f5151e"}],"trove/db/sqlalchemy/migrate_repo/versions/018_datastore_versions_fix.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"942dace632fb4479cef80ca8b15eda6c6b9f8f29","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from trove.db.sqlalchemy.migrate_repo.schema import Table"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def upgrade(migrate_engine):"},{"line_number":21,"context_line":"    meta \u003d MetaData()"},{"line_number":22,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":23,"context_line":"    datastore_versions \u003d Table(\u0027datastore_versions\u0027, meta, autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2B%2BnQ%3D","line":20,"updated":"2014-01-20 07:26:15.000000000","message":"note to others: there\u0027s already a unique constraint to ensure that a datastore has unique version names (via UniqueConstraint(\u0027datastore_id\u0027, \u0027name\u0027, name\u003d\u0027ds_versions\u0027)). given the aforementioned, \u0027name\u0027 itself shouldn\u0027t be unique\u003dTrue, hence this change.","commit_id":"ba4cdc2ed8842217d0d84d6384e2770907d9bc3f"}],"trove/tests/api/datastores.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"942dace632fb4479cef80ca8b15eda6c6b9f8f29","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        assert_equal(version.name, test_config.dbaas_datastore_version)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @test"},{"line_number":94,"context_line":"    def test_datastore_version_get_by_uuid_attrs(self):"},{"line_number":95,"context_line":"        version \u003d self.rd_client.datastore_versions.get_by_uuid("},{"line_number":96,"context_line":"            test_config.dbaas_datastore_version_id)"},{"line_number":97,"context_line":"        with TypeCheck(\u0027DatastoreVersion\u0027, version) as check:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2B%2Bkg%3D","line":94,"updated":"2014-01-20 07:26:15.000000000","message":"note to others: this will fail until https://review.openstack.org/#/c/60588/7/troveclient/v1/datastores.py merges.","commit_id":"ba4cdc2ed8842217d0d84d6384e2770907d9bc3f"}]}