)]}'
{"trove/common/rpc/impl_fake.py":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"017edf61b7dab803628188e0e99f2f19319a7c8f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import eventlet"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from trove.openstack.common.rpc.impl_fake import cast"},{"line_number":25,"context_line":"# F401 unused imports needed for tox tests"},{"line_number":26,"context_line":"from trove.openstack.common.rpc.impl_fake import create_connection  # noqa"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2F0NU%3D","line":25,"updated":"2013-12-30 22:26:03.000000000","message":"instead of # noqa you can just do \u0027assert create_connection\u0027 below. Then it will pass all the flake tests and be valid.","commit_id":"34639512dbfc04668b6b199b9e0604e9279e0eff"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"69a84557c0ca6c07a84a75b62eca96f73757adf4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import eventlet"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from trove.openstack.common.rpc.impl_fake import cast"},{"line_number":25,"context_line":"# F401 unused imports needed for tox tests"},{"line_number":26,"context_line":"from trove.openstack.common.rpc.impl_fake import create_connection  # noqa"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2FzX8%3D","line":25,"in_reply_to":"AAAAT3%2F%2F0NU%3D","updated":"2013-12-31 07:02:48.000000000","message":"done.","commit_id":"34639512dbfc04668b6b199b9e0604e9279e0eff"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"0b11f92ce2b701f403019fadb56eb79bc2e76092","unresolved":false,"context_lines":[{"line_number":35,"context_line":"cast \u003d non_blocking_cast"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"assert True, create_connection"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2Fq24%3D","line":38,"updated":"2014-01-03 20:50:00.000000000","message":"what does this do?\n\nThis is in the common rpc fake so i am not sure why you would do this?","commit_id":"fd38bc2e324d152e7f73b834ba1d04d3ab069976"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"8e3267e0a04bf727731afdb6e5f4330771adf0d5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"cast \u003d non_blocking_cast"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"assert True, create_connection"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2FqmE%3D","line":38,"in_reply_to":"AAAAT3%2F%2Fq24%3D","updated":"2014-01-03 20:57:35.000000000","message":"We needed to have create_connection imported in this file for tests to work and since there was no used code of this method so it was introducong pep8 errors.\n\nSo this assert was suggested by Robert Myers to be used so that we do not need a # noqa to override pep8.","commit_id":"fd38bc2e324d152e7f73b834ba1d04d3ab069976"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"129cd4ecb7f680a40aa1245f336b4f49a74c4a9b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"cast \u003d non_blocking_cast"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"assert True, create_connection"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F7ws%3D","line":38,"in_reply_to":"AAAAT3%2F%2FqmE%3D","updated":"2014-01-06 15:50:50.000000000","message":"Yes, this should just be \u0027assert create_connection\u0027 this is to get around pep8 rules which require you to use all imported modules. Instead of using # noqa which will disable all checking of the line. I just think this is cleaner, possibly you should add a comment why this is here.","commit_id":"fd38bc2e324d152e7f73b834ba1d04d3ab069976"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"95baf1fd3568f45cecd61ed67f0adbb9058d9842","unresolved":false,"context_lines":[{"line_number":35,"context_line":"cast \u003d non_blocking_cast"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"assert True, create_connection"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F7vs%3D","line":38,"in_reply_to":"AAAAUH%2F%2F7ws%3D","updated":"2014-01-06 16:08:23.000000000","message":"Fine, updating patch-set with comment.","commit_id":"fd38bc2e324d152e7f73b834ba1d04d3ab069976"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"f0f7080afac5c1c67d13dd959e273f7ed6451048","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import eventlet"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from trove.openstack.common.rpc.impl_fake import cast"},{"line_number":25,"context_line":"from trove.openstack.common.rpc.impl_fake import create_connection"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"original_cast \u003d cast"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2Fyvs%3D","line":25,"updated":"2014-01-08 12:04:53.000000000","message":"nit: you can use \n\n from trove.openstack.common.rpc.impl_fake import create_connection  # noqa\n\ninstead of lines 36-39","commit_id":"167c0ceb7a49ba3a687883eff86074d15b917493"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"3f18b20fe84f75bd6153ff5a87b98e2247159a4b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import eventlet"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from trove.openstack.common.rpc.impl_fake import cast"},{"line_number":25,"context_line":"from trove.openstack.common.rpc.impl_fake import create_connection"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"original_cast \u003d cast"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2Fyso%3D","line":25,"in_reply_to":"AAAAUH%2F%2Fyvs%3D","updated":"2014-01-08 12:16:33.000000000","message":"I used that earlier, but got the suggestion to use assert instead of noqa","commit_id":"167c0ceb7a49ba3a687883eff86074d15b917493"}],"trove/tests/api/header.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"59e740a0d62c84e20641d4d387811acfb022e6a6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from proboscis import test"},{"line_number":20,"context_line":"from proboscis.asserts import assert_raises"},{"line_number":21,"context_line":"from proboscis import SkipTest"},{"line_number":22,"context_line":"from functools import wraps"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FzYk%3D","line":20,"updated":"2014-01-08 09:24:22.000000000","message":"what about \"import only modules\" rule? You made a similar change in the instances_actions.py file (at least) and used \"from proboscis import asserts\" there.","commit_id":"c784eacc999f87b93fe3f03ed6182c75c668c61c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"91b7f8d2ad98a4cba3da08e83722fe3a0f2fbd39","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from proboscis import test"},{"line_number":20,"context_line":"from proboscis.asserts import assert_raises"},{"line_number":21,"context_line":"from proboscis import SkipTest"},{"line_number":22,"context_line":"from functools import wraps"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Fy%2Fk%3D","line":20,"in_reply_to":"AAAAUH%2F%2FzYk%3D","updated":"2014-01-08 10:47:33.000000000","message":"\"import only modules\" rule is still ignored, so, author is able to do anything only in terms of patchset description.\nMain idea is that such suggestion is out of scope of patch.","commit_id":"c784eacc999f87b93fe3f03ed6182c75c668c61c"}],"trove/tests/api/instances_actions.py":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"017edf61b7dab803628188e0e99f2f19319a7c8f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from proboscis import after_class"},{"line_number":19,"context_line":"from proboscis import before_class"},{"line_number":20,"context_line":"from proboscis import test"},{"line_number":21,"context_line":"from proboscis.asserts import assert_equal, assert_true, assert_raises,\\"},{"line_number":22,"context_line":"    assert_not_equal"},{"line_number":23,"context_line":"from proboscis.decorators import time_out"},{"line_number":24,"context_line":"from proboscis import SkipTest"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2F0NI%3D","line":21,"updated":"2013-12-30 22:26:03.000000000","message":"one import per line please","commit_id":"34639512dbfc04668b6b199b9e0604e9279e0eff"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"69a84557c0ca6c07a84a75b62eca96f73757adf4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from proboscis import after_class"},{"line_number":19,"context_line":"from proboscis import before_class"},{"line_number":20,"context_line":"from proboscis import test"},{"line_number":21,"context_line":"from proboscis.asserts import assert_equal, assert_true, assert_raises,\\"},{"line_number":22,"context_line":"    assert_not_equal"},{"line_number":23,"context_line":"from proboscis.decorators import time_out"},{"line_number":24,"context_line":"from proboscis import SkipTest"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2FzX4%3D","line":21,"in_reply_to":"AAAAT3%2F%2F0NI%3D","updated":"2013-12-31 07:02:48.000000000","message":"done.","commit_id":"34639512dbfc04668b6b199b9e0604e9279e0eff"}],"trove/tests/api/mgmt/malformed_json.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"59e740a0d62c84e20641d4d387811acfb022e6a6","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from collections import deque"},{"line_number":20,"context_line":"from proboscis import test"},{"line_number":21,"context_line":"from proboscis.asserts import assert_equal"},{"line_number":22,"context_line":"from proboscis import after_class"},{"line_number":23,"context_line":"from proboscis import before_class"},{"line_number":24,"context_line":"import troveclient.compat"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FzYc%3D","line":21,"updated":"2014-01-08 09:24:22.000000000","message":"ditto","commit_id":"c784eacc999f87b93fe3f03ed6182c75c668c61c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"91b7f8d2ad98a4cba3da08e83722fe3a0f2fbd39","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from collections import deque"},{"line_number":20,"context_line":"from proboscis import test"},{"line_number":21,"context_line":"from proboscis.asserts import assert_equal"},{"line_number":22,"context_line":"from proboscis import after_class"},{"line_number":23,"context_line":"from proboscis import before_class"},{"line_number":24,"context_line":"import troveclient.compat"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Fy%2Fc%3D","line":21,"in_reply_to":"AAAAUH%2F%2FzYc%3D","updated":"2014-01-08 10:47:33.000000000","message":"Same thing. Until \"import only modules\" rule ignored we have no strict rules on object importing.","commit_id":"c784eacc999f87b93fe3f03ed6182c75c668c61c"}],"trove/tests/unittests/common/test_remote.py":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"017edf61b7dab803628188e0e99f2f19319a7c8f","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from mockito import mock, when, unstub"},{"line_number":20,"context_line":"import testtools"},{"line_number":21,"context_line":"from testtools.matchers import Is, Not, KeysEqual, Equals, IsInstance"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import swiftclient.client"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2F0M4%3D","line":21,"updated":"2013-12-30 22:26:03.000000000","message":"from testtools import matchers; then below change all instances to matchers.foo","commit_id":"34639512dbfc04668b6b199b9e0604e9279e0eff"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"69a84557c0ca6c07a84a75b62eca96f73757adf4","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from mockito import mock, when, unstub"},{"line_number":20,"context_line":"import testtools"},{"line_number":21,"context_line":"from testtools.matchers import Is, Not, KeysEqual, Equals, IsInstance"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import swiftclient.client"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2FzX0%3D","line":21,"in_reply_to":"AAAAT3%2F%2F0M4%3D","updated":"2013-12-31 07:02:48.000000000","message":"done.","commit_id":"34639512dbfc04668b6b199b9e0604e9279e0eff"}],"trove/tests/util/client.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"59e740a0d62c84e20641d4d387811acfb022e6a6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from proboscis import asserts"},{"line_number":31,"context_line":"from trove.tests.config import CONFIG"},{"line_number":32,"context_line":"from troveclient.compat.xml import TroveXmlClient"},{"line_number":33,"context_line":"from trove.openstack.common import processutils"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FzXQ%3D","line":30,"updated":"2014-01-08 09:24:22.000000000","message":"please add an empty line after it","commit_id":"c784eacc999f87b93fe3f03ed6182c75c668c61c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"91b7f8d2ad98a4cba3da08e83722fe3a0f2fbd39","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from proboscis import asserts"},{"line_number":31,"context_line":"from trove.tests.config import CONFIG"},{"line_number":32,"context_line":"from troveclient.compat.xml import TroveXmlClient"},{"line_number":33,"context_line":"from trove.openstack.common import processutils"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Fy%2FY%3D","line":30,"in_reply_to":"AAAAUH%2F%2FzXQ%3D","updated":"2014-01-08 10:47:33.000000000","message":"agreed","commit_id":"c784eacc999f87b93fe3f03ed6182c75c668c61c"}]}