)]}'
{"releasenotes/notes/deprecate-default_neutron_networks-84cd00224d6b7bc1.yaml":[{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"0e5834e8744eeaf47c4648c69875a0b70b621403","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3fce034c_7d56155f","updated":"2019-04-17 07:18:55.000000000","message":"Modification in this file is not related to the change. Please, introduce fixes to release notes in a separate change.","commit_id":"88587e8c743ac09401a29611da042a6220fb4093"}],"releasenotes/notes/releasenotes/notes/fix-endpoint_type-option-not-used-with-single-tenant-f3e8b0f2807a026d.yaml":[{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"0e5834e8744eeaf47c4648c69875a0b70b621403","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3fce034c_9d518165","updated":"2019-04-17 07:18:55.000000000","message":"Modification in this file is not related to the change. Please, introduce fixes to release notes in a separate change.","commit_id":"88587e8c743ac09401a29611da042a6220fb4093"}],"trove/common/cfg.py":[{"author":{"_account_id":29995,"name":"Kasper Hasior","email":"k.hasior@partner.samsung.com","username":"k.hasior"},"change_message_id":"31c68340c77e97c67c705ae5866a43c0c21c2b0a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"               help\u003d\"The version of the image service client.\"),"},{"line_number":82,"context_line":"    cfg.BoolOpt(\u0027nova_api_insecure\u0027, default\u003dFalse,"},{"line_number":83,"context_line":"                help\u003d\"Allow to perform insecure SSL requests to nova.\"),"},{"line_number":84,"context_line":"    cfg.StrOpt(\u0027nova_keypair\u0027, default\u003d\u0027\u0027,"},{"line_number":85,"context_line":"               help\u003d\"Existing keypair name used to inject ssh keys into the \""},{"line_number":86,"context_line":"                    \"database instance, the keypair should be managed by the \""},{"line_number":87,"context_line":"                    \"cloud admin.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_47b72d88","line":84,"range":{"start_line":84,"start_character":38,"end_line":84,"end_character":42},"updated":"2019-04-11 11:21:53.000000000","message":"Shouldn\u0027t be the default value set to None instead of \u0027\u0027? Later this option is passed to nova client funtion whose \u0027key_pair\u0027 default value is None.","commit_id":"32169bd5ec7e2bc1cb8eb241c7b9abbf403890f1"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"f46179fb83cef5c10b52b6ddb80aed9c1e847731","unresolved":false,"context_lines":[{"line_number":81,"context_line":"               help\u003d\"The version of the image service client.\"),"},{"line_number":82,"context_line":"    cfg.BoolOpt(\u0027nova_api_insecure\u0027, default\u003dFalse,"},{"line_number":83,"context_line":"                help\u003d\"Allow to perform insecure SSL requests to nova.\"),"},{"line_number":84,"context_line":"    cfg.StrOpt(\u0027nova_keypair\u0027, default\u003d\u0027\u0027,"},{"line_number":85,"context_line":"               help\u003d\"Existing keypair name used to inject ssh keys into the \""},{"line_number":86,"context_line":"                    \"database instance, the keypair should be managed by the \""},{"line_number":87,"context_line":"                    \"cloud admin.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_02c5938e","line":84,"range":{"start_line":84,"start_character":38,"end_line":84,"end_character":42},"in_reply_to":"3fce034c_47b72d88","updated":"2019-04-11 11:45:07.000000000","message":"You are right, will change that. Thanks for the review.","commit_id":"32169bd5ec7e2bc1cb8eb241c7b9abbf403890f1"},{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"0e5834e8744eeaf47c4648c69875a0b70b621403","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    cfg.BoolOpt(\u0027nova_api_insecure\u0027, default\u003dFalse,"},{"line_number":83,"context_line":"                help\u003d\"Allow to perform insecure SSL requests to nova.\"),"},{"line_number":84,"context_line":"    cfg.StrOpt(\u0027nova_keypair\u0027, default\u003dNone,"},{"line_number":85,"context_line":"               help\u003d\"Existing keypair name used to inject ssh keys into the \""},{"line_number":86,"context_line":"                    \"database instance, the keypair should be managed by the \""},{"line_number":87,"context_line":"                    \"cloud admin.\"),"},{"line_number":88,"context_line":"    cfg.URIOpt(\u0027neutron_url\u0027, help\u003d\u0027URL without the tenant segment.\u0027),"},{"line_number":89,"context_line":"    cfg.StrOpt(\u0027neutron_service_type\u0027, default\u003d\u0027network\u0027,"},{"line_number":90,"context_line":"               help\u003d\u0027Service type to use when searching catalog.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_3d088d2a","line":87,"range":{"start_line":85,"start_character":21,"end_line":87,"end_character":33},"updated":"2019-04-17 07:18:55.000000000","message":"Alternative description to consider:\n\"Name of a Nova keypair to inject into a database instance to enable SSH access. The keypair should be prior created by the cloud operator.\"","commit_id":"88587e8c743ac09401a29611da042a6220fb4093"}],"trove/taskmanager/models.py":[{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"0e5834e8744eeaf47c4648c69875a0b70b621403","unresolved":false,"context_lines":[{"line_number":896,"context_line":"            security_groups\u003dsecurity_groups, block_device_mapping_v2\u003dbdmap_v2,"},{"line_number":897,"context_line":"            availability_zone\u003davailability_zone, nics\u003dnics,"},{"line_number":898,"context_line":"            config_drive\u003dconfig_drive, scheduler_hints\u003dscheduler_hints,"},{"line_number":899,"context_line":"            key_name\u003dCONF.nova_keypair)"},{"line_number":900,"context_line":"        LOG.debug(\"Created new compute instance %(server_id)s \""},{"line_number":901,"context_line":"                  \"for database instance %(id)s\","},{"line_number":902,"context_line":"                  {\u0027server_id\u0027: server.id, \u0027id\u0027: self.id})"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_20d62451","line":899,"range":{"start_line":899,"start_character":21,"end_line":899,"end_character":38},"updated":"2019-04-17 07:18:55.000000000","message":"Minor cosmetic suggestion: extract keypair name before the \"server.create\" statement, similarly to \"userdata\" and \"config_drive\". The statement has lots of arguments, let\u0027s keep it simple.","commit_id":"88587e8c743ac09401a29611da042a6220fb4093"}]}