)]}'
{"id":"openstack%2Ftrove~653349","triplet_id":"openstack%2Ftrove~master~Ia7d0ec0152de9ee4bdf10c8de80e8d32bbf4a42b","project":"openstack/trove","branch":"master","topic":"exception","hashtags":[],"change_id":"Ia7d0ec0152de9ee4bdf10c8de80e8d32bbf4a42b","subject":"Pass kwargs to exception to get better format of error message","status":"MERGED","created":"2019-04-17 08:21:19.000000000","updated":"2019-05-08 14:57:50.000000000","submitted":"2019-05-08 14:57:50.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"653349-1557327470796-ed6c2c04","meta_rev_id":"916defa6890c028f61c79166de4beb64eb96ac6a","_number":653349,"virtual_id_number":653349,"owner":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"value":2,"date":"2019-05-08 14:57:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-04-22 06:10:07.000000000","_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"all":[{"value":2,"date":"2019-04-22 05:44:11.000000000","_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"all":[{"value":1,"date":"2019-05-08 12:43:18.000000000","_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-08 12:43:18.000000000","updated_by":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"reviewer":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"state":"REVIEWER"},{"updated":"2019-05-08 14:57:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"db93a6ca70c77d9f565b1f3c64fb8d597b8aec46","author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"date":"2019-04-17 08:21:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"34bdcf8c61068891bba6a2b20a25db3d96087eb4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-17 12:09:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/49/653349/1/check/openstack-tox-cover/256940e/cover/ : SUCCESS in 19m 41s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/49/653349/1/check/openstack-tox-lower-constraints/6152ddb/ : SUCCESS in 13m 51s\n- openstack-tox-pep8 http://logs.openstack.org/49/653349/1/check/openstack-tox-pep8/98dc8a1/ : SUCCESS in 7m 18s\n- openstack-tox-py27 http://logs.openstack.org/49/653349/1/check/openstack-tox-py27/f17c879/ : SUCCESS in 12m 51s\n- openstack-tox-py35 http://logs.openstack.org/49/653349/1/check/openstack-tox-py35/606c253/ : SUCCESS in 16m 13s\n- openstack-tox-py36 http://logs.openstack.org/49/653349/1/check/openstack-tox-py36/7be5ca2/ : SUCCESS in 14m 09s\n- openstack-tox-py37 http://logs.openstack.org/49/653349/1/check/openstack-tox-py37/55f8f11/ : SUCCESS in 20m 05s\n- openstack-tox-docs http://logs.openstack.org/49/653349/1/check/openstack-tox-docs/b743c44/html/ : SUCCESS in 6m 37s\n- trove-functional-mysql http://logs.openstack.org/49/653349/1/check/trove-functional-mysql/b17c7df/ : SUCCESS in 2h 13m 44s\n- trove-scenario-mariadb-single http://logs.openstack.org/49/653349/1/check/trove-scenario-mariadb-single/8c29e4a/ : FAILURE in 37m 16s (non-voting)\n- trove-scenario-mariadb-multi http://logs.openstack.org/49/653349/1/check/trove-scenario-mariadb-multi/84fee02/ : FAILURE in 1h 07m 09s (non-voting)\n- trove-scenario-mysql-single http://logs.openstack.org/49/653349/1/check/trove-scenario-mysql-single/2cf98f9/ : SUCCESS in 2h 14m 08s\n- trove-scenario-mysql-multi http://logs.openstack.org/49/653349/1/check/trove-scenario-mysql-multi/55262dc/ : SUCCESS in 1h 58m 28s\n- trove-scenario-postgresql-single http://logs.openstack.org/49/653349/1/check/trove-scenario-postgresql-single/a6066bd/ : FAILURE in 1h 00m 31s (non-voting)\n- trove-scenario-postgresql-multi http://logs.openstack.org/49/653349/1/check/trove-scenario-postgresql-multi/67bc4d2/ : FAILURE in 1h 16m 54s (non-voting)\n- trove-scenario-pxc-single http://logs.openstack.org/49/653349/1/check/trove-scenario-pxc-single/e8cb9e7/ : FAILURE in 1h 06m 10s (non-voting)\n- trove-scenario-pxc-multi http://logs.openstack.org/49/653349/1/check/trove-scenario-pxc-multi/24a21bf/ : FAILURE in 1h 11m 28s (non-voting)\n- trove-scenario-redis-single http://logs.openstack.org/49/653349/1/check/trove-scenario-redis-single/5d20480/ : FAILURE in 1h 28m 19s (non-voting)\n- trove-scenario-redis-multi http://logs.openstack.org/49/653349/1/check/trove-scenario-redis-multi/1ebd9b3/ : FAILURE in 1h 25m 56s (non-voting)\n- trove-tox-fakemodetests http://logs.openstack.org/49/653349/1/check/trove-tox-fakemodetests/ee965c8/ : SUCCESS in 7m 30s\n- trove-tox-apiexamples http://logs.openstack.org/49/653349/1/check/trove-tox-apiexamples/f54c45b/ : SUCCESS in 6m 57s\n- trove-tox-bandit-baseline http://logs.openstack.org/49/653349/1/check/trove-tox-bandit-baseline/6d32548/ : SUCCESS in 6m 12s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/49/653349/1/check/openstack-tox-pylint/2670470/ : SUCCESS in 11m 00s","accounts_in_message":[],"_revision_number":1},{"id":"e4b4025a9cec8c831488017b559477aba1e3cb6e","author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"date":"2019-04-19 10:05:21.000000000","message":"Patch Set 1: Code-Review-1\n\nThanks for the patch, but could you please fix all the incorrect param for the exception DnsRecordNotFound and UserNotFound in the whole repo? I can see there are some others also need this change.","accounts_in_message":[],"_revision_number":1},{"id":"6cf03bb478c72a005714083acfc05f435888a491","author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"date":"2019-04-22 01:57:57.000000000","message":"Patch Set 1:\n\n\u003e Thanks for the patch, but could you please fix all the incorrect\n \u003e param for the exception DnsRecordNotFound and UserNotFound in the\n \u003e whole repo? I can see there are some others also need this change.\n\nSorry I seem not be able to find other DnsRecordNotFound and UserNotFound that need to be fixed, could you point out the position?","accounts_in_message":[],"_revision_number":1},{"id":"c1522930df35c05fa6fe35c55f22cc4d37427ef1","author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"date":"2019-04-22 04:35:48.000000000","message":"Patch Set 1:\n\n\u003e Sorry I seem not be able to find other DnsRecordNotFound and\n \u003e UserNotFound that need to be fixed, could you point out the\n \u003e position?\n\nBy searching UserNotFound, I can see all those references, https://paste.pics/ddf225202ad0007e622ff1c4a5582fb4","accounts_in_message":[],"_revision_number":1},{"id":"58673c7dde0efc3203b7ff159193f79f46fd81d2","author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"date":"2019-04-22 05:39:43.000000000","message":"Patch Set 1:\n\n\u003e \u003e Sorry I seem not be able to find other DnsRecordNotFound and\n \u003e \u003e UserNotFound that need to be fixed, could you point out the\n \u003e \u003e position?\n \u003e \n \u003e By searching UserNotFound, I can see all those references,\n \u003e https://paste.pics/ddf225202ad0007e622ff1c4a5582fb4\n\noh, if we pass formatted message directly to UserNotFound, it can also work, like\n\"trove/tests/fakes/guestagent.py:304:            raise rd_exception.UserNotFound(\ntrove/tests/fakes/guestagent.py-305-                \"User %s cannot be found on the instance.\" % username)\"\n\nso I just leave them unchanged.","accounts_in_message":[],"_revision_number":1},{"id":"32c6410918ffc4425060a6b0213973288db33200","author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"date":"2019-04-22 05:44:11.000000000","message":"Patch Set 1: Code-Review+2\n\nOK, don\u0027t worry, thanks for the explanation.","accounts_in_message":[],"_revision_number":1},{"id":"0b13cb5e9e5928f20fba59b2d5e90d9232593069","author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"date":"2019-04-22 06:10:07.000000000","message":"Patch Set 1:\n\nThanks for the quick response:)","accounts_in_message":[],"_revision_number":1},{"id":"c261b338fd3395bcc526454985b308b23696e1e1","author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"date":"2019-05-08 12:43:18.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"20139cb7da66e33f27da4a784f7ab79ce3c6f9f6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-08 12:43:33.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"b74d5942296c66471060225f9e5488d89bb0b21c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-08 14:57:50.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"3d7dca731169590b28ef94c10f268ad4a2e6ba61","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-08 14:57:50.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/49/653349/1/gate/openstack-tox-lower-constraints/579c215/ : SUCCESS in 12m 11s\n- openstack-tox-pep8 http://logs.openstack.org/49/653349/1/gate/openstack-tox-pep8/9d0d83b/ : SUCCESS in 6m 22s\n- openstack-tox-py27 http://logs.openstack.org/49/653349/1/gate/openstack-tox-py27/8440fbb/ : SUCCESS in 10m 36s\n- openstack-tox-py36 http://logs.openstack.org/49/653349/1/gate/openstack-tox-py36/f481b0a/ : SUCCESS in 12m 04s\n- openstack-tox-py37 http://logs.openstack.org/49/653349/1/gate/openstack-tox-py37/b57d7d0/ : SUCCESS in 15m 54s\n- openstack-tox-docs http://logs.openstack.org/49/653349/1/gate/openstack-tox-docs/9662ce8/html/ : SUCCESS in 6m 59s\n- trove-functional-mysql http://logs.openstack.org/49/653349/1/gate/trove-functional-mysql/de43261/ : SUCCESS in 1h 54m 57s\n- trove-scenario-mysql-single http://logs.openstack.org/49/653349/1/gate/trove-scenario-mysql-single/c08efb1/ : SUCCESS in 1h 54m 33s\n- trove-scenario-mysql-multi http://logs.openstack.org/49/653349/1/gate/trove-scenario-mysql-multi/64d8023/ : SUCCESS in 1h 34m 43s\n- trove-tox-fakemodetests http://logs.openstack.org/49/653349/1/gate/trove-tox-fakemodetests/ebb4c29/ : SUCCESS in 6m 04s\n- trove-tox-apiexamples http://logs.openstack.org/49/653349/1/gate/trove-tox-apiexamples/34fd81a/ : SUCCESS in 5m 19s\n- openstack-tox-pylint http://logs.openstack.org/49/653349/1/gate/openstack-tox-pylint/45d21f0/ : SUCCESS in 8m 05s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"74370e8c180861476bf0372d7e2d07ddbe60b5d2","revisions":{"74370e8c180861476bf0372d7e2d07ddbe60b5d2":{"kind":"REWORK","_number":1,"created":"2019-04-17 08:21:19.000000000","uploader":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"ref":"refs/changes/49/653349/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/trove","ref":"refs/changes/49/653349/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/trove refs/changes/49/653349/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/trove refs/changes/49/653349/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/trove refs/changes/49/653349/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/trove refs/changes/49/653349/1"}}},"commit":{"parents":[{"commit":"f4e17a34b91c99db363092c3ee93dca6da239f37","subject":"Merge \"Update master for stable/stein\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/trove/commit/f4e17a34b91c99db363092c3ee93dca6da239f37"}]}],"author":{"name":"zhufl","email":"zhu.fanglei@zte.com.cn","date":"2019-04-17 08:19:19.000000000","tz":480},"committer":{"name":"zhufl","email":"zhu.fanglei@zte.com.cn","date":"2019-04-17 08:19:19.000000000","tz":480},"subject":"Pass kwargs to exception to get better format of error message","message":"Pass kwargs to exception to get better format of error message\n\nIf we do not pass kwargs to exception, the parameter will be deemed\nas message and will be displayed directly. This is to pass kwargs to\nsome exceptions, to get better format of error message.\n\nChange-Id: Ia7d0ec0152de9ee4bdf10c8de80e8d32bbf4a42b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/trove/commit/74370e8c180861476bf0372d7e2d07ddbe60b5d2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/trove/commit/74370e8c180861476bf0372d7e2d07ddbe60b5d2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}