)]}'
{"trove/guestagent/volume.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"e684f1f84db5017141d50778acd69d5cfdce2989","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"def VolumeFs(fstype, format_options\u003d\u0027\u0027):"},{"line_number":173,"context_line":"    supported_fs \u003d {"},{"line_number":174,"context_line":"        \u0027xfs\u0027: FSXFS,"},{"line_number":175,"context_line":"        \u0027ext3\u0027: FSExt3,"},{"line_number":176,"context_line":"        \u0027ext4\u0027: FSExt4"},{"line_number":177,"context_line":"    }"},{"line_number":178,"context_line":"    return supported_fs[fstype](format_options)"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_a2c5950c","line":176,"range":{"start_line":174,"start_character":0,"end_line":176,"end_character":22},"updated":"2019-10-02 21:11:47.000000000","message":"Because there is a new file system type supported, could you please also add the \u0027choices\u0027 attribute for this option[1].\n\n[1]: https://github.com/openstack/trove/blob/cdac6278aff0ad564a881d16368bbdf9be732b99/trove/common/cfg.py#L205","commit_id":"dbdcca9a01aeac949cbda63bc6888fa203a6bd4c"},{"author":{"_account_id":8037,"name":"renminmin","email":"rmm0811@gmail.com","username":"renminmin"},"change_message_id":"685ae0f4b6a8770395e4d1ebed960d772bca768c","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"def VolumeFs(fstype, format_options\u003d\u0027\u0027):"},{"line_number":173,"context_line":"    supported_fs \u003d {"},{"line_number":174,"context_line":"        \u0027xfs\u0027: FSXFS,"},{"line_number":175,"context_line":"        \u0027ext3\u0027: FSExt3,"},{"line_number":176,"context_line":"        \u0027ext4\u0027: FSExt4"},{"line_number":177,"context_line":"    }"},{"line_number":178,"context_line":"    return supported_fs[fstype](format_options)"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_8f66a850","line":176,"range":{"start_line":174,"start_character":0,"end_line":176,"end_character":22},"in_reply_to":"3fa7e38b_a2c5950c","updated":"2019-10-17 03:03:45.000000000","message":"Done","commit_id":"dbdcca9a01aeac949cbda63bc6888fa203a6bd4c"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"e684f1f84db5017141d50778acd69d5cfdce2989","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"class VolumeDevice(object):"},{"line_number":182,"context_line":"    _VOLUME_FS \u003d None"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def __init__(self, device_path):"},{"line_number":185,"context_line":"        self.device_path \u003d device_path"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_429e2155","line":182,"range":{"start_line":182,"start_character":4,"end_line":182,"end_character":14},"updated":"2019-10-02 21:11:47.000000000","message":"Does this need to be a class variable? How about just define `self.volume_fs` for the object?","commit_id":"dbdcca9a01aeac949cbda63bc6888fa203a6bd4c"},{"author":{"_account_id":8037,"name":"renminmin","email":"rmm0811@gmail.com","username":"renminmin"},"change_message_id":"685ae0f4b6a8770395e4d1ebed960d772bca768c","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"class VolumeDevice(object):"},{"line_number":182,"context_line":"    _VOLUME_FS \u003d None"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def __init__(self, device_path):"},{"line_number":185,"context_line":"        self.device_path \u003d device_path"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_ef563c5c","line":182,"range":{"start_line":182,"start_character":4,"end_line":182,"end_character":14},"in_reply_to":"3fa7e38b_429e2155","updated":"2019-10-17 03:03:45.000000000","message":"Done","commit_id":"dbdcca9a01aeac949cbda63bc6888fa203a6bd4c"}]}