)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ce254f7e1517098e8326a8ef30d3c48698e6ccb1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    further issues and to aid in troubleshooting"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I3e36d4ab879073b685a0585d02a62dfe157a5b3c"},{"line_number":19,"context_line":"Fixes: Bug 1236620"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2Fknk%3D","line":19,"updated":"2014-01-10 21:57:57.000000000","message":"Closes-Bug: #","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"5d01eb6049f8c81d26f8f7203708411ab7524444","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    functions"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I3e36d4ab879073b685a0585d02a62dfe157a5b3c"},{"line_number":22,"context_line":"Closes-Bug: 1236620"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAAUH%2F%2BegE%3D","line":22,"updated":"2014-01-25 10:09:57.000000000","message":"Closes-Bug: #1236620","commit_id":"5db82304b90a01ab504e3fd44b7cbadadacb11a6"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"cc497b040d98c9c0135770da2e3eb4e6243b8714","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    to prevent further issues and to aid in troubleshooting"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    Changed usage of mysql to datastore in instance and task"},{"line_number":19,"context_line":"    functions"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I3e36d4ab879073b685a0585d02a62dfe157a5b3c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"AAAAUH%2F9ty8%3D","line":19,"updated":"2014-02-04 18:27:00.000000000","message":"Plz remove spaces in the non summary. Also, id like to see some partially implements blueprint XXX","commit_id":"53f019454ad29b3fc604a36253f7a6d0ef42455a"}],"trove/extensions/mgmt/instances/views.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ce254f7e1517098e8326a8ef30d3c48698e6ccb1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                result[\u0027instance\u0027][\u0027server\u0027][\u0027local_id\u0027] \u003d server.local_id"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        try:"},{"line_number":51,"context_line":"            service_status \u003d \\"},{"line_number":52,"context_line":"                self.instance.inst_service_status.status.api_status"},{"line_number":53,"context_line":"        except AttributeError:"},{"line_number":54,"context_line":"            service_status \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FksE%3D","line":51,"updated":"2014-01-10 21:57:57.000000000","message":"i would not suggest to use \\, () would be the best option","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"9b09e678780e03d5d07a2affc3c9c70ff32f295b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                result[\u0027instance\u0027][\u0027server\u0027][\u0027local_id\u0027] \u003d server.local_id"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        try:"},{"line_number":51,"context_line":"            service_status \u003d \\"},{"line_number":52,"context_line":"                self.instance.inst_service_status.status.api_status"},{"line_number":53,"context_line":"        except AttributeError:"},{"line_number":54,"context_line":"            service_status \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fafo%3D","line":51,"in_reply_to":"AAAAUH%2F%2FksE%3D","updated":"2014-01-14 23:38:35.000000000","message":"Done","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"1e9d4cc258ac2812cddd728ec828580f0e3a7d91","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                result[\u0027instance\u0027][\u0027server\u0027][\u0027local_id\u0027] \u003d server.local_id"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        try:"},{"line_number":51,"context_line":"            service_status \u003d \\"},{"line_number":52,"context_line":"                self.instance.inst_service_status.status.api_status"},{"line_number":53,"context_line":"        except AttributeError:"},{"line_number":54,"context_line":"            service_status \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fcfw%3D","line":51,"in_reply_to":"AAAAUH%2F%2FksE%3D","updated":"2014-01-13 20:11:19.000000000","message":"Thank you - much better","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"}],"trove/extensions/mysql/models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9ea5495121118cf74813ae79491228567626203a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"def load_and_verify(context, instance_id):"},{"line_number":41,"context_line":"    # Load InstanceServiceStatus to verify if its running"},{"line_number":42,"context_line":"    instance \u003d base_models.Instance.load(context, instance_id)"},{"line_number":43,"context_line":"    if not instance.is_datastore_running:"},{"line_number":44,"context_line":"        raise exception.UnprocessableEntity("},{"line_number":45,"context_line":"            \"Instance %s is not ready.\" % instance.id)"},{"line_number":46,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Bek4%3D","line":43,"updated":"2014-01-25 10:09:26.000000000","message":"in general, it\u0027s not the datastore, it instance object, so would be better to use is_running attribute, since it\u0027s common for all future instances","commit_id":"5db82304b90a01ab504e3fd44b7cbadadacb11a6"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"337ff6a4233fe3feccd551118229d08ccc6a99e5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"def load_and_verify(context, instance_id):"},{"line_number":41,"context_line":"    # Load InstanceServiceStatus to verify if its running"},{"line_number":42,"context_line":"    instance \u003d base_models.Instance.load(context, instance_id)"},{"line_number":43,"context_line":"    if not instance.is_datastore_running:"},{"line_number":44,"context_line":"        raise exception.UnprocessableEntity("},{"line_number":45,"context_line":"            \"Instance %s is not ready.\" % instance.id)"},{"line_number":46,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BasU%3D","line":43,"in_reply_to":"AAAAUH%2F%2BdaQ%3D","updated":"2014-01-27 06:47:02.000000000","message":"+1","commit_id":"5db82304b90a01ab504e3fd44b7cbadadacb11a6"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"fcf9ce2445350a10989901ec26b349698c5b3b70","unresolved":false,"context_lines":[{"line_number":40,"context_line":"def load_and_verify(context, instance_id):"},{"line_number":41,"context_line":"    # Load InstanceServiceStatus to verify if its running"},{"line_number":42,"context_line":"    instance \u003d base_models.Instance.load(context, instance_id)"},{"line_number":43,"context_line":"    if not instance.is_datastore_running:"},{"line_number":44,"context_line":"        raise exception.UnprocessableEntity("},{"line_number":45,"context_line":"            \"Instance %s is not ready.\" % instance.id)"},{"line_number":46,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BdaQ%3D","line":43,"in_reply_to":"AAAAUH%2F%2Bek4%3D","updated":"2014-01-25 21:47:47.000000000","message":"Denis - \n\nso here is the deal.  instance doesn\u0027t really convey anything useful especially in the context of object oriented programming. so in this case the Instance lineage in Trove is referring to a customer\u0027s trove Instance which is comprised of a Nova Compute Instance and a Datastore service.  I am not keen on the term datastore but it seems to be used often now to describe what data(base/store) service (mysql, mongo, etc).  \n\nSo in this case, all it is asking is \"Is the data(store/base) running\".","commit_id":"5db82304b90a01ab504e3fd44b7cbadadacb11a6"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"899ce267cc62d274c86ea2db3bc8b0eb7e32c886","unresolved":false,"context_lines":[{"line_number":40,"context_line":"def load_and_verify(context, instance_id):"},{"line_number":41,"context_line":"    # Load InstanceServiceStatus to verify if its running"},{"line_number":42,"context_line":"    instance \u003d base_models.Instance.load(context, instance_id)"},{"line_number":43,"context_line":"    if not instance.is_datastore_running:"},{"line_number":44,"context_line":"        raise exception.UnprocessableEntity("},{"line_number":45,"context_line":"            \"Instance %s is not ready.\" % instance.id)"},{"line_number":46,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F9%2B6Q%3D","line":43,"updated":"2014-01-31 11:36:53.000000000","message":"I see what you mean, but accordring to trove terms, datastore is an entity that defines on which image vm deployed, which packages would be installed etc. But we cannot say that datastore is running because it cannot be started. We are able to spin-up only instances with specific datastore (basicaly datastore is a determinant).\n\nSimple example (nova): VM could run, but flavor cannot. Same with trove instances and datastores.","commit_id":"f0c8c984b089582554b6d6279e8eb7c4d786e083"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"04b40f12947244ed9536bb3fbdbea3822f6fd639","unresolved":false,"context_lines":[{"line_number":40,"context_line":"def load_and_verify(context, instance_id):"},{"line_number":41,"context_line":"    # Load InstanceServiceStatus to verify if its running"},{"line_number":42,"context_line":"    instance \u003d base_models.Instance.load(context, instance_id)"},{"line_number":43,"context_line":"    if not instance.is_datastore_running:"},{"line_number":44,"context_line":"        raise exception.UnprocessableEntity("},{"line_number":45,"context_line":"            \"Instance %s is not ready.\" % instance.id)"},{"line_number":46,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F982g%3D","line":43,"updated":"2014-01-31 18:38:04.000000000","message":"copied from previous patchset\n\nI see what you mean, but accordring to trove terms, datastore is an entity that defines on which image vm deployed, which packages would be installed etc. But we cannot say that datastore is running because it cannot be started. We are able to spin-up only instances with specific datastore (basicaly datastore is a determinant).\n\nSimple example (nova): VM could run, but flavor cannot. Same with trove instances and datastores.","commit_id":"53f019454ad29b3fc604a36253f7a6d0ef42455a"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"cc497b040d98c9c0135770da2e3eb4e6243b8714","unresolved":false,"context_lines":[{"line_number":40,"context_line":"def load_and_verify(context, instance_id):"},{"line_number":41,"context_line":"    # Load InstanceServiceStatus to verify if its running"},{"line_number":42,"context_line":"    instance \u003d base_models.Instance.load(context, instance_id)"},{"line_number":43,"context_line":"    if not instance.is_datastore_running:"},{"line_number":44,"context_line":"        raise exception.UnprocessableEntity("},{"line_number":45,"context_line":"            \"Instance %s is not ready.\" % instance.id)"},{"line_number":46,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F9tz0%3D","line":43,"in_reply_to":"AAAAUH%2F982g%3D","updated":"2014-02-04 18:27:00.000000000","message":"im fine w/ is_datastore_running","commit_id":"53f019454ad29b3fc604a36253f7a6d0ef42455a"}],"trove/instance/models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":48,"context_line":"def load_server(context, instance_id, server_id):"},{"line_number":49,"context_line":"    \"\"\""},{"line_number":50,"context_line":"    Loads a server or raises an exception."},{"line_number":51,"context_line":"    :param context: user context of which is associated to the nova server"},{"line_number":52,"context_line":"    :param instance_id: the trove instance id corresponding to the nova server"},{"line_number":53,"context_line":"    (informational only)"},{"line_number":54,"context_line":"    :param server_id: the nova server id which will be retrieved"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fesg%3D","line":51,"updated":"2014-01-13 14:07:19.000000000","message":"would be better to use \"request context\", since context var is not related to any OS services","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"1e9d4cc258ac2812cddd728ec828580f0e3a7d91","unresolved":false,"context_lines":[{"line_number":48,"context_line":"def load_server(context, instance_id, server_id):"},{"line_number":49,"context_line":"    \"\"\""},{"line_number":50,"context_line":"    Loads a server or raises an exception."},{"line_number":51,"context_line":"    :param context: user context of which is associated to the nova server"},{"line_number":52,"context_line":"    :param instance_id: the trove instance id corresponding to the nova server"},{"line_number":53,"context_line":"    (informational only)"},{"line_number":54,"context_line":"    :param server_id: the nova server id which will be retrieved"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fc0M%3D","line":51,"in_reply_to":"AAAAUH%2F%2Fesg%3D","updated":"2014-01-13 20:11:19.000000000","message":"Denis - my intent here is not to rename every variable - the only one I changed, I believe is service_status (actually InstanceServiceStatus) in certain contexts because I felt it needed to made distinct from the other class ServiceStatus","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"9b09e678780e03d5d07a2affc3c9c70ff32f295b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"def load_server(context, instance_id, server_id):"},{"line_number":49,"context_line":"    \"\"\""},{"line_number":50,"context_line":"    Loads a server or raises an exception."},{"line_number":51,"context_line":"    :param context: user context of which is associated to the nova server"},{"line_number":52,"context_line":"    :param instance_id: the trove instance id corresponding to the nova server"},{"line_number":53,"context_line":"    (informational only)"},{"line_number":54,"context_line":"    :param server_id: the nova server id which will be retrieved"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fafk%3D","line":51,"in_reply_to":"AAAAUH%2F%2Fesg%3D","updated":"2014-01-14 23:38:35.000000000","message":"Done","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    :param context: user context of which is associated to the nova server"},{"line_number":52,"context_line":"    :param instance_id: the trove instance id corresponding to the nova server"},{"line_number":53,"context_line":"    (informational only)"},{"line_number":54,"context_line":"    :param server_id: the nova server id which will be retrieved"},{"line_number":55,"context_line":"    :type context: trove.common.context.TroveContext"},{"line_number":56,"context_line":"    :type instance_id: unicode"},{"line_number":57,"context_line":"    :type server_id: unicode"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fesc%3D","line":54,"updated":"2014-01-13 14:07:19.000000000","message":"compute instance id","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"9b09e678780e03d5d07a2affc3c9c70ff32f295b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    :param context: user context of which is associated to the nova server"},{"line_number":52,"context_line":"    :param instance_id: the trove instance id corresponding to the nova server"},{"line_number":53,"context_line":"    (informational only)"},{"line_number":54,"context_line":"    :param server_id: the nova server id which will be retrieved"},{"line_number":55,"context_line":"    :type context: trove.common.context.TroveContext"},{"line_number":56,"context_line":"    :type instance_id: unicode"},{"line_number":57,"context_line":"    :type server_id: unicode"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fafg%3D","line":54,"in_reply_to":"AAAAUH%2F%2Fesc%3D","updated":"2014-01-14 23:38:35.000000000","message":"Done","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    :type context: trove.common.context.TroveContext"},{"line_number":56,"context_line":"    :type instance_id: unicode"},{"line_number":57,"context_line":"    :type server_id: unicode"},{"line_number":58,"context_line":"    :rtype: novaclient.v1_1.servers.Server"},{"line_number":59,"context_line":"    \"\"\""},{"line_number":60,"context_line":"    client \u003d create_nova_client(context)"},{"line_number":61,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FesA%3D","line":58,"updated":"2014-01-13 14:07:19.000000000","message":"what if nova works with API v3 ?\nI would not suggest writing version.\nPreferable: novaclient server entity","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"1e9d4cc258ac2812cddd728ec828580f0e3a7d91","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    :type context: trove.common.context.TroveContext"},{"line_number":56,"context_line":"    :type instance_id: unicode"},{"line_number":57,"context_line":"    :type server_id: unicode"},{"line_number":58,"context_line":"    :rtype: novaclient.v1_1.servers.Server"},{"line_number":59,"context_line":"    \"\"\""},{"line_number":60,"context_line":"    client \u003d create_nova_client(context)"},{"line_number":61,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fc0A%3D","line":58,"in_reply_to":"AAAAUH%2F%2FesA%3D","updated":"2014-01-13 20:11:19.000000000","message":"the *type docs need to specify the exact type","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    @property"},{"line_number":189,"context_line":"    def inst_service_status(self):"},{"line_number":190,"context_line":"        \"\"\""},{"line_number":191,"context_line":"        Returns the Service Status for this instance.  For example, the status"},{"line_number":192,"context_line":"        of the mysql service which is running on the server...not the server"},{"line_number":193,"context_line":"        status itself."},{"line_number":194,"context_line":"        :return: the current status of the service"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FerY%3D","line":191,"updated":"2014-01-13 14:07:19.000000000","message":"for an instance, since method is common.\nDoc string should stay out of examples.","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"1e9d4cc258ac2812cddd728ec828580f0e3a7d91","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    @property"},{"line_number":189,"context_line":"    def inst_service_status(self):"},{"line_number":190,"context_line":"        \"\"\""},{"line_number":191,"context_line":"        Returns the Service Status for this instance.  For example, the status"},{"line_number":192,"context_line":"        of the mysql service which is running on the server...not the server"},{"line_number":193,"context_line":"        status itself."},{"line_number":194,"context_line":"        :return: the current status of the service"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FczE%3D","line":191,"in_reply_to":"AAAAUH%2F%2FerY%3D","updated":"2014-01-13 20:11:19.000000000","message":"I disagree.  The doc string should provide some context and in this case it is just illustrating the difference between service status and the several other status types in trove, nova, etc.","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ce254f7e1517098e8326a8ef30d3c48698e6ccb1","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            return InstanceStatus.ERROR"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        ### Check for taskmanager status."},{"line_number":215,"context_line":"        action \u003d self.db_info.task_status.action"},{"line_number":216,"context_line":"        if \u0027BUILDING\u0027 \u003d\u003d action:"},{"line_number":217,"context_line":"            if \u0027ERROR\u0027 \u003d\u003d self.db_info.server_status:"},{"line_number":218,"context_line":"                return InstanceStatus.ERROR"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fkrs%3D","line":215,"updated":"2014-01-10 21:57:57.000000000","message":"do this really need to be changed ?","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"1e9d4cc258ac2812cddd728ec828580f0e3a7d91","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            return InstanceStatus.ERROR"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        ### Check for taskmanager status."},{"line_number":215,"context_line":"        action \u003d self.db_info.task_status.action"},{"line_number":216,"context_line":"        if \u0027BUILDING\u0027 \u003d\u003d action:"},{"line_number":217,"context_line":"            if \u0027ERROR\u0027 \u003d\u003d self.db_info.server_status:"},{"line_number":218,"context_line":"                return InstanceStatus.ERROR"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fczk%3D","line":215,"in_reply_to":"AAAAUH%2F%2Fkrs%3D","updated":"2014-01-13 20:11:19.000000000","message":"since upper case designates CONSTANTS, I feel like this is an inappropriate/PEP8-like error","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ce254f7e1517098e8326a8ef30d3c48698e6ccb1","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        ### Check against the service status."},{"line_number":251,"context_line":"        # The service is only paused during a reboot."},{"line_number":252,"context_line":"        if rd_instance.ServiceStatuses.PAUSED \u003d\u003d \\"},{"line_number":253,"context_line":"                self.inst_service_status.status:"},{"line_number":254,"context_line":"            return InstanceStatus.REBOOT"},{"line_number":255,"context_line":"        # If the service status is NEW, then we are building."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fkrk%3D","line":252,"updated":"2014-01-10 21:57:57.000000000","message":"again, i would not suggest to use \\","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    :type context: trove.common.context.TroveContext"},{"line_number":322,"context_line":"    :param id: the unique ID of the instance"},{"line_number":323,"context_line":"    :type id: unicode or str"},{"line_number":324,"context_line":"    :return: a record of the instance as its states exists in persisted storage"},{"line_number":325,"context_line":"    :rtype: trove.instance.models.DBInstance"},{"line_number":326,"context_line":"    \"\"\""},{"line_number":327,"context_line":"    if context is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Feqk%3D","line":324,"updated":"2014-01-13 14:07:19.000000000","message":"which are exist in the persisted storage","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    def __init__(self, context, db_info, server, service_status):"},{"line_number":399,"context_line":"        \"\"\""},{"line_number":400,"context_line":"        Creates a new initialized representation of an instance composed of its"},{"line_number":401,"context_line":"        state in the database and its state from Nova"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        :param context: the context which contains the tenant that owns this"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fep4%3D","line":400,"updated":"2014-01-13 14:07:19.000000000","message":"*and its state and compute instance","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        Creates a new initialized representation of an instance composed of its"},{"line_number":401,"context_line":"        state in the database and its state from Nova"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        :param context: the context which contains the tenant that owns this"},{"line_number":404,"context_line":"        instance"},{"line_number":405,"context_line":"        :param db_info: the current state of this instance as it exists in the"},{"line_number":406,"context_line":"        db"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Feps%3D","line":403,"updated":"2014-01-13 14:07:19.000000000","message":":param context: request context","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        :param context: the context which contains the tenant that owns this"},{"line_number":404,"context_line":"        instance"},{"line_number":405,"context_line":"        :param db_info: the current state of this instance as it exists in the"},{"line_number":406,"context_line":"        db"},{"line_number":407,"context_line":"        :param server: the current state of this instance as it exists in the"},{"line_number":408,"context_line":"        Nova"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fepk%3D","line":405,"updated":"2014-01-13 14:07:19.000000000","message":":param db_info:  the current state of an instance","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        instance"},{"line_number":405,"context_line":"        :param db_info: the current state of this instance as it exists in the"},{"line_number":406,"context_line":"        db"},{"line_number":407,"context_line":"        :param server: the current state of this instance as it exists in the"},{"line_number":408,"context_line":"        Nova"},{"line_number":409,"context_line":"        :param service_status: the current state of the service on this"},{"line_number":410,"context_line":"        instance at it exists in the db"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FepI%3D","line":407,"updated":"2014-01-13 14:07:19.000000000","message":":param server: compute instance entity","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        db"},{"line_number":407,"context_line":"        :param server: the current state of this instance as it exists in the"},{"line_number":408,"context_line":"        Nova"},{"line_number":409,"context_line":"        :param service_status: the current state of the service on this"},{"line_number":410,"context_line":"        instance at it exists in the db"},{"line_number":411,"context_line":"        :type context: trove.common.context.TroveContext"},{"line_number":412,"context_line":"        :type db_info: trove.instance.models.DBInstance"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Feos%3D","line":409,"updated":"2014-01-13 14:07:19.000000000","message":":param service_status: trove instance service status","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        instance at it exists in the db"},{"line_number":411,"context_line":"        :type context: trove.common.context.TroveContext"},{"line_number":412,"context_line":"        :type db_info: trove.instance.models.DBInstance"},{"line_number":413,"context_line":"        :type server: novaclient.v1_1.servers.Server"},{"line_number":414,"context_line":"        :type service_status: trove.instance.models.InstanceServiceStatus"},{"line_number":415,"context_line":"        \"\"\""},{"line_number":416,"context_line":"        super(BaseInstance, self).__init__(context, db_info, service_status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Feog%3D","line":413,"updated":"2014-01-13 14:07:19.000000000","message":"again, please avoid using API versions","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":788,"context_line":"    def __init__(self, task_status, **kwargs):"},{"line_number":789,"context_line":"        \"\"\""},{"line_number":790,"context_line":"        Creates a new representation of the Trove Guest Instance for purposes"},{"line_number":791,"context_line":"        of persisting its state to a control database"},{"line_number":792,"context_line":"        :param task_status: the current state details of any activity or error"},{"line_number":793,"context_line":"         that is running on this guest instance (e.g. resizing, deleting)"},{"line_number":794,"context_line":"        :type task_status: trove.instance.tasks.InstanceTask"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FeoM%3D","line":791,"updated":"2014-01-13 14:07:19.000000000","message":"Too complicated and had nothing related to guest service, this model designed not only for statuses.\n\nPreferable: Creates a new trove instance entity","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":834,"context_line":"    def get_status(self):"},{"line_number":835,"context_line":"        \"\"\""},{"line_number":836,"context_line":"        Returns the current enumerated status of the Service running on the"},{"line_number":837,"context_line":"        instance.  This represents the host service itself, not the server"},{"line_number":838,"context_line":"        instance."},{"line_number":839,"context_line":"        :return: a ServiceStatus reference indicating the currently stored"},{"line_number":840,"context_line":"        status of the service"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fen0%3D","line":837,"updated":"2014-01-13 14:07:19.000000000","message":"Returns the current enumerated status of the Service running on the instance - \nis more than enough","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"9b09e678780e03d5d07a2affc3c9c70ff32f295b","unresolved":false,"context_lines":[{"line_number":834,"context_line":"    def get_status(self):"},{"line_number":835,"context_line":"        \"\"\""},{"line_number":836,"context_line":"        Returns the current enumerated status of the Service running on the"},{"line_number":837,"context_line":"        instance.  This represents the host service itself, not the server"},{"line_number":838,"context_line":"        instance."},{"line_number":839,"context_line":"        :return: a ServiceStatus reference indicating the currently stored"},{"line_number":840,"context_line":"        status of the service"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fabo%3D","line":837,"in_reply_to":"AAAAUH%2F%2Fen0%3D","updated":"2014-01-14 23:38:35.000000000","message":"Done","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":844,"context_line":""},{"line_number":845,"context_line":"    def set_status(self, value):"},{"line_number":846,"context_line":"        \"\"\""},{"line_number":847,"context_line":"        Sets the status of the hosted service.  This represents the hosted"},{"line_number":848,"context_line":"        service itself, not the server instance."},{"line_number":849,"context_line":"        :param value: current state of the hosted service"},{"line_number":850,"context_line":"        :type value: trove.common.instance.ServiceStatus"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fens%3D","line":847,"updated":"2014-01-13 14:07:19.000000000","message":"Sets the status of the hosted service.  - is enough.","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"9b09e678780e03d5d07a2affc3c9c70ff32f295b","unresolved":false,"context_lines":[{"line_number":844,"context_line":""},{"line_number":845,"context_line":"    def set_status(self, value):"},{"line_number":846,"context_line":"        \"\"\""},{"line_number":847,"context_line":"        Sets the status of the hosted service.  This represents the hosted"},{"line_number":848,"context_line":"        service itself, not the server instance."},{"line_number":849,"context_line":"        :param value: current state of the hosted service"},{"line_number":850,"context_line":"        :type value: trove.common.instance.ServiceStatus"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FaaE%3D","line":847,"in_reply_to":"AAAAUH%2F%2Fens%3D","updated":"2014-01-14 23:38:35.000000000","message":"Done","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"b974a7414ecdeba58f203aa1a86c7dcf023ec9f0","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    | n   ---------------------"},{"line_number":132,"context_line":"    | c       |"},{"line_number":133,"context_line":"    | e       |"},{"line_number":134,"context_line":"    -----------"},{"line_number":135,"context_line":"    \"\"\""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def __init__(self, context, db_info, service_status, root_password\u003dNone):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2Br3c%3D","line":134,"updated":"2014-01-23 07:34:00.000000000","message":"I love the artwork!","commit_id":"8734fed9e78318145bdf1f3e7688b87843c6c245"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"337ff6a4233fe3feccd551118229d08ccc6a99e5","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    | n   ---------------------"},{"line_number":132,"context_line":"    | c       |"},{"line_number":133,"context_line":"    | e       |"},{"line_number":134,"context_line":"    -----------"},{"line_number":135,"context_line":"    \"\"\""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def __init__(self, context, db_info, service_status, root_password\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BanA%3D","line":134,"updated":"2014-01-27 06:47:02.000000000","message":"whaaaa?","commit_id":"5db82304b90a01ab504e3fd44b7cbadadacb11a6"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"203ee3291989051cdbba4434d8517e1450f03bec","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    | n       |"},{"line_number":128,"context_line":"    | s       |"},{"line_number":129,"context_line":"    | t   ---------------------"},{"line_number":130,"context_line":"    | a   |  service (status) |"},{"line_number":131,"context_line":"    | n   ---------------------"},{"line_number":132,"context_line":"    | c       |"},{"line_number":133,"context_line":"    | e       |"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F9tms%3D","line":130,"updated":"2014-02-04 19:47:49.000000000","message":"This is picky, but can you make this consistent with what it\u0027s called on 417? These are a nice touch btw.","commit_id":"53f019454ad29b3fc604a36253f7a6d0ef42455a"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"203ee3291989051cdbba4434d8517e1450f03bec","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        \"\"\""},{"line_number":144,"context_line":"        self.context \u003d context"},{"line_number":145,"context_line":"        self.db_info \u003d db_info"},{"line_number":146,"context_line":"        self.inst_service_status \u003d service_status"},{"line_number":147,"context_line":"        self.root_pass \u003d root_password"},{"line_number":148,"context_line":"        self.ds_version \u003d (datastore_models.DatastoreVersion."},{"line_number":149,"context_line":"                           load_by_uuid(self.db_info.datastore_version_id))"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F9tpQ%3D","line":146,"updated":"2014-02-04 19:47:49.000000000","message":"I\u0027m a big believer that an attribute attached to an object does not need to reference the name of the object. So why rename this to \"inst_service_status\"?\n\nI think one issue is the naming around the time Trove was written was more nebulous. Back then, Mike didn\u0027t want use to call it \"MySqlStatus\" or something. I suggested \"app\" status and was struck down, so we ended up with \"service\" status. Maybe now it should be called \"datastore_status\"?","commit_id":"53f019454ad29b3fc604a36253f7a6d0ef42455a"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"203ee3291989051cdbba4434d8517e1450f03bec","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    @inst_service_status.setter"},{"line_number":212,"context_line":"    def inst_service_status(self, inst_service_status):"},{"line_number":213,"context_line":"        if inst_service_status and not isinstance(inst_service_status,"},{"line_number":214,"context_line":"                                                  InstanceServiceStatus):"},{"line_number":215,"context_line":"            raise ValueError(\"inst_service_status must be of type \""},{"line_number":216,"context_line":"                             \"InstanceServiceStatus. Got %s instead.\" %"},{"line_number":217,"context_line":"                             inst_service_status.__class__.__name__)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F9tos%3D","line":214,"updated":"2014-02-04 19:47:49.000000000","message":"\u003c3","commit_id":"53f019454ad29b3fc604a36253f7a6d0ef42455a"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"203ee3291989051cdbba4434d8517e1450f03bec","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            return InstanceStatus.ERROR"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        ### Check for taskmanager status."},{"line_number":227,"context_line":"        action \u003d self.db_info.task_status.action"},{"line_number":228,"context_line":"        if \u0027BUILDING\u0027 \u003d\u003d action:"},{"line_number":229,"context_line":"            if \u0027ERROR\u0027 \u003d\u003d self.db_info.server_status:"},{"line_number":230,"context_line":"                return InstanceStatus.ERROR"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F9tnE%3D","line":227,"updated":"2014-02-04 19:47:49.000000000","message":"You took out my FORTAN homage! :(","commit_id":"53f019454ad29b3fc604a36253f7a6d0ef42455a"}],"trove/taskmanager/models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":889,"context_line":""},{"line_number":890,"context_line":"    def __init__(self, instance):"},{"line_number":891,"context_line":"        \"\"\""},{"line_number":892,"context_line":"        Creates a new resize action that will resize the instance specified"},{"line_number":893,"context_line":"        :param instance: reference to existing instance that will be resized"},{"line_number":894,"context_line":"        :type instance: trove.taskmanager.models.BuiltInstanceTasks"},{"line_number":895,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FenY%3D","line":892,"updated":"2014-01-13 14:07:19.000000000","message":"resize given instance","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":927,"context_line":""},{"line_number":928,"context_line":"    @abstractmethod"},{"line_number":929,"context_line":"    def _record_action_success(self):"},{"line_number":930,"context_line":"        raise NotImplemented()"},{"line_number":931,"context_line":""},{"line_number":932,"context_line":"    def _assert_mysql_is_ok(self):"},{"line_number":933,"context_line":"        # Tell the guest to turn on MySQL, and ensure the status becomes"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fem4%3D","line":930,"updated":"2014-01-13 14:07:19.000000000","message":"what is the purpose of this methods ?","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"9b09e678780e03d5d07a2affc3c9c70ff32f295b","unresolved":false,"context_lines":[{"line_number":927,"context_line":""},{"line_number":928,"context_line":"    @abstractmethod"},{"line_number":929,"context_line":"    def _record_action_success(self):"},{"line_number":930,"context_line":"        raise NotImplemented()"},{"line_number":931,"context_line":""},{"line_number":932,"context_line":"    def _assert_mysql_is_ok(self):"},{"line_number":933,"context_line":"        # Tell the guest to turn on MySQL, and ensure the status becomes"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FaZ0%3D","line":930,"in_reply_to":"AAAAUH%2F%2Fem4%3D","updated":"2014-01-14 23:38:35.000000000","message":"makes the abstraction more clear to the reader in that it indicates exactly which methods need to be implemented by the subclasses.","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":965,"context_line":"            self.instance.guest.stop_db(do_not_start_on_reboot\u003dTrue)"},{"line_number":966,"context_line":"            self._perform_nova_action()"},{"line_number":967,"context_line":"        finally:"},{"line_number":968,"context_line":"            if self.instance.db_info.task_status !\u003d \\"},{"line_number":969,"context_line":"                    inst_models.InstanceTasks.NONE:"},{"line_number":970,"context_line":"                self.instance.update_db("},{"line_number":971,"context_line":"                    task_status\u003dinst_models.InstanceTasks.NONE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Femo%3D","line":968,"updated":"2014-01-13 14:07:19.000000000","message":"please avoid \\","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"9b09e678780e03d5d07a2affc3c9c70ff32f295b","unresolved":false,"context_lines":[{"line_number":965,"context_line":"            self.instance.guest.stop_db(do_not_start_on_reboot\u003dTrue)"},{"line_number":966,"context_line":"            self._perform_nova_action()"},{"line_number":967,"context_line":"        finally:"},{"line_number":968,"context_line":"            if self.instance.db_info.task_status !\u003d \\"},{"line_number":969,"context_line":"                    inst_models.InstanceTasks.NONE:"},{"line_number":970,"context_line":"                self.instance.update_db("},{"line_number":971,"context_line":"                    task_status\u003dinst_models.InstanceTasks.NONE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FaWg%3D","line":968,"in_reply_to":"AAAAUH%2F%2Femo%3D","updated":"2014-01-14 23:38:35.000000000","message":"Done","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"    def _record_action_success(self):"},{"line_number":1083,"context_line":"        LOG.debug(_(\"Updating instance %(id)s to flavor_id %(flavor_id)s.\")"},{"line_number":1084,"context_line":"                  % {\u0027id\u0027: self.instance.id, \u0027flavor_id\u0027: self.new_flavor_id})"},{"line_number":1085,"context_line":"        self.instance.update_db(flavor_id\u003dself.new_flavor_id)"},{"line_number":1086,"context_line":"        self.instance.update_db(task_status\u003dinst_models.InstanceTasks.NONE)"},{"line_number":1087,"context_line":"        self.instance.send_usage_event("},{"line_number":1088,"context_line":"            \u0027modify_flavor\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FemM%3D","line":1085,"updated":"2014-01-13 14:07:19.000000000","message":"you could do that with one call\n\nself.instance.update_db(flavor_id\u003dself.new_flavor_id, task_status\u003dinst_models.InstanceTasks.NONE)","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"9b09e678780e03d5d07a2affc3c9c70ff32f295b","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"    def _record_action_success(self):"},{"line_number":1083,"context_line":"        LOG.debug(_(\"Updating instance %(id)s to flavor_id %(flavor_id)s.\")"},{"line_number":1084,"context_line":"                  % {\u0027id\u0027: self.instance.id, \u0027flavor_id\u0027: self.new_flavor_id})"},{"line_number":1085,"context_line":"        self.instance.update_db(flavor_id\u003dself.new_flavor_id)"},{"line_number":1086,"context_line":"        self.instance.update_db(task_status\u003dinst_models.InstanceTasks.NONE)"},{"line_number":1087,"context_line":"        self.instance.send_usage_event("},{"line_number":1088,"context_line":"            \u0027modify_flavor\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FaWY%3D","line":1085,"in_reply_to":"AAAAUH%2F%2FemM%3D","updated":"2014-01-14 23:38:35.000000000","message":"Done","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"b974a7414ecdeba58f203aa1a86c7dcf023ec9f0","unresolved":false,"context_lines":[{"line_number":908,"context_line":"            raise TroveError(msg)"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"    @abstractmethod"},{"line_number":911,"context_line":"    def _start_mysql(self):"},{"line_number":912,"context_line":"        raise NotImplemented()"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"    @abstractmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2Br3o%3D","line":911,"updated":"2014-01-23 07:34:00.000000000","message":"I wouldn\u0027t mind renaming this method to _start_datastore or something not so mysql specific, now that we\u0027re trying to genericize Trove.","commit_id":"8734fed9e78318145bdf1f3e7688b87843c6c245"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"337ff6a4233fe3feccd551118229d08ccc6a99e5","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import traceback"},{"line_number":16,"context_line":"import os.path"},{"line_number":17,"context_line":"from abc import ABCMeta, abstractmethod"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from cinderclient import exceptions as cinder_exceptions"},{"line_number":20,"context_line":"from eventlet import greenthread"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Bakk%3D","line":17,"updated":"2014-01-27 06:47:02.000000000","message":"???????????\n\nir confused. Can we 1) discuss, and 2) if 1 passes, submit in a different review?","commit_id":"5db82304b90a01ab504e3fd44b7cbadadacb11a6"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"899ce267cc62d274c86ea2db3bc8b0eb7e32c886","unresolved":false,"context_lines":[{"line_number":1093,"context_line":"            instance_size\u003dself.new_flavor[\u0027ram\u0027],"},{"line_number":1094,"context_line":"            launched_at\u003dtimeutils.isotime(self.instance.updated),"},{"line_number":1095,"context_line":"            modify_at\u003dtimeutils.isotime(self.instance.updated),"},{"line_number":1096,"context_line":"            server\u003dself.instance.server)"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"    def _start_datastore(self):"},{"line_number":1099,"context_line":"        config \u003d self._render_config(self.instance.datastore_version.manager,"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F9%2B5U%3D","line":1096,"updated":"2014-01-31 11:36:53.000000000","message":"launched_at\u003dtimeutils.isotime(\n      self.instance.updated),\n      modify_at\u003dtimeutils.isotime(self.instance.updated),\n      server\u003dself.instance.server\n)","commit_id":"f0c8c984b089582554b6d6279e8eb7c4d786e083"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"899ce267cc62d274c86ea2db3bc8b0eb7e32c886","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"            modify_at\u003dtimeutils.isotime(self.instance.updated),"},{"line_number":1096,"context_line":"            server\u003dself.instance.server)"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"    def _start_datastore(self):"},{"line_number":1099,"context_line":"        config \u003d self._render_config(self.instance.datastore_version.manager,"},{"line_number":1100,"context_line":"                                     self.new_flavor, self.instance.id)"},{"line_number":1101,"context_line":"        self.instance.guest.start_db_with_conf_changes(config.config_contents)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F9%2B5I%3D","line":1098,"updated":"2014-01-31 11:36:53.000000000","message":"start instance, because you use connection to guest service, guest runs on VM, not on datastore.","commit_id":"f0c8c984b089582554b6d6279e8eb7c4d786e083"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"899ce267cc62d274c86ea2db3bc8b0eb7e32c886","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"                  {\u0027hostname\u0027: self.instance.hostname,"},{"line_number":1123,"context_line":"                   \u0027id\u0027: self.instance.id})"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"    def _start_datastore(self):"},{"line_number":1126,"context_line":"        self.instance.guest.restart()"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F9%2B5E%3D","line":1125,"updated":"2014-01-31 11:36:53.000000000","message":"start instance, because you use connection to guest service, guest runs on VM, not on datastore.","commit_id":"f0c8c984b089582554b6d6279e8eb7c4d786e083"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"203ee3291989051cdbba4434d8517e1450f03bec","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            self.report_root_enabled()"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        if not self.db_info.task_status.is_error:"},{"line_number":213,"context_line":"            self.reset_task_status()"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        # when DNS is supported, we attempt to add this after the"},{"line_number":216,"context_line":"        # instance is prepared.  Otherwise, if DNS fails, instances"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F9tkY%3D","line":213,"updated":"2014-02-04 19:47:49.000000000","message":"Nice.","commit_id":"53f019454ad29b3fc604a36253f7a6d0ef42455a"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"203ee3291989051cdbba4434d8517e1450f03bec","unresolved":false,"context_lines":[{"line_number":734,"context_line":"        finally:"},{"line_number":735,"context_line":"            self.reset_task_status()"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"    def compute_inst_status_matches(self, expected_status, server\u003dNone):"},{"line_number":738,"context_line":"        if not server:"},{"line_number":739,"context_line":"            server \u003d self.server"},{"line_number":740,"context_line":"        return server.status.upper() in ("}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F9tOQ%3D","line":737,"updated":"2014-02-04 19:47:49.000000000","message":"We should call this \"server_status_matches\" to be consistent with the rest of the code. \n\nI believe the word \"server\" is a better fit, since Trove is a consumer of Nova.","commit_id":"53f019454ad29b3fc604a36253f7a6d0ef42455a"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"203ee3291989051cdbba4434d8517e1450f03bec","unresolved":false,"context_lines":[{"line_number":830,"context_line":"        the reference on this BuiltInstanceTask reference"},{"line_number":831,"context_line":"        \"\"\""},{"line_number":832,"context_line":"        self.inst_service_status \u003d InstanceServiceStatus.find_by("},{"line_number":833,"context_line":"            instance_id\u003dself.id)"},{"line_number":834,"context_line":""},{"line_number":835,"context_line":"    def set_service_status_to_paused(self):"},{"line_number":836,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F9tjI%3D","line":833,"updated":"2014-02-04 19:47:49.000000000","message":"Oh man what pain did this cause?","commit_id":"53f019454ad29b3fc604a36253f7a6d0ef42455a"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"203ee3291989051cdbba4434d8517e1450f03bec","unresolved":false,"context_lines":[{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"    def _wait_for_revert_nova_action(self):"},{"line_number":1036,"context_line":"        # Wait for the server to return to ACTIVE after revert."},{"line_number":1037,"context_line":"        def wait_for_active():"},{"line_number":1038,"context_line":"            self.instance.refresh_compute_server_info()"},{"line_number":1039,"context_line":"            return self.instance.compute_inst_status_matches([\u0027ACTIVE\u0027])"},{"line_number":1040,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F9tgs%3D","line":1037,"updated":"2014-02-04 19:47:49.000000000","message":"An even better name would be \"server_is_active\".","commit_id":"53f019454ad29b3fc604a36253f7a6d0ef42455a"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"04b40f12947244ed9536bb3fbdbea3822f6fd639","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"            modify_at\u003dtimeutils.isotime(self.instance.updated),"},{"line_number":1096,"context_line":"            server\u003dself.instance.server)"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"    def _start_datastore(self):"},{"line_number":1099,"context_line":"        config \u003d self._render_config(self.instance.datastore_version.manager,"},{"line_number":1100,"context_line":"                                     self.new_flavor, self.instance.id)"},{"line_number":1101,"context_line":"        self.instance.guest.start_db_with_conf_changes(config.config_contents)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F982Y%3D","line":1098,"updated":"2014-01-31 18:38:04.000000000","message":"Copied from previous patchset\nstart instance, because you use connection to guest service, guest runs on VM, not on datastore.","commit_id":"53f019454ad29b3fc604a36253f7a6d0ef42455a"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"cc497b040d98c9c0135770da2e3eb4e6243b8714","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"            modify_at\u003dtimeutils.isotime(self.instance.updated),"},{"line_number":1096,"context_line":"            server\u003dself.instance.server)"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"    def _start_datastore(self):"},{"line_number":1099,"context_line":"        config \u003d self._render_config(self.instance.datastore_version.manager,"},{"line_number":1100,"context_line":"                                     self.new_flavor, self.instance.id)"},{"line_number":1101,"context_line":"        self.instance.guest.start_db_with_conf_changes(config.config_contents)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F9tzs%3D","line":1098,"in_reply_to":"AAAAUH%2F982Y%3D","updated":"2014-02-04 18:27:00.000000000","message":"im fine with _start_datastore","commit_id":"53f019454ad29b3fc604a36253f7a6d0ef42455a"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"04b40f12947244ed9536bb3fbdbea3822f6fd639","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"                  {\u0027hostname\u0027: self.instance.hostname,"},{"line_number":1123,"context_line":"                   \u0027id\u0027: self.instance.id})"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"    def _start_datastore(self):"},{"line_number":1126,"context_line":"        self.instance.guest.restart()"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F982A%3D","line":1125,"updated":"2014-01-31 18:38:04.000000000","message":"Copied from previous patchset start instance, because you use connection to guest service, guest runs on VM, not on datastore.","commit_id":"53f019454ad29b3fc604a36253f7a6d0ef42455a"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"cc497b040d98c9c0135770da2e3eb4e6243b8714","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"                  {\u0027hostname\u0027: self.instance.hostname,"},{"line_number":1123,"context_line":"                   \u0027id\u0027: self.instance.id})"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"    def _start_datastore(self):"},{"line_number":1126,"context_line":"        self.instance.guest.restart()"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F9tzk%3D","line":1125,"in_reply_to":"AAAAUH%2F982A%3D","updated":"2014-02-04 18:27:00.000000000","message":"im fine with _start_datastore","commit_id":"53f019454ad29b3fc604a36253f7a6d0ef42455a"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"203ee3291989051cdbba4434d8517e1450f03bec","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"                  {\u0027hostname\u0027: self.instance.hostname,"},{"line_number":1123,"context_line":"                   \u0027id\u0027: self.instance.id})"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"    def _start_datastore(self):"},{"line_number":1126,"context_line":"        self.instance.guest.restart()"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F9tf8%3D","line":1125,"in_reply_to":"AAAAUH%2F9tzk%3D","updated":"2014-02-04 19:47:49.000000000","message":"Me too- I think the word refers to the running datastore program and not just it\u0027s configuration.","commit_id":"53f019454ad29b3fc604a36253f7a6d0ef42455a"}],"trove/tests/api/instances_resize.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def tearDown(self):"},{"line_number":116,"context_line":"        super(ResizeTests, self).tearDown()"},{"line_number":117,"context_line":"        self._teardown()"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def _start_mysql(self):"},{"line_number":120,"context_line":"        config \u003d template.SingleInstanceConfigTemplate("},{"line_number":121,"context_line":"            \"mysql\", NEW_FLAVOR.__dict__, self.instance.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FemE%3D","side":"PARENT","line":118,"updated":"2014-01-13 14:07:19.000000000","message":"please return tearDown method","commit_id":"17d9bd5fbe5619609a1d3443d24e2431e809dc79"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        self._stop_db()"},{"line_number":173,"context_line":"        self._nova_resizes_successfully()"},{"line_number":174,"context_line":"        self.instance.set_service_status_to_paused()"},{"line_number":175,"context_line":"        self.instance.inst_service_status.status \u003d \\"},{"line_number":176,"context_line":"            rd_instance.ServiceStatuses.PAUSED"},{"line_number":177,"context_line":"        utils.poll_until(mox.IgnoreArg(), sleep_time\u003d2, time_out\u003d120)\\"},{"line_number":178,"context_line":"            .AndRaise(PollTimeOut)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FemA%3D","line":175,"updated":"2014-01-13 14:07:19.000000000","message":"avoid \\","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"9b09e678780e03d5d07a2affc3c9c70ff32f295b","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        self._stop_db()"},{"line_number":173,"context_line":"        self._nova_resizes_successfully()"},{"line_number":174,"context_line":"        self.instance.set_service_status_to_paused()"},{"line_number":175,"context_line":"        self.instance.inst_service_status.status \u003d \\"},{"line_number":176,"context_line":"            rd_instance.ServiceStatuses.PAUSED"},{"line_number":177,"context_line":"        utils.poll_until(mox.IgnoreArg(), sleep_time\u003d2, time_out\u003d120)\\"},{"line_number":178,"context_line":"            .AndRaise(PollTimeOut)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FVP0%3D","line":175,"in_reply_to":"AAAAUH%2F%2FemA%3D","updated":"2014-01-14 23:38:35.000000000","message":"Done","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        self._stop_db()"},{"line_number":187,"context_line":"        self._nova_resizes_successfully()"},{"line_number":188,"context_line":"        self.instance.set_service_status_to_paused()"},{"line_number":189,"context_line":"        self.instance.inst_service_status.status \u003d \\"},{"line_number":190,"context_line":"            rd_instance.ServiceStatuses.SHUTDOWN"},{"line_number":191,"context_line":"        utils.poll_until(mox.IgnoreArg(), sleep_time\u003d2, time_out\u003d120)"},{"line_number":192,"context_line":"        self._start_mysql()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fel8%3D","line":189,"updated":"2014-01-13 14:07:19.000000000","message":"avoid \\","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"9b09e678780e03d5d07a2affc3c9c70ff32f295b","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        self._stop_db()"},{"line_number":187,"context_line":"        self._nova_resizes_successfully()"},{"line_number":188,"context_line":"        self.instance.set_service_status_to_paused()"},{"line_number":189,"context_line":"        self.instance.inst_service_status.status \u003d \\"},{"line_number":190,"context_line":"            rd_instance.ServiceStatuses.SHUTDOWN"},{"line_number":191,"context_line":"        utils.poll_until(mox.IgnoreArg(), sleep_time\u003d2, time_out\u003d120)"},{"line_number":192,"context_line":"        self._start_mysql()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FVPw%3D","line":189,"in_reply_to":"AAAAUH%2F%2Fel8%3D","updated":"2014-01-14 23:38:35.000000000","message":"Done","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        self._stop_db()"},{"line_number":201,"context_line":"        self._nova_resizes_successfully()"},{"line_number":202,"context_line":"        self.instance.set_service_status_to_paused()"},{"line_number":203,"context_line":"        self.instance.inst_service_status.status \u003d \\"},{"line_number":204,"context_line":"            rd_instance.ServiceStatuses.RUNNING"},{"line_number":205,"context_line":"        utils.poll_until(mox.IgnoreArg(), sleep_time\u003d2, time_out\u003d120)"},{"line_number":206,"context_line":"        self._start_mysql()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fel4%3D","line":203,"updated":"2014-01-13 14:07:19.000000000","message":"avoid \\","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"9b09e678780e03d5d07a2affc3c9c70ff32f295b","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        self._stop_db()"},{"line_number":201,"context_line":"        self._nova_resizes_successfully()"},{"line_number":202,"context_line":"        self.instance.set_service_status_to_paused()"},{"line_number":203,"context_line":"        self.instance.inst_service_status.status \u003d \\"},{"line_number":204,"context_line":"            rd_instance.ServiceStatuses.RUNNING"},{"line_number":205,"context_line":"        utils.poll_until(mox.IgnoreArg(), sleep_time\u003d2, time_out\u003d120)"},{"line_number":206,"context_line":"        self._start_mysql()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FVPs%3D","line":203,"in_reply_to":"AAAAUH%2F%2Fel4%3D","updated":"2014-01-14 23:38:35.000000000","message":"Done","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        self._stop_db()"},{"line_number":213,"context_line":"        self._nova_resizes_successfully()"},{"line_number":214,"context_line":"        self.instance.set_service_status_to_paused()"},{"line_number":215,"context_line":"        self.instance.inst_service_status.status \u003d \\"},{"line_number":216,"context_line":"            rd_instance.ServiceStatuses.PAUSED"},{"line_number":217,"context_line":"        utils.poll_until(mox.IgnoreArg(),"},{"line_number":218,"context_line":"                         sleep_time\u003d2,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fels%3D","line":215,"updated":"2014-01-13 14:07:19.000000000","message":"avoid \\","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ce254f7e1517098e8326a8ef30d3c48698e6ccb1","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        self.server.migrate(force_host\u003dNone)"},{"line_number":247,"context_line":"        self._server_changes_to(\"VERIFY_RESIZE\", NEW_FLAVOR_ID)"},{"line_number":248,"context_line":"        self.instance.set_service_status_to_paused()"},{"line_number":249,"context_line":"        self.instance.inst_service_status.status \u003d \\"},{"line_number":250,"context_line":"            rd_instance.ServiceStatuses.RUNNING"},{"line_number":251,"context_line":"        utils.poll_until(mox.IgnoreArg(), sleep_time\u003d2, time_out\u003d120)"},{"line_number":252,"context_line":"        self._start_mysql()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fkoc%3D","line":249,"updated":"2014-01-10 21:57:57.000000000","message":"please use ()","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"9b09e678780e03d5d07a2affc3c9c70ff32f295b","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        self.server.migrate(force_host\u003dNone)"},{"line_number":247,"context_line":"        self._server_changes_to(\"VERIFY_RESIZE\", NEW_FLAVOR_ID)"},{"line_number":248,"context_line":"        self.instance.set_service_status_to_paused()"},{"line_number":249,"context_line":"        self.instance.inst_service_status.status \u003d \\"},{"line_number":250,"context_line":"            rd_instance.ServiceStatuses.RUNNING"},{"line_number":251,"context_line":"        utils.poll_until(mox.IgnoreArg(), sleep_time\u003d2, time_out\u003d120)"},{"line_number":252,"context_line":"        self._start_mysql()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FVPk%3D","line":249,"in_reply_to":"AAAAUH%2F%2Fkoc%3D","updated":"2014-01-14 23:38:35.000000000","message":"Done","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"}],"trove/tests/api/mgmt/instances_actions.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import mox"},{"line_number":16,"context_line":"import trove.common.instance"},{"line_number":17,"context_line":"from trove.backup import models as backup_models"},{"line_number":18,"context_line":"from trove.common.context import TroveContext"},{"line_number":19,"context_line":"from trove.instance.tasks import InstanceTasks"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FelU%3D","line":16,"updated":"2014-01-13 14:07:19.000000000","message":"from trove.common import instance as tr_inst","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self.context \u003d TroveContext(is_admin\u003dTrue)"},{"line_number":52,"context_line":"        self.tenant_id \u003d 999"},{"line_number":53,"context_line":"        self.db_info \u003d DBInstance.create("},{"line_number":54,"context_line":"            id\u003d\"inst-id-1\","},{"line_number":55,"context_line":"            name\u003d\"instance\","},{"line_number":56,"context_line":"            flavor_id\u003d1,"},{"line_number":57,"context_line":"            datastore_version_id\u003dtest_config.dbaas_datastore_version,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Felk%3D","line":54,"updated":"2014-01-13 14:07:19.000000000","message":"id is auto-generated","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            self.db_info,"},{"line_number":65,"context_line":"            self.server,"},{"line_number":66,"context_line":"            service_status\u003dimodels.InstanceServiceStatus("},{"line_number":67,"context_line":"                trove.common.instance.ServiceStatuses.RUNNING))"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _make_request(self, path\u003d\u0027/\u0027, context\u003dNone, **kwargs):"},{"line_number":70,"context_line":"        from webob import Request"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FelQ%3D","line":67,"updated":"2014-01-13 14:07:19.000000000","message":"tr_inst.ServiceStatuses.RUNNING","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"}],"trove/tests/fakes/nova.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            mapping \u003d \"%s::%s:%s\" % (volume.id, volume.size, 1)"},{"line_number":274,"context_line":"            block_device_mapping \u003d {\u0027vdb\u0027: mapping}"},{"line_number":275,"context_line":"            volumes \u003d [volume]"},{"line_number":276,"context_line":"            LOG.debug(\"Fake Volume Create %s with status %s\" %"},{"line_number":277,"context_line":"                      (volume.id, volume.status))"},{"line_number":278,"context_line":"        else:"},{"line_number":279,"context_line":"            volumes \u003d self._get_volumes_from_bdm(block_device_mapping)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FelM%3D","line":276,"updated":"2014-01-13 14:07:19.000000000","message":"_()","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"9b09e678780e03d5d07a2affc3c9c70ff32f295b","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            mapping \u003d \"%s::%s:%s\" % (volume.id, volume.size, 1)"},{"line_number":274,"context_line":"            block_device_mapping \u003d {\u0027vdb\u0027: mapping}"},{"line_number":275,"context_line":"            volumes \u003d [volume]"},{"line_number":276,"context_line":"            LOG.debug(\"Fake Volume Create %s with status %s\" %"},{"line_number":277,"context_line":"                      (volume.id, volume.status))"},{"line_number":278,"context_line":"        else:"},{"line_number":279,"context_line":"            volumes \u003d self._get_volumes_from_bdm(block_device_mapping)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FVM8%3D","line":276,"in_reply_to":"AAAAUH%2F%2FelM%3D","updated":"2014-01-14 23:38:35.000000000","message":"Done","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":490,"context_line":"        else:"},{"line_number":491,"context_line":"            volume.schedule_status(\"available\", 2)"},{"line_number":492,"context_line":"        LOG.debug(\"Fake volume created %s with status %s\" %"},{"line_number":493,"context_line":"                  (volume.id, volume.status))"},{"line_number":494,"context_line":"        LOG.info(\"FAKE_VOLUMES_DB : %s\" % FAKE_VOLUMES_DB)"},{"line_number":495,"context_line":"        return volume"},{"line_number":496,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FelE%3D","line":493,"updated":"2014-01-13 14:07:19.000000000","message":"_()","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ce254f7e1517098e8326a8ef30d3c48698e6ccb1","unresolved":false,"context_lines":[{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        if volume._current_status !\u003d \u0027available\u0027:"},{"line_number":505,"context_line":"            raise Exception(\"Invalid volume status: \""},{"line_number":506,"context_line":"                            \"expected \u0027in-use\u0027 but was \u0027%s\u0027\" %"},{"line_number":507,"context_line":"                            volume._current_status)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        def finish_resize():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FkoY%3D","line":506,"updated":"2014-01-10 21:57:57.000000000","message":"indents","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"9b09e678780e03d5d07a2affc3c9c70ff32f295b","unresolved":false,"context_lines":[{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        if volume._current_status !\u003d \u0027available\u0027:"},{"line_number":505,"context_line":"            raise Exception(\"Invalid volume status: \""},{"line_number":506,"context_line":"                            \"expected \u0027in-use\u0027 but was \u0027%s\u0027\" %"},{"line_number":507,"context_line":"                            volume._current_status)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        def finish_resize():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FVNs%3D","line":506,"in_reply_to":"AAAAUH%2F%2FkoY%3D","updated":"2014-01-14 23:38:35.000000000","message":"I am not sure why this shows up this way but it is correctly indented","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        if volume._current_status !\u003d \u0027available\u0027:"},{"line_number":505,"context_line":"            raise Exception(\"Invalid volume status: \""},{"line_number":506,"context_line":"                            \"expected \u0027in-use\u0027 but was \u0027%s\u0027\" %"},{"line_number":507,"context_line":"                            volume._current_status)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        def finish_resize():"},{"line_number":510,"context_line":"            volume.size \u003d new_size"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fek4%3D","line":507,"updated":"2014-01-13 14:07:19.000000000","message":"_()","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"9b09e678780e03d5d07a2affc3c9c70ff32f295b","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        if volume._current_status !\u003d \u0027available\u0027:"},{"line_number":505,"context_line":"            raise Exception(\"Invalid volume status: \""},{"line_number":506,"context_line":"                            \"expected \u0027in-use\u0027 but was \u0027%s\u0027\" %"},{"line_number":507,"context_line":"                            volume._current_status)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        def finish_resize():"},{"line_number":510,"context_line":"            volume.size \u003d new_size"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FVNA%3D","line":507,"in_reply_to":"AAAAUH%2F%2Fek4%3D","updated":"2014-01-14 23:38:35.000000000","message":"Done","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ce254f7e1517098e8326a8ef30d3c48698e6ccb1","unresolved":false,"context_lines":[{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        if volume._current_status !\u003d \u0027in-use\u0027:"},{"line_number":517,"context_line":"            raise Exception(\"Invalid volume status: \""},{"line_number":518,"context_line":"                            \"expected \u0027in-use\u0027 but was \u0027%s\u0027\" %"},{"line_number":519,"context_line":"                            volume._current_status)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"        def finish_detach():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FkoU%3D","line":518,"updated":"2014-01-10 21:57:57.000000000","message":"indents","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"9b09e678780e03d5d07a2affc3c9c70ff32f295b","unresolved":false,"context_lines":[{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        if volume._current_status !\u003d \u0027in-use\u0027:"},{"line_number":517,"context_line":"            raise Exception(\"Invalid volume status: \""},{"line_number":518,"context_line":"                            \"expected \u0027in-use\u0027 but was \u0027%s\u0027\" %"},{"line_number":519,"context_line":"                            volume._current_status)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"        def finish_detach():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FVNE%3D","line":518,"in_reply_to":"AAAAUH%2F%2FkoU%3D","updated":"2014-01-14 23:38:35.000000000","message":"see above","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        if volume._current_status !\u003d \u0027in-use\u0027:"},{"line_number":517,"context_line":"            raise Exception(\"Invalid volume status: \""},{"line_number":518,"context_line":"                            \"expected \u0027in-use\u0027 but was \u0027%s\u0027\" %"},{"line_number":519,"context_line":"                            volume._current_status)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"        def finish_detach():"},{"line_number":522,"context_line":"            volume._current_status \u003d \"available\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fek0%3D","line":519,"updated":"2014-01-13 14:07:19.000000000","message":"_()","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"9b09e678780e03d5d07a2affc3c9c70ff32f295b","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        if volume._current_status !\u003d \u0027in-use\u0027:"},{"line_number":517,"context_line":"            raise Exception(\"Invalid volume status: \""},{"line_number":518,"context_line":"                            \"expected \u0027in-use\u0027 but was \u0027%s\u0027\" %"},{"line_number":519,"context_line":"                            volume._current_status)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"        def finish_detach():"},{"line_number":522,"context_line":"            volume._current_status \u003d \"available\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FVNI%3D","line":519,"in_reply_to":"AAAAUH%2F%2Fek0%3D","updated":"2014-01-14 23:38:35.000000000","message":"Done","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ce254f7e1517098e8326a8ef30d3c48698e6ccb1","unresolved":false,"context_lines":[{"line_number":527,"context_line":""},{"line_number":528,"context_line":"        if volume._current_status \u003d\u003d \u0027in-use\u0027:"},{"line_number":529,"context_line":"            raise Exception(\"Invalid volume status: \""},{"line_number":530,"context_line":"                            \"expected \u0027available\u0027 but was \u0027%s\u0027\" %"},{"line_number":531,"context_line":"                            volume._current_status)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        def finish_attach():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FkoQ%3D","line":530,"updated":"2014-01-10 21:57:57.000000000","message":"indents","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"9b09e678780e03d5d07a2affc3c9c70ff32f295b","unresolved":false,"context_lines":[{"line_number":527,"context_line":""},{"line_number":528,"context_line":"        if volume._current_status \u003d\u003d \u0027in-use\u0027:"},{"line_number":529,"context_line":"            raise Exception(\"Invalid volume status: \""},{"line_number":530,"context_line":"                            \"expected \u0027available\u0027 but was \u0027%s\u0027\" %"},{"line_number":531,"context_line":"                            volume._current_status)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        def finish_attach():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FVNM%3D","line":530,"in_reply_to":"AAAAUH%2F%2FkoQ%3D","updated":"2014-01-14 23:38:35.000000000","message":"see above","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":528,"context_line":"        if volume._current_status \u003d\u003d \u0027in-use\u0027:"},{"line_number":529,"context_line":"            raise Exception(\"Invalid volume status: \""},{"line_number":530,"context_line":"                            \"expected \u0027available\u0027 but was \u0027%s\u0027\" %"},{"line_number":531,"context_line":"                            volume._current_status)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        def finish_attach():"},{"line_number":534,"context_line":"            volume._current_status \u003d \"in-use\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fekw%3D","line":531,"updated":"2014-01-13 14:07:19.000000000","message":"_()","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"9b09e678780e03d5d07a2affc3c9c70ff32f295b","unresolved":false,"context_lines":[{"line_number":528,"context_line":"        if volume._current_status \u003d\u003d \u0027in-use\u0027:"},{"line_number":529,"context_line":"            raise Exception(\"Invalid volume status: \""},{"line_number":530,"context_line":"                            \"expected \u0027available\u0027 but was \u0027%s\u0027\" %"},{"line_number":531,"context_line":"                            volume._current_status)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        def finish_attach():"},{"line_number":534,"context_line":"            volume._current_status \u003d \"in-use\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FVNQ%3D","line":531,"in_reply_to":"AAAAUH%2F%2Fekw%3D","updated":"2014-01-14 23:38:35.000000000","message":"Done","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"3518f6dee63f44d8dd4bd332085bb5bf82c1a92e","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            block_device_mapping \u003d {\u0027vdb\u0027: mapping}"},{"line_number":275,"context_line":"            volumes \u003d [volume]"},{"line_number":276,"context_line":"            LOG.debug(\"Fake Volume Create %s with status %s\" %"},{"line_number":277,"context_line":"                      (volume.id, volume.status))"},{"line_number":278,"context_line":"        else:"},{"line_number":279,"context_line":"            volumes \u003d self._get_volumes_from_bdm(block_device_mapping)"},{"line_number":280,"context_line":"            for volume in volumes:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FTF4%3D","line":277,"updated":"2014-01-15 10:49:43.000000000","message":"_() and formatting","commit_id":"625d9354af8ebf848e3daa74bd469248eecdb69c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"3518f6dee63f44d8dd4bd332085bb5bf82c1a92e","unresolved":false,"context_lines":[{"line_number":490,"context_line":"        else:"},{"line_number":491,"context_line":"            volume.schedule_status(\"available\", 2)"},{"line_number":492,"context_line":"        LOG.debug(\"Fake volume created %s with status %s\" %"},{"line_number":493,"context_line":"                  (volume.id, volume.status))"},{"line_number":494,"context_line":"        LOG.info(\"FAKE_VOLUMES_DB : %s\" % FAKE_VOLUMES_DB)"},{"line_number":495,"context_line":"        return volume"},{"line_number":496,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FTF0%3D","line":493,"updated":"2014-01-15 10:49:43.000000000","message":"_() and formatting","commit_id":"625d9354af8ebf848e3daa74bd469248eecdb69c"}],"trove/tests/unittests/api/common/test_limits.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    def test_GET_no_delay(self):"},{"line_number":274,"context_line":"        # Test a limit_inst handles 1 GET per second."},{"line_number":275,"context_line":"        limit_inst \u003d Limit(\"GET\", \"*\", \".*\", 1, 1)"},{"line_number":276,"context_line":"        when(limit_inst)._get_time().thenReturn(0.0)"},{"line_number":277,"context_line":"        delay \u003d limit_inst(\"GET\", \"/anything\")"},{"line_number":278,"context_line":"        self.assertEqual(None, delay)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Feko%3D","line":275,"updated":"2014-01-13 14:07:19.000000000","message":"no need to rename this var","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"}],"trove/tests/unittests/dns/test_designate_driver.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"3518f6dee63f44d8dd4bd332085bb5bf82c1a92e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from designateclient.v1.domains import Domain"},{"line_number":16,"context_line":"from designateclient.v1.records import Record"},{"line_number":17,"context_line":"from trove.dns.designate import driver"},{"line_number":18,"context_line":"import mockito"},{"line_number":19,"context_line":"from mockito import any"},{"line_number":20,"context_line":"from mockito import mock"},{"line_number":21,"context_line":"from mockito import when"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FTFo%3D","line":18,"updated":"2014-01-15 10:49:43.000000000","message":"blank line between project imports and test imports","commit_id":"625d9354af8ebf848e3daa74bd469248eecdb69c"}],"trove/tests/unittests/instance/test_instance_status.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_task_status_error_reports_error(self):"},{"line_number":50,"context_line":"        fake_db_info \u003d FakeDBInstance()"},{"line_number":51,"context_line":"        fake_status \u003d InstanceServiceStatus(ServiceStatuses.RUNNING)"},{"line_number":52,"context_line":"        fake_db_info.task_status.is_error \u003d True"},{"line_number":53,"context_line":"        instance \u003d SimpleInstance(\u0027dummy context\u0027, fake_db_info, fake_status)"},{"line_number":54,"context_line":"        self.assertEqual(InstanceStatus.ERROR, instance.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FekE%3D","line":51,"updated":"2014-01-13 14:07:19.000000000","message":"No need to change it. Since tests are correct, i dont think that tests should be changed.","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"1e9d4cc258ac2812cddd728ec828580f0e3a7d91","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_task_status_error_reports_error(self):"},{"line_number":50,"context_line":"        fake_db_info \u003d FakeDBInstance()"},{"line_number":51,"context_line":"        fake_status \u003d InstanceServiceStatus(ServiceStatuses.RUNNING)"},{"line_number":52,"context_line":"        fake_db_info.task_status.is_error \u003d True"},{"line_number":53,"context_line":"        instance \u003d SimpleInstance(\u0027dummy context\u0027, fake_db_info, fake_status)"},{"line_number":54,"context_line":"        self.assertEqual(InstanceStatus.ERROR, instance.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FcgM%3D","line":51,"in_reply_to":"AAAAUH%2F%2FekE%3D","updated":"2014-01-13 20:11:19.000000000","message":"I locked down the setter for this status - it must be an InstanceServiceStatus.  Further more since InstanceServiceStatus is a plain old object there is not need to create a Fake.","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_task_status_action_building_reports_build(self):"},{"line_number":57,"context_line":"        fake_db_info \u003d FakeDBInstance()"},{"line_number":58,"context_line":"        fake_status \u003d InstanceServiceStatus(ServiceStatuses.RUNNING)"},{"line_number":59,"context_line":"        fake_db_info.task_status.action \u003d \"BUILDING\""},{"line_number":60,"context_line":"        instance \u003d SimpleInstance(\u0027dummy context\u0027, fake_db_info, fake_status)"},{"line_number":61,"context_line":"        self.assertEqual(InstanceStatus.BUILD, instance.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FekA%3D","line":58,"updated":"2014-01-13 14:07:19.000000000","message":"No need to change it. Since tests are correct, i dont think that tests should be changed.","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def test_task_status_action_rebooting_reports_reboot(self):"},{"line_number":64,"context_line":"        fake_db_info \u003d FakeDBInstance()"},{"line_number":65,"context_line":"        fake_status \u003d InstanceServiceStatus(ServiceStatuses.RUNNING)"},{"line_number":66,"context_line":"        fake_db_info.task_status.action \u003d \"REBOOTING\""},{"line_number":67,"context_line":"        instance \u003d SimpleInstance(\u0027dummy context\u0027, fake_db_info, fake_status)"},{"line_number":68,"context_line":"        self.assertEqual(InstanceStatus.REBOOT, instance.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fej8%3D","line":65,"updated":"2014-01-13 14:07:19.000000000","message":"No need to change it. Since tests are correct, i dont think that tests should be changed.","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_task_status_action_resizing_reports_resize(self):"},{"line_number":71,"context_line":"        fake_db_info \u003d FakeDBInstance()"},{"line_number":72,"context_line":"        fake_status \u003d InstanceServiceStatus(ServiceStatuses.RUNNING)"},{"line_number":73,"context_line":"        fake_db_info.task_status.action \u003d \"RESIZING\""},{"line_number":74,"context_line":"        instance \u003d SimpleInstance(\u0027dummy context\u0027, fake_db_info, fake_status)"},{"line_number":75,"context_line":"        self.assertEqual(InstanceStatus.RESIZE, instance.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fej4%3D","line":72,"updated":"2014-01-13 14:07:19.000000000","message":"No need to change it. Since tests are correct, i dont think that tests should be changed.","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_task_status_action_deleting_reports_shutdown(self):"},{"line_number":78,"context_line":"        fake_db_info \u003d FakeDBInstance()"},{"line_number":79,"context_line":"        fake_status \u003d InstanceServiceStatus(ServiceStatuses.RUNNING)"},{"line_number":80,"context_line":"        fake_db_info.task_status.action \u003d \"DELETING\""},{"line_number":81,"context_line":"        instance \u003d SimpleInstance(\u0027dummy context\u0027, fake_db_info, fake_status)"},{"line_number":82,"context_line":"        self.assertEqual(InstanceStatus.SHUTDOWN, instance.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fej0%3D","line":79,"updated":"2014-01-13 14:07:19.000000000","message":"No need to change it. Since tests are correct, i dont think that tests should be changed.","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_nova_server_build_reports_build(self):"},{"line_number":85,"context_line":"        fake_db_info \u003d FakeDBInstance()"},{"line_number":86,"context_line":"        fake_status \u003d InstanceServiceStatus(ServiceStatuses.RUNNING)"},{"line_number":87,"context_line":"        fake_db_info.server_status \u003d \"BUILD\""},{"line_number":88,"context_line":"        instance \u003d SimpleInstance(\u0027dummy context\u0027, fake_db_info, fake_status)"},{"line_number":89,"context_line":"        self.assertEqual(InstanceStatus.BUILD, instance.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fejw%3D","line":86,"updated":"2014-01-13 14:07:19.000000000","message":"No need to change it. Since tests are correct, i dont think that tests should be changed.","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_nova_server_error_reports_error(self):"},{"line_number":92,"context_line":"        fake_db_info \u003d FakeDBInstance()"},{"line_number":93,"context_line":"        fake_status \u003d InstanceServiceStatus(ServiceStatuses.RUNNING)"},{"line_number":94,"context_line":"        fake_db_info.server_status \u003d \"ERROR\""},{"line_number":95,"context_line":"        instance \u003d SimpleInstance(\u0027dummy context\u0027, fake_db_info, fake_status)"},{"line_number":96,"context_line":"        self.assertEqual(InstanceStatus.ERROR, instance.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fejs%3D","line":93,"updated":"2014-01-13 14:07:19.000000000","message":"No need to change it. Since tests are correct, i dont think that tests should be changed.","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_nova_server_reboot_reports_reboot(self):"},{"line_number":99,"context_line":"        fake_db_info \u003d FakeDBInstance()"},{"line_number":100,"context_line":"        fake_status \u003d InstanceServiceStatus(ServiceStatuses.RUNNING)"},{"line_number":101,"context_line":"        fake_db_info.server_status \u003d \"REBOOT\""},{"line_number":102,"context_line":"        instance \u003d SimpleInstance(\u0027dummy context\u0027, fake_db_info, fake_status)"},{"line_number":103,"context_line":"        self.assertEqual(InstanceStatus.REBOOT, instance.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fejo%3D","line":100,"updated":"2014-01-13 14:07:19.000000000","message":"No need to change it. Since tests are correct, i dont think that tests should be changed.","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_nova_server_resize_reports_resize(self):"},{"line_number":106,"context_line":"        fake_db_info \u003d FakeDBInstance()"},{"line_number":107,"context_line":"        fake_status \u003d InstanceServiceStatus(ServiceStatuses.RUNNING)"},{"line_number":108,"context_line":"        fake_db_info.server_status \u003d \"RESIZE\""},{"line_number":109,"context_line":"        instance \u003d SimpleInstance(\u0027dummy context\u0027, fake_db_info, fake_status)"},{"line_number":110,"context_line":"        self.assertEqual(InstanceStatus.RESIZE, instance.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fejk%3D","line":107,"updated":"2014-01-13 14:07:19.000000000","message":"No need to change it. Since tests are correct, i dont think that tests should be changed.","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def test_nova_server_verify_resize_reports_resize(self):"},{"line_number":113,"context_line":"        fake_db_info \u003d FakeDBInstance()"},{"line_number":114,"context_line":"        fake_status \u003d InstanceServiceStatus(ServiceStatuses.RUNNING)"},{"line_number":115,"context_line":"        fake_db_info.server_status \u003d \"VERIFY_RESIZE\""},{"line_number":116,"context_line":"        instance \u003d SimpleInstance(\u0027dummy context\u0027, fake_db_info, fake_status)"},{"line_number":117,"context_line":"        self.assertEqual(InstanceStatus.RESIZE, instance.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fejg%3D","line":114,"updated":"2014-01-13 14:07:19.000000000","message":"No need to change it. Since tests are correct, i dont think that tests should be changed.","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def test_service_status_paused_reports_reboot(self):"},{"line_number":120,"context_line":"        fake_db_info \u003d FakeDBInstance()"},{"line_number":121,"context_line":"        fake_status \u003d InstanceServiceStatus(ServiceStatuses.RUNNING)"},{"line_number":122,"context_line":"        fake_status.set_status(ServiceStatuses.PAUSED)"},{"line_number":123,"context_line":"        instance \u003d SimpleInstance(\u0027dummy context\u0027, fake_db_info, fake_status)"},{"line_number":124,"context_line":"        self.assertEqual(InstanceStatus.REBOOT, instance.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fejc%3D","line":121,"updated":"2014-01-13 14:07:19.000000000","message":"No need to change it. Since tests are correct, i dont think that tests should be changed.","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_service_status_new_reports_build(self):"},{"line_number":127,"context_line":"        fake_db_info \u003d FakeDBInstance()"},{"line_number":128,"context_line":"        fake_status \u003d InstanceServiceStatus(ServiceStatuses.RUNNING)"},{"line_number":129,"context_line":"        fake_status.set_status(ServiceStatuses.NEW)"},{"line_number":130,"context_line":"        instance \u003d SimpleInstance(\u0027dummy context\u0027, fake_db_info, fake_status)"},{"line_number":131,"context_line":"        self.assertEqual(InstanceStatus.BUILD, instance.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FejU%3D","line":128,"updated":"2014-01-13 14:07:19.000000000","message":"No need to change it. Since tests are correct, i dont think that tests should be changed.","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def test_service_status_running_reports_active(self):"},{"line_number":134,"context_line":"        fake_db_info \u003d FakeDBInstance()"},{"line_number":135,"context_line":"        fake_status \u003d InstanceServiceStatus(ServiceStatuses.RUNNING)"},{"line_number":136,"context_line":"        fake_status.set_status(ServiceStatuses.RUNNING)"},{"line_number":137,"context_line":"        instance \u003d SimpleInstance(\u0027dummy context\u0027, fake_db_info, fake_status)"},{"line_number":138,"context_line":"        self.assertEqual(InstanceStatus.ACTIVE, instance.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FejQ%3D","line":135,"updated":"2014-01-13 14:07:19.000000000","message":"No need to change it. Since tests are correct, i dont think that tests should be changed.","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"}],"trove/tests/unittests/taskmanager/test_models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        self.new_flavor \u003d {\u0027id\u0027: 8, \u0027ram\u0027: 768, \u0027name\u0027: \u0027bigger_flavor\u0027}"},{"line_number":267,"context_line":"        stub_nova_server \u003d mock(novaclient.v1_1.servers.Server)"},{"line_number":268,"context_line":"        db_instance \u003d DBInstance(InstanceTasks.NONE,"},{"line_number":269,"context_line":"                                 id\u003dINST_ID,"},{"line_number":270,"context_line":"                                 name\u003d\u0027resize-inst-name\u0027,"},{"line_number":271,"context_line":"                                 datastore_version_id\u003d\u00271\u0027,"},{"line_number":272,"context_line":"                                 datastore_id\u003d\u0027id-1\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Feik%3D","line":269,"updated":"2014-01-13 14:07:19.000000000","message":"id is autogenerated attr","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"3518f6dee63f44d8dd4bd332085bb5bf82c1a92e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from trove.instance.tasks import InstanceTasks"},{"line_number":37,"context_line":"from trove.common.exception import TroveError"},{"line_number":38,"context_line":"from swiftclient.client import ClientException"},{"line_number":39,"context_line":"import trove.common.template as template"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"INST_ID \u003d \u0027dbinst-id-1\u0027"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FTFc%3D","line":39,"updated":"2014-01-15 10:49:43.000000000","message":"import statement should come before from statement","commit_id":"625d9354af8ebf848e3daa74bd469248eecdb69c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"3518f6dee63f44d8dd4bd332085bb5bf82c1a92e","unresolved":false,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def test_resize_volume_active(self):"},{"line_number":339,"context_line":"        self.instance_task.server.status \u003d \u0027ACTIVE\u0027"},{"line_number":340,"context_line":"        self.instance_task.resize_volume(\u00272\u0027)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def test_resize_volume_inactive(self):"},{"line_number":343,"context_line":"        self.instance_task.server.status \u003d \u0027SHUTDOWN\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FTFM%3D","line":340,"updated":"2014-01-15 10:49:43.000000000","message":"please make some assertions for this test","commit_id":"625d9354af8ebf848e3daa74bd469248eecdb69c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"3518f6dee63f44d8dd4bd332085bb5bf82c1a92e","unresolved":false,"context_lines":[{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def test_resize_volume_inactive(self):"},{"line_number":343,"context_line":"        self.instance_task.server.status \u003d \u0027SHUTDOWN\u0027"},{"line_number":344,"context_line":"        self.instance_task.resize_volume(\u00272\u0027)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"class BackupTasksTest(testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FTFI%3D","line":344,"updated":"2014-01-15 10:49:43.000000000","message":"please make some assertions for this test","commit_id":"625d9354af8ebf848e3daa74bd469248eecdb69c"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"203ee3291989051cdbba4434d8517e1450f03bec","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        verify(self.instance_task._guest).stop_db(do_not_start_on_reboot\u003dTrue)"},{"line_number":365,"context_line":"        verify(orig_server).resize(self.new_flavor[\u0027id\u0027])"},{"line_number":366,"context_line":"        self.assertThat(self.db_instance.task_status, Is(InstanceTasks.NONE))"},{"line_number":367,"context_line":"        self.assertThat(self.db_instance.flavor_id, Is(\u00276\u0027))"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def test_resize_volume_active(self):"},{"line_number":370,"context_line":"        self.instance_task.server.status \u003d \u0027ACTIVE\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F9tPM%3D","line":367,"updated":"2014-02-04 19:47:49.000000000","message":"I feel like the resize cases were already well covered in trove/tests/api/instances_resize.py. What was missing?","commit_id":"53f019454ad29b3fc604a36253f7a6d0ef42455a"}],"trove/tests/util/usage.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def notify(context, message):"},{"line_number":76,"context_line":"    \"\"\"Simple test notify function which saves the messages to global list.\"\"\""},{"line_number":77,"context_line":"    LOG.debug(\u0027Received Usage Notification: %s\u0027 % message)"},{"line_number":78,"context_line":"    payload \u003d message.get(\u0027payload\u0027, None)"},{"line_number":79,"context_line":"    payload[\u0027event_type\u0027] \u003d message[\u0027event_type\u0027]"},{"line_number":80,"context_line":"    resource_id \u003d payload[\u0027instance_id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Feh8%3D","line":77,"updated":"2014-01-13 14:07:19.000000000","message":"_()","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dfdc360dfae76de28859fcd609b30b8f99333028","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    resource_id \u003d payload[\u0027instance_id\u0027]"},{"line_number":81,"context_line":"    global MESSAGE_QUEUE"},{"line_number":82,"context_line":"    MESSAGE_QUEUE[resource_id].append(payload)"},{"line_number":83,"context_line":"    LOG.debug(\u0027Message Queue for %s now has %d messages\u0027 %"},{"line_number":84,"context_line":"              (resource_id, len(MESSAGE_QUEUE[resource_id])))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FeiE%3D","line":83,"updated":"2014-01-13 14:07:19.000000000","message":"_()","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ce254f7e1517098e8326a8ef30d3c48698e6ccb1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    global MESSAGE_QUEUE"},{"line_number":82,"context_line":"    MESSAGE_QUEUE[resource_id].append(payload)"},{"line_number":83,"context_line":"    LOG.debug(\u0027Message Queue for %s now has %d messages\u0027 %"},{"line_number":84,"context_line":"              (resource_id, len(MESSAGE_QUEUE[resource_id])))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fkno%3D","line":84,"updated":"2014-01-10 21:57:57.000000000","message":"please use keyword/dict for string formatting","commit_id":"061ad0efa3af9f4493abc063cb4f9f04a2af9781"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"3518f6dee63f44d8dd4bd332085bb5bf82c1a92e","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    resource_id \u003d payload[\u0027instance_id\u0027]"},{"line_number":81,"context_line":"    global MESSAGE_QUEUE"},{"line_number":82,"context_line":"    MESSAGE_QUEUE[resource_id].append(payload)"},{"line_number":83,"context_line":"    LOG.debug(\u0027Message Queue for %s now has %d messages\u0027 %"},{"line_number":84,"context_line":"              (resource_id, len(MESSAGE_QUEUE[resource_id])))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FTFA%3D","line":83,"updated":"2014-01-15 10:49:43.000000000","message":"_() and formatting","commit_id":"625d9354af8ebf848e3daa74bd469248eecdb69c"}]}