)]}'
{"trove/guestagent/db/models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"80baafe2431082df7c01b52d29c62e1a8e1894e8","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        return False"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    def _is_valid_host_name(self, value):"},{"line_number":377,"context_line":"        if (value is None) or (\"%\" in value):"},{"line_number":378,"context_line":"            # % is MySQL shorthand for \"everywhere\". Always permitted."},{"line_number":379,"context_line":"            # Null host defaults to % anyway."},{"line_number":380,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FDyw%3D","line":377,"updated":"2014-01-17 20:35:05.000000000","message":"Logic changed, previous value was examined:\n- if its equals to None;\n- if its equals to %.\n\nYou suggested next:\nthis check will pass if value \u003d \"%%%%%\", which is no acceptable value for host.\nIf you want to accept values such as 192.%.100.1, %.168.100.1, 192.169.%.1, 192.168.100.% you need to use multiple regexps for checking if host is valid.","commit_id":"20101529f308cdfafaf721271973aa0e04a298e1"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"689f8aac99155a274b1a40084a6a4e4611d05b39","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        return False"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    def _is_valid_host_name(self, value):"},{"line_number":377,"context_line":"        if (value is None) or (\"%\" in value):"},{"line_number":378,"context_line":"            # % is MySQL shorthand for \"everywhere\". Always permitted."},{"line_number":379,"context_line":"            # Null host defaults to % anyway."},{"line_number":380,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FDkI%3D","line":377,"in_reply_to":"AAAAUH%2F%2FDnM%3D","updated":"2014-01-17 21:21:28.000000000","message":"i went through mysql documentation, there\u0027s no examples of such wildcards, they are used only for hosts.\nSo, i still stand on more precise host validation through regexps.\n\nI\u0027d like to test it with \u0027create\u0027 query and accessing to those database from host which could suits to wildcard %%%","commit_id":"20101529f308cdfafaf721271973aa0e04a298e1"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"c3b81283aa5489458037ba8dbc7fc6886e9fc21c","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        return False"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    def _is_valid_host_name(self, value):"},{"line_number":377,"context_line":"        if (value is None) or (\"%\" in value):"},{"line_number":378,"context_line":"            # % is MySQL shorthand for \"everywhere\". Always permitted."},{"line_number":379,"context_line":"            # Null host defaults to % anyway."},{"line_number":380,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FDnM%3D","line":377,"in_reply_to":"AAAAUH%2F%2FDoE%3D","updated":"2014-01-17 21:09:07.000000000","message":"it could be name also and % means everything for mysql.","commit_id":"20101529f308cdfafaf721271973aa0e04a298e1"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"2e1001cb1e9bd9bf31cca9bf145b1b26f925a94d","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        return False"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    def _is_valid_host_name(self, value):"},{"line_number":377,"context_line":"        if (value is None) or (\"%\" in value):"},{"line_number":378,"context_line":"            # % is MySQL shorthand for \"everywhere\". Always permitted."},{"line_number":379,"context_line":"            # Null host defaults to % anyway."},{"line_number":380,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FDoE%3D","line":377,"in_reply_to":"AAAAUH%2F%2FDqA%3D","updated":"2014-01-17 21:06:21.000000000","message":"%%%% - yes, it\u0027s acceptable, but please define IP address for this wildcard.","commit_id":"20101529f308cdfafaf721271973aa0e04a298e1"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"8c8229cf3116492e5259dbb0feda3a43825d9a21","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        return False"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    def _is_valid_host_name(self, value):"},{"line_number":377,"context_line":"        if (value is None) or (\"%\" in value):"},{"line_number":378,"context_line":"            # % is MySQL shorthand for \"everywhere\". Always permitted."},{"line_number":379,"context_line":"            # Null host defaults to % anyway."},{"line_number":380,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FDqA%3D","line":377,"in_reply_to":"AAAAUH%2F%2FDyw%3D","updated":"2014-01-17 21:01:37.000000000","message":"%%%% is an acceptable value for mysql, I tested that.\n\nI tested that, refer https://gist.github.com/sushilkm/8481430\n\nI have put my observations.","commit_id":"20101529f308cdfafaf721271973aa0e04a298e1"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0ff8a829d60540951ab4532983c941ba9edb889c","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        if (\"%\" in value):"},{"line_number":381,"context_line":"            # % is MySQL shorthand for \"everywhere\". Always permitted."},{"line_number":382,"context_line":"            if re.match(\"^[\\w(-).]*[%]?[\\w(-).]*$\", value):"},{"line_number":383,"context_line":"                # This would match abc.% or %.com, but restrict %% or %.%"},{"line_number":384,"context_line":"                return True"},{"line_number":385,"context_line":"            else:"},{"line_number":386,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FDMc%3D","line":383,"updated":"2014-01-17 22:29:56.000000000","message":"*but restricts\n\nacceptable wildcards: \n%,\nx.x.x.%, \nx.x.%.x, \nx.%.x.x.,\n%x.x.x","commit_id":"f4a641baed2b6066c8caf2f29ac102a85a617f8a"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"02532c0c0bacdbbedbd4f3066997bd65bfdb314d","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        if (\"%\" in value):"},{"line_number":381,"context_line":"            # % is MySQL shorthand for \"everywhere\". Always permitted."},{"line_number":382,"context_line":"            if re.match(\"^[\\w(-).]*[%]?[\\w(-).]*$\", value):"},{"line_number":383,"context_line":"                # This would match abc.% or %.com, but restrict %% or %.%"},{"line_number":384,"context_line":"                return True"},{"line_number":385,"context_line":"            else:"},{"line_number":386,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FCC0%3D","line":383,"in_reply_to":"AAAAUH%2F%2FDCs%3D","updated":"2014-01-18 08:22:02.000000000","message":"So, I think the solution lies in we let the ip checking to as it was done earlier, and check for those hostnames which are not IP.\nI would put that soon.","commit_id":"f4a641baed2b6066c8caf2f29ac102a85a617f8a"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"3510a63793901d76610118e5694703f5b8feb062","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        if (\"%\" in value):"},{"line_number":381,"context_line":"            # % is MySQL shorthand for \"everywhere\". Always permitted."},{"line_number":382,"context_line":"            if re.match(\"^[\\w(-).]*[%]?[\\w(-).]*$\", value):"},{"line_number":383,"context_line":"                # This would match abc.% or %.com, but restrict %% or %.%"},{"line_number":384,"context_line":"                return True"},{"line_number":385,"context_line":"            else:"},{"line_number":386,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FDCs%3D","line":383,"in_reply_to":"AAAAUH%2F%2FDKk%3D","updated":"2014-01-17 23:12:57.000000000","message":"db models file responsice for mysql databases, so hostname could be a IP address too.","commit_id":"f4a641baed2b6066c8caf2f29ac102a85a617f8a"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"4e09013fbf89cab6bf460070dc1ddee3aa62ce8e","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        if (\"%\" in value):"},{"line_number":381,"context_line":"            # % is MySQL shorthand for \"everywhere\". Always permitted."},{"line_number":382,"context_line":"            if re.match(\"^[\\w(-).]*[%]?[\\w(-).]*$\", value):"},{"line_number":383,"context_line":"                # This would match abc.% or %.com, but restrict %% or %.%"},{"line_number":384,"context_line":"                return True"},{"line_number":385,"context_line":"            else:"},{"line_number":386,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FDKk%3D","line":383,"in_reply_to":"AAAAUH%2F%2FDMc%3D","updated":"2014-01-17 22:33:32.000000000","message":"i think u r confusing name with an ip","commit_id":"f4a641baed2b6066c8caf2f29ac102a85a617f8a"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"143610d97a3bd7ed08f307951c21dbd2dd213b66","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        if value is None:"},{"line_number":378,"context_line":"            # Null host defaults to % anyway."},{"line_number":379,"context_line":"            return True"},{"line_number":380,"context_line":"        if \"%\" in value and not(CONF.hostname_require_ipv4):"},{"line_number":381,"context_line":"            # Testing non-ip hostnames for % in name but not consecutives."},{"line_number":382,"context_line":"            if \"%%\" in value:"},{"line_number":383,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BaOA%3D","line":380,"updated":"2014-01-27 08:40:53.000000000","message":"this opens it up for zomg%zomg as a valid hostname now. im not sure thats the case we want.","commit_id":"7538a014c5c380c7e7a8efebb6f1c5cad5228374"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"5ba4b300c318081d8230d3d693080661a9a23dd3","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        if value is None:"},{"line_number":378,"context_line":"            # Null host defaults to % anyway."},{"line_number":379,"context_line":"            return True"},{"line_number":380,"context_line":"        if \"%\" in value and not(CONF.hostname_require_ipv4):"},{"line_number":381,"context_line":"            # Testing non-ip hostnames for % in name but not consecutives."},{"line_number":382,"context_line":"            if \"%%\" in value:"},{"line_number":383,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BaNQ%3D","line":380,"in_reply_to":"AAAAUH%2F%2BaOA%3D","updated":"2014-01-27 08:43:13.000000000","message":"I did not get it,\nIs there anything wrong with abcd%efgh as a hostname\n\nName could be anything.","commit_id":"7538a014c5c380c7e7a8efebb6f1c5cad5228374"}]}
