)]}'
{"trove/conductor/api.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c32019d64bbd81ac4d50394825fd8f21bd788535","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from trove.common import cfg"},{"line_number":17,"context_line":"from trove.openstack.common.rpc import proxy"},{"line_number":18,"context_line":"from trove.openstack.common import log as logging"},{"line_number":19,"context_line":"#from trove.openstack.common import timeutils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2B1V4%3D","line":19,"updated":"2014-01-21 16:11:24.000000000","message":"if its not used should it be removed ?","commit_id":"08088d1bbce83220ddcdb217fb7f22aded2827de"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"a841528b9c69defb180c79a096bd099db33f08fe","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from trove.common import cfg"},{"line_number":17,"context_line":"from trove.openstack.common.rpc import proxy"},{"line_number":18,"context_line":"from trove.openstack.common import log as logging"},{"line_number":19,"context_line":"#from trove.openstack.common import timeutils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2B1E8%3D","line":19,"in_reply_to":"AAAAUH%2F%2B1V4%3D","updated":"2014-01-21 16:54:58.000000000","message":"Yeah, that\u0027s another change I swore I\u0027d already made but got lost in the shuffle. I moved the timestamp generation to the guest agent and thought I\u0027d nailed this.","commit_id":"08088d1bbce83220ddcdb217fb7f22aded2827de"}],"trove/conductor/manager.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ad81cf0233bfc0cea65be177fcda23d431f12d10","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            tenant\u003dCONF.nova_proxy_admin_tenant_name)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _message_too_old(self, sent_at, last_updated):"},{"line_number":39,"context_line":"        LOG.debug(\"Sent at: %s\" % sent_at)"},{"line_number":40,"context_line":"        if sent_at is None:"},{"line_number":41,"context_line":"            LOG.info(\"No sent_at in message payload.\")"},{"line_number":42,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FAa0%3D","line":39,"updated":"2014-01-19 11:42:13.000000000","message":"_()","commit_id":"0cb590e9af40d0a89e197da975e900a5e0e1e4dd"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ad81cf0233bfc0cea65be177fcda23d431f12d10","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def _message_too_old(self, sent_at, last_updated):"},{"line_number":39,"context_line":"        LOG.debug(\"Sent at: %s\" % sent_at)"},{"line_number":40,"context_line":"        if sent_at is None:"},{"line_number":41,"context_line":"            LOG.info(\"No sent_at in message payload.\")"},{"line_number":42,"context_line":"            return False"},{"line_number":43,"context_line":"        last_up \u003d timeutils.strtime(last_updated)"},{"line_number":44,"context_line":"        LOG.debug(\"Last updated: %s\" % last_up)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FAaw%3D","line":41,"updated":"2014-01-19 11:42:13.000000000","message":"_()","commit_id":"0cb590e9af40d0a89e197da975e900a5e0e1e4dd"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ad81cf0233bfc0cea65be177fcda23d431f12d10","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            LOG.info(\"No sent_at in message payload.\")"},{"line_number":42,"context_line":"            return False"},{"line_number":43,"context_line":"        last_up \u003d timeutils.strtime(last_updated)"},{"line_number":44,"context_line":"        LOG.debug(\"Last updated: %s\" % last_up)"},{"line_number":45,"context_line":"        if sent_at \u003c last_up:"},{"line_number":46,"context_line":"            LOG.info(\"Rec\u0027d old message. Discarding.\")"},{"line_number":47,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FAao%3D","line":44,"updated":"2014-01-19 11:42:13.000000000","message":"_()","commit_id":"0cb590e9af40d0a89e197da975e900a5e0e1e4dd"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ad81cf0233bfc0cea65be177fcda23d431f12d10","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        last_up \u003d timeutils.strtime(last_updated)"},{"line_number":44,"context_line":"        LOG.debug(\"Last updated: %s\" % last_up)"},{"line_number":45,"context_line":"        if sent_at \u003c last_up:"},{"line_number":46,"context_line":"            LOG.info(\"Rec\u0027d old message. Discarding.\")"},{"line_number":47,"context_line":"            return True"},{"line_number":48,"context_line":"        return False"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FAak%3D","line":46,"updated":"2014-01-19 11:42:13.000000000","message":"_()","commit_id":"0cb590e9af40d0a89e197da975e900a5e0e1e4dd"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c32019d64bbd81ac4d50394825fd8f21bd788535","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                    \u0027key\u0027: k,"},{"line_number":95,"context_line":"                    \u0027value\u0027: v,"},{"line_number":96,"context_line":"                }"},{"line_number":97,"context_line":"                LOG.debug(_(\"Backup %(key)s: %(value)s\") % fields)"},{"line_number":98,"context_line":"                setattr(backup, k, v)"},{"line_number":99,"context_line":"        backup.save()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2B1Yg%3D","line":97,"updated":"2014-01-21 16:11:24.000000000","message":"would it be better not to define \"fields\" and use dicr explicitly ?","commit_id":"08088d1bbce83220ddcdb217fb7f22aded2827de"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"a841528b9c69defb180c79a096bd099db33f08fe","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                    \u0027key\u0027: k,"},{"line_number":95,"context_line":"                    \u0027value\u0027: v,"},{"line_number":96,"context_line":"                }"},{"line_number":97,"context_line":"                LOG.debug(_(\"Backup %(key)s: %(value)s\") % fields)"},{"line_number":98,"context_line":"                setattr(backup, k, v)"},{"line_number":99,"context_line":"        backup.save()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2B1Fw%3D","line":97,"in_reply_to":"AAAAUH%2F%2B1Yg%3D","updated":"2014-01-21 16:54:58.000000000","message":"There\u0027s a HACKING that was crying every time I used a format string with two hole in it, so I just used the long form so the tox pep8 environment would be happy. It\u0027s just a debug statement, anyway.","commit_id":"08088d1bbce83220ddcdb217fb7f22aded2827de"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"899cf789754d5208463315a15adc75c24bc97d9d","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            LOG.error(_(\"Rec\u0027d message is older than last seen. Discarding.\"))"},{"line_number":80,"context_line":"            seen.sent \u003d sent"},{"line_number":81,"context_line":"            seen.save()"},{"line_number":82,"context_line":"            return True"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F9tlg%3D","line":80,"updated":"2014-02-04 18:51:41.000000000","message":"Wait a second","commit_id":"920082d934fdae5296493d1c2c1851f9c357e4c4"}],"trove/db/sqlalchemy/migrate_repo/schema.py":[{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"011f2d51ee61fc5b2410d0ff78bc18d0d578ac94","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class Float(sqlalchemy.types.Float):"},{"line_number":63,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":64,"context_line":"        super(Float, self).__init__(*args, **kwargs)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def create_tables(tables):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F9tt4%3D","line":64,"updated":"2014-02-04 18:36:19.000000000","message":"Oh man... why did we ever do it the other way?\n\n*brain melts*","commit_id":"920082d934fdae5296493d1c2c1851f9c357e4c4"}],"trove/db/sqlalchemy/migrate_repo/versions/020_conductor_lastseen.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"f788e99a299748eb6b63cb05662c3ab550d2714e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"meta \u003d MetaData()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"conductor_lastseen \u003d Table("},{"line_number":27,"context_line":"    \u0027conductor_lastseen\u0027,"},{"line_number":28,"context_line":"    meta,"},{"line_number":29,"context_line":"    Column(\u0027instance_id\u0027, String(36), primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":30,"context_line":"    Column(\u0027method_name\u0027, String(36), primary_key\u003dTrue, nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F9sCU%3D","line":27,"updated":"2014-02-04 23:53:41.000000000","message":"this is being a bit picky, but shouldn\u0027t it be conductor_last_seen?\n\ncan you explain the naming of \"method_name\"?\n\ncan you explain why a float vs. a true date-typed column?","commit_id":"46021ed4d771e7064aabdd52d515196fd99d1b98"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"552d75081fda409ae247f3d685a85096dbf256ca","unresolved":false,"context_lines":[{"line_number":24,"context_line":"meta \u003d MetaData()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"conductor_lastseen \u003d Table("},{"line_number":27,"context_line":"    \u0027conductor_lastseen\u0027,"},{"line_number":28,"context_line":"    meta,"},{"line_number":29,"context_line":"    Column(\u0027instance_id\u0027, String(36), primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":30,"context_line":"    Column(\u0027method_name\u0027, String(36), primary_key\u003dTrue, nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F9n6c%3D","line":27,"in_reply_to":"AAAAUH%2F9sCU%3D","updated":"2014-02-05 15:37:43.000000000","message":"I figured it would take less time to just pick a name, roll with it, and possibly change it later, than to discuss the name before I did anything else.\n\nSame story with method_name, it\u0027s simply the name of the method, and I wasn\u0027t in the mood to dwell on the name.\n\nFor floats, I think it was Baz\u0027 idea mainly, but I want to guarantee subsecond values as a tie-breaker between messages that happen in the same second. In testing just yesterday I saw these changes throw out messages because they were a hundredth of a second out of phase. They\u0027re also easier to compare straight up, and don\u0027t bear a timezone to have to figure out. I also work on another guest agent implementation, and using DateTimes is possible, but I figured the floats would be the most portable.\n\nI have no problem changing any of this as is, but the only argument I have for things the way they are is that they\u0027ve been proven to work exactly as designed to solve the problem at hand.\n\nTo the point of backwards compatibility, messages that don\u0027t bear a \"sent\" field are exempt from this inspection altogether.","commit_id":"46021ed4d771e7064aabdd52d515196fd99d1b98"}],"trove/tests/unittests/conductor/test_methods.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ad81cf0233bfc0cea65be177fcda23d431f12d10","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                                 datetime.timedelta(seconds\u003dseconds))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def test_heartbeat_newer_timestamp_accepted(self):"},{"line_number":155,"context_line":"        payload \u003d {\u0027service_status\u0027: \u0027building\u0027}"},{"line_number":156,"context_line":"        iss_id \u003d self._create_iss()"},{"line_number":157,"context_line":"        iss \u003d self._get_iss(iss_id)"},{"line_number":158,"context_line":"        future \u003d self._add_time(iss.updated_at, 60)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FAaU%3D","line":155,"updated":"2014-01-19 11:42:13.000000000","message":"payload \u003d {\u0027service_status\u0027: t_instance.ServiceStatuses.BUILDING.description}","commit_id":"0cb590e9af40d0a89e197da975e900a5e0e1e4dd"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ad81cf0233bfc0cea65be177fcda23d431f12d10","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        self.assertEqual(t_instance.ServiceStatuses.BUILDING, iss.status)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def test_heartbeat_older_timestamp_discarded(self):"},{"line_number":165,"context_line":"        payload \u003d {\u0027service_status\u0027: \u0027building\u0027}"},{"line_number":166,"context_line":"        iss_id \u003d self._create_iss()"},{"line_number":167,"context_line":"        iss \u003d self._get_iss(iss_id)"},{"line_number":168,"context_line":"        past \u003d self._add_time(iss.updated_at, -60)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FAaM%3D","line":165,"updated":"2014-01-19 11:42:13.000000000","message":"payload \u003d {\u0027service_status\u0027: t_instance.ServiceStatuses.BUILDING.description}","commit_id":"0cb590e9af40d0a89e197da975e900a5e0e1e4dd"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c32019d64bbd81ac4d50394825fd8f21bd788535","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                                 datetime.timedelta(seconds\u003dseconds))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def test_heartbeat_newer_timestamp_accepted(self):"},{"line_number":155,"context_line":"        payload \u003d {\u0027service_status\u0027: \u0027building\u0027}"},{"line_number":156,"context_line":"        iss_id \u003d self._create_iss()"},{"line_number":157,"context_line":"        iss \u003d self._get_iss(iss_id)"},{"line_number":158,"context_line":"        future \u003d self._add_time(iss.updated_at, 60)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2B1X4%3D","line":155,"updated":"2014-01-21 16:11:24.000000000","message":"payload \u003d {\u0027service_status\u0027: t_instance.ServiceStatuses.BUILDING.description} would be more preferable","commit_id":"08088d1bbce83220ddcdb217fb7f22aded2827de"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"a841528b9c69defb180c79a096bd099db33f08fe","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                                 datetime.timedelta(seconds\u003dseconds))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def test_heartbeat_newer_timestamp_accepted(self):"},{"line_number":155,"context_line":"        payload \u003d {\u0027service_status\u0027: \u0027building\u0027}"},{"line_number":156,"context_line":"        iss_id \u003d self._create_iss()"},{"line_number":157,"context_line":"        iss \u003d self._get_iss(iss_id)"},{"line_number":158,"context_line":"        future \u003d self._add_time(iss.updated_at, 60)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2B1GU%3D","line":155,"in_reply_to":"AAAAUH%2F%2B1X4%3D","updated":"2014-01-21 16:54:58.000000000","message":"You know, I swear I made that change, but I did notice vim kept complaining that someone else had written to my files when I tried to :w them myself.","commit_id":"08088d1bbce83220ddcdb217fb7f22aded2827de"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c32019d64bbd81ac4d50394825fd8f21bd788535","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        self.assertEqual(t_instance.ServiceStatuses.BUILDING, iss.status)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def test_heartbeat_older_timestamp_discarded(self):"},{"line_number":165,"context_line":"        payload \u003d {\u0027service_status\u0027: \u0027building\u0027}"},{"line_number":166,"context_line":"        iss_id \u003d self._create_iss()"},{"line_number":167,"context_line":"        iss \u003d self._get_iss(iss_id)"},{"line_number":168,"context_line":"        past \u003d self._add_time(iss.updated_at, -60)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2B1X0%3D","line":165,"updated":"2014-01-21 16:11:24.000000000","message":"payload \u003d {\u0027service_status\u0027: t_instance.ServiceStatuses.BUILDING.description} would be more preferable","commit_id":"08088d1bbce83220ddcdb217fb7f22aded2827de"}]}
