)]}'
{"trove/guestagent/datastore/mysql/manager.py":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"3a531a03401bc93164505760ec1c5bcdb586f0b3","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            e \u003d sys.exc_info()"},{"line_number":155,"context_line":"            LOG.error(\"Prepare call failed to execute: %s\" %"},{"line_number":156,"context_line":"                      (\" \".join([str(each)for each in e])))"},{"line_number":157,"context_line":"            VerticaAppStatus.get().set_status(rd_instance."},{"line_number":158,"context_line":"                                              ServiceStatuses.FAILED)"},{"line_number":159,"context_line":"            raise RuntimeError(\"Prepare call failed to execute\")"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2BhlU%3D","line":157,"updated":"2014-01-24 18:49:09.000000000","message":"VerticaAppStatus?","commit_id":"72e79f1db1df5bbbf6c86f17e89274412cc83a86"},{"author":{"_account_id":8309,"name":"Pradeep Kumar Chandani","email":"chandani.pradeep@gmail.com","username":"pradeepchandani"},"change_message_id":"b329f30af6b2d18a879104104ebbb0d5e9fd6a77","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            e \u003d sys.exc_info()"},{"line_number":155,"context_line":"            LOG.error(\"Prepare call failed to execute: %s\" %"},{"line_number":156,"context_line":"                      (\" \".join([str(each)for each in e])))"},{"line_number":157,"context_line":"            VerticaAppStatus.get().set_status(rd_instance."},{"line_number":158,"context_line":"                                              ServiceStatuses.FAILED)"},{"line_number":159,"context_line":"            raise RuntimeError(\"Prepare call failed to execute\")"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2BhW4%3D","line":157,"in_reply_to":"AAAAUH%2F%2BhlU%3D","updated":"2014-01-24 19:51:27.000000000","message":"It was by mistake, corrected in next patch.","commit_id":"72e79f1db1df5bbbf6c86f17e89274412cc83a86"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"5c96e2f00682f7b1adafeef606f82599f6785453","unresolved":false,"context_lines":[{"line_number":151,"context_line":"            LOG.info(\u0027\"prepare\" call has finished.\u0027)"},{"line_number":152,"context_line":"        except Exception:"},{"line_number":153,"context_line":"            e \u003d sys.exc_info()"},{"line_number":154,"context_line":"            LOG.error(\"Prepare call failed to execute: %s\" %"},{"line_number":155,"context_line":"                      (\" \".join([str(each)for each in e])))"},{"line_number":156,"context_line":"            MySqlAppStatus.get().set_status(rd_instance."},{"line_number":157,"context_line":"                                            ServiceStatuses.FAILED)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F9d0o%3D","line":154,"updated":"2014-04-04 10:25:40.000000000","message":"translation is required","commit_id":"3c0b1e05b950f686ed168f7b8044ba6351395dc7"},{"author":{"_account_id":8309,"name":"Pradeep Kumar Chandani","email":"chandani.pradeep@gmail.com","username":"pradeepchandani"},"change_message_id":"5be389c9aa7b55809612d696b19defe4de511f34","unresolved":false,"context_lines":[{"line_number":151,"context_line":"            LOG.info(\u0027\"prepare\" call has finished.\u0027)"},{"line_number":152,"context_line":"        except Exception:"},{"line_number":153,"context_line":"            e \u003d sys.exc_info()"},{"line_number":154,"context_line":"            LOG.error(\"Prepare call failed to execute: %s\" %"},{"line_number":155,"context_line":"                      (\" \".join([str(each)for each in e])))"},{"line_number":156,"context_line":"            MySqlAppStatus.get().set_status(rd_instance."},{"line_number":157,"context_line":"                                            ServiceStatuses.FAILED)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F9dRI%3D","line":154,"in_reply_to":"AAAAWH%2F9d0o%3D","updated":"2014-04-04 11:42:58.000000000","message":"I am not doing translation related fixes here..its irrelevant for this patch.","commit_id":"3c0b1e05b950f686ed168f7b8044ba6351395dc7"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"edababfb727748a21caaa9e49481c5863215dd0b","unresolved":false,"context_lines":[{"line_number":151,"context_line":"            LOG.info(\u0027\"prepare\" call has finished.\u0027)"},{"line_number":152,"context_line":"        except Exception:"},{"line_number":153,"context_line":"            e \u003d sys.exc_info()"},{"line_number":154,"context_line":"            LOG.error(\"Prepare call failed to execute: %s\" %"},{"line_number":155,"context_line":"                      (\" \".join([str(each)for each in e])))"},{"line_number":156,"context_line":"            MySqlAppStatus.get().set_status(rd_instance."},{"line_number":157,"context_line":"                                            ServiceStatuses.FAILED)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F9dK8%3D","line":154,"in_reply_to":"AAAAWH%2F9dLw%3D","updated":"2014-04-04 11:56:43.000000000","message":"You adding logging call, you should do the localization!\n\nLOG.error(_(\"Prepare call failed to execute: %s\") % (\" \".join([str(each)for each in e])))\n\nyou should do it, noone other it\u0027s your patch, its your new code.\n\nEven more, it should be:\n\nexcept Exception as e:\n     LOG.error(e)","commit_id":"3c0b1e05b950f686ed168f7b8044ba6351395dc7"},{"author":{"_account_id":8309,"name":"Pradeep Kumar Chandani","email":"chandani.pradeep@gmail.com","username":"pradeepchandani"},"change_message_id":"ddf1e5c69eddef36a24505ae0843250a036bf963","unresolved":false,"context_lines":[{"line_number":151,"context_line":"            LOG.info(\u0027\"prepare\" call has finished.\u0027)"},{"line_number":152,"context_line":"        except Exception:"},{"line_number":153,"context_line":"            e \u003d sys.exc_info()"},{"line_number":154,"context_line":"            LOG.error(\"Prepare call failed to execute: %s\" %"},{"line_number":155,"context_line":"                      (\" \".join([str(each)for each in e])))"},{"line_number":156,"context_line":"            MySqlAppStatus.get().set_status(rd_instance."},{"line_number":157,"context_line":"                                            ServiceStatuses.FAILED)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F9dLw%3D","line":154,"in_reply_to":"AAAAWH%2F9dP8%3D","updated":"2014-04-04 11:53:53.000000000","message":"Someone who will fix translation for other logs will fix this..I am keeping things uniform.","commit_id":"3c0b1e05b950f686ed168f7b8044ba6351395dc7"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"206e4b875746d4d85df496bb344dc65344e6d79a","unresolved":false,"context_lines":[{"line_number":151,"context_line":"            LOG.info(\u0027\"prepare\" call has finished.\u0027)"},{"line_number":152,"context_line":"        except Exception:"},{"line_number":153,"context_line":"            e \u003d sys.exc_info()"},{"line_number":154,"context_line":"            LOG.error(\"Prepare call failed to execute: %s\" %"},{"line_number":155,"context_line":"                      (\" \".join([str(each)for each in e])))"},{"line_number":156,"context_line":"            MySqlAppStatus.get().set_status(rd_instance."},{"line_number":157,"context_line":"                                            ServiceStatuses.FAILED)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F9dP8%3D","line":154,"in_reply_to":"AAAAWH%2F9dRI%3D","updated":"2014-04-04 11:44:56.000000000","message":"You are actually adding new logging call, and passing string into it, it must be wrapped into the localization!","commit_id":"3c0b1e05b950f686ed168f7b8044ba6351395dc7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"9fd40b854f3d77c3bcc2110573ff0b0a98eadbe0","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            if users:"},{"line_number":150,"context_line":"                self.create_user(context, users)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"            LOG.info(\u0027\"prepare\" call has finished.\u0027)"},{"line_number":153,"context_line":"        except Exception as e:"},{"line_number":154,"context_line":"            LOG.error(e)"},{"line_number":155,"context_line":"            MySqlAppStatus.get().set_status(rd_instance."}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_373d4cdf","line":152,"updated":"2014-06-02 16:55:50.000000000","message":"need to localize this message.","commit_id":"c6cbfe874d30b41da160eb27970b428e377a4541"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"9fd40b854f3d77c3bcc2110573ff0b0a98eadbe0","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            LOG.error(e)"},{"line_number":155,"context_line":"            MySqlAppStatus.get().set_status(rd_instance."},{"line_number":156,"context_line":"                                            ServiceStatuses.FAILED)"},{"line_number":157,"context_line":"            raise RuntimeError(\"Prepare call failed to execute\")"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def restart(self, context):"},{"line_number":160,"context_line":"        app \u003d MySqlApp(MySqlAppStatus.get())"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_57401856","line":157,"updated":"2014-06-02 16:55:50.000000000","message":"need to localize this message.","commit_id":"c6cbfe874d30b41da160eb27970b428e377a4541"}]}