)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b40d7fdbf93a04585beee56dc6dd2e2f573ed69c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sushil Kumar \u003csushil.kumar2@globallogic.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-21 16:40:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Corrects spelling typos"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reasons:"},{"line_number":10,"context_line":"- There are few spelling typos in code-base."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAXH%2F%2FQ6E%3D","line":7,"updated":"2014-04-22 22:23:54.000000000","message":"all spelling errors are typos, not all typos are spelling errors. but this is a tautology ;)","commit_id":"65b639f2f0af5f505859ebbc45c2e9afe3d36297"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b40d7fdbf93a04585beee56dc6dd2e2f573ed69c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Corrects spelling typos"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reasons:"},{"line_number":10,"context_line":"- There are few spelling typos in code-base."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Changes:"},{"line_number":13,"context_line":"- Corrected spelling-mistakes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAXH%2F%2FQ6A%3D","line":10,"updated":"2014-04-22 22:23:54.000000000","message":"code base isn\u0027t hyphenated, just mentioning this because this bug fix is about typos ;)","commit_id":"65b639f2f0af5f505859ebbc45c2e9afe3d36297"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b40d7fdbf93a04585beee56dc6dd2e2f573ed69c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- There are few spelling typos in code-base."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Changes:"},{"line_number":13,"context_line":"- Corrected spelling-mistakes."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"No bug raised, since no functionality is touched in the patchset."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAXH%2F%2FQ54%3D","line":13,"updated":"2014-04-22 22:23:54.000000000","message":"nor is spelling mistakes ...","commit_id":"65b639f2f0af5f505859ebbc45c2e9afe3d36297"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b40d7fdbf93a04585beee56dc6dd2e2f573ed69c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Changes:"},{"line_number":13,"context_line":"- Corrected spelling-mistakes."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"No bug raised, since no functionality is touched in the patchset."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I892283b8f42af04b36dc8220a7bb97d12b8fb3f8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAXH%2F%2FQ5w%3D","line":15,"updated":"2014-04-22 22:23:54.000000000","message":"this is not true, there is in fact some new code which I question.","commit_id":"65b639f2f0af5f505859ebbc45c2e9afe3d36297"}],"trove/common/debug_utils.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f1e211d80b2b2ccfb69421389992f18869d3d796","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    enable debugging of new threads"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @param pydev_debug_host: remote debug server host name, \u0027localhost\u0027"},{"line_number":116,"context_line":"        if not specified or None"},{"line_number":117,"context_line":"    @param pydev_debug_port: remote debug server port, 5678"},{"line_number":118,"context_line":"        if not specified or None"},{"line_number":119,"context_line":"    @param pydev_path: optional path to pydevd library, used it pydevd is not"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FRDE%3D","line":116,"updated":"2014-04-22 22:21:08.000000000","message":"should that be *is* not specified?","commit_id":"65b639f2f0af5f505859ebbc45c2e9afe3d36297"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f1e211d80b2b2ccfb69421389992f18869d3d796","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    @param pydev_debug_host: remote debug server host name, \u0027localhost\u0027"},{"line_number":116,"context_line":"        if not specified or None"},{"line_number":117,"context_line":"    @param pydev_debug_port: remote debug server port, 5678"},{"line_number":118,"context_line":"        if not specified or None"},{"line_number":119,"context_line":"    @param pydev_path: optional path to pydevd library, used it pydevd is not"},{"line_number":120,"context_line":"        found in python sys.path"},{"line_number":121,"context_line":"    @return: True if debugging initialized,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FRC0%3D","line":118,"updated":"2014-04-22 22:21:08.000000000","message":"should that be *is* not specified","commit_id":"65b639f2f0af5f505859ebbc45c2e9afe3d36297"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"db2e0515cd6723a04efd8042de301b75363ff9f6","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        if not specified or None"},{"line_number":117,"context_line":"    @param pydev_debug_port: remote debug server port, 5678"},{"line_number":118,"context_line":"        if not specified or None"},{"line_number":119,"context_line":"    @param pydev_path: optional path to pydevd library, used it pydevd is not"},{"line_number":120,"context_line":"        found in python sys.path"},{"line_number":121,"context_line":"    @return: True if debugging initialized,"},{"line_number":122,"context_line":"        otherwise exception should be raised"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FSwQ%3D","line":119,"updated":"2014-04-22 18:00:51.000000000","message":"Should be - used *if* pydevd is not","commit_id":"65b639f2f0af5f505859ebbc45c2e9afe3d36297"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"db2e0515cd6723a04efd8042de301b75363ff9f6","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        import pydevd"},{"line_number":129,"context_line":"        LOG.debug(\"pydevd module was imported from system path\")"},{"line_number":130,"context_line":"    except ImportError:"},{"line_number":131,"context_line":"        LOG.debug(\"Cannot load pydevd module from system path. Try load it \""},{"line_number":132,"context_line":"                  \"from pydev_path: %s\", pydev_path)"},{"line_number":133,"context_line":"        assert pydev_path, \"pydev_path is not set\""},{"line_number":134,"context_line":"        if pydev_path not in sys.path:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FSw4%3D","line":131,"updated":"2014-04-22 18:00:51.000000000","message":"Should be - Try *loading* it","commit_id":"65b639f2f0af5f505859ebbc45c2e9afe3d36297"}],"trove/dns/designate/driver.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f1e211d80b2b2ccfb69421389992f18869d3d796","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                for record in records if record.name \u003d\u003d name]"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def get_dns_zones(self, name\u003dNone):"},{"line_number":117,"context_line":"        \"\"\"Returns all dns zones (optionally filtered by the name argument.\"\"\""},{"line_number":118,"context_line":"        domains \u003d self.dns_client.domains.list()"},{"line_number":119,"context_line":"        return [self.converter.domain_to_zone(domain)"},{"line_number":120,"context_line":"                for domain in domains if not name or domain.name \u003d\u003d name]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FRCc%3D","line":117,"updated":"2014-04-22 22:21:08.000000000","message":"missing a closing paren ;)","commit_id":"65b639f2f0af5f505859ebbc45c2e9afe3d36297"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f1e211d80b2b2ccfb69421389992f18869d3d796","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    def _get_records(self, dns_zone):"},{"line_number":131,"context_line":"        dns_zone \u003d dns_zone or self.default_dns_zone"},{"line_number":132,"context_line":"        if not dns_zone:"},{"line_number":133,"context_line":"            raise TypeError(\u0027DNS domain is must be specified\u0027)"},{"line_number":134,"context_line":"        return self.dns_client.records.list(dns_zone.id)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FRCU%3D","line":133,"updated":"2014-04-22 22:21:08.000000000","message":"*is must* ?","commit_id":"65b639f2f0af5f505859ebbc45c2e9afe3d36297"}],"trove/guestagent/datastore/redis/manager.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f1e211d80b2b2ccfb69421389992f18869d3d796","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def change_passwords(self, context, users):"},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        Changes the redis instance password,"},{"line_number":49,"context_line":"        it is currently not not implemented."},{"line_number":50,"context_line":"        \"\"\""},{"line_number":51,"context_line":"        raise exception.DatastoreOperationNotSupported("},{"line_number":52,"context_line":"            operation\u003d\u0027change_passwords\u0027, datastore\u003dMANAGER)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FRB8%3D","line":49,"updated":"2014-04-22 22:21:08.000000000","message":"*not not* implemented? i.e it is implemented?","commit_id":"65b639f2f0af5f505859ebbc45c2e9afe3d36297"}],"trove/guestagent/strategies/restore/mysql_impl.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f1e211d80b2b2ccfb69421389992f18869d3d796","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                       \" checksum: %(parent_checksum)s\") % metadata)"},{"line_number":207,"context_line":"            parent_location \u003d metadata[\u0027parent_location\u0027]"},{"line_number":208,"context_line":"            parent_checksum \u003d metadata[\u0027parent_checksum\u0027]"},{"line_number":209,"context_line":"            # Restore parents recursively so backup are applied sequentially"},{"line_number":210,"context_line":"            self._incremental_restore(parent_location, parent_checksum)"},{"line_number":211,"context_line":"            # for *this* backup set the incremental_dir"},{"line_number":212,"context_line":"            # just use the checksum for the incremental path as it is"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FQ9E%3D","line":209,"updated":"2014-04-22 22:21:08.000000000","message":"backup is .... or backups are.","commit_id":"65b639f2f0af5f505859ebbc45c2e9afe3d36297"}],"trove/instance/models.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"db2e0515cd6723a04efd8042de301b75363ff9f6","unresolved":false,"context_lines":[{"line_number":791,"context_line":""},{"line_number":792,"context_line":"    def reset_task_status(self):"},{"line_number":793,"context_line":"        LOG.info(\"Setting task status to NONE on instance %s...\" % self.id)"},{"line_number":794,"context_line":"        self.update_db(task_status\u003dInstanceTasks.NONE)"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"    def validate_can_perform_action(self):"},{"line_number":797,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FStQ%3D","line":794,"updated":"2014-04-22 18:00:51.000000000","message":"This doesn\u0027t look like a typo fix - should this be in a different patch?","commit_id":"65b639f2f0af5f505859ebbc45c2e9afe3d36297"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f1e211d80b2b2ccfb69421389992f18869d3d796","unresolved":false,"context_lines":[{"line_number":791,"context_line":""},{"line_number":792,"context_line":"    def reset_task_status(self):"},{"line_number":793,"context_line":"        LOG.info(\"Setting task status to NONE on instance %s...\" % self.id)"},{"line_number":794,"context_line":"        self.update_db(task_status\u003dInstanceTasks.NONE)"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"    def validate_can_perform_action(self):"},{"line_number":797,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FQ8w%3D","line":794,"updated":"2014-04-22 22:21:08.000000000","message":"ditto","commit_id":"65b639f2f0af5f505859ebbc45c2e9afe3d36297"}],"trove/instance/service.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"31e347e3b592c1db074e80a308737e5e5bdb3871","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        :param id: ???"},{"line_number":73,"context_line":"        \"\"\""},{"line_number":74,"context_line":"        LOG.info(\"req : \u0027%s\u0027\\n\\n\" % req)"},{"line_number":75,"context_line":"        LOG.info(\"Committing an ACTION again instance %s for tenant \u0027%s\u0027\""},{"line_number":76,"context_line":"                 % (id, tenant_id))"},{"line_number":77,"context_line":"        if not body:"},{"line_number":78,"context_line":"            raise exception.BadRequest(_(\"Invalid request body.\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2FvVo%3D","line":75,"updated":"2014-04-28 10:48:30.000000000","message":"this should be \u0027against\u0027 not \u0027again\u0027.","commit_id":"bcb797315dd12d17b54813b80fd5750a1820b380"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"8f2b33cda4b4c727bf4ff7c874f2bf5a9f9792e8","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        :param id: ???"},{"line_number":73,"context_line":"        \"\"\""},{"line_number":74,"context_line":"        LOG.info(\"req : \u0027%s\u0027\\n\\n\" % req)"},{"line_number":75,"context_line":"        LOG.info(\"Committing an ACTION again instance %s for tenant \u0027%s\u0027\""},{"line_number":76,"context_line":"                 % (id, tenant_id))"},{"line_number":77,"context_line":"        if not body:"},{"line_number":78,"context_line":"            raise exception.BadRequest(_(\"Invalid request body.\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2FvSU%3D","line":75,"in_reply_to":"AAAAXX%2F%2FvVo%3D","updated":"2014-04-28 10:56:00.000000000","message":"i would take your feedback","commit_id":"bcb797315dd12d17b54813b80fd5750a1820b380"}],"trove/templates/mysql/config.template":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f1e211d80b2b2ccfb69421389992f18869d3d796","unresolved":false,"context_lines":[{"line_number":9,"context_line":"port \u003d 3306"},{"line_number":10,"context_line":"basedir \u003d /usr"},{"line_number":11,"context_line":"datadir \u003d /var/lib/mysql"},{"line_number":12,"context_line":"tmpdir \u003d /var/tmp"},{"line_number":13,"context_line":"pid_file \u003d /var/run/mysqld/mysqld.pid"},{"line_number":14,"context_line":"skip-external-locking \u003d 1"},{"line_number":15,"context_line":"key_buffer_size \u003d {{ 50 * flavor[\u0027ram\u0027]//512 }}M"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAXH%2F%2FQ8Y%3D","line":12,"updated":"2014-04-22 22:21:08.000000000","message":"seems like an innocuous change, but why?","commit_id":"65b639f2f0af5f505859ebbc45c2e9afe3d36297"}],"trove/tests/api/instances_actions.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f1e211d80b2b2ccfb69421389992f18869d3d796","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        poll_until(is_finished_rebooting, time_out\u003dTIME_OUT_TIME)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def unsuccessful_restart(self):"},{"line_number":268,"context_line":"        \"\"\"Restart MySQL via the REST when it should fail, assert it does.\"\"\""},{"line_number":269,"context_line":"        assert not FAKE_MODE"},{"line_number":270,"context_line":"        self.mess_up_mysql()"},{"line_number":271,"context_line":"        self.call_reboot()"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FQ8E%3D","line":268,"updated":"2014-04-22 22:21:08.000000000","message":"What\u0027s this? We\u0027re speaking like yoda now?","commit_id":"65b639f2f0af5f505859ebbc45c2e9afe3d36297"}],"trove/tests/unittests/mgmt/test_models.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"db2e0515cd6723a04efd8042de301b75363ff9f6","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class TestNotificationTransformer(MockMgmtInstanceTest):"},{"line_number":75,"context_line":"    def test_transformer(self):"},{"line_number":76,"context_line":"        transformer \u003d mgmtmodels.NotificationTransformer(context\u003dself.context)"},{"line_number":77,"context_line":"        status \u003d rd_instance.ServiceStatuses.BUILDING.api_status"},{"line_number":78,"context_line":"        db_instance \u003d MockMgmtInstanceTest.build_db_instance("}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FSpM%3D","line":75,"updated":"2014-04-22 18:00:51.000000000","message":"Blank line should probably be before the \u0027def,\u0027 not after","commit_id":"65b639f2f0af5f505859ebbc45c2e9afe3d36297"}],"trove/tests/util/__init__.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"db2e0515cd6723a04efd8042de301b75363ff9f6","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"def iso_time(time_string):"},{"line_number":217,"context_line":"    \"\"\"Return a iso formatted datetime: 2013-04-15T19:50:23Z\"\"\""},{"line_number":218,"context_line":"    ts \u003d time_string.replace(\u0027 \u0027, \u0027T\u0027)"},{"line_number":219,"context_line":"    try:"},{"line_number":220,"context_line":"        micro \u003d ts.rindex(\u0027.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FSuY%3D","line":217,"updated":"2014-04-22 18:00:51.000000000","message":"Should be - Return *an* iso formatted","commit_id":"65b639f2f0af5f505859ebbc45c2e9afe3d36297"}]}