)]}'
{"trove/dns/designate/driver.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"1ae659c603edf4954d252964750f325f5f594768","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Record name has to end with a \u0027.\u0027 by dns standard"},{"line_number":87,"context_line":"        record \u003d Record(name\u003dentry.name + \u0027.\u0027,"},{"line_number":88,"context_line":"                        type\u003dentry.type,"},{"line_number":89,"context_line":"                        data\u003dlambda: content,"},{"line_number":90,"context_line":"                        ttl\u003dentry.ttl,"},{"line_number":91,"context_line":"                        priority\u003dentry.priority)"},{"line_number":92,"context_line":"        client.records.create(dns_zone.id, record)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BVkk%3D","line":89,"updated":"2014-01-27 22:25:45.000000000","message":"Just wondering why you are passing a function instead of the content? Designate record-creation expects an IP (as string) in the \u0027data\u0027 param.\n\nhttp://designate.readthedocs.org/en/latest/rest/records.html#create-record","commit_id":"7bdeb116dfa39290911493b10e81f7aa6c5a94e0"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"efa1a613b5784ddf1f84ac22ad897f3d279aad0b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Record name has to end with a \u0027.\u0027 by dns standard"},{"line_number":87,"context_line":"        record \u003d Record(name\u003dentry.name + \u0027.\u0027,"},{"line_number":88,"context_line":"                        type\u003dentry.type,"},{"line_number":89,"context_line":"                        data\u003dlambda: content,"},{"line_number":90,"context_line":"                        ttl\u003dentry.ttl,"},{"line_number":91,"context_line":"                        priority\u003dentry.priority)"},{"line_number":92,"context_line":"        client.records.create(dns_zone.id, record)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BVgY%3D","line":89,"updated":"2014-01-27 22:24:31.000000000","message":"Shouldn\u0027t this be just the content, assuming content \u003d a string such as an IP Address?","commit_id":"7bdeb116dfa39290911493b10e81f7aa6c5a94e0"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"8417c14e76cb01affdee11b80b21097215c580b3","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Record name has to end with a \u0027.\u0027 by dns standard"},{"line_number":87,"context_line":"        record \u003d Record(name\u003dentry.name + \u0027.\u0027,"},{"line_number":88,"context_line":"                        type\u003dentry.type,"},{"line_number":89,"context_line":"                        data\u003dlambda: content,"},{"line_number":90,"context_line":"                        ttl\u003dentry.ttl,"},{"line_number":91,"context_line":"                        priority\u003dentry.priority)"},{"line_number":92,"context_line":"        client.records.create(dns_zone.id, record)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BVfw%3D","line":89,"in_reply_to":"AAAAUH%2F%2BVgY%3D","updated":"2014-01-27 22:29:17.000000000","message":"Vipul, from the review, content is a string object of the IP to be used in the record","commit_id":"7bdeb116dfa39290911493b10e81f7aa6c5a94e0"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"0b6393b9e8798a48fad4ecb2f4c382e34acb0d2d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Record name has to end with a \u0027.\u0027 by dns standard"},{"line_number":87,"context_line":"        record \u003d Record(name\u003dentry.name + \u0027.\u0027,"},{"line_number":88,"context_line":"                        type\u003dentry.type,"},{"line_number":89,"context_line":"                        data\u003dlambda: content,"},{"line_number":90,"context_line":"                        ttl\u003dentry.ttl,"},{"line_number":91,"context_line":"                        priority\u003dentry.priority)"},{"line_number":92,"context_line":"        client.records.create(dns_zone.id, record)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BQko%3D","line":89,"updated":"2014-01-28 16:16:08.000000000","message":"Making a function is not needed. Just pass the content directly","commit_id":"d0d1be8879e6d22a2098483ee32b026b6e050e3a"}],"trove/instance/views.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"0b6393b9e8798a48fad4ecb2f4c382e34acb0d2d","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CONF \u003d cfg.CONF"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def get_ip_address(addresses):"},{"line_number":30,"context_line":"    if addresses is None:"},{"line_number":31,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BQjs%3D","line":28,"updated":"2014-01-28 16:16:08.000000000","message":"We don\u0027t need this method anymore. Lets deleted it too. It has been moved to the models and replaced by get_visible_ip_addresses()","commit_id":"d0d1be8879e6d22a2098483ee32b026b6e050e3a"}],"trove/tests/unittests/instance/test_instance_views.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"0b6393b9e8798a48fad4ecb2f4c382e34acb0d2d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.instance.addresses \u003d {\"private\": [{\"addr\": self.ip}]}"},{"line_number":56,"context_line":"        self.instance.volume_used \u003d \u00273\u0027"},{"line_number":57,"context_line":"        self.instance.root_password \u003d \u0027iloveyou\u0027"},{"line_number":58,"context_line":"        self.instance.get_visible_ip_addresses \u003d lambda: [\"1.2.3.4\"]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def tearDown(self):"},{"line_number":61,"context_line":"        super(InstanceDetailViewTest, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BQjE%3D","line":58,"updated":"2014-01-28 16:16:08.000000000","message":"Here too. Don\u0027t need to make it a function","commit_id":"d0d1be8879e6d22a2098483ee32b026b6e050e3a"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"b8d665beab13348cd1d02ab032832fbe202e9a17","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.instance.addresses \u003d {\"private\": [{\"addr\": self.ip}]}"},{"line_number":56,"context_line":"        self.instance.volume_used \u003d \u00273\u0027"},{"line_number":57,"context_line":"        self.instance.root_password \u003d \u0027iloveyou\u0027"},{"line_number":58,"context_line":"        self.instance.get_visible_ip_addresses \u003d lambda: [\"1.2.3.4\"]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def tearDown(self):"},{"line_number":61,"context_line":"        super(InstanceDetailViewTest, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BIbY%3D","line":58,"updated":"2014-01-29 21:08:47.000000000","message":"You forgot to remove the lambda here","commit_id":"7df130e683ded775da4df06f270d6685f9e165e4"}]}