)]}'
{"trove/guestagent/datastore/couchbase/manager.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"12d2a64e7450075902d9d974634b9a5125d80984","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class Manager(periodic_task.PeriodicTasks):"},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":"    This is Couchbase Manager class. It is dynamically loaded"},{"line_number":34,"context_line":"    based off of the service_type of the trove instance"},{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @periodic_task.periodic_task(ticks_between_runs\u003d3)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9Z6w%3D","line":34,"updated":"2014-02-07 06:30:38.000000000","message":"should be \"off of the datastore\", not \"off of the service_type\".","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"fa0effadf3fefbdabc0c81c76540ae279a81e11a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class Manager(periodic_task.PeriodicTasks):"},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":"    This is Couchbase Manager class. It is dynamically loaded"},{"line_number":34,"context_line":"    based off of the service_type of the trove instance"},{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @periodic_task.periodic_task(ticks_between_runs\u003d3)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9UfE%3D","line":34,"in_reply_to":"AAAAUH%2F9Z6w%3D","updated":"2014-02-08 01:38:03.000000000","message":"Done","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7672e6544776eb4ccee56446a723d8f5962a5c98","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        Resets to the default configuration,"},{"line_number":55,"context_line":"        currently this does nothing."},{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":"        raise NotImplemented()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _perform_restore(self, backup_info, context, restore_location, app):"},{"line_number":60,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9WD0%3D","line":57,"updated":"2014-02-07 15:46:44.000000000","message":"this one could be implemented easily, i\u0027d suggest to do this one.","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"fa0effadf3fefbdabc0c81c76540ae279a81e11a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        Resets to the default configuration,"},{"line_number":55,"context_line":"        currently this does nothing."},{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":"        raise NotImplemented()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _perform_restore(self, backup_info, context, restore_location, app):"},{"line_number":60,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2F%2FGA%3D","line":57,"in_reply_to":"AAAAUH%2F9WD0%3D","updated":"2014-02-08 01:38:03.000000000","message":"Couchbase does not use a config file. So we do not need this functionality.","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"12d2a64e7450075902d9d974634b9a5125d80984","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":67,"context_line":"                device_path\u003dNone, mount_point\u003dNone, backup_info\u003dNone,"},{"line_number":68,"context_line":"                config_contents\u003dNone, root_password\u003dNone):"},{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":"        This is called when the trove instance first comes online."},{"line_number":71,"context_line":"        It is the first rpc message passed from the task manager."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9Z5M%3D","line":68,"updated":"2014-02-07 06:30:38.000000000","message":"you\u0027re missing \"overrides\u003dNone\" as a named argument in prepare(), which is now necessary since configuration-groups has merged.","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"fa0effadf3fefbdabc0c81c76540ae279a81e11a","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":67,"context_line":"                device_path\u003dNone, mount_point\u003dNone, backup_info\u003dNone,"},{"line_number":68,"context_line":"                config_contents\u003dNone, root_password\u003dNone):"},{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":"        This is called when the trove instance first comes online."},{"line_number":71,"context_line":"        It is the first rpc message passed from the task manager."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9UZA%3D","line":68,"in_reply_to":"AAAAUH%2F9Z5M%3D","updated":"2014-02-08 01:38:03.000000000","message":"Done","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dc858a2a3b0759e87cd9a4493d61071fd2b95e44","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 eBay Software Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2FraU%3D","line":1,"updated":"2014-02-11 15:20:17.000000000","message":"I\u0027d suggest to add all methods which are mentioned at guestagent/api.py, to avoid rasing rpc exceptions related to missing methods.","commit_id":"af7b54501d3e048e75831593a8af3f22af427038"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"e73ffb12dadf067b016e2fdef05328cf074d0996","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 eBay Software Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2FcWw%3D","line":1,"in_reply_to":"AAAAUX%2F%2Fpp4%3D","updated":"2014-02-13 06:49:54.000000000","message":"Done","commit_id":"af7b54501d3e048e75831593a8af3f22af427038"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba806c9610b48b5700a477abb75d87450e71301b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 eBay Software Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2Fpp4%3D","line":1,"in_reply_to":"AAAAUX%2F%2Fpyg%3D","updated":"2014-02-11 18:39:54.000000000","message":"he\u0027s referring to https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/mysql/manager.py#L179-L192","commit_id":"af7b54501d3e048e75831593a8af3f22af427038"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"e59b787f36a4b54b56926dd47f479e394afb5ee2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 eBay Software Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2Fpyg%3D","line":1,"in_reply_to":"AAAAUX%2F%2FraU%3D","updated":"2014-02-11 18:27:24.000000000","message":"Could you please specify which ones are missing?","commit_id":"af7b54501d3e048e75831593a8af3f22af427038"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"59bbdc15836a150242574c17c33dfe47476cf51e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"ERROR_MSG \u003d _(\"Not supported\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class Manager(periodic_task.PeriodicTasks):"},{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":"    This is Couchbase Manager class. It is dynamically loaded"},{"line_number":36,"context_line":"    based off of the datastore of the trove instance"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2B0LA%3D","line":33,"updated":"2014-02-18 21:00:38.000000000","message":"At cursory glance patch looks good, but the way its being implemented (architecturally copied from mysql) is not correct, at all.\nEach invocation of constructors takes a lot of memory, each time manager tries to get actual status also loads memory.\nThe best way is re-write it same as cassandra (having only one application and status instance per lauch).","commit_id":"6666787e453530a9dbe37bf31edcf0eb22cbb702"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"39598bb4c115a22932b99ede7a8b346dcee6ff52","unresolved":false,"context_lines":[{"line_number":30,"context_line":"ERROR_MSG \u003d _(\"Not supported\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class Manager(periodic_task.PeriodicTasks):"},{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":"    This is Couchbase Manager class. It is dynamically loaded"},{"line_number":36,"context_line":"    based off of the datastore of the trove instance"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2Bz8E%3D","line":33,"in_reply_to":"AAAAUX%2F%2B0LA%3D","updated":"2014-02-20 19:12:17.000000000","message":"Done","commit_id":"6666787e453530a9dbe37bf31edcf0eb22cbb702"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"36c2ad720221da66fec4c6b2c7112c19d41e71c7","unresolved":false,"context_lines":[{"line_number":30,"context_line":"ERROR_MSG \u003d _(\"Not supported\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class Manager(periodic_task.PeriodicTasks):"},{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":"    This is Couchbase Manager class. It is dynamically loaded"},{"line_number":36,"context_line":"    based off of the datastore of the trove instance"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2Bz%2BE%3D","line":33,"in_reply_to":"AAAAUX%2F%2B0LA%3D","updated":"2014-02-18 21:21:36.000000000","message":"good catch.","commit_id":"6666787e453530a9dbe37bf31edcf0eb22cbb702"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"f6d5517c202a20594bdfb9b23b152312f3d80f02","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def change_passwords(self, context, users):"},{"line_number":50,"context_line":"        raise exception.TroveError(ERROR_MSG)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def reset_configuration(self, context, configuration):"},{"line_number":53,"context_line":"        raise exception.TroveError(ERROR_MSG)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVX%2F%2F5DQ%3D","line":52,"updated":"2014-02-27 15:15:28.000000000","message":"since couchbase doesn\u0027t have config file in a text form, this method should not raise an error, it should do \"pass\"","commit_id":"f2fe0105a36e3c577812962b34926601f4511857"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"726a1d494319cd276cdac9b97a1bd5b86d47671c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def change_passwords(self, context, users):"},{"line_number":50,"context_line":"        raise exception.TroveError(ERROR_MSG)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def reset_configuration(self, context, configuration):"},{"line_number":53,"context_line":"        raise exception.TroveError(ERROR_MSG)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVX%2F%2F2tA%3D","line":52,"in_reply_to":"AAAAVX%2F%2F3EU%3D","updated":"2014-02-27 20:00:45.000000000","message":"same opinion as Auston.","commit_id":"f2fe0105a36e3c577812962b34926601f4511857"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"50a3d21fdbc6c5c83e8772245f22b446888f80b5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def change_passwords(self, context, users):"},{"line_number":50,"context_line":"        raise exception.TroveError(ERROR_MSG)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def reset_configuration(self, context, configuration):"},{"line_number":53,"context_line":"        raise exception.TroveError(ERROR_MSG)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVX%2F%2F3EU%3D","line":52,"in_reply_to":"AAAAVX%2F%2F5DQ%3D","updated":"2014-02-27 18:58:23.000000000","message":"disagree. because couchbase does not support configuration-group operations, it should raise an error, just like it does for other operations it does not support. this behavior is consistent.","commit_id":"f2fe0105a36e3c577812962b34926601f4511857"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"f6d5517c202a20594bdfb9b23b152312f3d80f02","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        \"\"\""},{"line_number":80,"context_line":"        self.app.restart()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def start_db_with_conf_changes(self, context, config_contents):"},{"line_number":83,"context_line":"        raise exception.TroveError(ERROR_MSG)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def stop_db(self, context, do_not_start_on_reboot\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVX%2F%2F5Ds%3D","line":82,"updated":"2014-02-27 15:15:28.000000000","message":"since couchbase doesn\u0027t have config file in a text form, this method should not raise an error, it should do \"pass\"","commit_id":"f2fe0105a36e3c577812962b34926601f4511857"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"726a1d494319cd276cdac9b97a1bd5b86d47671c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        \"\"\""},{"line_number":80,"context_line":"        self.app.restart()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def start_db_with_conf_changes(self, context, config_contents):"},{"line_number":83,"context_line":"        raise exception.TroveError(ERROR_MSG)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def stop_db(self, context, do_not_start_on_reboot\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVX%2F%2F2ss%3D","line":82,"in_reply_to":"AAAAVX%2F%2F3EM%3D","updated":"2014-02-27 20:00:45.000000000","message":"same opinion as Auston.","commit_id":"f2fe0105a36e3c577812962b34926601f4511857"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"50a3d21fdbc6c5c83e8772245f22b446888f80b5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        \"\"\""},{"line_number":80,"context_line":"        self.app.restart()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def start_db_with_conf_changes(self, context, config_contents):"},{"line_number":83,"context_line":"        raise exception.TroveError(ERROR_MSG)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def stop_db(self, context, do_not_start_on_reboot\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVX%2F%2F3EM%3D","line":82,"in_reply_to":"AAAAVX%2F%2F5Ds%3D","updated":"2014-02-27 18:58:23.000000000","message":"disagree. because couchbase does not support configuration-group operations, it should raise an error, just like it does for other operations it does not support. this behavior is consistent.","commit_id":"f2fe0105a36e3c577812962b34926601f4511857"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"f6d5517c202a20594bdfb9b23b152312f3d80f02","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        device.resize_fs(mount_point)"},{"line_number":159,"context_line":"        LOG.debug(_(\"Resized the filesystem.\"))"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def update_overrides(self, context, overrides, remove\u003dFalse):"},{"line_number":162,"context_line":"        raise exception.TroveError(ERROR_MSG)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def apply_overrides(self, context, overrides):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVX%2F%2F5Do%3D","line":161,"updated":"2014-02-27 15:15:28.000000000","message":"since couchbase doesn\u0027t have config file in a text form, this method should not raise an error, it should do \"pass\"","commit_id":"f2fe0105a36e3c577812962b34926601f4511857"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"726a1d494319cd276cdac9b97a1bd5b86d47671c","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        device.resize_fs(mount_point)"},{"line_number":159,"context_line":"        LOG.debug(_(\"Resized the filesystem.\"))"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def update_overrides(self, context, overrides, remove\u003dFalse):"},{"line_number":162,"context_line":"        raise exception.TroveError(ERROR_MSG)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def apply_overrides(self, context, overrides):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVX%2F%2F2sk%3D","line":161,"in_reply_to":"AAAAVX%2F%2F3EI%3D","updated":"2014-02-27 20:00:45.000000000","message":"same opinion as Auston.","commit_id":"f2fe0105a36e3c577812962b34926601f4511857"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"50a3d21fdbc6c5c83e8772245f22b446888f80b5","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        device.resize_fs(mount_point)"},{"line_number":159,"context_line":"        LOG.debug(_(\"Resized the filesystem.\"))"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def update_overrides(self, context, overrides, remove\u003dFalse):"},{"line_number":162,"context_line":"        raise exception.TroveError(ERROR_MSG)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def apply_overrides(self, context, overrides):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVX%2F%2F3EI%3D","line":161,"in_reply_to":"AAAAVX%2F%2F5Do%3D","updated":"2014-02-27 18:58:23.000000000","message":"disagree. because couchbase does not support configuration-group operations, it should raise an error, just like it does for other operations it does not support. this behavior is consistent.","commit_id":"f2fe0105a36e3c577812962b34926601f4511857"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"f6d5517c202a20594bdfb9b23b152312f3d80f02","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    def update_overrides(self, context, overrides, remove\u003dFalse):"},{"line_number":162,"context_line":"        raise exception.TroveError(ERROR_MSG)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def apply_overrides(self, context, overrides):"},{"line_number":165,"context_line":"        raise exception.TroveError(ERROR_MSG)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVX%2F%2F5Dc%3D","line":164,"updated":"2014-02-27 15:15:28.000000000","message":"since couchbase doesn\u0027t have config file in a text form, this method should not raise an error, it should do \"pass\"","commit_id":"f2fe0105a36e3c577812962b34926601f4511857"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"726a1d494319cd276cdac9b97a1bd5b86d47671c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    def update_overrides(self, context, overrides, remove\u003dFalse):"},{"line_number":162,"context_line":"        raise exception.TroveError(ERROR_MSG)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def apply_overrides(self, context, overrides):"},{"line_number":165,"context_line":"        raise exception.TroveError(ERROR_MSG)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVX%2F%2F2sg%3D","line":164,"in_reply_to":"AAAAVX%2F%2F3EE%3D","updated":"2014-02-27 20:00:45.000000000","message":"same opinion as Auston.","commit_id":"f2fe0105a36e3c577812962b34926601f4511857"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"50a3d21fdbc6c5c83e8772245f22b446888f80b5","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    def update_overrides(self, context, overrides, remove\u003dFalse):"},{"line_number":162,"context_line":"        raise exception.TroveError(ERROR_MSG)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def apply_overrides(self, context, overrides):"},{"line_number":165,"context_line":"        raise exception.TroveError(ERROR_MSG)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVX%2F%2F3EE%3D","line":164,"in_reply_to":"AAAAVX%2F%2F5Dc%3D","updated":"2014-02-27 18:58:23.000000000","message":"disagree. because couchbase does not support configuration-group operations, it should raise an error, just like it does for other operations it does not support. this behavior is consistent.","commit_id":"f2fe0105a36e3c577812962b34926601f4511857"}],"trove/guestagent/datastore/couchbase/service.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"12d2a64e7450075902d9d974634b9a5125d80984","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from trove.openstack.common.gettextutils import _"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":"TIME_OUT \u003d 1200"},{"line_number":29,"context_line":"CONF \u003d cfg.CONF"},{"line_number":30,"context_line":"packager \u003d pkg.Package()"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9ZpM%3D","line":28,"updated":"2014-02-07 06:30:38.000000000","message":"please move TIME_OUT to couchbase/system.py","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"fa0effadf3fefbdabc0c81c76540ae279a81e11a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from trove.openstack.common.gettextutils import _"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":"TIME_OUT \u003d 1200"},{"line_number":29,"context_line":"CONF \u003d cfg.CONF"},{"line_number":30,"context_line":"packager \u003d pkg.Package()"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2F%2FGM%3D","line":28,"in_reply_to":"AAAAUH%2F9ZpM%3D","updated":"2014-02-08 01:38:03.000000000","message":"Done","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"12d2a64e7450075902d9d974634b9a5125d80984","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            cmd \u003d \u0027sudo chown couchbase:couchbase %s\u0027 % system\\"},{"line_number":63,"context_line":"                .COUCHBASE_MOUNT_POINT"},{"line_number":64,"context_line":"            utils.execute_with_timeout(cmd, shell\u003dTrue)"},{"line_number":65,"context_line":"            cmd \u003d \u0027sudo /opt/couchbase/bin/couchbase-cli node-init -c 127.0\u0027 \\"},{"line_number":66,"context_line":"                  \u0027.0.1:8091 --node-init-data-path\u003d/var/lib/couchbase -u \u0027 \\"},{"line_number":67,"context_line":"                  \u0027Administrator -p password\u0027"},{"line_number":68,"context_line":"            utils.execute_with_timeout(cmd, shell\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9ZnI%3D","line":65,"updated":"2014-02-07 06:30:38.000000000","message":"please move command to system.py so this can be reduced to \"cmd_node_init\".","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"fa0effadf3fefbdabc0c81c76540ae279a81e11a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            cmd \u003d \u0027sudo chown couchbase:couchbase %s\u0027 % system\\"},{"line_number":63,"context_line":"                .COUCHBASE_MOUNT_POINT"},{"line_number":64,"context_line":"            utils.execute_with_timeout(cmd, shell\u003dTrue)"},{"line_number":65,"context_line":"            cmd \u003d \u0027sudo /opt/couchbase/bin/couchbase-cli node-init -c 127.0\u0027 \\"},{"line_number":66,"context_line":"                  \u0027.0.1:8091 --node-init-data-path\u003d/var/lib/couchbase -u \u0027 \\"},{"line_number":67,"context_line":"                  \u0027Administrator -p password\u0027"},{"line_number":68,"context_line":"            utils.execute_with_timeout(cmd, shell\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9UW8%3D","line":65,"in_reply_to":"AAAAUH%2F9WDk%3D","updated":"2014-02-08 01:38:03.000000000","message":"Done","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"fa0effadf3fefbdabc0c81c76540ae279a81e11a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            cmd \u003d \u0027sudo chown couchbase:couchbase %s\u0027 % system\\"},{"line_number":63,"context_line":"                .COUCHBASE_MOUNT_POINT"},{"line_number":64,"context_line":"            utils.execute_with_timeout(cmd, shell\u003dTrue)"},{"line_number":65,"context_line":"            cmd \u003d \u0027sudo /opt/couchbase/bin/couchbase-cli node-init -c 127.0\u0027 \\"},{"line_number":66,"context_line":"                  \u0027.0.1:8091 --node-init-data-path\u003d/var/lib/couchbase -u \u0027 \\"},{"line_number":67,"context_line":"                  \u0027Administrator -p password\u0027"},{"line_number":68,"context_line":"            utils.execute_with_timeout(cmd, shell\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9UXA%3D","line":65,"in_reply_to":"AAAAUH%2F9ZnI%3D","updated":"2014-02-08 01:38:03.000000000","message":"Done","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7672e6544776eb4ccee56446a723d8f5962a5c98","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            cmd \u003d \u0027sudo chown couchbase:couchbase %s\u0027 % system\\"},{"line_number":63,"context_line":"                .COUCHBASE_MOUNT_POINT"},{"line_number":64,"context_line":"            utils.execute_with_timeout(cmd, shell\u003dTrue)"},{"line_number":65,"context_line":"            cmd \u003d \u0027sudo /opt/couchbase/bin/couchbase-cli node-init -c 127.0\u0027 \\"},{"line_number":66,"context_line":"                  \u0027.0.1:8091 --node-init-data-path\u003d/var/lib/couchbase -u \u0027 \\"},{"line_number":67,"context_line":"                  \u0027Administrator -p password\u0027"},{"line_number":68,"context_line":"            utils.execute_with_timeout(cmd, shell\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9WDk%3D","line":65,"in_reply_to":"AAAAUH%2F9ZnI%3D","updated":"2014-02-07 15:46:44.000000000","message":"and please do not use \\ for lines formatting","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"12d2a64e7450075902d9d974634b9a5125d80984","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            cmd \u003d \u0027sudo rm -rf /opt/couchbase/var/lib/couchbase/data\u0027"},{"line_number":70,"context_line":"            utils.execute_with_timeout(cmd, shell\u003dTrue)"},{"line_number":71,"context_line":"            LOG.info(_(\u0027Couchbase initialize cluster\u0027))"},{"line_number":72,"context_line":"            cmd \u003d \u0027sudo /opt/couchbase/bin/couchbase-cli cluster-init -c 127\u0027 \\"},{"line_number":73,"context_line":"                  \u0027.0.0.1:8091 --cluster-init-username\u003dAdministrator \u0027 \\"},{"line_number":74,"context_line":"                  \u0027--cluster-init-password\u003dpassword --cluster-init-port\u003d8091\u0027"},{"line_number":75,"context_line":"            utils.execute_with_timeout(cmd, shell\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9ZnA%3D","line":72,"updated":"2014-02-07 06:30:38.000000000","message":"please move command to system.py so this can be reduced to \"cmd_cluster_init\"","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"fa0effadf3fefbdabc0c81c76540ae279a81e11a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            cmd \u003d \u0027sudo rm -rf /opt/couchbase/var/lib/couchbase/data\u0027"},{"line_number":70,"context_line":"            utils.execute_with_timeout(cmd, shell\u003dTrue)"},{"line_number":71,"context_line":"            LOG.info(_(\u0027Couchbase initialize cluster\u0027))"},{"line_number":72,"context_line":"            cmd \u003d \u0027sudo /opt/couchbase/bin/couchbase-cli cluster-init -c 127\u0027 \\"},{"line_number":73,"context_line":"                  \u0027.0.0.1:8091 --cluster-init-username\u003dAdministrator \u0027 \\"},{"line_number":74,"context_line":"                  \u0027--cluster-init-password\u003dpassword --cluster-init-port\u003d8091\u0027"},{"line_number":75,"context_line":"            utils.execute_with_timeout(cmd, shell\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9USw%3D","line":72,"in_reply_to":"AAAAUH%2F9WDg%3D","updated":"2014-02-08 01:38:03.000000000","message":"Done","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7672e6544776eb4ccee56446a723d8f5962a5c98","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            cmd \u003d \u0027sudo rm -rf /opt/couchbase/var/lib/couchbase/data\u0027"},{"line_number":70,"context_line":"            utils.execute_with_timeout(cmd, shell\u003dTrue)"},{"line_number":71,"context_line":"            LOG.info(_(\u0027Couchbase initialize cluster\u0027))"},{"line_number":72,"context_line":"            cmd \u003d \u0027sudo /opt/couchbase/bin/couchbase-cli cluster-init -c 127\u0027 \\"},{"line_number":73,"context_line":"                  \u0027.0.0.1:8091 --cluster-init-username\u003dAdministrator \u0027 \\"},{"line_number":74,"context_line":"                  \u0027--cluster-init-password\u003dpassword --cluster-init-port\u003d8091\u0027"},{"line_number":75,"context_line":"            utils.execute_with_timeout(cmd, shell\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9WDg%3D","line":72,"in_reply_to":"AAAAUH%2F9ZnA%3D","updated":"2014-02-07 15:46:44.000000000","message":"please do not use \\ for lines formatting","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"1d107a16c9c5f64e854ae15a6f9f3d0575ccfcd2","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            LOG.error(_(\u0027Process execution error %s\u0027) % e)"},{"line_number":79,"context_line":"            raise RuntimeError(\"Couchbase initial setup failed\")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def complete_install_or_restart(self):"},{"line_number":83,"context_line":"        \"\"\""},{"line_number":84,"context_line":"        finalize status updates for install or restart."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9ZiI%3D","line":81,"updated":"2014-02-07 06:44:39.000000000","message":"remove this extra blank line, it violates E303","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"fa0effadf3fefbdabc0c81c76540ae279a81e11a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            LOG.error(_(\u0027Process execution error %s\u0027) % e)"},{"line_number":79,"context_line":"            raise RuntimeError(\"Couchbase initial setup failed\")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def complete_install_or_restart(self):"},{"line_number":83,"context_line":"        \"\"\""},{"line_number":84,"context_line":"        finalize status updates for install or restart."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9US0%3D","line":81,"in_reply_to":"AAAAUH%2F9ZiI%3D","updated":"2014-02-08 01:38:03.000000000","message":"Done","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7672e6544776eb4ccee56446a723d8f5962a5c98","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        Install the couchbase server."},{"line_number":91,"context_line":"        \"\"\""},{"line_number":92,"context_line":"        LOG.debug(_(\u0027Installing couchbase server\u0027))"},{"line_number":93,"context_line":"        msg \u003d _(\"Creating %s\") % (system.COUCHBASE_CONF_DIR)"},{"line_number":94,"context_line":"        LOG.debug(msg)"},{"line_number":95,"context_line":"        utils.execute_with_timeout(\u0027mkdir\u0027,"},{"line_number":96,"context_line":"                                   \u0027-p\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9WDQ%3D","line":93,"updated":"2014-02-07 15:46:44.000000000","message":"no need to trasform single value into a tuple","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"fa0effadf3fefbdabc0c81c76540ae279a81e11a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        Install the couchbase server."},{"line_number":91,"context_line":"        \"\"\""},{"line_number":92,"context_line":"        LOG.debug(_(\u0027Installing couchbase server\u0027))"},{"line_number":93,"context_line":"        msg \u003d _(\"Creating %s\") % (system.COUCHBASE_CONF_DIR)"},{"line_number":94,"context_line":"        LOG.debug(msg)"},{"line_number":95,"context_line":"        utils.execute_with_timeout(\u0027mkdir\u0027,"},{"line_number":96,"context_line":"                                   \u0027-p\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9US4%3D","line":93,"in_reply_to":"AAAAUH%2F9WDQ%3D","updated":"2014-02-08 01:38:03.000000000","message":"Done","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7672e6544776eb4ccee56446a723d8f5962a5c98","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            self._disable_db_on_boot()"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        try:"},{"line_number":137,"context_line":"            couchbase_service \u003d operating_system.service_discovery("},{"line_number":138,"context_line":"                system.SERVICE_CANDIDATES)"},{"line_number":139,"context_line":"            utils.execute_with_timeout(couchbase_service[\u0027cmd_stop\u0027],"},{"line_number":140,"context_line":"                                       shell\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9WCc%3D","line":137,"updated":"2014-02-07 15:46:44.000000000","message":"couchbase_service should be defined once per launch, please make it global and reuse everywhere you need it","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"fa0effadf3fefbdabc0c81c76540ae279a81e11a","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            self._disable_db_on_boot()"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        try:"},{"line_number":137,"context_line":"            couchbase_service \u003d operating_system.service_discovery("},{"line_number":138,"context_line":"                system.SERVICE_CANDIDATES)"},{"line_number":139,"context_line":"            utils.execute_with_timeout(couchbase_service[\u0027cmd_stop\u0027],"},{"line_number":140,"context_line":"                                       shell\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9US8%3D","line":137,"in_reply_to":"AAAAUH%2F9WCc%3D","updated":"2014-02-08 01:38:03.000000000","message":"Mysql/Mongo do not implement it as global. Could you please explain the need to do so?\n\nMongo patch : https://review.openstack.org/#/c/50597/49/trove/guestagent/datastore/mongodb/service.py","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"1d107a16c9c5f64e854ae15a6f9f3d0575ccfcd2","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            LOG.error(_(\"Start up of Couchbase failed!\"))"},{"line_number":181,"context_line":"            try:"},{"line_number":182,"context_line":"                utils.execute_with_timeout("},{"line_number":183,"context_line":"                    \u0027sudo\u0027,\u0027pkill\u0027, \u0027-9\u0027,\u0027couchbase-server\u0027)"},{"line_number":184,"context_line":"            except exception.ProcessExecutionError as p:"},{"line_number":185,"context_line":"                LOG.error(\u0027Error killing stalled Couchbase start command.\u0027)"},{"line_number":186,"context_line":"                LOG.error(p)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9Zj8%3D","line":183,"updated":"2014-02-07 06:44:39.000000000","message":"please move command to system.py so this can be reduced to \"cmd_kill\".\n\nalso, put a space between all comma separated items to be compliant with E231.","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"fa0effadf3fefbdabc0c81c76540ae279a81e11a","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            LOG.error(_(\"Start up of Couchbase failed!\"))"},{"line_number":181,"context_line":"            try:"},{"line_number":182,"context_line":"                utils.execute_with_timeout("},{"line_number":183,"context_line":"                    \u0027sudo\u0027,\u0027pkill\u0027, \u0027-9\u0027,\u0027couchbase-server\u0027)"},{"line_number":184,"context_line":"            except exception.ProcessExecutionError as p:"},{"line_number":185,"context_line":"                LOG.error(\u0027Error killing stalled Couchbase start command.\u0027)"},{"line_number":186,"context_line":"                LOG.error(p)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2F%2FGQ%3D","line":183,"in_reply_to":"AAAAUH%2F9Zj8%3D","updated":"2014-02-08 01:38:03.000000000","message":"Done","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7672e6544776eb4ccee56446a723d8f5962a5c98","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def _get_actual_db_status(self):"},{"line_number":205,"context_line":"        try:"},{"line_number":206,"context_line":"            cmd \u003d \u0027sudo %s\u0027 % (system.COUCHBASE_STATUS)"},{"line_number":207,"context_line":"            out, err \u003d utils.execute_with_timeout(cmd, shell\u003dTrue)"},{"line_number":208,"context_line":"            if \u0027not running\u0027 not in out:"},{"line_number":209,"context_line":"                return rd_instance.ServiceStatuses.RUNNING"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9WCU%3D","line":206,"updated":"2014-02-07 15:46:44.000000000","message":"no need to trasform single value into a tuple","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"fa0effadf3fefbdabc0c81c76540ae279a81e11a","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def _get_actual_db_status(self):"},{"line_number":205,"context_line":"        try:"},{"line_number":206,"context_line":"            cmd \u003d \u0027sudo %s\u0027 % (system.COUCHBASE_STATUS)"},{"line_number":207,"context_line":"            out, err \u003d utils.execute_with_timeout(cmd, shell\u003dTrue)"},{"line_number":208,"context_line":"            if \u0027not running\u0027 not in out:"},{"line_number":209,"context_line":"                return rd_instance.ServiceStatuses.RUNNING"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2F%2FGc%3D","line":206,"in_reply_to":"AAAAUH%2F9WCU%3D","updated":"2014-02-08 01:38:03.000000000","message":"Done","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"f6d5517c202a20594bdfb9b23b152312f3d80f02","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        Gets an instance of the CouchbaseAppStatus class."},{"line_number":200,"context_line":"        \"\"\""},{"line_number":201,"context_line":"        if not cls._instance:"},{"line_number":202,"context_line":"            cls._instance \u003d CouchbaseAppStatus()"},{"line_number":203,"context_line":"        return cls._instance"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def _get_actual_db_status(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVX%2F%2F5CI%3D","line":202,"updated":"2014-02-27 15:15:28.000000000","message":"singleton is not needed here, since you\u0027re already has an instance of status object inside manager class, prof: https://review.openstack.org/#/c/71407/10/trove/guestagent/datastore/couchbase/manager.py\n\n_get_actual_db_status is enough here.\n\nthis is how it done with cassandra, https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/cassandra/service.py#L188-L205","commit_id":"f2fe0105a36e3c577812962b34926601f4511857"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"726a1d494319cd276cdac9b97a1bd5b86d47671c","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        Gets an instance of the CouchbaseAppStatus class."},{"line_number":200,"context_line":"        \"\"\""},{"line_number":201,"context_line":"        if not cls._instance:"},{"line_number":202,"context_line":"            cls._instance \u003d CouchbaseAppStatus()"},{"line_number":203,"context_line":"        return cls._instance"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def _get_actual_db_status(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVX%2F%2F2sY%3D","line":202,"in_reply_to":"AAAAVX%2F%2F3D8%3D","updated":"2014-02-27 20:00:45.000000000","message":"Done","commit_id":"f2fe0105a36e3c577812962b34926601f4511857"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"50a3d21fdbc6c5c83e8772245f22b446888f80b5","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        Gets an instance of the CouchbaseAppStatus class."},{"line_number":200,"context_line":"        \"\"\""},{"line_number":201,"context_line":"        if not cls._instance:"},{"line_number":202,"context_line":"            cls._instance \u003d CouchbaseAppStatus()"},{"line_number":203,"context_line":"        return cls._instance"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def _get_actual_db_status(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVX%2F%2F3D8%3D","line":202,"in_reply_to":"AAAAVX%2F%2F5CI%3D","updated":"2014-02-27 18:58:23.000000000","message":"agreed.","commit_id":"f2fe0105a36e3c577812962b34926601f4511857"}],"trove/guestagent/datastore/couchbase/system.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dc858a2a3b0759e87cd9a4493d61071fd2b95e44","unresolved":false,"context_lines":[{"line_number":21,"context_line":"COUCHBASE_CONF_DIR \u003d \u0027/etc/couchbase\u0027"},{"line_number":22,"context_line":"COUCHBASE_MOUNT_POINT \u003d \u0027/var/lib/couchbase\u0027"},{"line_number":23,"context_line":"SERVICE_CANDIDATES \u003d [\"couchbase-server\"]"},{"line_number":24,"context_line":"cmd_couchbase_status \u003d \u0027sudo service couchbase-server status\u0027"},{"line_number":25,"context_line":"cmd_node_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli node-init \u0027"},{"line_number":26,"context_line":"                 \u0027-c 127.0.0.1:8091 --node-init-data-path\u003d%s \u0027"},{"line_number":27,"context_line":"                 \u0027-u Administrator -p password\u0027) % COUCHBASE_MOUNT_POINT"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2FrZc%3D","line":24,"updated":"2014-02-11 15:20:17.000000000","message":"service status doesn\u0027t guarantee  that database is really rinning and accessable.","commit_id":"af7b54501d3e048e75831593a8af3f22af427038"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"e73ffb12dadf067b016e2fdef05328cf074d0996","unresolved":false,"context_lines":[{"line_number":21,"context_line":"COUCHBASE_CONF_DIR \u003d \u0027/etc/couchbase\u0027"},{"line_number":22,"context_line":"COUCHBASE_MOUNT_POINT \u003d \u0027/var/lib/couchbase\u0027"},{"line_number":23,"context_line":"SERVICE_CANDIDATES \u003d [\"couchbase-server\"]"},{"line_number":24,"context_line":"cmd_couchbase_status \u003d \u0027sudo service couchbase-server status\u0027"},{"line_number":25,"context_line":"cmd_node_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli node-init \u0027"},{"line_number":26,"context_line":"                 \u0027-c 127.0.0.1:8091 --node-init-data-path\u003d%s \u0027"},{"line_number":27,"context_line":"                 \u0027-u Administrator -p password\u0027) % COUCHBASE_MOUNT_POINT"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2FcWM%3D","line":24,"in_reply_to":"AAAAUX%2F%2Foto%3D","updated":"2014-02-13 06:49:54.000000000","message":"Will implement this in an additional patch soon","commit_id":"af7b54501d3e048e75831593a8af3f22af427038"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"09e62b85b89ab7111fd588f185dde691a9ac949f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"COUCHBASE_CONF_DIR \u003d \u0027/etc/couchbase\u0027"},{"line_number":22,"context_line":"COUCHBASE_MOUNT_POINT \u003d \u0027/var/lib/couchbase\u0027"},{"line_number":23,"context_line":"SERVICE_CANDIDATES \u003d [\"couchbase-server\"]"},{"line_number":24,"context_line":"cmd_couchbase_status \u003d \u0027sudo service couchbase-server status\u0027"},{"line_number":25,"context_line":"cmd_node_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli node-init \u0027"},{"line_number":26,"context_line":"                 \u0027-c 127.0.0.1:8091 --node-init-data-path\u003d%s \u0027"},{"line_number":27,"context_line":"                 \u0027-u Administrator -p password\u0027) % COUCHBASE_MOUNT_POINT"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2Foto%3D","line":24,"in_reply_to":"AAAAUX%2F%2Fpsk%3D","updated":"2014-02-11 20:44:50.000000000","message":"Yes, i was looking for a better way to describe actual status of mongodb as well.\nI would suggest to you simple query, few examples:\nhttp://www.couchbase.com/docs/couchbase-manual-1.8/couchbase-monitoring-nodestats.html","commit_id":"af7b54501d3e048e75831593a8af3f22af427038"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba806c9610b48b5700a477abb75d87450e71301b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"COUCHBASE_CONF_DIR \u003d \u0027/etc/couchbase\u0027"},{"line_number":22,"context_line":"COUCHBASE_MOUNT_POINT \u003d \u0027/var/lib/couchbase\u0027"},{"line_number":23,"context_line":"SERVICE_CANDIDATES \u003d [\"couchbase-server\"]"},{"line_number":24,"context_line":"cmd_couchbase_status \u003d \u0027sudo service couchbase-server status\u0027"},{"line_number":25,"context_line":"cmd_node_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli node-init \u0027"},{"line_number":26,"context_line":"                 \u0027-c 127.0.0.1:8091 --node-init-data-path\u003d%s \u0027"},{"line_number":27,"context_line":"                 \u0027-u Administrator -p password\u0027) % COUCHBASE_MOUNT_POINT"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2Fpsk%3D","line":24,"in_reply_to":"AAAAUX%2F%2FpyY%3D","updated":"2014-02-11 18:39:54.000000000","message":"agreed, because your mongodb patch-set does the exact same thing. so if that\u0027s the case, please fix yours as well.","commit_id":"af7b54501d3e048e75831593a8af3f22af427038"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"e59b787f36a4b54b56926dd47f479e394afb5ee2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"COUCHBASE_CONF_DIR \u003d \u0027/etc/couchbase\u0027"},{"line_number":22,"context_line":"COUCHBASE_MOUNT_POINT \u003d \u0027/var/lib/couchbase\u0027"},{"line_number":23,"context_line":"SERVICE_CANDIDATES \u003d [\"couchbase-server\"]"},{"line_number":24,"context_line":"cmd_couchbase_status \u003d \u0027sudo service couchbase-server status\u0027"},{"line_number":25,"context_line":"cmd_node_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli node-init \u0027"},{"line_number":26,"context_line":"                 \u0027-c 127.0.0.1:8091 --node-init-data-path\u003d%s \u0027"},{"line_number":27,"context_line":"                 \u0027-u Administrator -p password\u0027) % COUCHBASE_MOUNT_POINT"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2FpyY%3D","line":24,"in_reply_to":"AAAAUX%2F%2FrZc%3D","updated":"2014-02-11 18:27:24.000000000","message":"Could you suggest the alternative solution?","commit_id":"af7b54501d3e048e75831593a8af3f22af427038"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dc858a2a3b0759e87cd9a4493d61071fd2b95e44","unresolved":false,"context_lines":[{"line_number":24,"context_line":"cmd_couchbase_status \u003d \u0027sudo service couchbase-server status\u0027"},{"line_number":25,"context_line":"cmd_node_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli node-init \u0027"},{"line_number":26,"context_line":"                 \u0027-c 127.0.0.1:8091 --node-init-data-path\u003d%s \u0027"},{"line_number":27,"context_line":"                 \u0027-u Administrator -p password\u0027) % COUCHBASE_MOUNT_POINT"},{"line_number":28,"context_line":"cmd_cluster_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli cluster-init \u0027"},{"line_number":29,"context_line":"                    \u0027-c 127.0.0.1:8091 --cluster-init-username\u003dAdministrator \u0027"},{"line_number":30,"context_line":"                    \u0027--cluster-init-password\u003dpassword \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2FrYo%3D","line":27,"updated":"2014-02-11 15:20:17.000000000","message":"seems like couchbase looks at localhost, so, i would suggest to make it reachable from any other hosts.\nIn DBaaS access restctictions are managed by firewall.","commit_id":"af7b54501d3e048e75831593a8af3f22af427038"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"e73ffb12dadf067b016e2fdef05328cf074d0996","unresolved":false,"context_lines":[{"line_number":24,"context_line":"cmd_couchbase_status \u003d \u0027sudo service couchbase-server status\u0027"},{"line_number":25,"context_line":"cmd_node_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli node-init \u0027"},{"line_number":26,"context_line":"                 \u0027-c 127.0.0.1:8091 --node-init-data-path\u003d%s \u0027"},{"line_number":27,"context_line":"                 \u0027-u Administrator -p password\u0027) % COUCHBASE_MOUNT_POINT"},{"line_number":28,"context_line":"cmd_cluster_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli cluster-init \u0027"},{"line_number":29,"context_line":"                    \u0027-c 127.0.0.1:8091 --cluster-init-username\u003dAdministrator \u0027"},{"line_number":30,"context_line":"                    \u0027--cluster-init-password\u003dpassword \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2FcUs%3D","line":27,"in_reply_to":"AAAAUX%2F%2FosY%3D","updated":"2014-02-13 06:49:54.000000000","message":"denis the ip address would suffice for single node couchbase-server instance scenario. The best practice is suggested for multi-node cluster environment.","commit_id":"af7b54501d3e048e75831593a8af3f22af427038"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"09e62b85b89ab7111fd588f185dde691a9ac949f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"cmd_couchbase_status \u003d \u0027sudo service couchbase-server status\u0027"},{"line_number":25,"context_line":"cmd_node_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli node-init \u0027"},{"line_number":26,"context_line":"                 \u0027-c 127.0.0.1:8091 --node-init-data-path\u003d%s \u0027"},{"line_number":27,"context_line":"                 \u0027-u Administrator -p password\u0027) % COUCHBASE_MOUNT_POINT"},{"line_number":28,"context_line":"cmd_cluster_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli cluster-init \u0027"},{"line_number":29,"context_line":"                    \u0027-c 127.0.0.1:8091 --cluster-init-username\u003dAdministrator \u0027"},{"line_number":30,"context_line":"                    \u0027--cluster-init-password\u003dpassword \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2FosY%3D","line":27,"in_reply_to":"AAAAUX%2F%2FprA%3D","updated":"2014-02-11 20:44:50.000000000","message":"I think this is enough for clarification and profs: http://www.couchbase.com/docs/couchbase-manual-2.0/couchbase-bestpractice-cloud-ip.html","commit_id":"af7b54501d3e048e75831593a8af3f22af427038"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba806c9610b48b5700a477abb75d87450e71301b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"cmd_couchbase_status \u003d \u0027sudo service couchbase-server status\u0027"},{"line_number":25,"context_line":"cmd_node_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli node-init \u0027"},{"line_number":26,"context_line":"                 \u0027-c 127.0.0.1:8091 --node-init-data-path\u003d%s \u0027"},{"line_number":27,"context_line":"                 \u0027-u Administrator -p password\u0027) % COUCHBASE_MOUNT_POINT"},{"line_number":28,"context_line":"cmd_cluster_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli cluster-init \u0027"},{"line_number":29,"context_line":"                    \u0027-c 127.0.0.1:8091 --cluster-init-username\u003dAdministrator \u0027"},{"line_number":30,"context_line":"                    \u0027--cluster-init-password\u003dpassword \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2FprA%3D","line":27,"in_reply_to":"AAAAUX%2F%2FpyI%3D","updated":"2014-02-11 18:39:54.000000000","message":"i\u0027d ask for a clarification as well. i\u0027m aware that the ip-address was peeled via eth0 for mongodb, but preliminary testing showed couchbase doesn\u0027t suffer from the same issue. are you stating this theoretically, or did you actually experience this with this patch-set?","commit_id":"af7b54501d3e048e75831593a8af3f22af427038"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"e59b787f36a4b54b56926dd47f479e394afb5ee2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"cmd_couchbase_status \u003d \u0027sudo service couchbase-server status\u0027"},{"line_number":25,"context_line":"cmd_node_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli node-init \u0027"},{"line_number":26,"context_line":"                 \u0027-c 127.0.0.1:8091 --node-init-data-path\u003d%s \u0027"},{"line_number":27,"context_line":"                 \u0027-u Administrator -p password\u0027) % COUCHBASE_MOUNT_POINT"},{"line_number":28,"context_line":"cmd_cluster_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli cluster-init \u0027"},{"line_number":29,"context_line":"                    \u0027-c 127.0.0.1:8091 --cluster-init-username\u003dAdministrator \u0027"},{"line_number":30,"context_line":"                    \u0027--cluster-init-password\u003dpassword \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2FpyI%3D","line":27,"in_reply_to":"AAAAUX%2F%2FrYo%3D","updated":"2014-02-11 18:27:24.000000000","message":"So should it not be localhost? Could you please clarify","commit_id":"af7b54501d3e048e75831593a8af3f22af427038"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dc858a2a3b0759e87cd9a4493d61071fd2b95e44","unresolved":false,"context_lines":[{"line_number":28,"context_line":"cmd_cluster_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli cluster-init \u0027"},{"line_number":29,"context_line":"                    \u0027-c 127.0.0.1:8091 --cluster-init-username\u003dAdministrator \u0027"},{"line_number":30,"context_line":"                    \u0027--cluster-init-password\u003dpassword \u0027"},{"line_number":31,"context_line":"                    \u0027--cluster-init-port\u003d8091\u0027)"},{"line_number":32,"context_line":"cmd_kill \u003d \u0027sudo pkill -9 couchbase-server\u0027"},{"line_number":33,"context_line":"cmd_own_data_dir \u003d (\u0027sudo chown couchbase:couchbase %s\u0027 %"},{"line_number":34,"context_line":"                    COUCHBASE_MOUNT_POINT)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2FrXY%3D","line":31,"updated":"2014-02-11 15:20:17.000000000","message":"Meaningless use of cluster initiating, i would not suggest to run cluster on one host, it\u0027s not the production deployment way.","commit_id":"af7b54501d3e048e75831593a8af3f22af427038"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba806c9610b48b5700a477abb75d87450e71301b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"cmd_cluster_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli cluster-init \u0027"},{"line_number":29,"context_line":"                    \u0027-c 127.0.0.1:8091 --cluster-init-username\u003dAdministrator \u0027"},{"line_number":30,"context_line":"                    \u0027--cluster-init-password\u003dpassword \u0027"},{"line_number":31,"context_line":"                    \u0027--cluster-init-port\u003d8091\u0027)"},{"line_number":32,"context_line":"cmd_kill \u003d \u0027sudo pkill -9 couchbase-server\u0027"},{"line_number":33,"context_line":"cmd_own_data_dir \u003d (\u0027sudo chown couchbase:couchbase %s\u0027 %"},{"line_number":34,"context_line":"                    COUCHBASE_MOUNT_POINT)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2FpqQ%3D","line":31,"in_reply_to":"AAAAUX%2F%2FpxQ%3D","updated":"2014-02-11 18:39:54.000000000","message":"denis: the nomenclature is misleading, this is only building a single instance. unless you\u0027ve uncovered a non-deprecated init command?","commit_id":"af7b54501d3e048e75831593a8af3f22af427038"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"e59b787f36a4b54b56926dd47f479e394afb5ee2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"cmd_cluster_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli cluster-init \u0027"},{"line_number":29,"context_line":"                    \u0027-c 127.0.0.1:8091 --cluster-init-username\u003dAdministrator \u0027"},{"line_number":30,"context_line":"                    \u0027--cluster-init-password\u003dpassword \u0027"},{"line_number":31,"context_line":"                    \u0027--cluster-init-port\u003d8091\u0027)"},{"line_number":32,"context_line":"cmd_kill \u003d \u0027sudo pkill -9 couchbase-server\u0027"},{"line_number":33,"context_line":"cmd_own_data_dir \u003d (\u0027sudo chown couchbase:couchbase %s\u0027 %"},{"line_number":34,"context_line":"                    COUCHBASE_MOUNT_POINT)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2FpxQ%3D","line":31,"in_reply_to":"AAAAUX%2F%2FrXY%3D","updated":"2014-02-11 18:27:24.000000000","message":"Here we are automating the cluster initializing for single instance couchbase. As we do not want the user to initialize the cluster via UI","commit_id":"af7b54501d3e048e75831593a8af3f22af427038"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"59bbdc15836a150242574c17c33dfe47476cf51e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"COUCHBASE_MOUNT_POINT \u003d \u0027/var/lib/couchbase\u0027"},{"line_number":23,"context_line":"SERVICE_CANDIDATES \u003d [\"couchbase-server\"]"},{"line_number":24,"context_line":"cmd_couchbase_status \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli server-info \u0027"},{"line_number":25,"context_line":"                        \u0027-c 127.0.0.1:8091 -u Administrator -p password \u0027)"},{"line_number":26,"context_line":"cmd_node_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli node-init \u0027"},{"line_number":27,"context_line":"                 \u0027-c 127.0.0.1:8091 --node-init-data-path\u003d%s \u0027"},{"line_number":28,"context_line":"                 \u0027-u Administrator -p password\u0027) % COUCHBASE_MOUNT_POINT"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2B0KQ%3D","line":25,"updated":"2014-02-18 21:00:38.000000000","message":"Nodes with both IPs and hostnames can exist in the same cluster. When you set the IP address using this method, you should not specify the address localhost or 127.0.0.1 as this will be invalid when used as the identifier for multiple nodes within the cluster. Instead, use the correct IP address for your host.\n\nPlease make intance launched with _real_ IP instead of this one.","commit_id":"6666787e453530a9dbe37bf31edcf0eb22cbb702"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"36c2ad720221da66fec4c6b2c7112c19d41e71c7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"COUCHBASE_MOUNT_POINT \u003d \u0027/var/lib/couchbase\u0027"},{"line_number":23,"context_line":"SERVICE_CANDIDATES \u003d [\"couchbase-server\"]"},{"line_number":24,"context_line":"cmd_couchbase_status \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli server-info \u0027"},{"line_number":25,"context_line":"                        \u0027-c 127.0.0.1:8091 -u Administrator -p password \u0027)"},{"line_number":26,"context_line":"cmd_node_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli node-init \u0027"},{"line_number":27,"context_line":"                 \u0027-c 127.0.0.1:8091 --node-init-data-path\u003d%s \u0027"},{"line_number":28,"context_line":"                 \u0027-u Administrator -p password\u0027) % COUCHBASE_MOUNT_POINT"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2Bz98%3D","line":25,"in_reply_to":"AAAAUX%2F%2B0KQ%3D","updated":"2014-02-18 21:21:36.000000000","message":"clusters will require a hostname, so there\u0027s no *real* need to do this in this patch-set, but i suppose it doesn\u0027t hurt.","commit_id":"6666787e453530a9dbe37bf31edcf0eb22cbb702"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"39598bb4c115a22932b99ede7a8b346dcee6ff52","unresolved":false,"context_lines":[{"line_number":22,"context_line":"COUCHBASE_MOUNT_POINT \u003d \u0027/var/lib/couchbase\u0027"},{"line_number":23,"context_line":"SERVICE_CANDIDATES \u003d [\"couchbase-server\"]"},{"line_number":24,"context_line":"cmd_couchbase_status \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli server-info \u0027"},{"line_number":25,"context_line":"                        \u0027-c 127.0.0.1:8091 -u Administrator -p password \u0027)"},{"line_number":26,"context_line":"cmd_node_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli node-init \u0027"},{"line_number":27,"context_line":"                 \u0027-c 127.0.0.1:8091 --node-init-data-path\u003d%s \u0027"},{"line_number":28,"context_line":"                 \u0027-u Administrator -p password\u0027) % COUCHBASE_MOUNT_POINT"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2Bg8U%3D","line":25,"in_reply_to":"AAAAUX%2F%2Bz7s%3D","updated":"2014-02-20 19:12:17.000000000","message":"Done","commit_id":"6666787e453530a9dbe37bf31edcf0eb22cbb702"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"966d05ab20be52403d7156e5757db92f2d04ce33","unresolved":false,"context_lines":[{"line_number":22,"context_line":"COUCHBASE_MOUNT_POINT \u003d \u0027/var/lib/couchbase\u0027"},{"line_number":23,"context_line":"SERVICE_CANDIDATES \u003d [\"couchbase-server\"]"},{"line_number":24,"context_line":"cmd_couchbase_status \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli server-info \u0027"},{"line_number":25,"context_line":"                        \u0027-c 127.0.0.1:8091 -u Administrator -p password \u0027)"},{"line_number":26,"context_line":"cmd_node_init \u003d (\u0027sudo /opt/couchbase/bin/couchbase-cli node-init \u0027"},{"line_number":27,"context_line":"                 \u0027-c 127.0.0.1:8091 --node-init-data-path\u003d%s \u0027"},{"line_number":28,"context_line":"                 \u0027-u Administrator -p password\u0027) % COUCHBASE_MOUNT_POINT"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2Bz7s%3D","line":25,"in_reply_to":"AAAAUX%2F%2Bz98%3D","updated":"2014-02-18 21:25:41.000000000","message":"accoring to couchbase docs, to make database accessable from any possible hosts, bind address should be a real IP address, not the loopback.","commit_id":"6666787e453530a9dbe37bf31edcf0eb22cbb702"}],"trove/tests/unittests/guestagent/test_dbaas.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7672e6544776eb4ccee56446a723d8f5962a5c98","unresolved":false,"context_lines":[{"line_number":50,"context_line":"from trove.guestagent.datastore.mysql.service import MySqlAppStatus"},{"line_number":51,"context_line":"from trove.guestagent.datastore.mysql.service import KeepAliveConnection"},{"line_number":52,"context_line":"from trove.guestagent.datastore.couchbase import service as cservice"},{"line_number":53,"context_line":"from trove.guestagent.datastore.couchbase.service import CouchbaseApp"},{"line_number":54,"context_line":"from trove.guestagent.db import models"},{"line_number":55,"context_line":"from trove.instance.models import InstanceServiceStatus"},{"line_number":56,"context_line":"from trove.tests.unittests.util import util"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9WBM%3D","line":53,"updated":"2014-02-07 15:46:44.000000000","message":"double importing, you could use: cservice.CouchbaseApp","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"fa0effadf3fefbdabc0c81c76540ae279a81e11a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"from trove.guestagent.datastore.mysql.service import MySqlAppStatus"},{"line_number":51,"context_line":"from trove.guestagent.datastore.mysql.service import KeepAliveConnection"},{"line_number":52,"context_line":"from trove.guestagent.datastore.couchbase import service as cservice"},{"line_number":53,"context_line":"from trove.guestagent.datastore.couchbase.service import CouchbaseApp"},{"line_number":54,"context_line":"from trove.guestagent.db import models"},{"line_number":55,"context_line":"from trove.instance.models import InstanceServiceStatus"},{"line_number":56,"context_line":"from trove.tests.unittests.util import util"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2F%2FFo%3D","line":53,"in_reply_to":"AAAAUH%2F9WBM%3D","updated":"2014-02-08 01:38:03.000000000","message":"Done","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"1d107a16c9c5f64e854ae15a6f9f3d0575ccfcd2","unresolved":false,"context_lines":[{"line_number":1487,"context_line":"        self.assert_reported_status(rd_instance.ServiceStatuses.NEW)"},{"line_number":1488,"context_line":""},{"line_number":1489,"context_line":""},{"line_number":1490,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9ZiM%3D","line":1490,"updated":"2014-02-07 06:44:39.000000000","message":"remove this extra blank line, it violates W391.","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"},{"author":{"_account_id":9431,"name":"Khyati Sheth","email":"khysheth@ebaysf.com","username":"khysheth"},"change_message_id":"fa0effadf3fefbdabc0c81c76540ae279a81e11a","unresolved":false,"context_lines":[{"line_number":1487,"context_line":"        self.assert_reported_status(rd_instance.ServiceStatuses.NEW)"},{"line_number":1488,"context_line":""},{"line_number":1489,"context_line":""},{"line_number":1490,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9USU%3D","line":1490,"in_reply_to":"AAAAUH%2F9ZiM%3D","updated":"2014-02-08 01:38:03.000000000","message":"Done","commit_id":"a5da573a9d3b194c0f53cf9953f726549cce2520"}]}