)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"0f5f6a7134d73606808f93a0e0710f8c4b90e391","unresolved":false,"context_lines":[{"line_number":19,"context_line":"the call to the guest will fail anyway."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I4e1ca75a150ed58233c21372d21c6337596e43d0"},{"line_number":22,"context_line":"Closes-Bug: 1278282"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUX%2F%2FnPw%3D","line":22,"updated":"2014-02-12 00:45:07.000000000","message":"Closes-Bug: #1278282","commit_id":"c85e5260e836c0f4365aca602b7877aaf88eedd3"}],"trove/taskmanager/models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"808ef879a1fe2435c964da3ed9d77271662b9aa6","unresolved":false,"context_lines":[{"line_number":1201,"context_line":"                  % self.instance.id)"},{"line_number":1202,"context_line":"        self.instance.server.confirm_resize()"},{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"    def _datastore_is_online(self):"},{"line_number":1205,"context_line":"        self.instance._refresh_compute_service_status()"},{"line_number":1206,"context_line":"        return (self.instance.service_status \u003d\u003d"},{"line_number":1207,"context_line":"                rd_instance.ServiceStatuses.RUNNING)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2F4So%3D","line":1204,"updated":"2014-02-10 07:56:05.000000000","message":"Why datastore ? since we\u0027re talking to trove instance(nova compute vm). \nShould be def _is_instance_running","commit_id":"d1f33cdf4275c1bd14d6dc2d75ca2b3fde562f8d"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"60fcc50e91cd4470fbcb83fa0b68cbe54f20688b","unresolved":false,"context_lines":[{"line_number":1201,"context_line":"                  % self.instance.id)"},{"line_number":1202,"context_line":"        self.instance.server.confirm_resize()"},{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"    def _datastore_is_online(self):"},{"line_number":1205,"context_line":"        self.instance._refresh_compute_service_status()"},{"line_number":1206,"context_line":"        return (self.instance.service_status \u003d\u003d"},{"line_number":1207,"context_line":"                rd_instance.ServiceStatuses.RUNNING)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FzeY%3D","line":1204,"in_reply_to":"AAAAUX%2F%2F4So%3D","updated":"2014-02-10 18:09:24.000000000","message":"service_status should be called \"datastore_status\" since it\u0027s the value represents whether the program (such as MySQL, Cassandra, etc) is running.","commit_id":"d1f33cdf4275c1bd14d6dc2d75ca2b3fde562f8d"}],"trove/tests/api/instances_resize.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"397e29b283337140d5793769bf0d23ce93c8380b","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        utils.poll_until(mox.IgnoreArg(), sleep_time\u003d2, time_out\u003d120)"},{"line_number":180,"context_line":"        self._start_mysql()"},{"line_number":181,"context_line":"        utils.poll_until(mox.IgnoreArg(), sleep_time\u003d2, time_out\u003d120)\\"},{"line_number":182,"context_line":"            .AndRaise(PollTimeOut)"},{"line_number":183,"context_line":"        self.instance.guest.reset_configuration(mox.IgnoreArg())"},{"line_number":184,"context_line":"        self.instance.server.revert_resize()"},{"line_number":185,"context_line":"        self._server_changes_to(\"ACTIVE\", OLD_FLAVOR_ID)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FuyU%3D","line":182,"updated":"2014-02-11 06:42:24.000000000","message":"i\u0027d suggest to avoid use of \\","commit_id":"131131f3640698541361adc9ff0401e18571108c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"92a3ff52367c8a3af12e062b15e92e4a4f768944","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        utils.poll_until(mox.IgnoreArg(), sleep_time\u003d2, time_out\u003d120)"},{"line_number":180,"context_line":"        self._start_mysql()"},{"line_number":181,"context_line":"        utils.poll_until(mox.IgnoreArg(), sleep_time\u003d2, time_out\u003d120)\\"},{"line_number":182,"context_line":"            .AndRaise(PollTimeOut)"},{"line_number":183,"context_line":"        self.instance.guest.reset_configuration(mox.IgnoreArg())"},{"line_number":184,"context_line":"        self.instance.server.revert_resize()"},{"line_number":185,"context_line":"        self._server_changes_to(\"ACTIVE\", OLD_FLAVOR_ID)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2Fru8%3D","line":182,"in_reply_to":"AAAAUX%2F%2FsBs%3D","updated":"2014-02-11 14:37:42.000000000","message":"Best option:\n utils.poll_until(mox.IgnoreArg(), sleep_time\u003d2,\n                  time_out\u003d120).AndRaise(PollTimeOut)","commit_id":"131131f3640698541361adc9ff0401e18571108c"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"3a348f0c28aa00ccc1142f425c7295dd4efb2d21","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        utils.poll_until(mox.IgnoreArg(), sleep_time\u003d2, time_out\u003d120)"},{"line_number":180,"context_line":"        self._start_mysql()"},{"line_number":181,"context_line":"        utils.poll_until(mox.IgnoreArg(), sleep_time\u003d2, time_out\u003d120)\\"},{"line_number":182,"context_line":"            .AndRaise(PollTimeOut)"},{"line_number":183,"context_line":"        self.instance.guest.reset_configuration(mox.IgnoreArg())"},{"line_number":184,"context_line":"        self.instance.server.revert_resize()"},{"line_number":185,"context_line":"        self._server_changes_to(\"ACTIVE\", OLD_FLAVOR_ID)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FsBs%3D","line":182,"in_reply_to":"AAAAUX%2F%2FuyU%3D","updated":"2014-02-11 14:07:50.000000000","message":"The alternatives are:\n\npoll \u003d utils.poll_until(mox.IgnoreArg(), sleep_time\u003d2, time_out\u003d120)\npoll.AndRaise(PollTimeOut)\n\nand\n\n(utils.poll_until(mox.IgnoreArg(), sleep_time\u003d2, time_out\u003d120)\n            .AndRaise(PollTimeOut))\n\nBoth of which are painfully ugly. Is this really better? PEP8 didn\u0027t object which makes me think that in some cases, like this, it is ok.","commit_id":"131131f3640698541361adc9ff0401e18571108c"}]}