)]}'
{"trove/tests/api/backups.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"1e9bd152c3d26cb04c9923aecaf8843841ad0a2b","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    @test(depends_on\u003d[RestoreUsingBackup.test_restore],"},{"line_number":283,"context_line":"          runs_after\u003d[RestoreUsingBackup.test_restore])"},{"line_number":284,"context_line":"    def test_instance_restored(self):"},{"line_number":285,"context_line":"        self._poll(restore_instance_id)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    \"\"\""},{"line_number":288,"context_line":"        Wait until the instance is finished restoring from incremental backup."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FEKs%3D","line":285,"updated":"2014-02-17 10:56:13.000000000","message":"I\u0027d suggest to add assertation here with try-except PollUntil timeout","commit_id":"d019457341f317ba553f2d7c3dbaa8733baadf43"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"1e9bd152c3d26cb04c9923aecaf8843841ad0a2b","unresolved":false,"context_lines":[{"line_number":321,"context_line":"          runs_after\u003d[WaitForRestoreToFinish."},{"line_number":322,"context_line":"          test_instance_restored_incremental])"},{"line_number":323,"context_line":"    def test_database_restored_incremental(self):"},{"line_number":324,"context_line":"        self._poll(incremental_restore_instance_id, incremental_db)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"@test(groups\u003d[GROUP, tests.INSTANCES])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FEKg%3D","line":324,"updated":"2014-02-17 10:56:13.000000000","message":"I\u0027d suggest to add assertation here with try-except PollUntil timeout","commit_id":"d019457341f317ba553f2d7c3dbaa8733baadf43"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"1e9bd152c3d26cb04c9923aecaf8843841ad0a2b","unresolved":false,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    @test(runs_after\u003d[VerifyRestore.test_database_restored])"},{"line_number":348,"context_line":"    def test_delete_restored_instance(self):"},{"line_number":349,"context_line":"        self._delete(restore_instance_id)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    @test(runs_after\u003d[VerifyRestore.test_database_restored_incremental])"},{"line_number":352,"context_line":"    def test_delete_restored_instance_incremental(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FEKc%3D","line":349,"updated":"2014-02-17 10:56:13.000000000","message":"I\u0027d suggest to add assertation here with try-except PollUntil timeout","commit_id":"d019457341f317ba553f2d7c3dbaa8733baadf43"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"1e9bd152c3d26cb04c9923aecaf8843841ad0a2b","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    @test(runs_after\u003d[VerifyRestore.test_database_restored_incremental])"},{"line_number":352,"context_line":"    def test_delete_restored_instance_incremental(self):"},{"line_number":353,"context_line":"        self._delete(incremental_restore_instance_id)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"@test(runs_after\u003d[DeleteRestoreInstance],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FEKY%3D","line":353,"updated":"2014-02-17 10:56:13.000000000","message":"I\u0027d suggest to add assertation here with try-except PollUntil timeout","commit_id":"d019457341f317ba553f2d7c3dbaa8733baadf43"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"3667f0b80286edbae04fb3decbebe6e5f46324ba","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        return result.id"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @test(runs_after\u003d[WaitForBackupCreateToFinish],"},{"line_number":253,"context_line":"          depends_on\u003d[WaitForBackupCreateToFinish])"},{"line_number":254,"context_line":"    def test_restore(self):"},{"line_number":255,"context_line":"        global restore_instance_id"},{"line_number":256,"context_line":"        restore_instance_id \u003d self._restore(backup_info.id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2Fyeo%3D","line":253,"updated":"2014-03-04 04:47:27.000000000","message":"Hmm.. all of the tests are annotated to run_after and depend on the same test.  Not sure what the behavior is in this case, -1 just to clarify.","commit_id":"9719b756e2b6608f3aa7da3cc2439c46289a3bad"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"f256ad23420b210346823a4b6f56a1ae6b6748ea","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        return result.id"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @test(runs_after\u003d[WaitForBackupCreateToFinish],"},{"line_number":253,"context_line":"          depends_on\u003d[WaitForBackupCreateToFinish])"},{"line_number":254,"context_line":"    def test_restore(self):"},{"line_number":255,"context_line":"        global restore_instance_id"},{"line_number":256,"context_line":"        restore_instance_id \u003d self._restore(backup_info.id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2FBZ0%3D","line":253,"in_reply_to":"AAAAVn%2F%2FWTw%3D","updated":"2014-03-10 16:38:20.000000000","message":"Changed to just depends_on.","commit_id":"9719b756e2b6608f3aa7da3cc2439c46289a3bad"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"1891e14abe6831cd9143248a955e0d7bcf8cca45","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        return result.id"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @test(runs_after\u003d[WaitForBackupCreateToFinish],"},{"line_number":253,"context_line":"          depends_on\u003d[WaitForBackupCreateToFinish])"},{"line_number":254,"context_line":"    def test_restore(self):"},{"line_number":255,"context_line":"        global restore_instance_id"},{"line_number":256,"context_line":"        restore_instance_id \u003d self._restore(backup_info.id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2FWTw%3D","line":253,"in_reply_to":"AAAAVn%2F%2Fyeo%3D","updated":"2014-03-06 17:40:25.000000000","message":"On the left, line 255, the original code did similar depends_on and runs_after on the same class. I feel it is sufficient for just depends_on and here\u0027s why:\n\n\"In Proboscis, if one tests depends on another which fails, the dependent test raises Nose’s SkipTest or calls unittest’s skipTest() automatically, making it easier to track down the real problem.\"\n\n\"runs_after...affects only the order of test runs. If a test noted by runs_after fails, the test method or class targeted by the decorator will not be skipped.\"\n\nIn other words, when both are present, it would seem to me that depends_on is enough, since in order to determine success of your depends_on reference, you must allow it to complete. Therefore, runs_after is redundant when depends_on is present.\n\nThoughts?","commit_id":"9719b756e2b6608f3aa7da3cc2439c46289a3bad"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"cca77da662c52206b28d3e34eda930aec25b9518","unresolved":false,"context_lines":[{"line_number":327,"context_line":"          test_instance_restored],)"},{"line_number":328,"context_line":"    def test_database_restored(self):"},{"line_number":329,"context_line":"        # to be added"},{"line_number":330,"context_line":"        pass"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    @test(depends_on\u003d[WaitForRestoreToFinish."},{"line_number":333,"context_line":"          test_instance_restored_incremental],"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2Fw9w%3D","line":330,"updated":"2014-03-04 08:30:03.000000000","message":"rather than have a false positive, I would suggest converting this to a comment for now...or better yet implement this.","commit_id":"9719b756e2b6608f3aa7da3cc2439c46289a3bad"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"f256ad23420b210346823a4b6f56a1ae6b6748ea","unresolved":false,"context_lines":[{"line_number":327,"context_line":"          test_instance_restored],)"},{"line_number":328,"context_line":"    def test_database_restored(self):"},{"line_number":329,"context_line":"        # to be added"},{"line_number":330,"context_line":"        pass"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    @test(depends_on\u003d[WaitForRestoreToFinish."},{"line_number":333,"context_line":"          test_instance_restored_incremental],"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2FBZw%3D","line":330,"in_reply_to":"AAAAVn%2F%2FWTk%3D","updated":"2014-03-10 16:38:20.000000000","message":"Done","commit_id":"9719b756e2b6608f3aa7da3cc2439c46289a3bad"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"1891e14abe6831cd9143248a955e0d7bcf8cca45","unresolved":false,"context_lines":[{"line_number":327,"context_line":"          test_instance_restored],)"},{"line_number":328,"context_line":"    def test_database_restored(self):"},{"line_number":329,"context_line":"        # to be added"},{"line_number":330,"context_line":"        pass"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    @test(depends_on\u003d[WaitForRestoreToFinish."},{"line_number":333,"context_line":"          test_instance_restored_incremental],"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2FWTk%3D","line":330,"in_reply_to":"AAAAVn%2F%2Fw9w%3D","updated":"2014-03-06 17:40:25.000000000","message":"Great point.","commit_id":"9719b756e2b6608f3aa7da3cc2439c46289a3bad"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"97b5cebeb0193205d884f4395ebfff61a57a2612","unresolved":false,"context_lines":[{"line_number":315,"context_line":"                return True"},{"line_number":316,"context_line":"            else:"},{"line_number":317,"context_line":"                return False"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        poll_until(db_is_found, time_out\u003d60 * 10, sleep_time\u003d10)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    @test(depends_on\u003d[WaitForRestoreToFinish."}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2BtO8%3D","line":318,"updated":"2014-03-24 23:00:04.000000000","message":"this could be reduced to \n\n   return db in [d.name for d in databases]","commit_id":"745f45a4ca0f1f5e27fd7a26ba213f7ae9783626"}]}