)]}'
{"etc/trove/trove-guestagent.conf.sample":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"70150058cfbb55252ec95d3b0e8188c2ab8162b1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"[redis]"},{"line_number":82,"context_line":"mount_point \u003d /var/lib/redis"},{"line_number":83,"context_line":"backup_strategy \u003d NA"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAUX%2F%2BxdQ%3D","line":84,"updated":"2014-02-19 06:14:36.000000000","message":"why not have it one mount_point parameter only \n\nmount_point \u003d  /var/lib\n\nand wherever we need to use it we may use it mount_point+\"/\"+datastore","commit_id":"881697493004673352b4ba71a1c39ba4d0396c00"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c356f867e36deb1ffe42bfd4a63950ce4359ca41","unresolved":false,"context_lines":[{"line_number":81,"context_line":"[redis]"},{"line_number":82,"context_line":"mount_point \u003d /var/lib/redis"},{"line_number":83,"context_line":"backup_strategy \u003d NA"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAUX%2F%2BxZU%3D","line":84,"in_reply_to":"AAAAUX%2F%2BxdQ%3D","updated":"2014-02-19 06:25:31.000000000","message":"Because it\u0027ll bring inconsistent volume mounting. \nSuppose user defined storage directory as /home/user/mysql in confit template, with your suggestion it\u0027ll be impossible to mount volume into the storage directory. \nAnother example. Cassandra stores it\u0027s data in /var/lib/cassandra/data. \nSo, it means, again, inconsistent mounting. \nThis patch gives to a deployer more flexibility, but your suggestion will make more troubles in long term perspective.\n\nMount point per datastore is the best of possible options. \n\nAnd last patch was abandoned, long time ago. Ilya don\u0027t mind that I took this task.","commit_id":"881697493004673352b4ba71a1c39ba4d0396c00"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba8c4d9097772157ef99f010abfa55cc6c6a601a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"backup_chunk_size \u003d 65536"},{"line_number":71,"context_line":"backup_segment_max_size \u003d 2147483648"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"[mysql]"},{"line_number":74,"context_line":"mount_point \u003d /var/lib/mysql"},{"line_number":75,"context_line":"backup_strategy \u003d InnoBackupEx"},{"line_number":76,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAVX%2F%2F%2BUc%3D","line":73,"updated":"2014-02-27 03:24:08.000000000","message":"since mount_point is already clearly defined in cfg.py, and the likelihood that even a minority of users will desire an override is highly unlikely, let\u0027s not duplicate what\u0027s already in cfg.py here.\n\nin short, don\u0027t add anything to this file.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"}],"etc/trove/trove-taskmanager.conf.sample":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba8c4d9097772157ef99f010abfa55cc6c6a601a","unresolved":false,"context_lines":[{"line_number":131,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Guestagent related \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":132,"context_line":"#guest_config \u003d $pybasedir/etc/trove/trove-guestagent.conf.sample"},{"line_number":133,"context_line":"#cloudinit_location \u003d /etc/trove/cloudinit"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"[mysql]"},{"line_number":136,"context_line":"mount_point \u003d /var/lib/mysql"},{"line_number":137,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAVX%2F%2F%2BUE%3D","line":134,"updated":"2014-02-27 03:24:08.000000000","message":"since mount_point is already clearly defined in cfg.py, and the likelihood that even a minority of users will desire an override is highly unlikely, let\u0027s not duplicate what\u0027s already in cfg.py here.\n\nin short, don\u0027t add anything to this file.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"1ecabffd57d5b9a0b381d0ddeda2246b0757dbe4","unresolved":false,"context_lines":[{"line_number":129,"context_line":"#pydev_path \u003d \u003cpath\u003e"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Guestagent related \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":132,"context_line":"#guest_config \u003d $pybasedir/etc/trove/trove-guestagent.conf.sample"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAVX%2F%2F3Mc%3D","line":132,"updated":"2014-02-27 18:41:24.000000000","message":"you accidentally removed\n\n#cloudinit_location \u003d /etc/trove/cloudinit","commit_id":"d6c762a2ff66464f5f9e321d07e439b24cc4bf50"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"3af9f612ad60828370095ef164a01b2f47dd10a2","unresolved":false,"context_lines":[{"line_number":129,"context_line":"#pydev_path \u003d \u003cpath\u003e"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Guestagent related \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":132,"context_line":"#guest_config \u003d $pybasedir/etc/trove/trove-guestagent.conf.sample"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAVX%2F%2F18w%3D","line":132,"in_reply_to":"AAAAVX%2F%2F3Mc%3D","updated":"2014-02-27 22:05:31.000000000","message":"denis can\u0027t modify this for a day or so, so since it\u0027s aesthetic only, it\u0027s fine for now (considering the flood of interdependent patches we need to land)","commit_id":"d6c762a2ff66464f5f9e321d07e439b24cc4bf50"}],"etc/trove/trove.conf.test":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba8c4d9097772157ef99f010abfa55cc6c6a601a","unresolved":false,"context_lines":[{"line_number":179,"context_line":"#Add this filter to log request and response for debugging"},{"line_number":180,"context_line":"[filter:debug]"},{"line_number":181,"context_line":"paste.filter_factory \u003d trove.common.wsgi:Debug"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"[mysql]"},{"line_number":184,"context_line":"mount_point \u003d /var/lib/mysql"},{"line_number":185,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAVX%2F%2F%2BUA%3D","line":182,"updated":"2014-02-27 03:24:08.000000000","message":"since mount_point is already clearly defined in cfg.py, and the likelihood that even a minority of users will desire an override is highly unlikely, let\u0027s not duplicate what\u0027s already in cfg.py here.\n\nin short, don\u0027t add anything to this file.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"}],"trove/common/cfg.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba8c4d9097772157ef99f010abfa55cc6c6a601a","unresolved":false,"context_lines":[{"line_number":271,"context_line":"mysql_opts \u003d ["},{"line_number":272,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027InnoBackupEx\u0027,"},{"line_number":273,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"},{"line_number":274,"context_line":"    cfg.StrOpt(\u0027mount_point\u0027, default\u003d\u0027/var/lib/mysql\u0027),"},{"line_number":275,"context_line":"]"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"# Cassandra"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F%2BS8%3D","line":274,"updated":"2014-02-27 03:24:08.000000000","message":"mount_path should have a help string.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba8c4d9097772157ef99f010abfa55cc6c6a601a","unresolved":false,"context_lines":[{"line_number":277,"context_line":"# Cassandra"},{"line_number":278,"context_line":"cassandra_group \u003d cfg.OptGroup("},{"line_number":279,"context_line":"    \u0027cassandra\u0027, title\u003d\u0027Cassandra options\u0027,"},{"line_number":280,"context_line":"    help\u003d\"Oslo option group designed for Cassandra datastore\")"},{"line_number":281,"context_line":"cassandra_opts \u003d ["},{"line_number":282,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027NodetoolSnapshot\u0027,"},{"line_number":283,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F%2BT0%3D","line":280,"updated":"2014-02-27 03:24:08.000000000","message":"remove this help, it\u0027s not in https://review.openstack.org/#/c/50944/18/trove/common/cfg.py.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"e2556190958cb02073b9653f8ccc158dd30e4e1b","unresolved":false,"context_lines":[{"line_number":277,"context_line":"# Cassandra"},{"line_number":278,"context_line":"cassandra_group \u003d cfg.OptGroup("},{"line_number":279,"context_line":"    \u0027cassandra\u0027, title\u003d\u0027Cassandra options\u0027,"},{"line_number":280,"context_line":"    help\u003d\"Oslo option group designed for Cassandra datastore\")"},{"line_number":281,"context_line":"cassandra_opts \u003d ["},{"line_number":282,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027NodetoolSnapshot\u0027,"},{"line_number":283,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F8c8%3D","line":280,"in_reply_to":"AAAAVX%2F%2F%2BT0%3D","updated":"2014-02-27 08:12:22.000000000","message":"i think help string should be here.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"3e40990d2665108266faec8f8afba04922551be3","unresolved":false,"context_lines":[{"line_number":277,"context_line":"# Cassandra"},{"line_number":278,"context_line":"cassandra_group \u003d cfg.OptGroup("},{"line_number":279,"context_line":"    \u0027cassandra\u0027, title\u003d\u0027Cassandra options\u0027,"},{"line_number":280,"context_line":"    help\u003d\"Oslo option group designed for Cassandra datastore\")"},{"line_number":281,"context_line":"cassandra_opts \u003d ["},{"line_number":282,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027NodetoolSnapshot\u0027,"},{"line_number":283,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F8RY%3D","line":280,"in_reply_to":"AAAAVX%2F%2F8c8%3D","updated":"2014-02-27 08:23:50.000000000","message":"that works. please update https://review.openstack.org/#/c/50944/18/trove/common/cfg.py then, because it\u0027s likely to merge first.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba8c4d9097772157ef99f010abfa55cc6c6a601a","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    \u0027cassandra\u0027, title\u003d\u0027Cassandra options\u0027,"},{"line_number":280,"context_line":"    help\u003d\"Oslo option group designed for Cassandra datastore\")"},{"line_number":281,"context_line":"cassandra_opts \u003d ["},{"line_number":282,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027NodetoolSnapshot\u0027,"},{"line_number":283,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"},{"line_number":284,"context_line":"    cfg.StrOpt(\u0027mount_point\u0027, default\u003d\u0027/var/lib/cassandra\u0027),"},{"line_number":285,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F%2BTg%3D","line":282,"updated":"2014-02-27 03:24:08.000000000","message":"backup_strategy should be None here, because the Cassandra backup logic has not landed yet.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba8c4d9097772157ef99f010abfa55cc6c6a601a","unresolved":false,"context_lines":[{"line_number":281,"context_line":"cassandra_opts \u003d ["},{"line_number":282,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027NodetoolSnapshot\u0027,"},{"line_number":283,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"},{"line_number":284,"context_line":"    cfg.StrOpt(\u0027mount_point\u0027, default\u003d\u0027/var/lib/cassandra\u0027),"},{"line_number":285,"context_line":"]"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"# Redis"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F%2BTE%3D","line":284,"updated":"2014-02-27 03:24:08.000000000","message":"mount_path should have a help string.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba8c4d9097772157ef99f010abfa55cc6c6a601a","unresolved":false,"context_lines":[{"line_number":287,"context_line":"# Redis"},{"line_number":288,"context_line":"redis_group \u003d cfg.OptGroup("},{"line_number":289,"context_line":"    \u0027redis\u0027, title\u003d\u0027Redis options\u0027,"},{"line_number":290,"context_line":"    help\u003d\"Oslo option group designed for Redis datastore\")"},{"line_number":291,"context_line":"redis_opts \u003d ["},{"line_number":292,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027NA\u0027,"},{"line_number":293,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F%2BTw%3D","line":290,"updated":"2014-02-27 03:24:08.000000000","message":"remove this help, it\u0027s not in https://review.openstack.org/#/c/50944/18/trove/common/cfg.py.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"e2556190958cb02073b9653f8ccc158dd30e4e1b","unresolved":false,"context_lines":[{"line_number":287,"context_line":"# Redis"},{"line_number":288,"context_line":"redis_group \u003d cfg.OptGroup("},{"line_number":289,"context_line":"    \u0027redis\u0027, title\u003d\u0027Redis options\u0027,"},{"line_number":290,"context_line":"    help\u003d\"Oslo option group designed for Redis datastore\")"},{"line_number":291,"context_line":"redis_opts \u003d ["},{"line_number":292,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027NA\u0027,"},{"line_number":293,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F8c4%3D","line":290,"in_reply_to":"AAAAVX%2F%2F%2BTw%3D","updated":"2014-02-27 08:12:22.000000000","message":"i think help string should be here.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"3e40990d2665108266faec8f8afba04922551be3","unresolved":false,"context_lines":[{"line_number":287,"context_line":"# Redis"},{"line_number":288,"context_line":"redis_group \u003d cfg.OptGroup("},{"line_number":289,"context_line":"    \u0027redis\u0027, title\u003d\u0027Redis options\u0027,"},{"line_number":290,"context_line":"    help\u003d\"Oslo option group designed for Redis datastore\")"},{"line_number":291,"context_line":"redis_opts \u003d ["},{"line_number":292,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027NA\u0027,"},{"line_number":293,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F8RU%3D","line":290,"in_reply_to":"AAAAVX%2F%2F8c4%3D","updated":"2014-02-27 08:23:50.000000000","message":"that works. please update https://review.openstack.org/#/c/50944/18/trove/common/cfg.py then, because it\u0027s likely to merge first.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba8c4d9097772157ef99f010abfa55cc6c6a601a","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    \u0027redis\u0027, title\u003d\u0027Redis options\u0027,"},{"line_number":290,"context_line":"    help\u003d\"Oslo option group designed for Redis datastore\")"},{"line_number":291,"context_line":"redis_opts \u003d ["},{"line_number":292,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027NA\u0027,"},{"line_number":293,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"},{"line_number":294,"context_line":"    cfg.StrOpt(\u0027mount_point\u0027, default\u003d\u0027/var/lib/redis\u0027),"},{"line_number":295,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F%2BTQ%3D","line":292,"updated":"2014-02-27 03:24:08.000000000","message":"backup_strategy should be None vs. \u0027NA\u0027 (None is a meaningful primitive, whereas \u0027NA\u0027 is a custom string literal to indicate the same thing).","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba8c4d9097772157ef99f010abfa55cc6c6a601a","unresolved":false,"context_lines":[{"line_number":291,"context_line":"redis_opts \u003d ["},{"line_number":292,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027NA\u0027,"},{"line_number":293,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"},{"line_number":294,"context_line":"    cfg.StrOpt(\u0027mount_point\u0027, default\u003d\u0027/var/lib/redis\u0027),"},{"line_number":295,"context_line":"]"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"CONF.register_group(mysql_group)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F%2BTA%3D","line":294,"updated":"2014-02-27 03:24:08.000000000","message":"mount_path should have a help string.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"}],"trove/guestagent/api.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba8c4d9097772157ef99f010abfa55cc6c6a601a","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        LOG.debug(_(\"Check Volume Info on Instance %s\"), self.id)"},{"line_number":271,"context_line":"        # self._check_for_hearbeat()"},{"line_number":272,"context_line":"        return self._call(\"get_filesystem_stats\", AGENT_LOW_TIMEOUT,"},{"line_number":273,"context_line":"                          fs_path\u003dNone)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def update_guest(self):"},{"line_number":276,"context_line":"        \"\"\"Make a synchronous call to update the guest agent.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F%2BQU%3D","line":273,"updated":"2014-02-27 03:24:08.000000000","message":"note: fs_path is kept as an argument to avoid breaking the message contract.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"e2556190958cb02073b9653f8ccc158dd30e4e1b","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        LOG.debug(_(\"Check Volume Info on Instance %s\"), self.id)"},{"line_number":271,"context_line":"        # self._check_for_hearbeat()"},{"line_number":272,"context_line":"        return self._call(\"get_filesystem_stats\", AGENT_LOW_TIMEOUT,"},{"line_number":273,"context_line":"                          fs_path\u003dNone)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def update_guest(self):"},{"line_number":276,"context_line":"        \"\"\"Make a synchronous call to update the guest agent.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F8cA%3D","line":273,"in_reply_to":"AAAAVX%2F%2F%2BQU%3D","updated":"2014-02-27 08:12:22.000000000","message":"yes, its still mentioned to avoid breaking API contract between guest and api/tm","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"}],"trove/guestagent/backup/backupagent.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba8c4d9097772157ef99f010abfa55cc6c6a601a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            })"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # Store the size of the filesystem before the backup."},{"line_number":89,"context_line":"        mount_point \u003d CONF.get(\u0027mysql\u0027 if not CONF.datastore_manager"},{"line_number":90,"context_line":"                               else CONF.datastore_manager).mount_point"},{"line_number":91,"context_line":"        stats \u003d get_filesystem_volume_stats(mount_point)"},{"line_number":92,"context_line":"        backup \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F%2BQs%3D","line":89,"updated":"2014-02-27 03:24:08.000000000","message":"given that mount_point is being correctly defaulted in cfg.py for every datastore, i don\u0027t see why this overly cautious checking is necessary?\n\nre-worded: if this logic is run, that means cfg.py has mount_point for every datastore (because both changes are in the same patch-set, i.e. this one), which means you can\u0027t possibly need to default to \u0027mysql\u0027.\n\nam i missing something?","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"e2556190958cb02073b9653f8ccc158dd30e4e1b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            })"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # Store the size of the filesystem before the backup."},{"line_number":89,"context_line":"        mount_point \u003d CONF.get(\u0027mysql\u0027 if not CONF.datastore_manager"},{"line_number":90,"context_line":"                               else CONF.datastore_manager).mount_point"},{"line_number":91,"context_line":"        stats \u003d get_filesystem_volume_stats(mount_point)"},{"line_number":92,"context_line":"        backup \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F8Zc%3D","line":89,"in_reply_to":"AAAAVX%2F%2F%2BQs%3D","updated":"2014-02-27 08:12:22.000000000","message":"since backupagent is generic method, it should have generic logic for retrieving mount point.\n\nThis check is performed because default manager is mentioned as None in cfg.py. Basically it lets tests not to be broken.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"1ecabffd57d5b9a0b381d0ddeda2246b0757dbe4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"CONF \u003d cfg.CONF"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"MANAGER \u003d CONF.datastore_manager"},{"line_number":35,"context_line":"# If datastore manager is not mentioned in guest"},{"line_number":36,"context_line":"# configuration file, would be used mysql as datastore_manager by the default"},{"line_number":37,"context_line":"STRATEGY \u003d CONF.get(\u0027mysql\u0027 if not MANAGER else MANAGER).backup_strategy"},{"line_number":38,"context_line":"NAMESPACE \u003d CONF.backup_namespace"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVX%2F%2F3L0%3D","line":35,"updated":"2014-02-27 18:41:24.000000000","message":"a slight grammar fix:\n\n\"would be used mysql as datastore_manager by the default\"\n\nshould be:\n\n\"mysql is used as the datastore_manager by default\"","commit_id":"d6c762a2ff66464f5f9e321d07e439b24cc4bf50"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"3af9f612ad60828370095ef164a01b2f47dd10a2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"CONF \u003d cfg.CONF"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"MANAGER \u003d CONF.datastore_manager"},{"line_number":35,"context_line":"# If datastore manager is not mentioned in guest"},{"line_number":36,"context_line":"# configuration file, would be used mysql as datastore_manager by the default"},{"line_number":37,"context_line":"STRATEGY \u003d CONF.get(\u0027mysql\u0027 if not MANAGER else MANAGER).backup_strategy"},{"line_number":38,"context_line":"NAMESPACE \u003d CONF.backup_namespace"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVX%2F%2F18o%3D","line":35,"in_reply_to":"AAAAVX%2F%2F3L0%3D","updated":"2014-02-27 22:05:31.000000000","message":"denis can\u0027t modify this for a day or so, so since it\u0027s aesthetic only, it\u0027s fine for now (considering the flood of interdependent patches we need to land)","commit_id":"d6c762a2ff66464f5f9e321d07e439b24cc4bf50"}],"trove/guestagent/datastore/cassandra/manager.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba8c4d9097772157ef99f010abfa55cc6c6a601a","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def get_filesystem_stats(self, context, fs_path):"},{"line_number":50,"context_line":"        \"\"\"Gets the filesystem stats for the path given. \"\"\""},{"line_number":51,"context_line":"        mount_point \u003d CONF.get("},{"line_number":52,"context_line":"            \u0027mysql\u0027 if not MANAGER else MANAGER).mount_point"},{"line_number":53,"context_line":"        return dbaas.get_filesystem_volume_stats(mount_point)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F%2BSg%3D","line":51,"updated":"2014-02-27 03:24:08.000000000","message":"given that mount_point is being correctly defaulted in cfg.py for every datastore, i don\u0027t see why this overly cautious checking is necessary?\n\nre-worded: if this logic is run, that means cfg.py has mount_point for every datastore (because both changes are in the same patch-set, i.e. this one), which means you can\u0027t possibly need to default to \u0027mysql\u0027.\n\nam i missing something?","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"e2556190958cb02073b9653f8ccc158dd30e4e1b","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def get_filesystem_stats(self, context, fs_path):"},{"line_number":50,"context_line":"        \"\"\"Gets the filesystem stats for the path given. \"\"\""},{"line_number":51,"context_line":"        mount_point \u003d CONF.get("},{"line_number":52,"context_line":"            \u0027mysql\u0027 if not MANAGER else MANAGER).mount_point"},{"line_number":53,"context_line":"        return dbaas.get_filesystem_volume_stats(mount_point)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F8Yc%3D","line":51,"in_reply_to":"AAAAVX%2F%2F%2BSg%3D","updated":"2014-02-27 08:12:22.000000000","message":"Yes, i thought about making more clean config value retrieving, but i did it in this way to show that this method is common to each datastore manager, it will be easier to extract them into guest manager mixing class.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba8c4d9097772157ef99f010abfa55cc6c6a601a","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def reset_configuration(self, context, configuration):"},{"line_number":62,"context_line":"        self.app.reset_configuration(configuration)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":65,"context_line":"                device_path\u003dNone, mount_point\u003dNone, backup_info\u003dNone,"},{"line_number":66,"context_line":"                config_contents\u003dNone, root_password\u003dNone, overrides\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F%2BO8%3D","line":63,"updated":"2014-02-27 03:24:08.000000000","message":"it doesn\u0027t make much sense that the mount_point is defined in trove api/tm, is passed in the prepare(), and not stored anywhere for later consultation. why should subsequent operations in the guest (like get_filesystem_stats above) rely on the trove-guestagent.conf/cfg.py, when it should rely on the originating value received in the prepare()? it\u0027s quite possible the mount_path in prepare() accidentally drifts from the value in cfg.py/trove-guestagent.conf.\n\ndoesn\u0027t it make more sense in the long run to (1) include mount_point in /etc/guest_info and use that as the source of truth for all guest operations and (2) remove mount_point from prepare()?\n\nthat, or take the mount_path in prepare() and persist it somewhere for later consultation (and then consult that)?","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"e2556190958cb02073b9653f8ccc158dd30e4e1b","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def reset_configuration(self, context, configuration):"},{"line_number":62,"context_line":"        self.app.reset_configuration(configuration)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":65,"context_line":"                device_path\u003dNone, mount_point\u003dNone, backup_info\u003dNone,"},{"line_number":66,"context_line":"                config_contents\u003dNone, root_password\u003dNone, overrides\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F8XI%3D","line":63,"in_reply_to":"AAAAVX%2F%2F%2BO8%3D","updated":"2014-02-27 08:12:22.000000000","message":"Since we are not able to break API contract mount point should come through parameters in prepare call. And this type of chages deserves huge discussion with all team. Until that it\u0027ll be like i did it here.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"3e40990d2665108266faec8f8afba04922551be3","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def reset_configuration(self, context, configuration):"},{"line_number":62,"context_line":"        self.app.reset_configuration(configuration)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":65,"context_line":"                device_path\u003dNone, mount_point\u003dNone, backup_info\u003dNone,"},{"line_number":66,"context_line":"                config_contents\u003dNone, root_password\u003dNone, overrides\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F8QM%3D","line":63,"in_reply_to":"AAAAVX%2F%2F8XI%3D","updated":"2014-02-27 08:23:50.000000000","message":"i agree we can\u0027t change it *right* now, hence the \"long-term\" reference; i just wanted to \"air things out in the open\" for others who are also reading this review, so that we\u0027re all on the same page when future discussions occur.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"}],"trove/guestagent/datastore/cassandra/system.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba8c4d9097772157ef99f010abfa55cc6c6a601a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"CASSANDRA_TEMP_CONF \u003d \"/tmp/cassandra.yaml\""},{"line_number":25,"context_line":"CASSANDRA_TEMP_DIR \u003d \"/tmp/cassandra\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"INIT_FS \u003d \"sudo mkdir -p /var/lib/cassandra\""},{"line_number":28,"context_line":"ENABLE_CASSANDRA_ON_BOOT \u003d \"sudo update-rc.d cassandra enable\""},{"line_number":29,"context_line":"DISABLE_CASSANDRA_ON_BOOT \u003d \"sudo update-rc.d cassandra disable\""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F%2BSU%3D","line":27,"updated":"2014-02-27 03:24:08.000000000","message":"now that the mount_point parameter in prepare() is meaningful and used (vs. being thrown away), the actual value of mount_point should be used here vs. you hardcoding it.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"e2556190958cb02073b9653f8ccc158dd30e4e1b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"CASSANDRA_TEMP_CONF \u003d \"/tmp/cassandra.yaml\""},{"line_number":25,"context_line":"CASSANDRA_TEMP_DIR \u003d \"/tmp/cassandra\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"INIT_FS \u003d \"sudo mkdir -p /var/lib/cassandra\""},{"line_number":28,"context_line":"ENABLE_CASSANDRA_ON_BOOT \u003d \"sudo update-rc.d cassandra enable\""},{"line_number":29,"context_line":"DISABLE_CASSANDRA_ON_BOOT \u003d \"sudo update-rc.d cassandra disable\""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F8Ww%3D","line":27,"in_reply_to":"AAAAVX%2F%2F%2BSU%3D","updated":"2014-02-27 08:12:22.000000000","message":"agreed","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"}],"trove/guestagent/datastore/mysql/manager.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba8c4d9097772157ef99f010abfa55cc6c6a601a","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def get_filesystem_stats(self, context, fs_path):"},{"line_number":165,"context_line":"        \"\"\"Gets the filesystem stats for the path given. \"\"\""},{"line_number":166,"context_line":"        mount_point \u003d CONF.get("},{"line_number":167,"context_line":"            \u0027mysql\u0027 if not MANAGER else MANAGER).mount_point"},{"line_number":168,"context_line":"        return dbaas.get_filesystem_volume_stats(mount_point)"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F%2BSQ%3D","line":166,"updated":"2014-02-27 03:24:08.000000000","message":"given that mount_point is being correctly defaulted in cfg.py for every datastore, i don\u0027t see why this overly cautious checking is necessary?\n\nre-worded: if this logic is run, that means cfg.py has mount_point for every datastore (because both changes are in the same patch-set, i.e. this one), which means you can\u0027t possibly need to default to \u0027mysql\u0027.\n\nam i missing something?","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"e2556190958cb02073b9653f8ccc158dd30e4e1b","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def get_filesystem_stats(self, context, fs_path):"},{"line_number":165,"context_line":"        \"\"\"Gets the filesystem stats for the path given. \"\"\""},{"line_number":166,"context_line":"        mount_point \u003d CONF.get("},{"line_number":167,"context_line":"            \u0027mysql\u0027 if not MANAGER else MANAGER).mount_point"},{"line_number":168,"context_line":"        return dbaas.get_filesystem_volume_stats(mount_point)"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F8Wo%3D","line":166,"in_reply_to":"AAAAVX%2F%2F%2BSQ%3D","updated":"2014-02-27 08:12:22.000000000","message":"Yes, i thought about making more clean config value retrieving, but i did it in this way to show that this method is common to each datastore manager, it will be easier to extract them into guest manager mixing class.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"}],"trove/guestagent/datastore/redis/manager.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ba8c4d9097772157ef99f010abfa55cc6c6a601a","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def get_filesystem_stats(self, context, fs_path):"},{"line_number":114,"context_line":"        \"\"\"Gets the filesystem stats for the path given. \"\"\""},{"line_number":115,"context_line":"        mount_point \u003d CONF.get("},{"line_number":116,"context_line":"            \u0027mysql\u0027 if not MANAGER else MANAGER).mount_point"},{"line_number":117,"context_line":"        return dbaas.get_filesystem_volume_stats(mount_point)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def create_backup(self, context, backup_info):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F%2BSM%3D","line":116,"updated":"2014-02-27 03:24:08.000000000","message":"given that mount_point is being correctly defaulted in cfg.py for every datastore, i don\u0027t see why this overly cautious checking is necessary?\n\nre-worded: if this logic is run, that means cfg.py has mount_point for every datastore (because both changes are in the same patch-set, i.e. this one), which means you can\u0027t possibly need to default to \u0027mysql\u0027.\n\nam i missing something?","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"e2556190958cb02073b9653f8ccc158dd30e4e1b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def get_filesystem_stats(self, context, fs_path):"},{"line_number":114,"context_line":"        \"\"\"Gets the filesystem stats for the path given. \"\"\""},{"line_number":115,"context_line":"        mount_point \u003d CONF.get("},{"line_number":116,"context_line":"            \u0027mysql\u0027 if not MANAGER else MANAGER).mount_point"},{"line_number":117,"context_line":"        return dbaas.get_filesystem_volume_stats(mount_point)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def create_backup(self, context, backup_info):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F8Wk%3D","line":116,"in_reply_to":"AAAAVX%2F%2F%2BSM%3D","updated":"2014-02-27 08:12:22.000000000","message":"Yes, i thought about making more clean config value retrieving, but i did it in this way to show that this method is common to each datastore manager, it will be easier to extract them into guest manager mixing class.","commit_id":"a20c3511d86c9e5b6e4c719b8bafa46c8800237f"}]}
