)]}'
{"trove/instance/models.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"85630a0c3e45532b4fc6fe9a956de8818e4fd5e2","unresolved":false,"context_lines":[{"line_number":1530,"context_line":"        # cases where action cannot be performed"},{"line_number":1531,"context_line":"        status_type \u003d \u0027instance\u0027"},{"line_number":1532,"context_line":"        if (self.db_info.server_status not in [\u0027ACTIVE\u0027, \u0027HEALTHY\u0027] and"},{"line_number":1533,"context_line":"            action not in \u0027eject_replica_source\u0027):"},{"line_number":1534,"context_line":"            status \u003d self.db_info.server_status"},{"line_number":1535,"context_line":"        elif (self.db_info.task_status !\u003d InstanceTasks.NONE and"},{"line_number":1536,"context_line":"              self.db_info.task_status !\u003d InstanceTasks.RESTART_REQUIRED):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_cdc40843","line":1533,"updated":"2020-11-12 21:44:40.000000000","message":"I am wondering if the action is eject_replica_source and the task status of the existing primary is not NONE, or the primary is doing backup, does that affect the ejection?","commit_id":"e6b5f47102d59282cc847bf18980393e183106c4"},{"author":{"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"},"change_message_id":"1fb3b674fea0692ab1695309215224806eefa704","unresolved":false,"context_lines":[{"line_number":1530,"context_line":"        # cases where action cannot be performed"},{"line_number":1531,"context_line":"        status_type \u003d \u0027instance\u0027"},{"line_number":1532,"context_line":"        if (self.db_info.server_status not in [\u0027ACTIVE\u0027, \u0027HEALTHY\u0027] and"},{"line_number":1533,"context_line":"            action not in \u0027eject_replica_source\u0027):"},{"line_number":1534,"context_line":"            status \u003d self.db_info.server_status"},{"line_number":1535,"context_line":"        elif (self.db_info.task_status !\u003d InstanceTasks.NONE and"},{"line_number":1536,"context_line":"              self.db_info.task_status !\u003d InstanceTasks.RESTART_REQUIRED):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_328b4268","line":1533,"in_reply_to":"1f621f24_5024fb5d","updated":"2020-11-16 04:06:04.000000000","message":"Oh, I understand. I was fixed it. Please review for me. Thanks!","commit_id":"e6b5f47102d59282cc847bf18980393e183106c4"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"4d347ad432da4efe2a8e79f247a5d3453117d128","unresolved":false,"context_lines":[{"line_number":1530,"context_line":"        # cases where action cannot be performed"},{"line_number":1531,"context_line":"        status_type \u003d \u0027instance\u0027"},{"line_number":1532,"context_line":"        if (self.db_info.server_status not in [\u0027ACTIVE\u0027, \u0027HEALTHY\u0027] and"},{"line_number":1533,"context_line":"            action not in \u0027eject_replica_source\u0027):"},{"line_number":1534,"context_line":"            status \u003d self.db_info.server_status"},{"line_number":1535,"context_line":"        elif (self.db_info.task_status !\u003d InstanceTasks.NONE and"},{"line_number":1536,"context_line":"              self.db_info.task_status !\u003d InstanceTasks.RESTART_REQUIRED):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_5024fb5d","line":1533,"in_reply_to":"1f621f24_5e0d3c8e","updated":"2020-11-14 21:43:00.000000000","message":"What I am saying is, should we consider allowing ejection even if the task status of the primary is not None or the primary is doing backup?","commit_id":"e6b5f47102d59282cc847bf18980393e183106c4"},{"author":{"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"},"change_message_id":"cccc850429263f50aeba08c9351cd22814f9f615","unresolved":false,"context_lines":[{"line_number":1530,"context_line":"        # cases where action cannot be performed"},{"line_number":1531,"context_line":"        status_type \u003d \u0027instance\u0027"},{"line_number":1532,"context_line":"        if (self.db_info.server_status not in [\u0027ACTIVE\u0027, \u0027HEALTHY\u0027] and"},{"line_number":1533,"context_line":"            action not in \u0027eject_replica_source\u0027):"},{"line_number":1534,"context_line":"            status \u003d self.db_info.server_status"},{"line_number":1535,"context_line":"        elif (self.db_info.task_status !\u003d InstanceTasks.NONE and"},{"line_number":1536,"context_line":"              self.db_info.task_status !\u003d InstanceTasks.RESTART_REQUIRED):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_5e0d3c8e","line":1533,"in_reply_to":"1f621f24_cdc40843","updated":"2020-11-13 02:33:05.000000000","message":"If task_status of the existing primary is not None, it hit the condition line 1535 and if primary is doing backup, it hit condition line 1541. I don\u0027t see it affecting allow eject  even if server_status in nova is not ACTIVE","commit_id":"e6b5f47102d59282cc847bf18980393e183106c4"}]}