)]}'
{"trove/common/neutron.py":[{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"d2b3489bc2ece30e2edf8ff89cec4f25abfd547e","unresolved":true,"context_lines":[{"line_number":30,"context_line":"def check_extension_enabled(client, extension_alias):"},{"line_number":31,"context_line":"    \"\"\"Check if an extension is enabled in Neutron.\"\"\""},{"line_number":32,"context_line":"    global NEUTRON_EXTENSION_CACHE"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    if extension_alias in NEUTRON_EXTENSION_CACHE:"},{"line_number":35,"context_line":"        status \u003d NEUTRON_EXTENSION_CACHE[extension_alias]"},{"line_number":36,"context_line":"        LOG.debug(f\"Neutron extension {extension_alias} cached as \""}],"source_content_type":"text/x-python","patch_set":1,"id":"2cf20861_a1c63243","line":33,"updated":"2020-12-03 23:27:48.000000000","message":"The logic here would mean if the extension didn\u0027t exist then it would keep trying to request to see if it existed as opposed to using the cache. Is that intended?\n\nMaybe setting the cache to None then check if cache is None and if so refresh the cache, then check to see if the extension is in there?","commit_id":"5d19f8e40a90bd2381b683ac5959f73d3377557f"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"81485bdab45220208a120a3673e5eb7ef2303208","unresolved":true,"context_lines":[{"line_number":30,"context_line":"def check_extension_enabled(client, extension_alias):"},{"line_number":31,"context_line":"    \"\"\"Check if an extension is enabled in Neutron.\"\"\""},{"line_number":32,"context_line":"    global NEUTRON_EXTENSION_CACHE"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    if extension_alias in NEUTRON_EXTENSION_CACHE:"},{"line_number":35,"context_line":"        status \u003d NEUTRON_EXTENSION_CACHE[extension_alias]"},{"line_number":36,"context_line":"        LOG.debug(f\"Neutron extension {extension_alias} cached as \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9c64798e_060c1c20","line":33,"in_reply_to":"137f79fb_8db4ba56","updated":"2020-12-06 23:35:50.000000000","message":"Ah yes, good point","commit_id":"5d19f8e40a90bd2381b683ac5959f73d3377557f"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"b2d196051b9c7af523b4b34976426faf1e4ce2d0","unresolved":true,"context_lines":[{"line_number":30,"context_line":"def check_extension_enabled(client, extension_alias):"},{"line_number":31,"context_line":"    \"\"\"Check if an extension is enabled in Neutron.\"\"\""},{"line_number":32,"context_line":"    global NEUTRON_EXTENSION_CACHE"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    if extension_alias in NEUTRON_EXTENSION_CACHE:"},{"line_number":35,"context_line":"        status \u003d NEUTRON_EXTENSION_CACHE[extension_alias]"},{"line_number":36,"context_line":"        LOG.debug(f\"Neutron extension {extension_alias} cached as \""}],"source_content_type":"text/x-python","patch_set":1,"id":"773c7f83_69cd6a8f","line":33,"in_reply_to":"2cf20861_a1c63243","updated":"2020-12-04 22:29:10.000000000","message":"Good idea.","commit_id":"5d19f8e40a90bd2381b683ac5959f73d3377557f"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"b8213b27ba25892b977454fcd8649e6301aab9b8","unresolved":true,"context_lines":[{"line_number":30,"context_line":"def check_extension_enabled(client, extension_alias):"},{"line_number":31,"context_line":"    \"\"\"Check if an extension is enabled in Neutron.\"\"\""},{"line_number":32,"context_line":"    global NEUTRON_EXTENSION_CACHE"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    if extension_alias in NEUTRON_EXTENSION_CACHE:"},{"line_number":35,"context_line":"        status \u003d NEUTRON_EXTENSION_CACHE[extension_alias]"},{"line_number":36,"context_line":"        LOG.debug(f\"Neutron extension {extension_alias} cached as \""}],"source_content_type":"text/x-python","patch_set":1,"id":"137f79fb_8db4ba56","line":33,"in_reply_to":"773c7f83_69cd6a8f","updated":"2020-12-04 22:32:56.000000000","message":"Wait, if extension is not enabled, its value is set to False in Line45, trove won\u0027t send request next time.","commit_id":"5d19f8e40a90bd2381b683ac5959f73d3377557f"}]}
