)]}'
{"trove/guestagent/strategies/restore/base.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"129b69523ae704145291a4c79c2593520e074f9e","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            self.process.stdin.write(chunk)"},{"line_number":119,"context_line":"            content_length +\u003d len(chunk)"},{"line_number":120,"context_line":"        self.process.stdin.close()"},{"line_number":121,"context_line":"        self.process.wait()"},{"line_number":122,"context_line":"        LOG.info(_(\"Restored %s bytes from stream.\") % content_length)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        return content_length"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2F9d8%3D","line":121,"updated":"2014-02-27 05:58:15.000000000","message":"from http://docs.python.org/2/library/subprocess.html#subprocess.Popen.wait\n\n\"This will deadlock when using stdout\u003dPIPE and/or stderr\u003dPIPE and the child process generates enough output to a pipe such that it blocks waiting for the OS pipe buffer to accept more data. Use communicate() to avoid that.\"\n\nthat warning gives me pause.","commit_id":"b9e5341962644d0a2d4f24383d264af20551a43f"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"50d2505c3109b431031ef03706dd8b342fef5b55","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            self.process.stdin.write(chunk)"},{"line_number":119,"context_line":"            content_length +\u003d len(chunk)"},{"line_number":120,"context_line":"        self.process.stdin.close()"},{"line_number":121,"context_line":"        self.process.wait()"},{"line_number":122,"context_line":"        LOG.info(_(\"Restored %s bytes from stream.\") % content_length)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        return content_length"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2F89M%3D","line":121,"in_reply_to":"AAAAVX%2F%2F9d8%3D","updated":"2014-02-27 06:55:27.000000000","message":"I saw this and it scared me too. I mentioned it to Robert. But we didnt think too much of it. Ill go ahead and use communicate() instead just to be safe","commit_id":"b9e5341962644d0a2d4f24383d264af20551a43f"}]}