)]}'
{"trove/templates/percona/config.template":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"f4dda6c91789fc7366ff55d512b09063d6ee7e0b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"####tmpdir \u003d /tmp"},{"line_number":13,"context_line":"tmpdir \u003d /var/tmp"},{"line_number":14,"context_line":"pid_file \u003d /var/run/mysqld/mysqld.pid"},{"line_number":15,"context_line":"skip-external-locking \u003d 1"},{"line_number":16,"context_line":"key_buffer_size \u003d {{ 50 * flavor[\u0027ram\u0027]//512 }}M"},{"line_number":17,"context_line":"max_allowed_packet \u003d {{ 1 * flavor[\u0027ram\u0027]//512 }}M"},{"line_number":18,"context_line":"thread_stack \u003d 192K"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAVX%2F%2F9Rw%3D","line":15,"updated":"2014-02-27 06:08:01.000000000","message":"is the \"\u003d 1\" incompatible with mysql for these 3? if not, why not just move these over there and we avoid the need to fork percona into a new template.","commit_id":"e1b9fc54145fe5100125521f3e487b20ee87ee71"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"05dbf000b90b41af730d1354e9802b3ab4c37e18","unresolved":false,"context_lines":[{"line_number":12,"context_line":"####tmpdir \u003d /tmp"},{"line_number":13,"context_line":"tmpdir \u003d /var/tmp"},{"line_number":14,"context_line":"pid_file \u003d /var/run/mysqld/mysqld.pid"},{"line_number":15,"context_line":"skip-external-locking \u003d 1"},{"line_number":16,"context_line":"key_buffer_size \u003d {{ 50 * flavor[\u0027ram\u0027]//512 }}M"},{"line_number":17,"context_line":"max_allowed_packet \u003d {{ 1 * flavor[\u0027ram\u0027]//512 }}M"},{"line_number":18,"context_line":"thread_stack \u003d 192K"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAVX%2F%2F87I%3D","line":15,"in_reply_to":"AAAAVX%2F%2F8%2BI%3D","updated":"2014-02-27 06:58:14.000000000","message":"right, my question is: if templates/mysql/config.template is changed to have \"skip-external-locking \u003d 1\" vs. \"skip-external-locking\", will mysql still accept it?\n\nif so, and if that\u0027s true for the two [mysqldump] options below, then my question is why not continue to use a single config.template for both of them? that is unless, you\u0027ve also changed the validation-rules.json for percona to be slightly different also?","commit_id":"e1b9fc54145fe5100125521f3e487b20ee87ee71"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"a810e1daea943c7af003e21aa0f2afb2c9ac2079","unresolved":false,"context_lines":[{"line_number":12,"context_line":"####tmpdir \u003d /tmp"},{"line_number":13,"context_line":"tmpdir \u003d /var/tmp"},{"line_number":14,"context_line":"pid_file \u003d /var/run/mysqld/mysqld.pid"},{"line_number":15,"context_line":"skip-external-locking \u003d 1"},{"line_number":16,"context_line":"key_buffer_size \u003d {{ 50 * flavor[\u0027ram\u0027]//512 }}M"},{"line_number":17,"context_line":"max_allowed_packet \u003d {{ 1 * flavor[\u0027ram\u0027]//512 }}M"},{"line_number":18,"context_line":"thread_stack \u003d 192K"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAVX%2F%2F82M%3D","line":15,"in_reply_to":"AAAAVX%2F%2F83I%3D","updated":"2014-02-27 07:12:12.000000000","message":"i\u0027m not sure what i was looking at, but you\u0027re right. i swear i saw just \"skip-external-locking\" vs. \"skip-external-locking \u003d 1\" for templates/mysql/config.template; i blame my sleepyness ;)\n\nto answer your second question: if your percona datastore-version had the manager as \u0027mysql\u0027, then it would work. but, since we already have them split, that\u0027s probably a bigger and more controversial decision.","commit_id":"e1b9fc54145fe5100125521f3e487b20ee87ee71"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"f58325cee2484c485898f612b1f7f6c303245ed7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"####tmpdir \u003d /tmp"},{"line_number":13,"context_line":"tmpdir \u003d /var/tmp"},{"line_number":14,"context_line":"pid_file \u003d /var/run/mysqld/mysqld.pid"},{"line_number":15,"context_line":"skip-external-locking \u003d 1"},{"line_number":16,"context_line":"key_buffer_size \u003d {{ 50 * flavor[\u0027ram\u0027]//512 }}M"},{"line_number":17,"context_line":"max_allowed_packet \u003d {{ 1 * flavor[\u0027ram\u0027]//512 }}M"},{"line_number":18,"context_line":"thread_stack \u003d 192K"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAVX%2F%2F83I%3D","line":15,"in_reply_to":"AAAAVX%2F%2F87I%3D","updated":"2014-02-27 07:04:52.000000000","message":"yes mysql will accept it. In fact, in mysql, it already has \u0027skip-external-locking \u003d 1\u0027. \nHow can we use a single template for both if they are different datastores? Trove will look in templates/{datastore} for its templates. So we need to have a copy in the template/percona because that is where trove will look for it. Or is there a way?","commit_id":"e1b9fc54145fe5100125521f3e487b20ee87ee71"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"7e7541cea3f658a271a0c80c428ab652cc201659","unresolved":false,"context_lines":[{"line_number":12,"context_line":"####tmpdir \u003d /tmp"},{"line_number":13,"context_line":"tmpdir \u003d /var/tmp"},{"line_number":14,"context_line":"pid_file \u003d /var/run/mysqld/mysqld.pid"},{"line_number":15,"context_line":"skip-external-locking \u003d 1"},{"line_number":16,"context_line":"key_buffer_size \u003d {{ 50 * flavor[\u0027ram\u0027]//512 }}M"},{"line_number":17,"context_line":"max_allowed_packet \u003d {{ 1 * flavor[\u0027ram\u0027]//512 }}M"},{"line_number":18,"context_line":"thread_stack \u003d 192K"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAVX%2F%2F8%2BI%3D","line":15,"in_reply_to":"AAAAVX%2F%2F9Rw%3D","updated":"2014-02-27 06:54:07.000000000","message":"Actually with these additions, this template is now identical to the one in mysql. But dont they need to be forked into a new template for percona, since percona is a diferent datastore and trove will look in the templates/percona for its templates.","commit_id":"e1b9fc54145fe5100125521f3e487b20ee87ee71"}]}
