)]}'
{"trove/instance/models.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"eefbfc09454ba9c3de28aa7f40a571f2cb92daa9","unresolved":true,"context_lines":[{"line_number":1684,"context_line":"            # Check the configuration template has defaults for all modified"},{"line_number":1685,"context_line":"            # values."},{"line_number":1686,"context_line":"            has_defaults_for_all \u003d all(key in default_config.keys()"},{"line_number":1687,"context_line":"                                       for key in current_overrides.keys())"},{"line_number":1688,"context_line":"            if (not current_config.does_configuration_need_restart() and"},{"line_number":1689,"context_line":"                    has_defaults_for_all):"},{"line_number":1690,"context_line":"                LOG.debug(\"Applying runtime configuration changes.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"c86815ca_9b76a466","side":"PARENT","line":1687,"updated":"2021-01-14 17:41:53.000000000","message":"This makes sure after removing custom configs, the database could set a default value explicitly, why it\u0027s removed?","commit_id":"7cb6e06bc154a3ff96dc4bdbec46f2a80479af7d"},{"author":{"_account_id":32324,"name":"zhangjunhui","email":"zhangjunhui@yovole.com","username":"zhangjunhui"},"change_message_id":"2b027541bce3ecaca47ac2d4fcccb314599b80fd","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"            # Check the configuration template has defaults for all modified"},{"line_number":1685,"context_line":"            # values."},{"line_number":1686,"context_line":"            has_defaults_for_all \u003d all(key in default_config.keys()"},{"line_number":1687,"context_line":"                                       for key in current_overrides.keys())"},{"line_number":1688,"context_line":"            if (not current_config.does_configuration_need_restart() and"},{"line_number":1689,"context_line":"                    has_defaults_for_all):"},{"line_number":1690,"context_line":"                LOG.debug(\"Applying runtime configuration changes.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"b668fcff_225a2d7c","side":"PARENT","line":1687,"in_reply_to":"22cc599a_ab1f0519","updated":"2021-01-19 02:35:38.000000000","message":"I think \"has_defaults_for_all is True when the keys in current_overrides are also defined in default_config.\" is the same mean as \"has_defaults_for_all is True when there are configuration items in default_config but not in current_overrides\".\nIn my case, the configurations items in default_config is more than items in current_overrides,   then if I detach a configuration, it is always set instance status to RESTART_REQUIRED. but in some datastore such as redis, restart instance will cause data loss, or need many time to persistent to disk, and reload it again to memory.\nWhen I see these codes in here, I think it must have a reason, maybe other datastores need them  , and I just don\u0027t know.\nSo if it has other issues, please let me know, I will try to solve them.\nAnyway, thinks a lot for your time to review my code.","commit_id":"7cb6e06bc154a3ff96dc4bdbec46f2a80479af7d"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"6c56904b2333714285095394d6e416c5a9ac771e","unresolved":true,"context_lines":[{"line_number":1684,"context_line":"            # Check the configuration template has defaults for all modified"},{"line_number":1685,"context_line":"            # values."},{"line_number":1686,"context_line":"            has_defaults_for_all \u003d all(key in default_config.keys()"},{"line_number":1687,"context_line":"                                       for key in current_overrides.keys())"},{"line_number":1688,"context_line":"            if (not current_config.does_configuration_need_restart() and"},{"line_number":1689,"context_line":"                    has_defaults_for_all):"},{"line_number":1690,"context_line":"                LOG.debug(\"Applying runtime configuration changes.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"22cc599a_ab1f0519","side":"PARENT","line":1687,"in_reply_to":"96ff305b_5dd86db6","updated":"2021-01-18 21:20:05.000000000","message":"`has_defaults_for_all is True when there are configuration items in default_config but not in current_overrides`, this is incorrect. has_defaults_for_all is True when the keys in current_overrides are also defined in default_config.","commit_id":"7cb6e06bc154a3ff96dc4bdbec46f2a80479af7d"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"8eff414ce4266e8bd4e7bf5f838ae441bb63c2f5","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"            # Check the configuration template has defaults for all modified"},{"line_number":1685,"context_line":"            # values."},{"line_number":1686,"context_line":"            has_defaults_for_all \u003d all(key in default_config.keys()"},{"line_number":1687,"context_line":"                                       for key in current_overrides.keys())"},{"line_number":1688,"context_line":"            if (not current_config.does_configuration_need_restart() and"},{"line_number":1689,"context_line":"                    has_defaults_for_all):"},{"line_number":1690,"context_line":"                LOG.debug(\"Applying runtime configuration changes.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"144986c5_43992a26","side":"PARENT","line":1687,"in_reply_to":"a8d03f26_22d9c393","updated":"2021-01-19 09:55:36.000000000","message":"Let\u0027s move the discussion to storyboard.","commit_id":"7cb6e06bc154a3ff96dc4bdbec46f2a80479af7d"},{"author":{"_account_id":32324,"name":"zhangjunhui","email":"zhangjunhui@yovole.com","username":"zhangjunhui"},"change_message_id":"f3f8fcbad1a4b8ac3d161fae964496142c3bc37f","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"            # Check the configuration template has defaults for all modified"},{"line_number":1685,"context_line":"            # values."},{"line_number":1686,"context_line":"            has_defaults_for_all \u003d all(key in default_config.keys()"},{"line_number":1687,"context_line":"                                       for key in current_overrides.keys())"},{"line_number":1688,"context_line":"            if (not current_config.does_configuration_need_restart() and"},{"line_number":1689,"context_line":"                    has_defaults_for_all):"},{"line_number":1690,"context_line":"                LOG.debug(\"Applying runtime configuration changes.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"a8d03f26_22d9c393","side":"PARENT","line":1687,"in_reply_to":"b668fcff_225a2d7c","updated":"2021-01-19 02:42:45.000000000","message":"\"has_defaults_for_all is \u0027False\u0027 when the keys in current_overrides are also defined in default_config.\" is the same mean as \"has_defaults_for_all is True when there are configuration items in default_config but not in current_overrides\"\nhas_defaults_for_all\u003dFalse -\u003e RESTART_REQUIRED, I think this is my key polint 😊","commit_id":"7cb6e06bc154a3ff96dc4bdbec46f2a80479af7d"},{"author":{"_account_id":32324,"name":"zhangjunhui","email":"zhangjunhui@yovole.com","username":"zhangjunhui"},"change_message_id":"ba87048f7c8fe6b7e649d4c7560c35e0fa6a9e72","unresolved":true,"context_lines":[{"line_number":1684,"context_line":"            # Check the configuration template has defaults for all modified"},{"line_number":1685,"context_line":"            # values."},{"line_number":1686,"context_line":"            has_defaults_for_all \u003d all(key in default_config.keys()"},{"line_number":1687,"context_line":"                                       for key in current_overrides.keys())"},{"line_number":1688,"context_line":"            if (not current_config.does_configuration_need_restart() and"},{"line_number":1689,"context_line":"                    has_defaults_for_all):"},{"line_number":1690,"context_line":"                LOG.debug(\"Applying runtime configuration changes.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"d7b0e03c_257b0b4d","side":"PARENT","line":1687,"in_reply_to":"c86815ca_9b76a466","updated":"2021-01-15 01:10:40.000000000","message":"has_defaults_for_all is True when there are configuration items in default_config but not in current_overrides. In detach case, tove removes configurations in current_overrides, those configurations in the list of has_defaults_for_all don\u0027t change at all, if don\u0027t change then why set instace\u0027s status to RESTART_REQUIRED?","commit_id":"7cb6e06bc154a3ff96dc4bdbec46f2a80479af7d"},{"author":{"_account_id":32324,"name":"zhangjunhui","email":"zhangjunhui@yovole.com","username":"zhangjunhui"},"change_message_id":"bd3c9fed01be4f613d6f2d41e968249e0099199e","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"            # Check the configuration template has defaults for all modified"},{"line_number":1685,"context_line":"            # values."},{"line_number":1686,"context_line":"            has_defaults_for_all \u003d all(key in default_config.keys()"},{"line_number":1687,"context_line":"                                       for key in current_overrides.keys())"},{"line_number":1688,"context_line":"            if (not current_config.does_configuration_need_restart() and"},{"line_number":1689,"context_line":"                    has_defaults_for_all):"},{"line_number":1690,"context_line":"                LOG.debug(\"Applying runtime configuration changes.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"96ff305b_5dd86db6","side":"PARENT","line":1687,"in_reply_to":"d7b0e03c_257b0b4d","updated":"2021-01-18 11:38:38.000000000","message":"Ack","commit_id":"7cb6e06bc154a3ff96dc4bdbec46f2a80479af7d"}]}