)]}'
{"trove/tests/unittests/backup/test_backupagent.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"d181904c1bc7a85c1c6f5eb6c8cfa38f32b51afc","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            \u0027parent_checksum\u0027: \u0027md5\u0027,"},{"line_number":370,"context_line":"        }"},{"line_number":371,"context_line":"        when(mysql_impl.InnoBackupExIncremental).metadata().thenReturn(meta)"},{"line_number":372,"context_line":"        when(mysql_impl.InnoBackupExIncremental).run().thenReturn(True)"},{"line_number":373,"context_line":"        when(mysql_impl.InnoBackupExIncremental).__exit__().thenReturn(True)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        agent \u003d backupagent.BackupAgent()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FRiQ%3D","line":372,"updated":"2014-03-18 23:16:54.000000000","message":"Perhaps you should mock the __enter__ instead of run(). That way, the _run_pre_backup() and _run_post_backup() are already mocked as well.","commit_id":"19d940516ecb0d7d6621f09be3f76dc1b5c482b5"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"fdac5d7824b0f4b69fc37532ebd3b074338b720a","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            \u0027parent_checksum\u0027: \u0027md5\u0027,"},{"line_number":370,"context_line":"        }"},{"line_number":371,"context_line":"        when(mysql_impl.InnoBackupExIncremental).metadata().thenReturn(meta)"},{"line_number":372,"context_line":"        when(mysql_impl.InnoBackupExIncremental).run().thenReturn(True)"},{"line_number":373,"context_line":"        when(mysql_impl.InnoBackupExIncremental).__exit__().thenReturn(True)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        agent \u003d backupagent.BackupAgent()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FQtw%3D","line":372,"in_reply_to":"AAAAWH%2F%2FRiQ%3D","updated":"2014-03-19 02:26:33.000000000","message":"It\u0027s generally a good idea to mock out the smallest possible subset of functionality and let the tests actually hit the rest. In this case clearly we don\u0027t want to be running the actual backup command, so we should mock just that piece out. It\u0027s possible that you\u0027d want to test something in the pre / post backup hooks, so let\u0027s not mock it out unless we absolutely need to.","commit_id":"19d940516ecb0d7d6621f09be3f76dc1b5c482b5"}]}