)]}'
{"trove/guestagent/datastore/cassandra/system.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"de4cbf9e771785498caa9b09e122d2b89f83d35a","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# cassandra binary stored at /usr/sbin/"},{"line_number":32,"context_line":"START_CASSANDRA \u003d \"sudo /usr/sbin/cassandra\""},{"line_number":33,"context_line":"STOP_CASSANDRA \u003d \"sudo service cassandra stop\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"CASSANDRA_STATUS \u003d \"\"\"echo \"use system;\" \u003e /tmp/check; cqlsh -f /tmp/check\"\"\""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2Bw4I%3D","line":33,"updated":"2014-03-24 14:53:16.000000000","message":"doesn\u0027t work at ubuntu precise 12.04 LTS.","commit_id":"a651a8caca373e4afa9c56480c8b5fad079a716b"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"8ff6bbf7776e24eddd65a3271e150c57b5867b16","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# cassandra binary stored at /usr/sbin/"},{"line_number":32,"context_line":"START_CASSANDRA \u003d \"sudo /usr/sbin/cassandra\""},{"line_number":33,"context_line":"STOP_CASSANDRA \u003d \"sudo service cassandra stop\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"CASSANDRA_STATUS \u003d \"\"\"echo \"use system;\" \u003e /tmp/check; cqlsh -f /tmp/check\"\"\""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2BUzA%3D","line":33,"in_reply_to":"AAAAWH%2F%2BvtU%3D","updated":"2014-03-27 16:05:56.000000000","message":"ya where did u get this info denis?","commit_id":"a651a8caca373e4afa9c56480c8b5fad079a716b"},{"author":{"_account_id":8136,"name":"Viswa Vutharkar","email":"vpvutharkar@ebaysf.com","username":"vvutharkar"},"change_message_id":"bac6b1549f87eb28ff8fac32cc1b585ebc955c76","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# cassandra binary stored at /usr/sbin/"},{"line_number":32,"context_line":"START_CASSANDRA \u003d \"sudo /usr/sbin/cassandra\""},{"line_number":33,"context_line":"STOP_CASSANDRA \u003d \"sudo service cassandra stop\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"CASSANDRA_STATUS \u003d \"\"\"echo \"use system;\" \u003e /tmp/check; cqlsh -f /tmp/check\"\"\""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2BvtU%3D","line":33,"in_reply_to":"AAAAWH%2F%2Bw4I%3D","updated":"2014-03-24 17:15:16.000000000","message":"Denis M. \nHow do you say \"service cassandra stop\" does not work in ubuntu 12.04? Do you have log of any errors it throws?\n\nAlso, if it does not work, then how come you used it at https://github.com/openstack/trove-integration/blob/master/scripts/files/elements/ubuntu-cassandra/install.d/10-cassandra#L17  ?\n\nIs there probably some environmental differences why it works in the install.d element and not as part of trove guest agent? May be some condition that caused Cassandra to hang in your Trove guest environment during your testing which made you to give up \u0027service stop\u0027 and seek \u0027killall java\u0027 ? I would recommend to test further and reproduce the problem so we could figure out what the actual underlying root cause is.\n\nAlso, since we (Trove) don\u0027t necessarily control how the datastore images should be built by our customers and also  what else could be running on them, we should not be making unsafe assumptions that Cassandra might be the only type of java process running on the guestagent. I see one example in our company in future where we might have an internal log collection or a monitoring daemon that could also be a Java process, and the \u0027killall java\u0027 command\ncould kill those processes also besides killing Cassandra.\n\nIf it is absolutely necessary to use kill (if \u0027service cassandra stop\u0027 cannot be made to work for whatever reason), then the kill command has to be very precise rather than overarching \"killall java\"\n\nAlso I tested on a ubuntu precise 12.04 VM in my test environment and it works fine for me. Granted, I did not provision it via Trove, but ran the install.d script directly on a fresh base ubuntu 12.04 VM.\n\n\n vvutharkar@cass1-165855:~$ sudo service cassandra start\nvvutharkar@cass1-165855:~$ ps -ef | grep cassandra | grep -v grep |wc -l\n1\nvvutharkar@cass1-165855:~$ sudo service cassandra stop\nvvutharkar@cass1-165855:~$ ps -ef | grep cassandra | grep -v grep |wc -l\n0\nvvutharkar@cass1-165855:~$ uname -a\nLinux cass1-165855 3.2.0-58-virtual #88-Ubuntu SMP Tue \nDec 3 17:58:13 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux\nvvutharkar@cass1-165855:~$ lsb_release -a\nNo LSB modules are available.\nDistributor ID:\tUbuntu\nDescription:\tUbuntu 12.04.4 LTS\nRelease:\t12.04\nCodename:\tprecise","commit_id":"a651a8caca373e4afa9c56480c8b5fad079a716b"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"af32e70f906a7da205b4854c40e49d0e6e6a1a41","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# cassandra binary stored at /usr/sbin/"},{"line_number":32,"context_line":"START_CASSANDRA \u003d \"sudo /usr/sbin/cassandra\""},{"line_number":33,"context_line":"STOP_CASSANDRA \u003d \"sudo service cassandra stop\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"CASSANDRA_STATUS \u003d \"\"\"echo \"use system;\" \u003e /tmp/check; cqlsh -f /tmp/check\"\"\""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2BEwI%3D","line":33,"in_reply_to":"AAAAWH%2F%2Bw4I%3D","updated":"2014-03-31 03:38:27.000000000","message":"Denis, can you please provide more info about this does not/would not work in precise 12.04 LTS? Just a snippet saying \"this doesn\u0027t work\" is not really effective from a code review perspective.\n\n\nThanks!","commit_id":"a651a8caca373e4afa9c56480c8b5fad079a716b"},{"author":{"_account_id":8136,"name":"Viswa Vutharkar","email":"vpvutharkar@ebaysf.com","username":"vvutharkar"},"change_message_id":"c43e02dd5e622e0951f185d93f591bceecf84892","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"CASSANDRA_STATUS \u003d \"\"\"echo \"use system;\" \u003e /tmp/check; cqlsh -f /tmp/check\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"CASSANDRA_KILL \u003d \"sudo killall java  || true\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"TIME_OUT \u003d 10000"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2BvaY%3D","line":37,"updated":"2014-03-24 17:37:47.000000000","message":"The same argument about overarching \u0027killall java\u0027 applies here as well. If you had to kill the Cassandra process \n(because start service failed to start it properly) then kill the precise process(es) corresponding to Cassandra.  Not ALL java processes.","commit_id":"a651a8caca373e4afa9c56480c8b5fad079a716b"},{"author":{"_account_id":8136,"name":"Viswa Vutharkar","email":"vpvutharkar@ebaysf.com","username":"vvutharkar"},"change_message_id":"5e87a937c2e8093ed5de130eee6bfe1ee93352a6","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"CASSANDRA_STATUS \u003d \"\"\"echo \"use system;\" \u003e /tmp/check; cqlsh -f /tmp/check\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"CASSANDRA_KILL \u003d \"sudo killall java  || true\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"TIME_OUT \u003d 10000"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2Bu5w%3D","line":37,"in_reply_to":"AAAAWH%2F%2BvaY%3D","updated":"2014-03-24 18:32:49.000000000","message":"Seems like this and other such improper handling of stopping services of all data stores will be taken care by https://wiki.openstack.org/wiki/Trove/Blueprints/guest-agent-datastore-control-abstraction. \n\nI am good with that.","commit_id":"a651a8caca373e4afa9c56480c8b5fad079a716b"}]}
