)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"1f4e2dc29002168aad442a2b772351ab82c27687","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a0860835_ceb3f4b2","updated":"2022-06-20 23:07:00.000000000","message":"Hi Bo, Thanks for your patch! Do you think the new parameter should be applied to all existing users too?\n\nBasically I think\n\n* the default values of all new configuration parameters should be disabled. Except that that parameters must be applied to all existing users.\n* the default values of configuration parameters that already exist should not be changed. If we need to change them, it is safer that we make new alternative parameters and deprecate existing parameters.\n\nIf this patch will lead to unnecessary volume creation for existing users who don\u0027t want to use that volume, I propose:\n* The default CONF.volume_rootdisk_size should be zero.\n* The condition to call _create_root_volume should be something like this:\n```\nif CONF.trove_volume_support and CONF.volume_rootdisk_size \u003e 0:\n    call_create_root_volume\n```\n\nThanks in advance,\nHirotaka","commit_id":"7a76f3a869715ad5e45f243b6d6e14379aec91ab"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c68221c2f9c3de9103f90dedd99bd5cf2dc61ad8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fac0ff3b_999fc5c8","updated":"2022-06-20 12:17:00.000000000","message":"Hi, hirotaka, Could you help to review this ps ? thanks in advance.","commit_id":"7a76f3a869715ad5e45f243b6d6e14379aec91ab"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"45ae3969a269c833a9b36d29588187562ab99051","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bd1c3d11_7d3370c6","updated":"2023-06-28 12:08:48.000000000","message":"any updates?","commit_id":"7a76f3a869715ad5e45f243b6d6e14379aec91ab"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"847292b65386404a19f71179b3ce1e375fd5362a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a2eafca_868efa80","in_reply_to":"0b4360f6_12483c92","updated":"2023-02-27 01:56:40.000000000","message":"Hi Bo! I understand your infra and what you want to add support to Trove. I think this patch provides a way to mount a suitable filesystem for logging or for the other reasons. This may be required for all users if disk-full problem is common for all users, but I think it depends on users situation. disk-full problems can be handled by logging libraries(using log-level or log-rotation functionality).","commit_id":"7a76f3a869715ad5e45f243b6d6e14379aec91ab"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"66ac5de3bae901fa83eda66f763944d8191152b8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c812fc4c_f3ff77d9","in_reply_to":"1fa66df7_05d4ab90","updated":"2022-07-18 08:00:25.000000000","message":"Hi Bo! Thanks for the reply. I don\u0027t understand the reason why all users need to create another volume. Please see my previous comment when you will change the default Trove behavior.\n\nThanks in advance,\nHirotaka","commit_id":"7a76f3a869715ad5e45f243b6d6e14379aec91ab"},{"author":{"_account_id":33551,"name":"Ammad Ali","email":"syedammad83@gmail.com"},"change_message_id":"375abf4f2e42357d75c5ecc8cc44aef8b11de64d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"64a89bb0_7181d424","in_reply_to":"2e26770f_3fd0c1df","updated":"2023-03-07 09:57:42.000000000","message":"Sorry to jump in, as a cloud service provider we have been experiencing an issue.\n- Trove creates root volume on compute node\u0027s local storage in our case \n- There is an issue identified that on ubuntu 22.04 openstack zed release, the live migration of instance does not work. Looks like a bug in qemu.The issue descried here https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/2000153\n- The above issue is blocker in upgrade of openstack to ubuntu 22.04. \n\nSo, I think this patch will help to address the above issue as well.","commit_id":"7a76f3a869715ad5e45f243b6d6e14379aec91ab"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"bbc4bd1c1d7c5ca0f68adcf7b95e5f7700701a82","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3cbffb9d_c6757a2d","in_reply_to":"54f568d5_9f677ecd","updated":"2023-07-05 09:51:23.000000000","message":"thanks, after you fix the conflict, i will submit a zuul jobs to test this patch.","commit_id":"7a76f3a869715ad5e45f243b6d6e14379aec91ab"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"788fd195382c06e783fcf900a646970562b0441b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"68d3a139_3afc4174","in_reply_to":"5a2eafca_868efa80","updated":"2023-02-27 02:11:44.000000000","message":"Problems about log just is one of examples. We should think about common situations.\n- Save client\u0027s costs\n- Save infras resources\n- Work right. When we do create a database with size of disk is 20Gb? How can we know about amount of empty disk that client can use to save data?\n- etc ...","commit_id":"7a76f3a869715ad5e45f243b6d6e14379aec91ab"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"15d7b50138ba2a9e038411c72f92bb9d81f5ea50","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"54f568d5_9f677ecd","in_reply_to":"64a89bb0_7181d424","updated":"2023-07-05 02:59:28.000000000","message":"ok. I will maintain this patch","commit_id":"7a76f3a869715ad5e45f243b6d6e14379aec91ab"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"496adad192cfc1f8197f824a48061fe040774083","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aa48b14a_de7d309c","in_reply_to":"68d3a139_3afc4174","updated":"2023-02-27 05:22:46.000000000","message":"Hi Bo, Thanks for your reply! I understand root filesystem mounted on some device is sometimes not suitable for database usage when OpenStack cluster is for general purpose. In such a case, it is reasonable that we should provide Trove users options(ex:`trove_volume_support`) to mount a suitable filesystem for database and such options should be defaultly enabled.","commit_id":"7a76f3a869715ad5e45f243b6d6e14379aec91ab"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"00031d0f10826beb331a6b89e3075ea7e8aa459a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1fa66df7_05d4ab90","in_reply_to":"a0860835_ceb3f4b2","updated":"2022-07-12 09:56:32.000000000","message":"Nope, I think we should make this as default, all user when create trove instances will create 2 volumes: 1 rootdisk and 1 datadisk. not anymore.","commit_id":"7a76f3a869715ad5e45f243b6d6e14379aec91ab"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"cfd41f114926004a02c8d092899dd2ab9739df13","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2e26770f_3fd0c1df","in_reply_to":"aa48b14a_de7d309c","updated":"2023-02-27 07:17:03.000000000","message":"Yup. I agree with your opinion.","commit_id":"7a76f3a869715ad5e45f243b6d6e14379aec91ab"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"de199e6a44164127ae6b86beaf25cc3712bdf4c5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0b4360f6_12483c92","in_reply_to":"c812fc4c_f3ff77d9","updated":"2023-02-17 03:19:18.000000000","message":"I think we need create separate volumes because we had many case to deploy service in others infra.\nExample:\n- in my infra had 2 type of disk are SSD and HDD. we want SSD use for save data of database, HDD use for OS system (logic of business)\n- if we don\u0027t use separate, maybe data of logs OS will make fulldisk - make database of service can\u0027t save to disk or database of service can\u0027t work\n- with logic of business, if our users choose size of disk to save data of database. we can\u0027t reserve correct size to serve clients.","commit_id":"7a76f3a869715ad5e45f243b6d6e14379aec91ab"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"1f4e2dc29002168aad442a2b772351ab82c27687","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4dd1e3ab_c2ad72a8","in_reply_to":"fac0ff3b_999fc5c8","updated":"2022-06-20 23:07:00.000000000","message":"Hi Wu, Sure! I will review this patch.","commit_id":"7a76f3a869715ad5e45f243b6d6e14379aec91ab"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"2b2fdc7ae061298cf2b09d5cd8d49186b5c1793f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5f390ea8_4d2090e3","updated":"2023-08-07 04:51:04.000000000","message":"/recheck","commit_id":"edf5079fc0533a2baf3557009b7f0fbf8603b674"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"2bf7e01b4ab291bdb46c7bf6b7dec1214251b8fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4ccf7507_eef47f63","updated":"2023-11-03 04:29:32.000000000","message":"@wu.chunyang help me, let do review this patch","commit_id":"a2e21bdae65531b61ed29891f37e1357d05a0559"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"27814474d2d383f084a672b30199295545119d0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f411eed6_290498d2","updated":"2023-11-03 07:05:43.000000000","message":"Hi, Tron, I know your situation from the comment, but i agree with hirotaka more, As Openstack is not only used in public cloud purpose ,but also for private cloud that users may not need to always create a root disk for trove instance. so i think add a new parameter may be a better choice. and please add a release note as well. more discussion, let\u0027s move the storyboard. thanks","commit_id":"a2e21bdae65531b61ed29891f37e1357d05a0559"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"fa1515bd8fa1e0b2e24919362e574c54ea5f830c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dbc10757_57c12225","in_reply_to":"4ccf7507_eef47f63","updated":"2023-11-03 06:10:45.000000000","message":"OK, now problem, I will review this soon.","commit_id":"a2e21bdae65531b61ed29891f37e1357d05a0559"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"1c4cbe719c391813778f8f045439b512fad199a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b21faac0_751396dc","updated":"2023-11-03 08:55:49.000000000","message":"All of the CI test for mysql 5.7 are failed","commit_id":"5dc71f41e436c6912050bd0cbe5c1ecc63fa7344"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b589ee11b50703450bf70a15fbec5c2593fd3279","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f305c452_2b1f409b","in_reply_to":"0b5bf36a_026b650d","updated":"2023-11-07 08:04:39.000000000","message":"How can I run this in local?  -\u003e you can run a devstack with tempest test in your local. but not recommend, because your local environment is different from the zuul.\n\nI checked the log, it seems like the nova instance created timeout(stuck in building status). \n\nI guess perhaps the default volume_rootdisk_size is too large to create instance in zuul ? BTW shall we enable this feature by default?","commit_id":"5dc71f41e436c6912050bd0cbe5c1ecc63fa7344"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"61127a17cfd24bd0c995d099db866dc22f42f27a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d8867a39_71a4291f","in_reply_to":"10c16e3d_b99cad29","updated":"2023-11-07 09:34:28.000000000","message":"make sense，thanks, let\u0027s update this commit and add a release note for this feature.","commit_id":"5dc71f41e436c6912050bd0cbe5c1ecc63fa7344"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"35af2dab67e6c7ab0140565ce5eba359bf20d44b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d3ad184e_c87b68de","in_reply_to":"b21faac0_751396dc","updated":"2023-11-06 03:21:08.000000000","message":"How can I run this in local? I was run with `tox - e py39` - it was passed all unitest.\n\nCurrent, I don\u0027t know why it can\u0027t pass CI.","commit_id":"5dc71f41e436c6912050bd0cbe5c1ecc63fa7344"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"057d6fff92d4fff2253f3bdfb0f3c208291f8553","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0b5bf36a_026b650d","in_reply_to":"d3ad184e_c87b68de","updated":"2023-11-06 03:26:39.000000000","message":"Seem, database instance can\u0027t be create with status ACTIVE.","commit_id":"5dc71f41e436c6912050bd0cbe5c1ecc63fa7344"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"ee31e5075b5416a8915eb51511d212aada0c607e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"10c16e3d_b99cad29","in_reply_to":"f305c452_2b1f409b","updated":"2023-11-07 08:32:40.000000000","message":"Up until now, I don\u0027t see anybody claim about this problem. Maybe, some provider can have private patch or not. So, I think, we will make this feature not enable by default.","commit_id":"5dc71f41e436c6912050bd0cbe5c1ecc63fa7344"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"fe6aeacfe663570acc34d24aca45f722dee5ab16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c973151c_3df9ef99","updated":"2023-11-14 13:39:27.000000000","message":"Hi, the CI was passed by setting the volume_time_out to a larger number. \nAccording to the result of CI test, if user enables this feature in the future, the volume_time_out value might not be sufficient by default.","commit_id":"6ad9c14483dd0f2079d1d65860afbe05fef8c5d4"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"67aa7fc07467cdb48d0af9810c4fed6ebf5f525b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"10773da3_4b0d3cb7","updated":"2023-11-13 07:38:12.000000000","message":"timeout while creating root volume. more details: https://zuul.opendev.org/t/openstack/build/2551752e379345eea9397a467e0a22e3/log/controller/logs/screen-tr-tmgr.txt#694","commit_id":"6ad9c14483dd0f2079d1d65860afbe05fef8c5d4"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"903780be188953d64ad79497087044637951ac53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a0a4f435_57f56158","in_reply_to":"077400fa_749d69b6","updated":"2023-11-13 09:56:08.000000000","message":"thanks for your advise, I will try it again.","commit_id":"6ad9c14483dd0f2079d1d65860afbe05fef8c5d4"},{"author":{"_account_id":36245,"name":"Asaad Abbasi","display_name":"Asaad Abbasi","email":"asaad.abbasi@gmail.com","username":"AsaadNA"},"change_message_id":"4a326f5197aa85c7ef75c3e699db1f17d946c453","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"077400fa_749d69b6","in_reply_to":"10773da3_4b0d3cb7","updated":"2023-11-13 09:35:27.000000000","message":"Was encountering the same issue, it was fixed by increasing the volume_time_out option","commit_id":"6ad9c14483dd0f2079d1d65860afbe05fef8c5d4"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"16785ed872cdac411f6ef5f6c503577fadff4f0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f68a309e_ff12a9b1","in_reply_to":"a0a4f435_57f56158","updated":"2023-11-14 01:51:16.000000000","message":"many thanks.\n\n@wu.chunyang Do you know about the image\u0027s size that being use to create trove guest agent? The `volume_time_out` option being config with 60 as default, I think this value don\u0027t too short to create the volume.","commit_id":"6ad9c14483dd0f2079d1d65860afbe05fef8c5d4"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"2e9196d0b4c6861efb63d613b1a2b6e75770bfb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9b2afb6f_24ed268b","in_reply_to":"f68a309e_ff12a9b1","updated":"2023-11-14 02:12:24.000000000","message":"Hi Bo, the volume size used to create the root volume was 10G, refer to:https://zuul.opendev.org/t/openstack/build/2551752e379345eea9397a467e0a22e3/log/controller/logs/screen-c-api.txt#1656\n\nBTW, During the creation of root volume,  cinder will download the glance image to cinder volume. perhaps the network was too slow， which caused the download not to complete within the timeout period.","commit_id":"6ad9c14483dd0f2079d1d65860afbe05fef8c5d4"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"1efb28339f0527030efbccb96e2d92e747e986a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"09329264_b0370c32","updated":"2023-12-05 06:56:04.000000000","message":"Great! All CI jobs passed.","commit_id":"d6aa04c0d568c207a678b5f8de077d7706789441"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"503a80bf985abbc3b60cbb7b4905200f5e886b4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ff9e7d97_595ff138","updated":"2023-12-06 03:31:00.000000000","message":"need a small docs fix. thanks","commit_id":"d6aa04c0d568c207a678b5f8de077d7706789441"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3baef77a33824a4748e175b489b16363c6bc2aec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"85e903ab_184d7be9","updated":"2023-12-06 07:19:20.000000000","message":"I am sorry that i missed to check the unit test code.","commit_id":"321fc5a720d31b1e373a1c8aa2e3184e4bdb53cb"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"3e1e645bdc95b7e30417a75d2746082da079bfc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3ed7d745_35a9ed7b","updated":"2023-12-07 01:40:01.000000000","message":"/recheck","commit_id":"8a5b837a47a6496b3ce43a88449f6d6cd95acf0e"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"4fa3fc94e11c6230c31f8fc0531b65258a9b7d8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2964e7f4_208bdefe","updated":"2023-12-07 03:07:20.000000000","message":"recheck","commit_id":"8a5b837a47a6496b3ce43a88449f6d6cd95acf0e"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"4fa3fc94e11c6230c31f8fc0531b65258a9b7d8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8444ce11_db6f82bf","in_reply_to":"3ed7d745_35a9ed7b","updated":"2023-12-07 03:07:20.000000000","message":"timeout while waiting the instance transitions into ACTIVE status. I will increase the database build time in case of running on the low speed zuul nodes.","commit_id":"8a5b837a47a6496b3ce43a88449f6d6cd95acf0e"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"92d567e51aea4ca60930b908e9ad2e3d2fea37c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"a43ae0d8_6b2099fd","updated":"2023-12-08 02:09:13.000000000","message":"2023-12-07 09:38:35.006 772 ERROR trove.guestagent.datastore.postgres.service docker.errors.APIError: 500 Server Error for http+docker://localhost/v1.43/containers/35a86ce8c80a94272df2132b8b44acacd40fda20c6e89f3482d7e73f2f2177a0/restart?t\u003d600: Internal Server Error (\"Cannot restart container 35a86ce8c80a94272df2132b8b44acacd40fda20c6e89f3482d7e73f2f2177a0: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error running hook #0: error running hook: exit status 1, stdout: , stderr: failed to set IPv6 gateway while updating gateway: file exists: unknown\")","commit_id":"a92836d0aae6b691499ac37a737305967ad18d71"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"92d567e51aea4ca60930b908e9ad2e3d2fea37c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ea42b71c_079b8025","updated":"2023-12-08 02:09:13.000000000","message":"2023-12-07 09:38:35.006 772 ERROR trove.guestagent.datastore.postgres.service docker.errors.APIError: 500 Server Error for http+docker://localhost/v1.43/containers/35a86ce8c80a94272df2132b8b44acacd40fda20c6e89f3482d7e73f2f2177a0/restart?t\u003d600: Internal Server Error (\"Cannot restart container 35a86ce8c80a94272df2132b8b44acacd40fda20c6e89f3482d7e73f2f2177a0: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error running hook #0: error running hook: exit status 1, stdout: , stderr: failed to set IPv6 gateway while updating gateway: file exists: unknown\")","commit_id":"a92836d0aae6b691499ac37a737305967ad18d71"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"cecf5ce2320b8db1b73ac07d8ed178ec7e7fa295","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"56a6aa71_66162526","updated":"2023-12-14 01:20:59.000000000","message":"/recheck","commit_id":"8b6ff821a13888336c141f9b006e648bf75a1744"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"a168165fdc3fb8b2d6f4bb5a4d3f9fa380d30e52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a9f1ea0d_ee1dd922","updated":"2023-12-15 04:54:43.000000000","message":"@wu.chunyang: Can you help me debug and fix error log CI? I don\u0027t know about root cause of this error.","commit_id":"8b6ff821a13888336c141f9b006e648bf75a1744"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c74deca78e84423a096f4baf00629f50a878ebc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"4d67f666_e57784e7","updated":"2023-12-14 01:29:02.000000000","message":"recheck","commit_id":"8b6ff821a13888336c141f9b006e648bf75a1744"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"907a7902a36a48d340b7978e9c43240ac7ff25c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"6a34988e_487b2d72","updated":"2023-12-14 07:24:01.000000000","message":"recheck","commit_id":"8b6ff821a13888336c141f9b006e648bf75a1744"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"4428545f9c3905e4e4e938b78335c41b9d440a15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"b66ba9c8_527473d9","updated":"2023-12-15 05:38:47.000000000","message":"recheck","commit_id":"8b6ff821a13888336c141f9b006e648bf75a1744"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"ee0278fa58c501a4cc615a8e4768eadae5a5fc92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d5c07b6a_1c39714b","updated":"2023-12-15 03:05:31.000000000","message":"recheck","commit_id":"8b6ff821a13888336c141f9b006e648bf75a1744"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c74deca78e84423a096f4baf00629f50a878ebc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"30f919df_44b41942","in_reply_to":"56a6aa71_66162526","updated":"2023-12-14 01:29:02.000000000","message":"hi， you should comment \"recheck\" rather then \"/recheck\". please remove the slash","commit_id":"8b6ff821a13888336c141f9b006e648bf75a1744"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"4428545f9c3905e4e4e938b78335c41b9d440a15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"73d63f31_982e4b5f","in_reply_to":"a9f1ea0d_ee1dd922","updated":"2023-12-15 05:38:47.000000000","message":"devstack ran failed，recheck should be ok.","commit_id":"8b6ff821a13888336c141f9b006e648bf75a1744"}],"releasenotes/notes/add-support-create-instance-with-rootdisk-cinder.yaml":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"503a80bf985abbc3b60cbb7b4905200f5e886b4a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Implements nova instances with root disk in cinder backend"},{"line_number":4,"context_line":"    if config `volume_rootdisk_support` is True"},{"line_number":5,"context_line":"    The size of root disk being create is `volume_rootdisk_size`"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fixes:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"2ade499c_5eb19186","line":4,"range":{"start_line":4,"start_character":7,"end_line":4,"end_character":13},"updated":"2023-12-06 03:31:00.000000000","message":"s/config/the configuration/","commit_id":"d6aa04c0d568c207a678b5f8de077d7706789441"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"503a80bf985abbc3b60cbb7b4905200f5e886b4a","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Implements nova instances with root disk in cinder backend"},{"line_number":4,"context_line":"    if config `volume_rootdisk_support` is True"},{"line_number":5,"context_line":"    The size of root disk being create is `volume_rootdisk_size`"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - By the create nova instances with root disk in cinder backend"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"71aa9929_703246ac","line":5,"range":{"start_line":5,"start_character":32,"end_line":5,"end_character":38},"updated":"2023-12-06 03:31:00.000000000","message":"created ?","commit_id":"d6aa04c0d568c207a678b5f8de077d7706789441"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"503a80bf985abbc3b60cbb7b4905200f5e886b4a","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    The size of root disk being create is `volume_rootdisk_size`"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - By the create nova instances with root disk in cinder backend"},{"line_number":9,"context_line":"    It will allow live migrate nova instances and features when use"},{"line_number":10,"context_line":"    cinder as storage backend."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"4fcb9b3e_ba342ae6","line":10,"range":{"start_line":8,"start_character":4,"end_line":10,"end_character":30},"updated":"2023-12-06 03:31:00.000000000","message":"When creating Nova instances with a root disk in the Cinder backend, it will allow live migration of Nova instances and features when using Cinder as the storage backend.","commit_id":"d6aa04c0d568c207a678b5f8de077d7706789441"}],"trove/common/cfg.py":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"27814474d2d383f084a672b30199295545119d0c","unresolved":true,"context_lines":[{"line_number":65,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":66,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dTrue,"},{"line_number":67,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for datadir.\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027volume_rootdisk_size\u0027, default\u003d16,"},{"line_number":69,"context_line":"               help\u003d\u0027Size of volume disk for Database instance\u0027),"},{"line_number":70,"context_line":"    cfg.ListOpt(\u0027admin_roles\u0027, default\u003d[\u0027admin\u0027],"},{"line_number":71,"context_line":"                help\u003d\u0027Roles to add to an admin user.\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffee7046_8ade6bae","line":68,"updated":"2023-11-03 07:05:43.000000000","message":"The default 16G for root disk is a bit large.","commit_id":"a2e21bdae65531b61ed29891f37e1357d05a0559"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"735ab2d20eb0698ab01fc287fee1fffa6c76ca0b","unresolved":true,"context_lines":[{"line_number":63,"context_line":"                help\u003d\u0027Port the API server will listen on.\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027api_paste_config\u0027, default\u003d\"api-paste.ini\","},{"line_number":65,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":66,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dFalse,"},{"line_number":67,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for rootdisk.\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027volume_rootdisk_size\u0027, default\u003d10,"},{"line_number":69,"context_line":"               help\u003d\u0027Size of volume disk for Database instance\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"b612278d_20198624","line":66,"updated":"2023-11-09 14:23:31.000000000","message":"this opt was used for datadir. i think we shouldn\u0027t change the default behavior.","commit_id":"6ad9c14483dd0f2079d1d65860afbe05fef8c5d4"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"562aa29f9c4fda93be44c2f62fb3be705e09a393","unresolved":true,"context_lines":[{"line_number":63,"context_line":"                help\u003d\u0027Port the API server will listen on.\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027api_paste_config\u0027, default\u003d\"api-paste.ini\","},{"line_number":65,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":66,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dFalse,"},{"line_number":67,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for rootdisk.\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027volume_rootdisk_size\u0027, default\u003d10,"},{"line_number":69,"context_line":"               help\u003d\u0027Size of volume disk for Database instance\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"f76e9f8b_21102701","line":66,"in_reply_to":"173bbb3c_f4d4e76b","updated":"2023-11-10 01:36:22.000000000","message":"I think we can use this option in this case.","commit_id":"6ad9c14483dd0f2079d1d65860afbe05fef8c5d4"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"54036cc86f15abbd6ad4777c8a0f0ad3b426880b","unresolved":true,"context_lines":[{"line_number":63,"context_line":"                help\u003d\u0027Port the API server will listen on.\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027api_paste_config\u0027, default\u003d\"api-paste.ini\","},{"line_number":65,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":66,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dFalse,"},{"line_number":67,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for rootdisk.\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027volume_rootdisk_size\u0027, default\u003d10,"},{"line_number":69,"context_line":"               help\u003d\u0027Size of volume disk for Database instance\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"e8ff008b_bd72fd76","line":66,"in_reply_to":"257e34d5_6da2fe38","updated":"2023-11-27 14:12:46.000000000","message":"hello Ammand, Thanks for your advice. BTW, do you need this feature in your environment?","commit_id":"6ad9c14483dd0f2079d1d65860afbe05fef8c5d4"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"e07721ca94300594e2673252302827a959868392","unresolved":true,"context_lines":[{"line_number":63,"context_line":"                help\u003d\u0027Port the API server will listen on.\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027api_paste_config\u0027, default\u003d\"api-paste.ini\","},{"line_number":65,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":66,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dFalse,"},{"line_number":67,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for rootdisk.\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027volume_rootdisk_size\u0027, default\u003d10,"},{"line_number":69,"context_line":"               help\u003d\u0027Size of volume disk for Database instance\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf95e533_d49e6c9b","line":66,"in_reply_to":"46a98db9_1af8b0ea","updated":"2023-11-15 01:51:44.000000000","message":"I had also review this option again. As you know, to create nova instances, we can config the volume size in nova flavors or create root volume from glance image with the specific size.\n\nSo, if you create nova instance by an ephemeral flavor, we don\u0027t need step create the rootdisk.\n\nI think we should use this option. What do you think about this?","commit_id":"6ad9c14483dd0f2079d1d65860afbe05fef8c5d4"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"fe6aeacfe663570acc34d24aca45f722dee5ab16","unresolved":true,"context_lines":[{"line_number":63,"context_line":"                help\u003d\u0027Port the API server will listen on.\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027api_paste_config\u0027, default\u003d\"api-paste.ini\","},{"line_number":65,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":66,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dFalse,"},{"line_number":67,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for rootdisk.\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027volume_rootdisk_size\u0027, default\u003d10,"},{"line_number":69,"context_line":"               help\u003d\u0027Size of volume disk for Database instance\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"46a98db9_1af8b0ea","line":66,"in_reply_to":"52819362_b7d19372","updated":"2023-11-14 13:39:27.000000000","message":"Hi, I checked the trove_volume_support in trove, it seems to be only used in the flavor response. But I don\u0027t think we should re-use this value for supporting of root disk, because this may change our API response which needs to keep stable for downstream user. \n\nI suggest to use `volume_rootdisk_size` to check whether we should enable this feature. for example: setting the volume_rootdisk_size to 0 by default means this feature was disable, another positive integer means the root_disk size to use.","commit_id":"6ad9c14483dd0f2079d1d65860afbe05fef8c5d4"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"efa589a4b13bd2e712e0249bf0930738be436d30","unresolved":true,"context_lines":[{"line_number":63,"context_line":"                help\u003d\u0027Port the API server will listen on.\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027api_paste_config\u0027, default\u003d\"api-paste.ini\","},{"line_number":65,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":66,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dFalse,"},{"line_number":67,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for rootdisk.\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027volume_rootdisk_size\u0027, default\u003d10,"},{"line_number":69,"context_line":"               help\u003d\u0027Size of volume disk for Database instance\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"46c17d8e_285fdeb0","line":66,"in_reply_to":"66c52a7a_bdbf3feb","updated":"2023-11-29 03:21:58.000000000","message":"Hi， LGTM, Let\u0027s add a new config opt to control this. And it would be better to add a doc for this feature. thanks","commit_id":"6ad9c14483dd0f2079d1d65860afbe05fef8c5d4"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"26e227fad9da0e76b540b76b492a8de33819f35d","unresolved":true,"context_lines":[{"line_number":63,"context_line":"                help\u003d\u0027Port the API server will listen on.\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027api_paste_config\u0027, default\u003d\"api-paste.ini\","},{"line_number":65,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":66,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dFalse,"},{"line_number":67,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for rootdisk.\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027volume_rootdisk_size\u0027, default\u003d10,"},{"line_number":69,"context_line":"               help\u003d\u0027Size of volume disk for Database instance\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"c9698051_8af7f358","line":66,"in_reply_to":"80e5dcce_308a3548","updated":"2023-11-17 02:03:37.000000000","message":"Whether flavors that ephemeral \u003d 0GB  // yes, of course, when cinder was supported, most flavors\u0027 ephemeral-storage was set to 0, but for some cases that cinder was not supported, then users may need to set ephemeral disk in the flavor, this depends on users\u0027 business.  \n\nBTW, Ephemeral storage is a local disk that was created by the nova and was mounted into VMs as a data disk.\n\nIn my opinion, we might as well use the `volume_rootdisk_size` to check whether we should enable this feature. and add a document to reminder users to adjust their  default volume_time_out values as well as to  enable cinder service.","commit_id":"6ad9c14483dd0f2079d1d65860afbe05fef8c5d4"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"d8473fb7a3f88ec125b5d52cb7c88700434aed14","unresolved":true,"context_lines":[{"line_number":63,"context_line":"                help\u003d\u0027Port the API server will listen on.\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027api_paste_config\u0027, default\u003d\"api-paste.ini\","},{"line_number":65,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":66,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dFalse,"},{"line_number":67,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for rootdisk.\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027volume_rootdisk_size\u0027, default\u003d10,"},{"line_number":69,"context_line":"               help\u003d\u0027Size of volume disk for Database instance\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"80e5dcce_308a3548","line":66,"in_reply_to":"922aa6d9_8935772b","updated":"2023-11-17 01:37:55.000000000","message":"I see, and I have a question that is: Whether have flavors that ephemeral \u003d 0GB?\nIn my case, all my flavors being set ephemral \u003d 0GB (this maybe a logic of business, organize).\nHave you some advice to handle this?","commit_id":"6ad9c14483dd0f2079d1d65860afbe05fef8c5d4"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"e133e5173882510253ab4b4134463c62746bdc5c","unresolved":true,"context_lines":[{"line_number":63,"context_line":"                help\u003d\u0027Port the API server will listen on.\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027api_paste_config\u0027, default\u003d\"api-paste.ini\","},{"line_number":65,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":66,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dFalse,"},{"line_number":67,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for rootdisk.\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027volume_rootdisk_size\u0027, default\u003d10,"},{"line_number":69,"context_line":"               help\u003d\u0027Size of volume disk for Database instance\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"173bbb3c_f4d4e76b","line":66,"in_reply_to":"b612278d_20198624","updated":"2023-11-10 01:35:31.000000000","message":"I see it just being use in https://opendev.org/openstack/trove/src/branch/master/trove/flavor/views.py#L51.\n\nthis option hasn\u0027t effects in code with default datadir.","commit_id":"6ad9c14483dd0f2079d1d65860afbe05fef8c5d4"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"65fc264ff99a1b800f4bcd61669d4de32e9bdb71","unresolved":true,"context_lines":[{"line_number":63,"context_line":"                help\u003d\u0027Port the API server will listen on.\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027api_paste_config\u0027, default\u003d\"api-paste.ini\","},{"line_number":65,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":66,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dFalse,"},{"line_number":67,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for rootdisk.\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027volume_rootdisk_size\u0027, default\u003d10,"},{"line_number":69,"context_line":"               help\u003d\u0027Size of volume disk for Database instance\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"922aa6d9_8935772b","line":66,"in_reply_to":"bf95e533_d49e6c9b","updated":"2023-11-16 14:14:01.000000000","message":"Hi, I guess either you or I may have a misunderstanding here.\nAs i known, trove_volume_support was used here[0], and was invoked by [1]. this is not the nova flavor used to create vm. but a dict gets values from the nova flavor to return to the client. this controller used by the command \"openstack datastore flavor show\"\n\nThe previous default value of trove_volume_support is True, so It might break the logic[0], the CONF.device_path\u0027s default value is not None, so the previous api will not return local_storage key in the response, but now it does, which may affect the downstream users.\n\nAdditionally, we can\u0027t benefit from re-using this value in any way.\n\nI am not sure whether you have seen my last comment, so here i will talk about it again. \nwith this feature enabled, we also need to guide user to adjust volume_time_out value appropriate for their environment. Do you think if we need a document for it?\nthanks.\n\n[0]:https://github.com/openstack/trove/blob/master/trove/flavor/views.py#L51\n[1]:https://github.com/openstack/trove/blob/master/trove/flavor/service.py#L35","commit_id":"6ad9c14483dd0f2079d1d65860afbe05fef8c5d4"},{"author":{"_account_id":33551,"name":"Ammad Ali","email":"syedammad83@gmail.com"},"change_message_id":"50f83113c69beba5ad8c74feab5582d0e0148df1","unresolved":true,"context_lines":[{"line_number":63,"context_line":"                help\u003d\u0027Port the API server will listen on.\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027api_paste_config\u0027, default\u003d\"api-paste.ini\","},{"line_number":65,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":66,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dFalse,"},{"line_number":67,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for rootdisk.\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027volume_rootdisk_size\u0027, default\u003d10,"},{"line_number":69,"context_line":"               help\u003d\u0027Size of volume disk for Database instance\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"257e34d5_6da2fe38","line":66,"in_reply_to":"c9698051_8af7f358","updated":"2023-11-27 09:47:05.000000000","message":"I would suggest to create two new parameters to check whether trove should enable this feature or not. The one volume_rootdisk_support (to check if root volume need to be created) and other volume_rootdisk_size (to check root volume size).","commit_id":"6ad9c14483dd0f2079d1d65860afbe05fef8c5d4"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"1f3c28a51fe16002982dfa29da36ebab2f45eb74","unresolved":true,"context_lines":[{"line_number":63,"context_line":"                help\u003d\u0027Port the API server will listen on.\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027api_paste_config\u0027, default\u003d\"api-paste.ini\","},{"line_number":65,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":66,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dFalse,"},{"line_number":67,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for rootdisk.\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027volume_rootdisk_size\u0027, default\u003d10,"},{"line_number":69,"context_line":"               help\u003d\u0027Size of volume disk for Database instance\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"66c52a7a_bdbf3feb","line":66,"in_reply_to":"e8ff008b_bd72fd76","updated":"2023-11-28 02:07:46.000000000","message":"hello Ammand, thanks for your advice.\n\ncc wu.chunyang: This logic just is logic of business because, I doing as a cloud provider, the root disk should be create in storage backends and must be required features of cinder. If we create with local disk, we do migrate nova instances, other tasks so hard.","commit_id":"6ad9c14483dd0f2079d1d65860afbe05fef8c5d4"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"cec1ee420b1294297d7c8ad7a0ea83e5179cdedf","unresolved":true,"context_lines":[{"line_number":63,"context_line":"                help\u003d\u0027Port the API server will listen on.\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027api_paste_config\u0027, default\u003d\"api-paste.ini\","},{"line_number":65,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":66,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027, default\u003dFalse,"},{"line_number":67,"context_line":"                help\u003d\u0027Whether to provision a Cinder volume for rootdisk.\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027volume_rootdisk_size\u0027, default\u003d10,"},{"line_number":69,"context_line":"               help\u003d\u0027Size of volume disk for Database instance\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"52819362_b7d19372","line":66,"in_reply_to":"f76e9f8b_21102701","updated":"2023-11-13 02:33:27.000000000","message":"CI still failed with this patch. I am going to figure it out.","commit_id":"6ad9c14483dd0f2079d1d65860afbe05fef8c5d4"}],"trove/tests/unittests/taskmanager/test_models.py":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3baef77a33824a4748e175b489b16363c6bc2aec","unresolved":true,"context_lines":[{"line_number":451,"context_line":"            is_public\u003dFalse"},{"line_number":452,"context_line":"        )"},{"line_number":453,"context_line":"        image_id \u003d \u0027mysql-image-id\u0027"},{"line_number":454,"context_line":"        if cfg.CONF.trove_volume_support:"},{"line_number":455,"context_line":"            mock_create_root_volume.assert_called_with("},{"line_number":456,"context_line":"                \u0027mysql-image-id\u0027, 10, \u0027volume_type\u0027, None)"},{"line_number":457,"context_line":"            image_id \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"790e7f00_95e519d7","line":454,"updated":"2023-12-06 07:19:20.000000000","message":"volume_rootdisk_support ？","commit_id":"321fc5a720d31b1e373a1c8aa2e3184e4bdb53cb"}]}