)]}'
{"trove/taskmanager/models.py":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"9b69bd3851ce34e78e477212d72c11680724a799","unresolved":false,"context_lines":[{"line_number":1142,"context_line":"            elif volume.size !\u003d self.new_size:"},{"line_number":1143,"context_line":"                self.instance.update_db(volume_size\u003dvolume.size)"},{"line_number":1144,"context_line":"                self._recover_full(self._verify_extend)"},{"line_number":1145,"context_line":"            raise"},{"line_number":1146,"context_line":"        except Exception:"},{"line_number":1147,"context_line":"            LOG.exception(_(\"Error encountered trying to verify extend for \""},{"line_number":1148,"context_line":"                          \"the volume %(vol_id)s for instance %(id)s\") % {"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWn%2F%2F%2F%2F8%3D","side":"PARENT","line":1145,"updated":"2014-04-08 00:39:17.000000000","message":"Does this really \"lose\" the first exception as the commit message implies? I think the \"raise\" here simply re-raises the first exception (so it\u0027s not lost). Is this actually a bug, or simply refactoring to make better use of oslo code? If it\u0027s the latter, can we correct the commit message, please?","commit_id":"a4a914c907d354407ea4ab0946beffa4aca8447f"},{"author":{"_account_id":7236,"name":"Kiyohiro Adachi","email":"kiy-adachi@vx.jp.nec.com","username":"kadachi"},"change_message_id":"b4b14a63c4e64e2ff909722d63d84cd102f80abf","unresolved":false,"context_lines":[{"line_number":1142,"context_line":"            elif volume.size !\u003d self.new_size:"},{"line_number":1143,"context_line":"                self.instance.update_db(volume_size\u003dvolume.size)"},{"line_number":1144,"context_line":"                self._recover_full(self._verify_extend)"},{"line_number":1145,"context_line":"            raise"},{"line_number":1146,"context_line":"        except Exception:"},{"line_number":1147,"context_line":"            LOG.exception(_(\"Error encountered trying to verify extend for \""},{"line_number":1148,"context_line":"                          \"the volume %(vol_id)s for instance %(id)s\") % {"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ae8d1ca_06fcfb3d","side":"PARENT","line":1145,"in_reply_to":"AAAAW3%2F%2FWTk%3D","updated":"2014-05-27 08:39:24.000000000","message":"I am sorry to have kept you waiting.\n\nI\u0027ve re-check the source code.\n\nI thought that it was because calling a cinder in \u0027self.instance.volume_client.volumes.get()\u0027, and there is a possibility of an exception.\n\n\nI\u0027m sorry if I misunderstood.","commit_id":"a4a914c907d354407ea4ab0946beffa4aca8447f"},{"author":{"_account_id":7236,"name":"Kiyohiro Adachi","email":"kiy-adachi@vx.jp.nec.com","username":"kadachi"},"change_message_id":"6c8e7f66e00e96de4845f20300228401be4e50d7","unresolved":false,"context_lines":[{"line_number":1142,"context_line":"            elif volume.size !\u003d self.new_size:"},{"line_number":1143,"context_line":"                self.instance.update_db(volume_size\u003dvolume.size)"},{"line_number":1144,"context_line":"                self._recover_full(self._verify_extend)"},{"line_number":1145,"context_line":"            raise"},{"line_number":1146,"context_line":"        except Exception:"},{"line_number":1147,"context_line":"            LOG.exception(_(\"Error encountered trying to verify extend for \""},{"line_number":1148,"context_line":"                          \"the volume %(vol_id)s for instance %(id)s\") % {"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWn%2F%2F%2FrM%3D","side":"PARENT","line":1145,"in_reply_to":"AAAAWn%2F%2F%2F%2F8%3D","updated":"2014-04-08 02:15:11.000000000","message":"Thank you for comment. Another exception occurs in an exception handler, the first exception is lost. In that case, if we do not save the exception information when it entered the exception handler, it will not know what exception whether the first was caused by. If we use excutils.save_and_reraise_exception(), it can be seen the first exception in the log, such as the following. \"ERROR:root:Original exception being dropped: [\u0027Traceback (most recent call last):\\n\u0027, \u0027  File \"trove/taskmanager/models.py\", line 1131, in _verify_extend\\n    time_out\u003dCONF.volume_time_out)\\n\u0027, \u0027  File \"/opt/stack/trove/.tox/py27/local/lib/python2.7/site-packages/mock.py\", line 955, in __call__\\n    return _mock_self._mock_call(*args, **kwargs)\\n\u0027, \u0027  File \"/opt/stack/trove/.tox/py27/local/lib/python2.7/site-packages/mock.py\", line 1010, in _mock_call\\n    raise effect\\n\u0027, \u0027PollTimeOut: Polling request timed out.\\n\u0027]\"","commit_id":"a4a914c907d354407ea4ab0946beffa4aca8447f"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"42dfb335fc0ca47c052ee8583e19434709b49811","unresolved":false,"context_lines":[{"line_number":1142,"context_line":"            elif volume.size !\u003d self.new_size:"},{"line_number":1143,"context_line":"                self.instance.update_db(volume_size\u003dvolume.size)"},{"line_number":1144,"context_line":"                self._recover_full(self._verify_extend)"},{"line_number":1145,"context_line":"            raise"},{"line_number":1146,"context_line":"        except Exception:"},{"line_number":1147,"context_line":"            LOG.exception(_(\"Error encountered trying to verify extend for \""},{"line_number":1148,"context_line":"                          \"the volume %(vol_id)s for instance %(id)s\") % {"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2FWTk%3D","side":"PARENT","line":1145,"in_reply_to":"AAAAWn%2F%2F%2FrM%3D","updated":"2014-04-15 08:32:07.000000000","message":"Which exception is occurring in the exception handler which is re-writing the PollTimeOut exception? \n\nIf one exists, there may be another bug here, and I\u0027m afraid that by doing this, we might be silencing the other exception being raised as a side effect of that issue.","commit_id":"a4a914c907d354407ea4ab0946beffa4aca8447f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7d24c9523099142da4ccfe04993a88b9a946424d","unresolved":false,"context_lines":[{"line_number":1143,"context_line":"                             time_out\u003dCONF.volume_time_out)"},{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"            self.instance.update_db(volume_size\u003dself.new_size)"},{"line_number":1146,"context_line":"        except PollTimeOut:"},{"line_number":1147,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1148,"context_line":"                LOG.exception(_(\"Timeout trying to extend the volume \""},{"line_number":1149,"context_line":"                                \"%(vol_id)s for instance %(id)s\") % {"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_8e3b90c7","line":1146,"updated":"2014-06-24 12:34:59.000000000","message":"I guess this two exception sections can be simplified/re-written in one.","commit_id":"1f32504e71030cb1b50aa245ffc46c0536f15052"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"561970dbcb4dc5ee2c5175bb9e8bbdc46f7e9f8c","unresolved":false,"context_lines":[{"line_number":1188,"context_line":"                    LOG.exception(_(\"Timeout trying to extend the volume \""},{"line_number":1189,"context_line":"                                    \"%(vol_id)s for instance %(id)s\") % {"},{"line_number":1190,"context_line":"                                        \u0027vol_id\u0027: self.instance.volume_id,"},{"line_number":1191,"context_line":"                                        \u0027id\u0027: self.instance.id})"},{"line_number":1192,"context_line":"                    volume \u003d self.instance.volume_client.volumes.get("},{"line_number":1193,"context_line":"                        self.instance.volume_id)"},{"line_number":1194,"context_line":"                    if volume.status \u003d\u003d \u0027extending\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_f58d47d4","line":1191,"updated":"2014-08-21 14:19:18.000000000","message":"missing period","commit_id":"048f9496c542f15947fce4b8f3deba101930132c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"561970dbcb4dc5ee2c5175bb9e8bbdc46f7e9f8c","unresolved":false,"context_lines":[{"line_number":1199,"context_line":"                else:"},{"line_number":1200,"context_line":"                    LOG.exception(_(\"Error encountered trying to verify extend\""},{"line_number":1201,"context_line":"                                    \" for the volume %(vol_id)s for instance \""},{"line_number":1202,"context_line":"                                    \"%(id)s\") % {"},{"line_number":1203,"context_line":"                                        \u0027vol_id\u0027: self.instance.volume_id,"},{"line_number":1204,"context_line":"                                        \u0027id\u0027: self.instance.id})"},{"line_number":1205,"context_line":"                    self._recover_full(self._verify_extend)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_b5ae6f2c","line":1202,"updated":"2014-08-21 14:19:18.000000000","message":"missing period","commit_id":"048f9496c542f15947fce4b8f3deba101930132c"}],"trove/tests/unittests/taskmanager/test_models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7d24c9523099142da4ccfe04993a88b9a946424d","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        self.instance.reset_mock()"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    def test_resize_volume_verify_extend_no_volume_and_double_exceptions(self):"},{"line_number":411,"context_line":"        # Raise cinder_exceptions.ClientException() by volume \u003d None."},{"line_number":412,"context_line":"        self.instance.volume_client.volumes.get \u003d MagicMock(return_value\u003dNone)"},{"line_number":413,"context_line":"        # Raise RuntimeError() from self._recover_full() in the"},{"line_number":414,"context_line":"        # exception handler."}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_8e62b0d7","line":411,"updated":"2014-06-24 12:34:59.000000000","message":"as for me, this comments are not required and actually not needed here","commit_id":"1f32504e71030cb1b50aa245ffc46c0536f15052"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7d24c9523099142da4ccfe04993a88b9a946424d","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        # Raise cinder_exceptions.ClientException() by volume \u003d None."},{"line_number":412,"context_line":"        self.instance.volume_client.volumes.get \u003d MagicMock(return_value\u003dNone)"},{"line_number":413,"context_line":"        # Raise RuntimeError() from self._recover_full() in the"},{"line_number":414,"context_line":"        # exception handler."},{"line_number":415,"context_line":"        self.action._recover_full \u003d MagicMock("},{"line_number":416,"context_line":"            side_effect\u003dRuntimeError(\"test exception\"))"},{"line_number":417,"context_line":"        # We expect the exception of the second time."}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_ae5f6c0e","line":414,"updated":"2014-06-24 12:34:59.000000000","message":"same","commit_id":"1f32504e71030cb1b50aa245ffc46c0536f15052"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7d24c9523099142da4ccfe04993a88b9a946424d","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        # exception handler."},{"line_number":415,"context_line":"        self.action._recover_full \u003d MagicMock("},{"line_number":416,"context_line":"            side_effect\u003dRuntimeError(\"test exception\"))"},{"line_number":417,"context_line":"        # We expect the exception of the second time."},{"line_number":418,"context_line":"        self.assertRaises(RuntimeError, self.action._verify_extend)"},{"line_number":419,"context_line":"        self.instance.reset_mock()"},{"line_number":420,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_ce5cb81c","line":417,"updated":"2014-06-24 12:34:59.000000000","message":"same","commit_id":"1f32504e71030cb1b50aa245ffc46c0536f15052"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7d24c9523099142da4ccfe04993a88b9a946424d","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        self.instance.reset_mock()"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def test_resize_volume_poll_timeout_and_double_exceptions(self):"},{"line_number":431,"context_line":"        # Raise PollTimeOut() from utils.poll_until()."},{"line_number":432,"context_line":"        utils.poll_until \u003d MagicMock(side_effect\u003dPollTimeOut)"},{"line_number":433,"context_line":"        # Raise RuntimeError() from self._recover_full() in the"},{"line_number":434,"context_line":"        # exception handler."}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_ee9894ce","line":431,"updated":"2014-06-24 12:34:59.000000000","message":"same","commit_id":"1f32504e71030cb1b50aa245ffc46c0536f15052"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7d24c9523099142da4ccfe04993a88b9a946424d","unresolved":false,"context_lines":[{"line_number":430,"context_line":"    def test_resize_volume_poll_timeout_and_double_exceptions(self):"},{"line_number":431,"context_line":"        # Raise PollTimeOut() from utils.poll_until()."},{"line_number":432,"context_line":"        utils.poll_until \u003d MagicMock(side_effect\u003dPollTimeOut)"},{"line_number":433,"context_line":"        # Raise RuntimeError() from self._recover_full() in the"},{"line_number":434,"context_line":"        # exception handler."},{"line_number":435,"context_line":"        self.action._recover_full \u003d MagicMock("},{"line_number":436,"context_line":"            side_effect\u003dRuntimeError(\"test exception\"))"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_2ea35c01","line":433,"updated":"2014-06-24 12:34:59.000000000","message":"same","commit_id":"1f32504e71030cb1b50aa245ffc46c0536f15052"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7d24c9523099142da4ccfe04993a88b9a946424d","unresolved":false,"context_lines":[{"line_number":610,"context_line":"        self.stub_verifying_server.status \u003d \u0027ACTIVE\u0027"},{"line_number":611,"context_line":"        with patch.object(self.instance_task._nova_client.servers, \u0027get\u0027,"},{"line_number":612,"context_line":"                          return_value\u003dself.stub_verifying_server):"},{"line_number":613,"context_line":"            # Raise RuntimeError() from self.instance.guest.restart()."},{"line_number":614,"context_line":"            self.instance_task._guest.restart \u003d MagicMock("},{"line_number":615,"context_line":"                side_effect\u003dRuntimeError(\"test exception\"))"},{"line_number":616,"context_line":"            # We expect the exception of the second time."}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_4ea8a8db","line":613,"updated":"2014-06-24 12:34:59.000000000","message":"same","commit_id":"1f32504e71030cb1b50aa245ffc46c0536f15052"}]}