)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"124795651bc5270a5e85e91656b9aae7ed0840d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b6ad731a_560bb418","updated":"2022-09-02 07:05:39.000000000","message":"Hi Wu! Could you please check this too? m(_ _)m","commit_id":"9ef5fc0e55ff058f1163253b907fc7e58a366d1e"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"83a4ce222495f626486baab10b08e920fb7b4e71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c9334dd3_4fe45c1d","updated":"2023-10-25 12:33:39.000000000","message":"Hello Wu, Thanks for the review!","commit_id":"c167159c4a95506f5c72671c9e8d6d59869666cc"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"cd82999d54af1192ba439afe78dfcdfe66a94712","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"058bed17_a71a5c29","in_reply_to":"c9334dd3_4fe45c1d","updated":"2023-10-25 14:32:07.000000000","message":"you are welcome.","commit_id":"c167159c4a95506f5c72671c9e8d6d59869666cc"}],"trove/taskmanager/models.py":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"5b222381b5a733f31484e19d982395ffefe9233c","unresolved":true,"context_lines":[{"line_number":221,"context_line":"        \"\"\"Wait for all instances to become ACTIVE.\"\"\""},{"line_number":222,"context_line":"        return self._all_instances_acquire_status("},{"line_number":223,"context_line":"            instance_ids, cluster_id, shard_id,"},{"line_number":224,"context_line":"            srvstatus.ServiceStatuses.HEALTHY,"},{"line_number":225,"context_line":"            fast_fail_statuses\u003d["},{"line_number":226,"context_line":"                srvstatus.ServiceStatuses.FAILED,"},{"line_number":227,"context_line":"                srvstatus.ServiceStatuses.FAILED_TIMEOUT_GUESTAGENT"}],"source_content_type":"text/x-python","patch_set":2,"id":"f77430d0_c5752371","line":224,"updated":"2022-09-07 02:02:23.000000000","message":"Hi, HEALTHY status means the instance is functional, but, this function seems just expected ACTIVE status. I think both HEALTH or RUNNING should be consider as ACTIVE status.","commit_id":"9ef5fc0e55ff058f1163253b907fc7e58a366d1e"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"c33391d2e732b9ce763bf7e8d29ae43b143871c6","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        \"\"\"Wait for all instances to become ACTIVE.\"\"\""},{"line_number":222,"context_line":"        return self._all_instances_acquire_status("},{"line_number":223,"context_line":"            instance_ids, cluster_id, shard_id,"},{"line_number":224,"context_line":"            srvstatus.ServiceStatuses.HEALTHY,"},{"line_number":225,"context_line":"            fast_fail_statuses\u003d["},{"line_number":226,"context_line":"                srvstatus.ServiceStatuses.FAILED,"},{"line_number":227,"context_line":"                srvstatus.ServiceStatuses.FAILED_TIMEOUT_GUESTAGENT"}],"source_content_type":"text/x-python","patch_set":2,"id":"4c99abd9_a63aacae","line":224,"in_reply_to":"f77430d0_c5752371","updated":"2022-09-16 10:54:10.000000000","message":"Hi Wu! I added `_all_instances_healthy` method to check if all instances are healthy.","commit_id":"9ef5fc0e55ff058f1163253b907fc7e58a366d1e"}]}