)]}'
{"devstack/settings":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"fbb112261785434353f040db958429c525a05a3e","unresolved":true,"context_lines":[{"line_number":90,"context_line":"TROVE_DATABASE_IMAGE_MYSQL\u003d${TROVE_DATABASE_IMAGE_MYSQL:-\"mysql\"}"},{"line_number":91,"context_line":"TROVE_DATABASE_IMAGE_POSTGRES\u003d${TROVE_DATABASE_IMAGE_POSTGRES:-\"postgres\"}"},{"line_number":92,"context_line":"TROVE_DATABASE_BACKUP_IMAGE_MYSQL\u003d${TROVE_DATABASE_BACKUP_IMAGE_MYSQL:-\"openstacktrove/db-backup-mysql:1.1.0\"}"},{"line_number":93,"context_line":"TROVE_DATABASE_BACKUP_IMAGE_POSTGRES\u003d${TROVE_DATABASE_BACKUP_IMAGE_POSTGRES:-\"openstacktrove/db-backup-postgresql:1.1.2\"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"2927f2c1_6930f026","line":93,"updated":"2022-11-09 11:42:02.000000000","message":"LGTM, but openstacktrove organization is still no maintained by trove-team. I would like to build those images in our CI?","commit_id":"4f04f0abc82ed18eb13ba79937595f3dd06600c5"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"0c4fe2d36ced2007f0bad627f754a240d387dc32","unresolved":true,"context_lines":[{"line_number":90,"context_line":"TROVE_DATABASE_IMAGE_MYSQL\u003d${TROVE_DATABASE_IMAGE_MYSQL:-\"mysql\"}"},{"line_number":91,"context_line":"TROVE_DATABASE_IMAGE_POSTGRES\u003d${TROVE_DATABASE_IMAGE_POSTGRES:-\"postgres\"}"},{"line_number":92,"context_line":"TROVE_DATABASE_BACKUP_IMAGE_MYSQL\u003d${TROVE_DATABASE_BACKUP_IMAGE_MYSQL:-\"openstacktrove/db-backup-mysql:1.1.0\"}"},{"line_number":93,"context_line":"TROVE_DATABASE_BACKUP_IMAGE_POSTGRES\u003d${TROVE_DATABASE_BACKUP_IMAGE_POSTGRES:-\"openstacktrove/db-backup-postgresql:1.1.2\"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"cf61414a_835bc133","line":93,"in_reply_to":"2927f2c1_6930f026","updated":"2022-11-10 02:54:55.000000000","message":"Hi Wu, Thanks for your reply! I think we should apply the Docker-Sponsored Open Source Program[1] and create a new organization maintained by trove-team.\n\n---\n[1]: https://www.docker.com/community/open-source/application/","commit_id":"4f04f0abc82ed18eb13ba79937595f3dd06600c5"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"85843b277f9f5ebfc33f920c98ab301a0d2afcc4","unresolved":false,"context_lines":[{"line_number":90,"context_line":"TROVE_DATABASE_IMAGE_MYSQL\u003d${TROVE_DATABASE_IMAGE_MYSQL:-\"mysql\"}"},{"line_number":91,"context_line":"TROVE_DATABASE_IMAGE_POSTGRES\u003d${TROVE_DATABASE_IMAGE_POSTGRES:-\"postgres\"}"},{"line_number":92,"context_line":"TROVE_DATABASE_BACKUP_IMAGE_MYSQL\u003d${TROVE_DATABASE_BACKUP_IMAGE_MYSQL:-\"openstacktrove/db-backup-mysql:1.1.0\"}"},{"line_number":93,"context_line":"TROVE_DATABASE_BACKUP_IMAGE_POSTGRES\u003d${TROVE_DATABASE_BACKUP_IMAGE_POSTGRES:-\"openstacktrove/db-backup-postgresql:1.1.2\"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"aa6954b0_cff7fd91","line":93,"in_reply_to":"9bbc4a48_5c327ecc","updated":"2022-12-08 03:24:15.000000000","message":"Hi Wu! Thanks you very much for your comment!\n\nI will abandon this patch because we should not require external resources(accounts) other than our openstack infrastructure to maintain our code.\n\nThe current problem is that Trove users currently use the Trove docker images[1] on DockerHub that are not maintained by us when they install Trove by devstack[2].\n\nSo, I will provide another patch for the Trove devstack plugin script[3] to use Trove docker images on a docker private repository when installing Trove.\n\n---\n[1]: https://github.com/openstack/trove/blob/master/devstack/settings#L90-L93\n[2]: https://docs.openstack.org/trove/latest/install/install-devstack.html\n[3]: https://github.com/openstack/trove/blob/master/devstack/plugin.sh","commit_id":"4f04f0abc82ed18eb13ba79937595f3dd06600c5"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"5705746c4f193a2676e10db75f4d1d58e753d2ec","unresolved":false,"context_lines":[{"line_number":90,"context_line":"TROVE_DATABASE_IMAGE_MYSQL\u003d${TROVE_DATABASE_IMAGE_MYSQL:-\"mysql\"}"},{"line_number":91,"context_line":"TROVE_DATABASE_IMAGE_POSTGRES\u003d${TROVE_DATABASE_IMAGE_POSTGRES:-\"postgres\"}"},{"line_number":92,"context_line":"TROVE_DATABASE_BACKUP_IMAGE_MYSQL\u003d${TROVE_DATABASE_BACKUP_IMAGE_MYSQL:-\"openstacktrove/db-backup-mysql:1.1.0\"}"},{"line_number":93,"context_line":"TROVE_DATABASE_BACKUP_IMAGE_POSTGRES\u003d${TROVE_DATABASE_BACKUP_IMAGE_POSTGRES:-\"openstacktrove/db-backup-postgresql:1.1.2\"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"bd63757c_6e985d59","line":93,"in_reply_to":"aa6954b0_cff7fd91","updated":"2022-12-08 03:32:29.000000000","message":"Hi，I have added one , could you help review it? https://review.opendev.org/c/openstack/trove/+/865221.  currently, the docker registry should be ok, it passed in CI","commit_id":"4f04f0abc82ed18eb13ba79937595f3dd06600c5"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"acf924a1252febf914586ab1ede2d72918e9e4a5","unresolved":true,"context_lines":[{"line_number":90,"context_line":"TROVE_DATABASE_IMAGE_MYSQL\u003d${TROVE_DATABASE_IMAGE_MYSQL:-\"mysql\"}"},{"line_number":91,"context_line":"TROVE_DATABASE_IMAGE_POSTGRES\u003d${TROVE_DATABASE_IMAGE_POSTGRES:-\"postgres\"}"},{"line_number":92,"context_line":"TROVE_DATABASE_BACKUP_IMAGE_MYSQL\u003d${TROVE_DATABASE_BACKUP_IMAGE_MYSQL:-\"openstacktrove/db-backup-mysql:1.1.0\"}"},{"line_number":93,"context_line":"TROVE_DATABASE_BACKUP_IMAGE_POSTGRES\u003d${TROVE_DATABASE_BACKUP_IMAGE_POSTGRES:-\"openstacktrove/db-backup-postgresql:1.1.2\"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9bbc4a48_5c327ecc","line":93,"in_reply_to":"cf61414a_835bc133","updated":"2022-11-29 11:36:54.000000000","message":"Hi, sorry, I am not familiar with Docker-Sponsored organizations.Currently, I build images in our CI system And run a local registry in our devstack deployment so that we can get a functional environment for our testing. if you think docker organization is more convenient, free to do that, thanks very much.","commit_id":"4f04f0abc82ed18eb13ba79937595f3dd06600c5"}]}