)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c11e640dc4e550711a985462acd2f5b6d23ede08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2acb438c_5e0ab890","updated":"2022-11-11 13:17:57.000000000","message":"Hi Hirotaka, could you help review this PS? This ps adds a periodic job  to pull/build and push images to local registry, after that, we compress the docker registry files and publish to tarball.openstack.org. with this tarball, we can install a local registry in our devstack deployment ","commit_id":"c9089a381ce81856148f3434d1b810f252b1ca69"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"9fde9b05208570fd6908a8a0539213275fc6756a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fc5907a9_da01a937","updated":"2022-11-18 02:15:32.000000000","message":"yes, you are right. thanks.","commit_id":"c9089a381ce81856148f3434d1b810f252b1ca69"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"80be9fa06debd91ae015e907340b8b3bba86baf7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ce8514b1_d29fc59e","updated":"2022-11-21 00:14:07.000000000","message":"Hi Wu! LGTM, Thank you for updating the patch.","commit_id":"5a960b37a463984aea3fff078e8fcb5ccd85a949"}],"playbooks/image-build/docker-registry.yaml":[{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"5b4178028966324d54826aa39c38359e0a3085fa","unresolved":true,"context_lines":[{"line_number":28,"context_line":"        - \"mysql:8.0\""},{"line_number":29,"context_line":"        - \"mariadb:10.4\""},{"line_number":30,"context_line":"        - \"postgres:12\""},{"line_number":31,"context_line":"    - name: Build mysql 5.7 backup image"},{"line_number":32,"context_line":"      become: true"},{"line_number":33,"context_line":"      shell: docker build -t 127.0.0.1:5000/trove-datastores/db-backup-mysql:5.7 ."},{"line_number":34,"context_line":"      args:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"85b63af9_3514d414","line":31,"updated":"2022-11-15 04:40:26.000000000","message":"Hello Wu! LGTM but I think the backup docker image name of `mysql` should be \u0027127.0.0.1:5000/trove-datastores/db-backup-mysql8.0:1.1.0\u0027 or something like that.\n\nPlease see:\nhttps://opendev.org/openstack/trove/src/branch/master/trove/guestagent/datastore/mysql/service.py#L63-L76\n\nTest code to simulate the lines above:\n```\n\u003e\u003e\u003e import semantic_version\n\u003e\u003e\u003e image \u003d \u0027127.0.0.1:5000/trove-datastores/db-backup-mysql:1.1.0\u0027\t\t#  `backup_docker_image` value in trove-guestagent.conf\n\u003e\u003e\u003e name, tag \u003d image.rsplit(\u0027:\u0027, 1)\n\u003e\u003e\u003e cur_ver \u003d semantic_version.Version.coerce(\u00278.0\u0027)\n\u003e\u003e\u003e minor_ver \u003d f\"{cur_ver.major}.{cur_ver.minor}\"\n\u003e\u003e\u003e return_str \u003d f\"{name}{minor_ver}:{tag}\"\n\u003e\u003e\u003e return_str\n\u0027127.0.0.1:5000/trove-datastores/db-backup-mysql8.0:1.1.0\u0027\t\t\t#  `docker tag and `docker push` image name\n```","commit_id":"c9089a381ce81856148f3434d1b810f252b1ca69"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"9fde9b05208570fd6908a8a0539213275fc6756a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        - \"mysql:8.0\""},{"line_number":29,"context_line":"        - \"mariadb:10.4\""},{"line_number":30,"context_line":"        - \"postgres:12\""},{"line_number":31,"context_line":"    - name: Build mysql 5.7 backup image"},{"line_number":32,"context_line":"      become: true"},{"line_number":33,"context_line":"      shell: docker build -t 127.0.0.1:5000/trove-datastores/db-backup-mysql:5.7 ."},{"line_number":34,"context_line":"      args:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"a147da02_8081d4f2","line":31,"in_reply_to":"85b63af9_3514d414","updated":"2022-11-18 02:15:32.000000000","message":"Done","commit_id":"c9089a381ce81856148f3434d1b810f252b1ca69"}]}