)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"c11d05b6e9a7939aeeb372598a984b2960817f6c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"provide a custom guest implmenentation without affecting the"},{"line_number":14,"context_line":"existing impls and taskmanager. This is also an effort to better"},{"line_number":15,"context_line":"define the contract between the guest and the taskmanager."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"partially implements: blueprint refactoring-datastore-options-in-cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: If0f6f375aa74e6ac40a5ccefd0a6b2b0e7e04ab0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"baada198_e9ee7321","line":16,"updated":"2014-07-18 17:14:46.000000000","message":"Can you please add hub_cap as a co-author on the patch since you\u0027re changing the Author in the git commit? Thanks!","commit_id":"83581760e7d1ecb74351f484f169faf7fcec0c72"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e87c8782b9345b4fac1401ac3e82cb5fac672f03","unresolved":false,"context_lines":[{"line_number":13,"context_line":"provide a custom guest implmenentation without affecting the"},{"line_number":14,"context_line":"existing impls and taskmanager. This is also an effort to better"},{"line_number":15,"context_line":"define the contract between the guest and the taskmanager."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"partially implements: blueprint refactoring-datastore-options-in-cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: If0f6f375aa74e6ac40a5ccefd0a6b2b0e7e04ab0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"baada198_d5e04799","line":16,"in_reply_to":"baada198_e9ee7321","updated":"2014-07-20 03:29:42.000000000","message":"Nikhil, I\u0027ve not been able to find any indication of how to do this other than to put a Co-Author: with his name.","commit_id":"83581760e7d1ecb74351f484f169faf7fcec0c72"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"fb327138d61cd5d90b15e03faeed6606d5c1c0dc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Amrith Kumar \u003camrith@tesora.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-12-16 16:42:05 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removal of uneeded guest mount_point from taskmgr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In an effort to promote a better seperation of concerns between"},{"line_number":10,"context_line":"the taskmanager and the guest impls, the mount_point was identifed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"da86d52c_e24ebec0","line":7,"updated":"2015-02-03 01:29:21.000000000","message":"unneeded instead of uneeded :)","commit_id":"7a72d87277bd4e84b7425a17fb3d9e844a924347"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"fb327138d61cd5d90b15e03faeed6606d5c1c0dc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removal of uneeded guest mount_point from taskmgr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In an effort to promote a better seperation of concerns between"},{"line_number":10,"context_line":"the taskmanager and the guest impls, the mount_point was identifed"},{"line_number":11,"context_line":"as a field the taskmanager didnt actually use. By removing the"},{"line_number":12,"context_line":"mount_point from the taskmanager, we are closer to being able to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"da86d52c_22c8d621","line":9,"updated":"2015-02-03 01:29:21.000000000","message":"separation","commit_id":"7a72d87277bd4e84b7425a17fb3d9e844a924347"}],"trove/guestagent/api.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"8b3194d6e36e8b4f577e2f8d1a254e9e761b9e56","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    def mount_volume(self, device_path\u003dNone):"},{"line_number":292,"context_line":"        \"\"\"Mount the volume.\"\"\""},{"line_number":293,"context_line":"        LOG.debug(\"Mount volume on instance %(id)s\" % {"},{"line_number":294,"context_line":"            \u0027id\u0027: self.id})"},{"line_number":295,"context_line":"        self._call(\"mount_volume\", AGENT_LOW_TIMEOUT,"},{"line_number":296,"context_line":"                   device_path\u003ddevice_path)"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_a4b26004","line":294,"updated":"2014-07-16 05:07:14.000000000","message":"this now can fit in one line","commit_id":"83581760e7d1ecb74351f484f169faf7fcec0c72"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ab3eaf55c305b8106c40059dccdb7d0efbafba10","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        return self._call(\"get_diagnostics\", AGENT_LOW_TIMEOUT)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    def prepare(self, memory_mb, packages, databases, users,"},{"line_number":217,"context_line":"                device_path\u003d\u0027/dev/vdb\u0027, backup_info\u003dNone,"},{"line_number":218,"context_line":"                config_contents\u003dNone, root_password\u003dNone, overrides\u003dNone,"},{"line_number":219,"context_line":"                cluster_config\u003dNone):"},{"line_number":220,"context_line":"        \"\"\"Make an asynchronous call to prepare the guest"}],"source_content_type":"text/x-python","patch_set":17,"id":"baa201ad_78604e01","line":217,"updated":"2014-10-17 01:53:22.000000000","message":"this breaks the contract.","commit_id":"ad2267f7077b99542c6db146b80a7fd84da65a41"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"079f5419da8f281aa5f6d062e9ce6427939957d5","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        return self._call(\"get_diagnostics\", AGENT_LOW_TIMEOUT)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    def prepare(self, memory_mb, packages, databases, users,"},{"line_number":217,"context_line":"                device_path\u003d\u0027/dev/vdb\u0027, backup_info\u003dNone,"},{"line_number":218,"context_line":"                config_contents\u003dNone, root_password\u003dNone, overrides\u003dNone,"},{"line_number":219,"context_line":"                cluster_config\u003dNone):"},{"line_number":220,"context_line":"        \"\"\"Make an asynchronous call to prepare the guest"}],"source_content_type":"text/x-python","patch_set":17,"id":"baa201ad_64f0a091","line":217,"in_reply_to":"baa201ad_78604e01","updated":"2014-10-17 12:14:14.000000000","message":"Will revert signature and add an error if mount_point is provided.","commit_id":"ad2267f7077b99542c6db146b80a7fd84da65a41"}],"trove/guestagent/datastore/cassandra/manager.py":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"c11d05b6e9a7939aeeb372598a984b2960817f6c","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":60,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":61,"context_line":"                root_password\u003dNone, overrides\u003dNone):"},{"line_number":62,"context_line":"        LOG.info(_(\"Setting status BUILDING\"))"},{"line_number":63,"context_line":"        self.appStatus.begin_install()"},{"line_number":64,"context_line":"        LOG.info(\"Installing cassandra\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_4e0cc542","line":61,"updated":"2014-07-18 17:14:46.000000000","message":"I suggest we don\u0027t change the prepare call signature for backwards compatibility reasons. Otherwise it\u0027s possible for a new guest to choke on a message from an older taskmanager during an upgrade. We can remove the value completely next cycle.\n\n(Just to clarify, all the actual changes below function are good, just leave the function signature unaltered)","commit_id":"83581760e7d1ecb74351f484f169faf7fcec0c72"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e87c8782b9345b4fac1401ac3e82cb5fac672f03","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":60,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":61,"context_line":"                root_password\u003dNone, overrides\u003dNone):"},{"line_number":62,"context_line":"        LOG.info(_(\"Setting status BUILDING\"))"},{"line_number":63,"context_line":"        self.appStatus.begin_install()"},{"line_number":64,"context_line":"        LOG.info(\"Installing cassandra\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_f5dd4bde","line":61,"in_reply_to":"baada198_4e0cc542","updated":"2014-07-20 03:29:42.000000000","message":"Done","commit_id":"83581760e7d1ecb74351f484f169faf7fcec0c72"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ec7e10a832aa5cf36fb66fb45d3127b199075d62","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.app.reset_configuration(configuration)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":60,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":61,"context_line":"                root_password\u003dNone, overrides\u003dNone, mount_point\u003dNone):"},{"line_number":62,"context_line":"        if mount_point:"},{"line_number":63,"context_line":"            LOG.debug(\"The mount_point option is deprecated.\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_10b64ddc","line":60,"updated":"2014-07-20 06:10:50.000000000","message":"Please revert changes in method signature","commit_id":"a0e4274634645ce3f3b8edf95919a49a5ebfdd4e"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b7dcebf99ce436bbb3a7851f411dfac58d397f67","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.app.reset_configuration(configuration)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":60,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":61,"context_line":"                root_password\u003dNone, overrides\u003dNone, mount_point\u003dNone):"},{"line_number":62,"context_line":"        if mount_point:"},{"line_number":63,"context_line":"            LOG.debug(\"The mount_point option is deprecated.\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_79c77512","line":60,"in_reply_to":"baada198_10b64ddc","updated":"2014-07-20 11:34:25.000000000","message":"I did. mount_point\u003dNone is again part of the signature.","commit_id":"a0e4274634645ce3f3b8edf95919a49a5ebfdd4e"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ec7e10a832aa5cf36fb66fb45d3127b199075d62","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":60,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":61,"context_line":"                root_password\u003dNone, overrides\u003dNone, mount_point\u003dNone):"},{"line_number":62,"context_line":"        if mount_point:"},{"line_number":63,"context_line":"            LOG.debug(\"The mount_point option is deprecated.\")"},{"line_number":64,"context_line":"        LOG.info(_(\"Setting status BUILDING\"))"},{"line_number":65,"context_line":"        self.appStatus.begin_install()"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_f0d399fe","line":62,"updated":"2014-07-20 06:10:50.000000000","message":"This notification should be a part of Guest API  usage. Please move it into api.py","commit_id":"a0e4274634645ce3f3b8edf95919a49a5ebfdd4e"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b7dcebf99ce436bbb3a7851f411dfac58d397f67","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":60,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":61,"context_line":"                root_password\u003dNone, overrides\u003dNone, mount_point\u003dNone):"},{"line_number":62,"context_line":"        if mount_point:"},{"line_number":63,"context_line":"            LOG.debug(\"The mount_point option is deprecated.\")"},{"line_number":64,"context_line":"        LOG.info(_(\"Setting status BUILDING\"))"},{"line_number":65,"context_line":"        self.appStatus.begin_install()"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_99cc4937","line":62,"in_reply_to":"baada198_f0d399fe","updated":"2014-07-20 11:34:25.000000000","message":"Can\u0027t do that because api.py no longer uses mount_point in the prepare() call.","commit_id":"a0e4274634645ce3f3b8edf95919a49a5ebfdd4e"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"518376d2c14e43cea3cf1b4012b1d6ac13b57dd1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def reset_configuration(self, context, configuration):"},{"line_number":57,"context_line":"        self.app.reset_configuration(configuration)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":60,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":61,"context_line":"                root_password\u003dNone, overrides\u003dNone, mount_point\u003dNone):"},{"line_number":62,"context_line":"        if mount_point:"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_5f97df8f","line":59,"updated":"2014-07-21 11:46:57.000000000","message":"Nothing changed.\n\nSignature should be (take a look at arguments order):\n\nSee https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/cassandra/manager.py#L61-L63","commit_id":"e47b4fa6d0dcb446a4549eca8e25fe42ccc38be8"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6f554a89a3ce85b828c61e8726e6af2a1a973bd1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def reset_configuration(self, context, configuration):"},{"line_number":57,"context_line":"        self.app.reset_configuration(configuration)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":60,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":61,"context_line":"                root_password\u003dNone, overrides\u003dNone, mount_point\u003dNone):"},{"line_number":62,"context_line":"        if mount_point:"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_619ccc0f","line":59,"in_reply_to":"baada198_1e152d4c","updated":"2014-07-22 09:12:14.000000000","message":"Will revert. I didn\u0027t find any such calls in the code base but in theory there could be code (not in Trove) that someone wrote, that would break.","commit_id":"e47b4fa6d0dcb446a4549eca8e25fe42ccc38be8"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"4723c32b3e1db036265a8e06681bee9a388deaf8","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def reset_configuration(self, context, configuration):"},{"line_number":57,"context_line":"        self.app.reset_configuration(configuration)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":60,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":61,"context_line":"                root_password\u003dNone, overrides\u003dNone, mount_point\u003dNone):"},{"line_number":62,"context_line":"        if mount_point:"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_f6ab6e85","line":59,"in_reply_to":"baada198_5f97df8f","updated":"2014-07-21 17:31:15.000000000","message":"the order is changed, yes. That doesn\u0027t change the signature, does it?","commit_id":"e47b4fa6d0dcb446a4549eca8e25fe42ccc38be8"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"90c58d1c63cb47ad06ae249f43fe980e62bc58ab","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def reset_configuration(self, context, configuration):"},{"line_number":57,"context_line":"        self.app.reset_configuration(configuration)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":60,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":61,"context_line":"                root_password\u003dNone, overrides\u003dNone, mount_point\u003dNone):"},{"line_number":62,"context_line":"        if mount_point:"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_1e152d4c","line":59,"in_reply_to":"baada198_f6ab6e85","updated":"2014-07-22 09:02:48.000000000","message":"It depends on whether any calls are being made to this function treating the kwargs as positional args. Consider this example:\n\n \u003e\u003e\u003e def foo(a\u003d1, b\u003d2):\n ...   print a\n ...   print b\n ...\n \u003e\u003e\u003e foo(3, 4)\n 3\n 4\n \u003e\u003e\u003e def foo(b\u003d2, a\u003d1):\n ...   print a\n ...   print b\n ...\n \u003e\u003e\u003e foo(3, 4)\n 4\n 3\n\nIf kwargs are always used as kwargs, this shouldn\u0027t matter, but since python does allow you to supply positional args for your kwarg list, it\u0027s probably safest to leave the order of the kwargs unchanged in the function definition.\n\nHope this makes sense.","commit_id":"e47b4fa6d0dcb446a4549eca8e25fe42ccc38be8"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"7cfff8d31da51dbaf19efc6318e62581dc6a7da8","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                config_contents\u003dNone, root_password\u003dNone, overrides\u003dNone,"},{"line_number":62,"context_line":"                cluster_config\u003dNone):"},{"line_number":63,"context_line":"        if mount_point:"},{"line_number":64,"context_line":"            LOG.debug(\"The mount_point option is deprecated.\")"},{"line_number":65,"context_line":"        LOG.info(_(\"Setting status of instance to BUILDING.\"))"},{"line_number":66,"context_line":"        self.appStatus.begin_install()"},{"line_number":67,"context_line":"        LOG.debug(\"Installing cassandra.\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"baa201ad_81d908f5","line":64,"range":{"start_line":64,"start_character":16,"end_line":64,"end_character":21},"updated":"2014-10-07 14:18:16.000000000","message":"This really should be a warning as it indicates that a feature has changed. It is typical to run with debug off and this message would not be seen.","commit_id":"57fc95d08ce980fa05e2053c063848159369484a"}],"trove/guestagent/datastore/couchbase/manager.py":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"c11d05b6e9a7939aeeb372598a984b2960817f6c","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":59,"context_line":"                device_path\u003dNone, backup_info\u003dNone,"},{"line_number":60,"context_line":"                config_contents\u003dNone, root_password\u003dNone, overrides\u003dNone):"},{"line_number":61,"context_line":"        \"\"\""},{"line_number":62,"context_line":"        This is called when the trove instance first comes online."},{"line_number":63,"context_line":"        It is the first rpc message passed from the task manager."}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_29a78b0c","line":60,"updated":"2014-07-18 17:14:46.000000000","message":"Same comment about not changing this function signature.","commit_id":"83581760e7d1ecb74351f484f169faf7fcec0c72"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e87c8782b9345b4fac1401ac3e82cb5fac672f03","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":59,"context_line":"                device_path\u003dNone, backup_info\u003dNone,"},{"line_number":60,"context_line":"                config_contents\u003dNone, root_password\u003dNone, overrides\u003dNone):"},{"line_number":61,"context_line":"        \"\"\""},{"line_number":62,"context_line":"        This is called when the trove instance first comes online."},{"line_number":63,"context_line":"        It is the first rpc message passed from the task manager."}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_15ee3f8b","line":60,"in_reply_to":"baada198_29a78b0c","updated":"2014-07-20 03:29:42.000000000","message":"Done","commit_id":"83581760e7d1ecb74351f484f169faf7fcec0c72"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"518376d2c14e43cea3cf1b4012b1d6ac13b57dd1","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":59,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":60,"context_line":"                root_password\u003dNone, overrides\u003dNone, mount_point\u003dNone):"},{"line_number":61,"context_line":"        \"\"\""},{"line_number":62,"context_line":"        This is called when the trove instance first comes online."},{"line_number":63,"context_line":"        It is the first rpc message passed from the task manager."}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_df384fa2","line":60,"updated":"2014-07-21 11:46:57.000000000","message":"Nothing changed.\n\nSignature should be (take a look at arguments order):\n\nSee https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/couchbase/manager.py#L60-L62","commit_id":"e47b4fa6d0dcb446a4549eca8e25fe42ccc38be8"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"4723c32b3e1db036265a8e06681bee9a388deaf8","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":59,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":60,"context_line":"                root_password\u003dNone, overrides\u003dNone, mount_point\u003dNone):"},{"line_number":61,"context_line":"        \"\"\""},{"line_number":62,"context_line":"        This is called when the trove instance first comes online."},{"line_number":63,"context_line":"        It is the first rpc message passed from the task manager."}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_167d421c","line":60,"in_reply_to":"baada198_df384fa2","updated":"2014-07-21 17:31:15.000000000","message":"the order is changed, yes. That doesn\u0027t change the signature, does it?","commit_id":"e47b4fa6d0dcb446a4549eca8e25fe42ccc38be8"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"7cfff8d31da51dbaf19efc6318e62581dc6a7da8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        prepare handles all the base configuration of the Couchbase instance."},{"line_number":68,"context_line":"        \"\"\""},{"line_number":69,"context_line":"        if mount_point:"},{"line_number":70,"context_line":"            LOG.debug(\"The mount_point option is deprecated.\")"},{"line_number":71,"context_line":"        self.appStatus.begin_install()"},{"line_number":72,"context_line":"        self.app.install_if_needed(packages)"},{"line_number":73,"context_line":"        if device_path:"}],"source_content_type":"text/x-python","patch_set":14,"id":"baa201ad_01f51856","line":70,"updated":"2014-10-07 14:18:16.000000000","message":"warning","commit_id":"57fc95d08ce980fa05e2053c063848159369484a"}],"trove/guestagent/datastore/mongodb/manager.py":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"c11d05b6e9a7939aeeb372598a984b2960817f6c","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":45,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":46,"context_line":"                root_password\u003dNone, overrides\u003dNone):"},{"line_number":47,"context_line":"        \"\"\"Makes ready DBAAS on a Guest container.\"\"\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        LOG.debug(\"Prepare MongoDB instance\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_69ac23ee","line":46,"updated":"2014-07-18 17:14:46.000000000","message":"Same comment about not changing this function signature.","commit_id":"83581760e7d1ecb74351f484f169faf7fcec0c72"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e87c8782b9345b4fac1401ac3e82cb5fac672f03","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":45,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":46,"context_line":"                root_password\u003dNone, overrides\u003dNone):"},{"line_number":47,"context_line":"        \"\"\"Makes ready DBAAS on a Guest container.\"\"\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        LOG.debug(\"Prepare MongoDB instance\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_35f34374","line":46,"in_reply_to":"baada198_69ac23ee","updated":"2014-07-20 03:29:42.000000000","message":"Done","commit_id":"83581760e7d1ecb74351f484f169faf7fcec0c72"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"518376d2c14e43cea3cf1b4012b1d6ac13b57dd1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \"\"\"Update the status of the MongoDB service.\"\"\""},{"line_number":42,"context_line":"        self.status.update()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":45,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":46,"context_line":"                root_password\u003dNone, overrides\u003dNone, mount_point\u003dNone):"},{"line_number":47,"context_line":"        \"\"\"Makes ready DBAAS on a Guest container.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_5f4c3f42","line":44,"updated":"2014-07-21 11:46:57.000000000","message":"Nothing changed.\n\nPlease revert signature \n\nSee https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/mongodb/manager.py#L45-L47","commit_id":"e47b4fa6d0dcb446a4549eca8e25fe42ccc38be8"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"4723c32b3e1db036265a8e06681bee9a388deaf8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \"\"\"Update the status of the MongoDB service.\"\"\""},{"line_number":42,"context_line":"        self.status.update()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":45,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":46,"context_line":"                root_password\u003dNone, overrides\u003dNone, mount_point\u003dNone):"},{"line_number":47,"context_line":"        \"\"\"Makes ready DBAAS on a Guest container.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_766e7e65","line":44,"in_reply_to":"baada198_5f4c3f42","updated":"2014-07-21 17:31:15.000000000","message":"the order is changed, yes. That doesn\u0027t change the signature, does it?","commit_id":"e47b4fa6d0dcb446a4549eca8e25fe42ccc38be8"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"7cfff8d31da51dbaf19efc6318e62581dc6a7da8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                cluster_config\u003dNone):"},{"line_number":50,"context_line":"        \"\"\"Makes ready DBAAS on a Guest container.\"\"\""},{"line_number":51,"context_line":"        if mount_point:"},{"line_number":52,"context_line":"            LOG.debug(\"The mount_point option is deprecated.\")"},{"line_number":53,"context_line":"        LOG.debug(\"Prepare MongoDB instance\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.status.begin_install()"}],"source_content_type":"text/x-python","patch_set":14,"id":"baa201ad_61050445","line":52,"updated":"2014-10-07 14:18:16.000000000","message":"warning","commit_id":"57fc95d08ce980fa05e2053c063848159369484a"}],"trove/guestagent/datastore/mysql/manager.py":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"c11d05b6e9a7939aeeb372598a984b2960817f6c","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":109,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":110,"context_line":"                root_password\u003dNone, overrides\u003dNone):"},{"line_number":111,"context_line":"        \"\"\"Makes ready DBAAS on a Guest container.\"\"\""},{"line_number":112,"context_line":"        MySqlAppStatus.get().begin_install()"},{"line_number":113,"context_line":"        # status end_mysql_install set with secure()"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_e987535f","line":110,"updated":"2014-07-18 17:14:46.000000000","message":"Same comment about not changing this function signature.","commit_id":"83581760e7d1ecb74351f484f169faf7fcec0c72"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e87c8782b9345b4fac1401ac3e82cb5fac672f03","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":109,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":110,"context_line":"                root_password\u003dNone, overrides\u003dNone):"},{"line_number":111,"context_line":"        \"\"\"Makes ready DBAAS on a Guest container.\"\"\""},{"line_number":112,"context_line":"        MySqlAppStatus.get().begin_install()"},{"line_number":113,"context_line":"        # status end_mysql_install set with secure()"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_55e437a7","line":110,"in_reply_to":"baada198_e987535f","updated":"2014-07-20 03:29:42.000000000","message":"Done","commit_id":"83581760e7d1ecb74351f484f169faf7fcec0c72"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"518376d2c14e43cea3cf1b4012b1d6ac13b57dd1","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            raise"},{"line_number":106,"context_line":"        LOG.info(_(\"Restored database successfully\"))"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":109,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":110,"context_line":"                root_password\u003dNone, overrides\u003dNone, mount_point\u003dNone):"},{"line_number":111,"context_line":"        \"\"\"Makes ready DBAAS on a Guest container.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_7f6e6397","line":108,"updated":"2014-07-21 11:46:57.000000000","message":"Same,\nsee https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/mysql/manager.py#L108-L110","commit_id":"e47b4fa6d0dcb446a4549eca8e25fe42ccc38be8"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"4723c32b3e1db036265a8e06681bee9a388deaf8","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            raise"},{"line_number":106,"context_line":"        LOG.info(_(\"Restored database successfully\"))"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":109,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":110,"context_line":"                root_password\u003dNone, overrides\u003dNone, mount_point\u003dNone):"},{"line_number":111,"context_line":"        \"\"\"Makes ready DBAAS on a Guest container.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_b693b64d","line":108,"in_reply_to":"baada198_7f6e6397","updated":"2014-07-21 17:31:15.000000000","message":"the order is changed, yes. That doesn\u0027t change the signature, does it?","commit_id":"e47b4fa6d0dcb446a4549eca8e25fe42ccc38be8"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"7cfff8d31da51dbaf19efc6318e62581dc6a7da8","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                cluster_config\u003dNone):"},{"line_number":117,"context_line":"        \"\"\"Makes ready DBAAS on a Guest container.\"\"\""},{"line_number":118,"context_line":"        if mount_point:"},{"line_number":119,"context_line":"            LOG.debug(\"The mount_point option is deprecated.\")"},{"line_number":120,"context_line":"        MySqlAppStatus.get().begin_install()"},{"line_number":121,"context_line":"        # status end_mysql_install set with secure()"},{"line_number":122,"context_line":"        app \u003d MySqlApp(MySqlAppStatus.get())"}],"source_content_type":"text/x-python","patch_set":14,"id":"baa201ad_c1f6b05c","line":119,"updated":"2014-10-07 14:18:16.000000000","message":"warning","commit_id":"57fc95d08ce980fa05e2053c063848159369484a"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"6205e9f0bc4bbb540088948a58f47fb7f083d874","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            self._perform_restore(backup_info, context,"},{"line_number":140,"context_line":"                                  MOUNT_POINT, app)"},{"line_number":141,"context_line":"        LOG.debug(\"Securing MySQL now.\")"},{"line_number":142,"context_line":"        LOG.info(_(\"Securing mysql now.\"))"},{"line_number":143,"context_line":"        app.secure(config_contents, overrides)"},{"line_number":144,"context_line":"        enable_root_on_restore \u003d (backup_info and"},{"line_number":145,"context_line":"                                  MySqlAdmin().is_root_enabled())"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_78b575cc","line":142,"updated":"2014-10-18 03:47:42.000000000","message":"you accidentally have two \"security mysql now\" statements.","commit_id":"ce0f1c9d27913b14986cf521f88127b7f31ce330"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"af33c8845e12d775f3e0fdf01f5823457edc0829","unresolved":false,"context_lines":[{"line_number":39,"context_line":"REPLICATION_NAMESPACE \u003d CONF.get(MANAGER).replication_namespace"},{"line_number":40,"context_line":"REPLICATION_STRATEGY_CLASS \u003d get_replication_strategy(REPLICATION_STRATEGY,"},{"line_number":41,"context_line":"                                                      REPLICATION_NAMESPACE)"},{"line_number":42,"context_line":"MOUNT_POINT \u003d CONF.mysql.mount_point"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class Manager(periodic_task.PeriodicTasks):"}],"source_content_type":"text/x-python","patch_set":23,"id":"3a961159_cd2df4ff","line":42,"updated":"2014-12-23 11:41:50.000000000","message":"MOUNT_POINT \u003d CONF.get(MANAGER).mount_point","commit_id":"7a72d87277bd4e84b7425a17fb3d9e844a924347"}],"trove/guestagent/datastore/redis/manager.py":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"c11d05b6e9a7939aeeb372598a984b2960817f6c","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":73,"context_line":"                device_path\u003dNone, backup_info\u003dNone,"},{"line_number":74,"context_line":"                config_contents\u003dNone, root_password\u003dNone, overrides\u003dNone):"},{"line_number":75,"context_line":"        \"\"\""},{"line_number":76,"context_line":"        This is called when the trove instance first comes online."},{"line_number":77,"context_line":"        It is the first rpc message passed from the task manager."}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_297eab6a","line":74,"updated":"2014-07-18 17:14:46.000000000","message":"Same comment about not changing this function signature.","commit_id":"83581760e7d1ecb74351f484f169faf7fcec0c72"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e87c8782b9345b4fac1401ac3e82cb5fac672f03","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":73,"context_line":"                device_path\u003dNone, backup_info\u003dNone,"},{"line_number":74,"context_line":"                config_contents\u003dNone, root_password\u003dNone, overrides\u003dNone):"},{"line_number":75,"context_line":"        \"\"\""},{"line_number":76,"context_line":"        This is called when the trove instance first comes online."},{"line_number":77,"context_line":"        It is the first rpc message passed from the task manager."}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_75e93b7e","line":74,"in_reply_to":"baada198_297eab6a","updated":"2014-07-20 03:29:42.000000000","message":"Done","commit_id":"83581760e7d1ecb74351f484f169faf7fcec0c72"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"518376d2c14e43cea3cf1b4012b1d6ac13b57dd1","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        raise exception.DatastoreOperationNotSupported("},{"line_number":70,"context_line":"            operation\u003d\u0027_perform_restore\u0027, datastore\u003dMANAGER)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":73,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":74,"context_line":"                root_password\u003dNone, overrides\u003dNone, mount_point\u003dNone):"},{"line_number":75,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_1f0d67e8","line":72,"updated":"2014-07-21 11:46:57.000000000","message":"Same. \nSee https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/redis/manager.py#L72-L74","commit_id":"e47b4fa6d0dcb446a4549eca8e25fe42ccc38be8"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"4723c32b3e1db036265a8e06681bee9a388deaf8","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        raise exception.DatastoreOperationNotSupported("},{"line_number":70,"context_line":"            operation\u003d\u0027_perform_restore\u0027, datastore\u003dMANAGER)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def prepare(self, context, packages, databases, memory_mb, users,"},{"line_number":73,"context_line":"                device_path\u003dNone, backup_info\u003dNone, config_contents\u003dNone,"},{"line_number":74,"context_line":"                root_password\u003dNone, overrides\u003dNone, mount_point\u003dNone):"},{"line_number":75,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_16a462a4","line":72,"in_reply_to":"baada198_1f0d67e8","updated":"2014-07-21 17:31:15.000000000","message":"the order is changed, yes. That doesn\u0027t change the signature, does it?","commit_id":"e47b4fa6d0dcb446a4549eca8e25fe42ccc38be8"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"7cfff8d31da51dbaf19efc6318e62581dc6a7da8","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        prepare handles all the base configuration of the redis instance."},{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        if mount_point:"},{"line_number":82,"context_line":"            LOG.debug(\"The mount_point option is deprecated.\")"},{"line_number":83,"context_line":"        try:"},{"line_number":84,"context_line":"            app \u003d RedisApp(RedisAppStatus.get())"},{"line_number":85,"context_line":"            RedisAppStatus.get().begin_install()"}],"source_content_type":"text/x-python","patch_set":14,"id":"baa201ad_219f7c04","line":82,"updated":"2014-10-07 14:18:16.000000000","message":"warning","commit_id":"57fc95d08ce980fa05e2053c063848159369484a"}],"trove/taskmanager/models.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"6205e9f0bc4bbb540088948a58f47fb7f083d874","unresolved":false,"context_lines":[{"line_number":477,"context_line":"            err \u003d inst_models.InstanceTasks.BUILDING_ERROR_SERVER"},{"line_number":478,"context_line":"            self._log_and_raise(e, msg, err)"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        device_path \u003d self.device_path"},{"line_number":481,"context_line":"        mount_point \u003d CONF.get(datastore_manager).mount_point"},{"line_number":482,"context_line":"        volume_info \u003d {\u0027device_path\u0027: device_path, \u0027mount_point\u0027: mount_point}"},{"line_number":483,"context_line":"        LOG.debug(\"End _create_server_volume for id: %s\" % self.id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_f8d7a5eb","line":480,"updated":"2014-10-18 03:47:42.000000000","message":"unless i\u0027m missing something, the mount_point logic here could be removed, because it isn\u0027t sent in prepare() any longer.","commit_id":"ce0f1c9d27913b14986cf521f88127b7f31ce330"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"6205e9f0bc4bbb540088948a58f47fb7f083d874","unresolved":false,"context_lines":[{"line_number":581,"context_line":"            err \u003d inst_models.InstanceTasks.BUILDING_ERROR_SERVER"},{"line_number":582,"context_line":"            self._log_and_raise(e, msg, err)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        device_path \u003d self.device_path"},{"line_number":585,"context_line":"        mount_point \u003d CONF.get(datastore_manager).mount_point"},{"line_number":586,"context_line":"        volume_info \u003d {\u0027device_path\u0027: device_path, \u0027mount_point\u0027: mount_point}"},{"line_number":587,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_1804697d","line":584,"updated":"2014-10-18 03:47:42.000000000","message":"unless i\u0027m missing something, the mount_point logic here could be removed, because it isn\u0027t sent in prepare() any longer.","commit_id":"ce0f1c9d27913b14986cf521f88127b7f31ce330"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"6205e9f0bc4bbb540088948a58f47fb7f083d874","unresolved":false,"context_lines":[{"line_number":617,"context_line":"    def _build_volume_info(self, datastore_manager, volume_size\u003dNone):"},{"line_number":618,"context_line":"        volume_info \u003d None"},{"line_number":619,"context_line":"        volume_support \u003d self.volume_support"},{"line_number":620,"context_line":"        device_path \u003d self.device_path"},{"line_number":621,"context_line":"        mount_point \u003d CONF.get(datastore_manager).mount_point"},{"line_number":622,"context_line":"        LOG.debug(\"trove volume support \u003d %s\" % volume_support)"},{"line_number":623,"context_line":"        if volume_support:"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_7803b573","line":620,"updated":"2014-10-18 03:47:42.000000000","message":"unless i\u0027m missing something, the mount_point logic here could be removed, because it isn\u0027t sent in prepare() any longer.","commit_id":"ce0f1c9d27913b14986cf521f88127b7f31ce330"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"6205e9f0bc4bbb540088948a58f47fb7f083d874","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"        self.instance \u003d instance"},{"line_number":1170,"context_line":"        self.old_size \u003d int(old_size)"},{"line_number":1171,"context_line":"        self.new_size \u003d int(new_size)"},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":"    def get_mount_point(self):"},{"line_number":1174,"context_line":"        mount_point \u003d CONF.get("},{"line_number":1175,"context_line":"            self.instance.datastore_version.manager).mount_point"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_98f7798c","line":1172,"updated":"2014-10-18 03:47:42.000000000","message":"this method is now unused i believe.","commit_id":"ce0f1c9d27913b14986cf521f88127b7f31ce330"}],"trove/tests/unittests/guestagent/test_cassandra_manager.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"284bd05d8f7096bbad2ad03441fb1bd894964b46","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                             databases\u003dNone,"},{"line_number":130,"context_line":"                             memory_mb\u003d\u00272048\u0027, users\u003dNone,"},{"line_number":131,"context_line":"                             device_path\u003ddevice_path,"},{"line_number":132,"context_line":"                             mount_point\u003d\"/var/lib/cassandra\","},{"line_number":133,"context_line":"                             backup_info\u003dbackup_info,"},{"line_number":134,"context_line":"                             overrides\u003dNone)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_d0721511","side":"PARENT","line":132,"updated":"2014-07-20 06:17:25.000000000","message":"Please revert changes in tests","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b7dcebf99ce436bbb3a7851f411dfac58d397f67","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                             databases\u003dNone,"},{"line_number":130,"context_line":"                             memory_mb\u003d\u00272048\u0027, users\u003dNone,"},{"line_number":131,"context_line":"                             device_path\u003ddevice_path,"},{"line_number":132,"context_line":"                             mount_point\u003d\"/var/lib/cassandra\","},{"line_number":133,"context_line":"                             backup_info\u003dbackup_info,"},{"line_number":134,"context_line":"                             overrides\u003dNone)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_f9daa5e7","side":"PARENT","line":132,"in_reply_to":"baada198_d0721511","updated":"2014-07-20 11:34:25.000000000","message":"Why, the whole point is that we remove mount_point.","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"}],"trove/tests/unittests/guestagent/test_couchbase_manager.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"284bd05d8f7096bbad2ad03441fb1bd894964b46","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        #invocation"},{"line_number":84,"context_line":"        self.manager.prepare(self.context, self.packages, None, 2048,"},{"line_number":85,"context_line":"                             None, device_path\u003ddevice_path,"},{"line_number":86,"context_line":"                             mount_point\u003d\u0027/var/lib/couchbase\u0027,"},{"line_number":87,"context_line":"                             backup_info\u003dbackup_info)"},{"line_number":88,"context_line":"        #verification/assertion"},{"line_number":89,"context_line":"        mock_status.begin_install.assert_any_call()"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_30651145","side":"PARENT","line":86,"updated":"2014-07-20 06:17:25.000000000","message":"Same, parameter still exists, and you could show that difference between mount point in method parameters and conf option","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b7dcebf99ce436bbb3a7851f411dfac58d397f67","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        #invocation"},{"line_number":84,"context_line":"        self.manager.prepare(self.context, self.packages, None, 2048,"},{"line_number":85,"context_line":"                             None, device_path\u003ddevice_path,"},{"line_number":86,"context_line":"                             mount_point\u003d\u0027/var/lib/couchbase\u0027,"},{"line_number":87,"context_line":"                             backup_info\u003dbackup_info)"},{"line_number":88,"context_line":"        #verification/assertion"},{"line_number":89,"context_line":"        mock_status.begin_install.assert_any_call()"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_19d839ee","side":"PARENT","line":86,"in_reply_to":"baada198_30651145","updated":"2014-07-20 11:34:25.000000000","message":"sorry, that would be out of scope.","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"}],"trove/tests/unittests/guestagent/test_mongodb_manager.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"284bd05d8f7096bbad2ad03441fb1bd894964b46","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                             packages\u003d[\u0027package\u0027],"},{"line_number":88,"context_line":"                             memory_mb\u003d\u00272048\u0027, users\u003dNone,"},{"line_number":89,"context_line":"                             device_path\u003ddevice_path,"},{"line_number":90,"context_line":"                             mount_point\u003d\u0027/var/lib/mongodb\u0027,"},{"line_number":91,"context_line":"                             backup_info\u003dbackup_info)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # verification/assertion"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_705b0986","side":"PARENT","line":90,"updated":"2014-07-20 06:17:25.000000000","message":"Same","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b7dcebf99ce436bbb3a7851f411dfac58d397f67","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                             packages\u003d[\u0027package\u0027],"},{"line_number":88,"context_line":"                             memory_mb\u003d\u00272048\u0027, users\u003dNone,"},{"line_number":89,"context_line":"                             device_path\u003ddevice_path,"},{"line_number":90,"context_line":"                             mount_point\u003d\u0027/var/lib/mongodb\u0027,"},{"line_number":91,"context_line":"                             backup_info\u003dbackup_info)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # verification/assertion"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_39e17d9b","side":"PARENT","line":90,"in_reply_to":"baada198_705b0986","updated":"2014-07-20 11:34:25.000000000","message":"same answer.","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"21f580b6a87ad27d5ac372870ea6ade807bafb4e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        mock_app.install_if_needed.assert_any_call([\u0027package\u0027])"},{"line_number":96,"context_line":"        mock_app.stop_db.assert_any_call()"},{"line_number":97,"context_line":"        VolumeDevice.format.assert_any_call()"},{"line_number":98,"context_line":"        VolumeDevice.migrate_data.assert_any_call(\u0027/var/lib/mongodb\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_931dab65","side":"PARENT","line":98,"updated":"2014-07-22 11:53:50.000000000","message":"please revert this line","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"15e7287cca2f6aa44ddc4bf57a9f2558a203cff4","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        mock_app.install_if_needed.assert_any_call([\u0027package\u0027])"},{"line_number":96,"context_line":"        mock_app.stop_db.assert_any_call()"},{"line_number":97,"context_line":"        VolumeDevice.format.assert_any_call()"},{"line_number":98,"context_line":"        VolumeDevice.migrate_data.assert_any_call(\u0027/var/lib/mongodb\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_8a5f224d","side":"PARENT","line":98,"in_reply_to":"baada198_349cbb5b","updated":"2014-07-29 16:18:08.000000000","message":"No it does not. In the change set (this change set) the call is replaced by one which uses the config parameter and not the argument to the function.","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"5c4e846959a0baa1040b8778ae5c4c5232fff0cc","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        mock_app.install_if_needed.assert_any_call([\u0027package\u0027])"},{"line_number":96,"context_line":"        mock_app.stop_db.assert_any_call()"},{"line_number":97,"context_line":"        VolumeDevice.format.assert_any_call()"},{"line_number":98,"context_line":"        VolumeDevice.migrate_data.assert_any_call(\u0027/var/lib/mongodb\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_349cbb5b","side":"PARENT","line":98,"in_reply_to":"baada198_44636819","updated":"2014-07-29 15:32:25.000000000","message":"This call still exists at https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/mongodb/manager.py#L64\n\nSo, i don\u0027t see any reasons to drop this assert","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"93f7a180e74aa8e6b016b416bf682433fe589ec8","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        mock_app.install_if_needed.assert_any_call([\u0027package\u0027])"},{"line_number":96,"context_line":"        mock_app.stop_db.assert_any_call()"},{"line_number":97,"context_line":"        VolumeDevice.format.assert_any_call()"},{"line_number":98,"context_line":"        VolumeDevice.migrate_data.assert_any_call(\u0027/var/lib/mongodb\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_44636819","side":"PARENT","line":98,"in_reply_to":"baada198_931dab65","updated":"2014-07-28 19:29:27.000000000","message":"please explain why.","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"}],"trove/tests/unittests/guestagent/test_mysql_manager.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"284bd05d8f7096bbad2ad03441fb1bd894964b46","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                             databases\u003dNone,"},{"line_number":207,"context_line":"                             users\u003dNone,"},{"line_number":208,"context_line":"                             device_path\u003ddevice_path,"},{"line_number":209,"context_line":"                             mount_point\u003d\u0027/var/lib/mysql\u0027,"},{"line_number":210,"context_line":"                             backup_info\u003dbackup_info,"},{"line_number":211,"context_line":"                             overrides\u003doverrides)"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_b050415f","side":"PARENT","line":209,"updated":"2014-07-20 06:17:25.000000000","message":"Same","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b7dcebf99ce436bbb3a7851f411dfac58d397f67","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                             databases\u003dNone,"},{"line_number":207,"context_line":"                             users\u003dNone,"},{"line_number":208,"context_line":"                             device_path\u003ddevice_path,"},{"line_number":209,"context_line":"                             mount_point\u003d\u0027/var/lib/mysql\u0027,"},{"line_number":210,"context_line":"                             backup_info\u003dbackup_info,"},{"line_number":211,"context_line":"                             overrides\u003doverrides)"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_99f36972","side":"PARENT","line":209,"in_reply_to":"baada198_b050415f","updated":"2014-07-20 11:34:25.000000000","message":"same answer","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"}],"trove/tests/unittests/guestagent/test_redis_manager.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"284bd05d8f7096bbad2ad03441fb1bd894964b46","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.manager.prepare(self.context, self.packages,"},{"line_number":92,"context_line":"                             None, \u00272048\u0027,"},{"line_number":93,"context_line":"                             None, device_path\u003ddevice_path,"},{"line_number":94,"context_line":"                             mount_point\u003dmount_point,"},{"line_number":95,"context_line":"                             backup_info\u003dbackup_info)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        self.assertEqual(redis_service.RedisAppStatus.get.call_count, 2)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_d04935b9","side":"PARENT","line":94,"updated":"2014-07-20 06:17:25.000000000","message":"Same","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b7dcebf99ce436bbb3a7851f411dfac58d397f67","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.manager.prepare(self.context, self.packages,"},{"line_number":92,"context_line":"                             None, \u00272048\u0027,"},{"line_number":93,"context_line":"                             None, device_path\u003ddevice_path,"},{"line_number":94,"context_line":"                             mount_point\u003dmount_point,"},{"line_number":95,"context_line":"                             backup_info\u003dbackup_info)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        self.assertEqual(redis_service.RedisAppStatus.get.call_count, 2)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_b9e4ada8","side":"PARENT","line":94,"in_reply_to":"baada198_d04935b9","updated":"2014-07-20 11:34:25.000000000","message":"same answer","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"284bd05d8f7096bbad2ad03441fb1bd894964b46","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        VolumeDevice.format.assert_any_call()"},{"line_number":100,"context_line":"        redis_service.RedisApp.install_if_needed.assert_any_call(self.packages)"},{"line_number":101,"context_line":"        redis_service.RedisApp.write_config.assert_any_call(None)"},{"line_number":102,"context_line":"        operating_system.update_owner.assert_any_call("},{"line_number":103,"context_line":"            \u0027redis\u0027, \u0027redis\u0027, mount_point)"},{"line_number":104,"context_line":"        redis_service.RedisApp.restart.assert_any_call()"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_f04639a6","side":"PARENT","line":102,"updated":"2014-07-20 06:17:25.000000000","message":"Why it was dropped?","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b7dcebf99ce436bbb3a7851f411dfac58d397f67","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        VolumeDevice.format.assert_any_call()"},{"line_number":100,"context_line":"        redis_service.RedisApp.install_if_needed.assert_any_call(self.packages)"},{"line_number":101,"context_line":"        redis_service.RedisApp.write_config.assert_any_call(None)"},{"line_number":102,"context_line":"        operating_system.update_owner.assert_any_call("},{"line_number":103,"context_line":"            \u0027redis\u0027, \u0027redis\u0027, mount_point)"},{"line_number":104,"context_line":"        redis_service.RedisApp.restart.assert_any_call()"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_d9e96180","side":"PARENT","line":102,"in_reply_to":"baada198_f04639a6","updated":"2014-07-20 11:34:25.000000000","message":"because mount_point parameter was removed.","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"405c539a97895b8a843b380758e9b467fa41a857","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        VolumeDevice.format.assert_any_call()"},{"line_number":100,"context_line":"        redis_service.RedisApp.install_if_needed.assert_any_call(self.packages)"},{"line_number":101,"context_line":"        redis_service.RedisApp.write_config.assert_any_call(None)"},{"line_number":102,"context_line":"        operating_system.update_owner.assert_any_call("},{"line_number":103,"context_line":"            \u0027redis\u0027, \u0027redis\u0027, mount_point)"},{"line_number":104,"context_line":"        redis_service.RedisApp.restart.assert_any_call()"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_f33347f5","side":"PARENT","line":102,"updated":"2014-07-22 11:54:18.000000000","message":"same, please revert this change","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"15e7287cca2f6aa44ddc4bf57a9f2558a203cff4","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        VolumeDevice.format.assert_any_call()"},{"line_number":100,"context_line":"        redis_service.RedisApp.install_if_needed.assert_any_call(self.packages)"},{"line_number":101,"context_line":"        redis_service.RedisApp.write_config.assert_any_call(None)"},{"line_number":102,"context_line":"        operating_system.update_owner.assert_any_call("},{"line_number":103,"context_line":"            \u0027redis\u0027, \u0027redis\u0027, mount_point)"},{"line_number":104,"context_line":"        redis_service.RedisApp.restart.assert_any_call()"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_4a7d0ab2","side":"PARENT","line":102,"in_reply_to":"baada198_14cdf75e","updated":"2014-07-29 16:18:08.000000000","message":"No it does not. In the change set (this change set) the call is replaced by one which uses the config parameter and not the argument to the function.","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"5c4e846959a0baa1040b8778ae5c4c5232fff0cc","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        VolumeDevice.format.assert_any_call()"},{"line_number":100,"context_line":"        redis_service.RedisApp.install_if_needed.assert_any_call(self.packages)"},{"line_number":101,"context_line":"        redis_service.RedisApp.write_config.assert_any_call(None)"},{"line_number":102,"context_line":"        operating_system.update_owner.assert_any_call("},{"line_number":103,"context_line":"            \u0027redis\u0027, \u0027redis\u0027, mount_point)"},{"line_number":104,"context_line":"        redis_service.RedisApp.restart.assert_any_call()"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_14cdf75e","side":"PARENT","line":102,"in_reply_to":"baada198_846900fa","updated":"2014-07-29 15:32:25.000000000","message":"Same as previous comment,\nsee https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/redis/manager.py#L89","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"93f7a180e74aa8e6b016b416bf682433fe589ec8","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        VolumeDevice.format.assert_any_call()"},{"line_number":100,"context_line":"        redis_service.RedisApp.install_if_needed.assert_any_call(self.packages)"},{"line_number":101,"context_line":"        redis_service.RedisApp.write_config.assert_any_call(None)"},{"line_number":102,"context_line":"        operating_system.update_owner.assert_any_call("},{"line_number":103,"context_line":"            \u0027redis\u0027, \u0027redis\u0027, mount_point)"},{"line_number":104,"context_line":"        redis_service.RedisApp.restart.assert_any_call()"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_846900fa","side":"PARENT","line":102,"in_reply_to":"baada198_f33347f5","updated":"2014-07-28 19:29:27.000000000","message":"please explain why","commit_id":"68e04dc5f6f5f73e0fe544d88b9849cab3b39df7"}]}