)]}'
{"trove/common/cfg.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"daf931ea0d00314b46a5bc267689b259e112e28b","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                    \u0027max_header_line may need to be increased when using \u0027"},{"line_number":253,"context_line":"                    \u0027large tokens (typically those generated by the \u0027"},{"line_number":254,"context_line":"                    \u0027Keystone v3 API with big service catalogs\u0027),"},{"line_number":255,"context_line":"    cfg.DictOpt(\u0027security_group_tcp_ports\u0027,"},{"line_number":256,"context_line":"                default\u003d{\u0027mysql\u0027: [\u00273306\u0027],"},{"line_number":257,"context_line":"                         \u0027percona\u0027: [\u00273306\u0027],"},{"line_number":258,"context_line":"                         \u0027mongodb\u0027: [\u00272500\u0027, \u002727017\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2Ffpw%3D","line":255,"updated":"2014-04-14 08:35:03.000000000","message":"As for me this variant is not applicapable because if i want to extend number of the ports for any datastore i would need to mention all other datastores which seems completely superfluous. I\u0027d suggest another wayh of the refactoring of this part of the code:\n\n1. Separate config definers for trove-api, -taskmanager, -conductor and guestagent. I should be like:\n - trove/common/cfg.py for trove-api, -taskmanager, -conductor\n\n - guestagent/common/cfg.py for guestagent\n\n2. Ports should be left as they are in trove/common/cfg.py\n\n3. Guestagent should start with his own options definer:\n - instead of\n   https://github.com/openstack/trove/blob/master/trove/cmd/guest.py#L27 \n   should be trove/guestagent/common/cfg.py\n\nEventually, it\u0027s totally bad idea to use dict options for this kind of config attribute.","commit_id":"a50d754124ef9427ed8a3a7de7a02c6035e829a4"}]}