)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"2fb3e86e112009dec805123c08afec8b3cb13814","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"50e0500b_84bb463e","updated":"2023-02-09 05:47:25.000000000","message":"We need to discuss on which MariaDB version Trove supports. \n\nFYI: \nUbuntu focal includes mariadb-server-10.3.x.\nhttps://packages.ubuntu.com/focal/mariadb-server\n\nUbuntu jammy includes mariadb-server-10.6.x.\nhttps://packages.ubuntu.com/jammy/mariadb-server\n","commit_id":"f7b431ea6508b1808bb1294c9db01ac8514625f3"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b920db796c96cbab6d64df9d3a683ffc7b0f53a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7d859a49_a2f05a96","in_reply_to":"50e0500b_84bb463e","updated":"2023-02-28 14:52:38.000000000","message":"refer to https://hub.docker.com/_/mariadb, mariadb is now supported from 10.3 to 10.11, I would like to support mariadb 10.3 only in trove, but If you are interested in maintaining 10.6 in trove. It\u0027s also ok for me.","commit_id":"f7b431ea6508b1808bb1294c9db01ac8514625f3"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"98adffafadbff04bfca3696395e0052f66a7d65c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d3aadbd8_828b96f9","in_reply_to":"7d859a49_a2f05a96","updated":"2023-04-09 17:42:28.000000000","message":"Hello Wu! Thank you for your feedback. I have changed the `install.sh` script because I think we should avoid hardcoding of datastore versions. Here are examples of how to call the script in `docker build`.\n\nmysql-5.7\n```\n$ head -n 5 Dockerfile \nFROM ubuntu:18.04\nLABEL maintainer\u003d\"anlin.kong@gmail.com\"\n\nARG DATASTORE\u003d\"mysql\"\nARG DATASTORE_VERSION\u003d\"5.7\"\n$ DATABASE_BACKUP_VERSION\u003d1.1.2\n$ docker build -t testuser/db-backup-mysql:${DATABASE_BACKUP_VERSION} .\n...\n \u003d\u003e [6/7] RUN ./install.sh --datastore mysql --datastore-version 5.7  \n...\n```\n\nmariadb-10.7.8\n```\n$ head -n 5 Dockerfile \nFROM ubuntu:18.04\nLABEL maintainer\u003d\"anlin.kong@gmail.com\"\n\nARG DATASTORE\u003d\"mariadb\"\nARG DATASTORE_VERSION\u003d\"10.7.8\"\n$ DATABASE_BACKUP_VERSION\u003d1.1.2\n$ docker build -t testuser/db-backup-mariadb:${DATABASE_BACKUP_VERSION} .\n...\n \u003d\u003e [6/7] RUN ./install.sh --datastore mariadb --datastore-version 10.7.8\n...\n```\n\npostgresql-12.14\n```\n$ head -n 5 Dockerfile \nFROM ubuntu:18.04\nLABEL maintainer\u003d\"anlin.kong@gmail.com\"\n\nARG DATASTORE\u003d\"postgresql\"\nARG DATASTORE_VERSION\u003d\"12.14\"\n$ docker build -t testuser/db-backup-postgresql:${DATABASE_BACKUP_VERSION} .\n...\n \u003d\u003e [6/7] RUN ./install.sh --datastore postgresql --datastore-version 12.14\n...\n```","commit_id":"f7b431ea6508b1808bb1294c9db01ac8514625f3"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"5710b24d688818c3e3a48438168fbd4c8e930e30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"41f9f03d_498f3bdb","updated":"2023-04-10 01:38:19.000000000","message":"I think we shouldn\u0027t break other logic of trove. So I want this problem being handled by me. Let give it to me.","commit_id":"f595857f872349e6457a95ae808c59b11df51997"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"c4c22614714029d59f894d6ef472432141e18e3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7c181a2b_ccd87641","in_reply_to":"047e94ee_81d0a97c","updated":"2023-04-11 01:57:36.000000000","message":"`I think compatibility is really important for us` - I accept with your opinion but I think we shouldn\u0027t break logic of trove when bootstrap a database instance.\nWe shouldn\u0027t focus to resolved the problems and ignore some common case and other datastores. It just make trove more complicated","commit_id":"f595857f872349e6457a95ae808c59b11df51997"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"32b8111becaf015b3504a913590d18f362218712","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"047e94ee_81d0a97c","in_reply_to":"41f9f03d_498f3bdb","updated":"2023-04-10 15:30:44.000000000","message":"Hi Bo! Thanks for your feedback. I fixed the script because I think compatibility is really important for us.","commit_id":"f595857f872349e6457a95ae808c59b11df51997"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"12fc59b2f93e98b05f787eaea5f83cdad0a9e9e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"184f9988_99d6dc07","in_reply_to":"7c181a2b_ccd87641","updated":"2023-04-12 15:25:18.000000000","message":"Hi Bo, Thanks for your feedback!\n\n\u003e I think we shouldn\u0027t break logic of trove when bootstrap a database instance.\n\nI think my latest patch doesn\u0027t break the current logic.\n\n\u003e We shouldn\u0027t focus to resolved the problems and ignore some common case and other datastores.\n\nI think we should support more MariaDB versions because MariaDB is one of the famous open source RDB like.The other OpenStack services also support MariaDB[1]. Let\u0027s make Trove better! I will maintain the code in Trove at least.:)\n\n\u003e It just make trove more complicated\n\nWe should not be afraid to add new features or maintain compatibility for fear of complications. Because every product can be getting complicated when adding new features as well as preserving existing features for compatibility. \n\nEspecially when we will break compatibility, the feature (or API, or configuration option) should be marked deprecated (and still be supported) in at least one “tick” release branch, and for at least 12 months of releases.[2]\n\n--\n1: https://docs.openstack.org/install-guide/environment-sql-database.html\n2: https://docs.openstack.org/project-team-guide/deprecation.html","commit_id":"f595857f872349e6457a95ae808c59b11df51997"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"0ab4ec86ef1b0c222cd232b9236b3e9847807872","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fc417358_a08d6cf8","updated":"2023-04-14 09:05:46.000000000","message":"Hi Wu and Bo, chould you please check this?","commit_id":"fb5bac6e467ba867eb8ab287490ccc96cc3f9af5"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"35e84d7866d504ce7cacd53ad397d1c01ba20def","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8697b959_a3ea485c","in_reply_to":"6c01bd23_532626fb","updated":"2023-04-18 09:52:45.000000000","message":"Adding a new datastore needs more tests. we don\u0027t have any test for 10.7  especially the backup part. I would Add a datastore support matrix in our docs.","commit_id":"fb5bac6e467ba867eb8ab287490ccc96cc3f9af5"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"5f48cd8dc820c1b99727041797f9f9951c90b5c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0ecbd216_9850b56c","in_reply_to":"8697b959_a3ea485c","updated":"2023-04-18 23:25:40.000000000","message":"Thanks for the feedbacks!\n\n\u003e Adding a new datastore needs more tests. we don\u0027t have any test for 10.7 especially the backup part.\n\nYes, there are currently no tests for backup part but we should add tests for backup/install.sh and tests for each backup drivers as well.","commit_id":"fb5bac6e467ba867eb8ab287490ccc96cc3f9af5"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"3b282f15de6faaea1f7fe1e52e994c0b19ce5c54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6c01bd23_532626fb","in_reply_to":"fc417358_a08d6cf8","updated":"2023-04-15 03:54:53.000000000","message":"No, I will add new commit as soon as to support trove can support more version of any database.","commit_id":"fb5bac6e467ba867eb8ab287490ccc96cc3f9af5"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"79a9333aa228724dd95610387a9852b9d8a6321e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"8c66af77_6a50f0d4","updated":"2023-08-29 07:00:48.000000000","message":"Fixed.","commit_id":"68e211f02212b0852e938718bdbbf31b612ae947"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"231fa7e4269604f0c860701fabb1af24a1107584","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"2dce172a_b6058f74","updated":"2023-08-29 09:14:44.000000000","message":"I need a carefully look before +w.","commit_id":"68e211f02212b0852e938718bdbbf31b612ae947"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3a9ccced23ae1df2dcf83bb7667b3b694d881376","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"a4f0b541_f47611f4","updated":"2023-08-29 08:55:50.000000000","message":"LGTM, CI passed.","commit_id":"68e211f02212b0852e938718bdbbf31b612ae947"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"d2576b418abc5b96c01817c24b97358f5f96d6ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"7b768721_4d6a899e","updated":"2023-09-12 01:24:03.000000000","message":"You should correct with title of commit: change \"MariadDB\" to \"MariaDB\"","commit_id":"ab618fc5fe01fce0688e4145b3496082ba50bf76"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"5c50eb773a30a9c7b399f13d6fbff1ec4e0f7d34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"40399a92_72b7dd05","updated":"2023-10-07 08:03:27.000000000","message":"LGTM, thanks.","commit_id":"1062b035ce91016ea85fc7bce8f00c3376c2db91"}],"backup/install.sh":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"baf4127c148ecefbfab28a8fb3f3d0745a10f8da","unresolved":true,"context_lines":[{"line_number":70,"context_line":"fi"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"if [ \"${OPT_DATASTORE}\" \u003d \"mysql\" ]; then"},{"line_number":73,"context_line":"\t# assign \"5.7\" for backward compatibility if "},{"line_number":74,"context_line":"\tif [ \"${OPT_DATASTORE_VERSION}\" \u003d \"5.7\" ]; then"},{"line_number":75,"context_line":"\t\tcurl -sSL https://repo.percona.com/apt/percona-release_latest.${OS_RELEASE_CODENAME}_all.deb -o percona-release.deb"},{"line_number":76,"context_line":"\t\tdpkg -i percona-release.deb"}],"source_content_type":"text/x-sh","patch_set":22,"id":"308a3f7c_3a9a32f2","line":73,"range":{"start_line":73,"start_character":43,"end_line":73,"end_character":45},"updated":"2023-08-29 13:26:44.000000000","message":"if ?","commit_id":"68e211f02212b0852e938718bdbbf31b612ae947"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"fb2eb9b0250bfae3ad4950ae6387405ae89d6e98","unresolved":false,"context_lines":[{"line_number":70,"context_line":"fi"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"if [ \"${OPT_DATASTORE}\" \u003d \"mysql\" ]; then"},{"line_number":73,"context_line":"\t# assign \"5.7\" for backward compatibility if "},{"line_number":74,"context_line":"\tif [ \"${OPT_DATASTORE_VERSION}\" \u003d \"5.7\" ]; then"},{"line_number":75,"context_line":"\t\tcurl -sSL https://repo.percona.com/apt/percona-release_latest.${OS_RELEASE_CODENAME}_all.deb -o percona-release.deb"},{"line_number":76,"context_line":"\t\tdpkg -i percona-release.deb"}],"source_content_type":"text/x-sh","patch_set":22,"id":"82070cd2_074055eb","line":73,"range":{"start_line":73,"start_character":43,"end_line":73,"end_character":45},"in_reply_to":"308a3f7c_3a9a32f2","updated":"2023-09-11 13:53:17.000000000","message":"Sorry, the comment is old memo. removed.","commit_id":"68e211f02212b0852e938718bdbbf31b612ae947"}],"trove/guestagent/datastore/mariadb/service.py":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"6f3890b23e934a7d8757ae767e91e85fe5c56388","unresolved":true,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import semantic_version"},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from trove.common import exception"},{"line_number":21,"context_line":"from trove.common import utils"}],"source_content_type":"text/x-python","patch_set":12,"id":"7b421962_1aa1a749","line":18,"in_reply_to":"7a3b7101_471c6609","updated":"2023-06-16 02:04:00.000000000","message":"\u003e pep8: H306: imports not in alphabetical order (semantic_version, oslo_log.log)\n\nPlease fix.","commit_id":"c6bf801f8ffa747442a8921d023b9f704e318bc8"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"4249c028ecc9004a84622026b3e00bd441b47f7a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import semantic_version"},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from trove.common import exception"},{"line_number":21,"context_line":"from trove.common import utils"}],"source_content_type":"text/x-python","patch_set":12,"id":"a95d5e77_63f71ea1","line":18,"in_reply_to":"7b421962_1aa1a749","updated":"2023-08-25 07:55:46.000000000","message":"Done","commit_id":"c6bf801f8ffa747442a8921d023b9f704e318bc8"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"6f3890b23e934a7d8757ae767e91e85fe5c56388","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        For example, this method converts"},{"line_number":90,"context_line":"        openstacktrove/db-backup-mariadb:1.0.0 to"},{"line_number":91,"context_line":"        openstacktrove/db-backup-mariadb10.7:1.0.0"},{"line_number":92,"context_line":"        \"\"\""},{"line_number":93,"context_line":"        image \u003d cfg.get_configuration_property(\u0027backup_docker_image\u0027)"},{"line_number":94,"context_line":"        name, tag \u003d image.rsplit(\u0027:\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":12,"id":"29cce94b_7ebbb025","line":91,"updated":"2023-06-16 02:04:00.000000000","message":"this change may break the user upgrade and our CI tests. we need add docs about this. and currently , our CI tests backup logic using this image, thus we also need to update the devstack install scripts and CI tests. refer to: https://github.com/openstack/trove/blob/master/playbooks/image-build/docker-registry.yaml#L46\nhttps://github.com/openstack/trove/blob/master/devstack/settings#L91","commit_id":"c6bf801f8ffa747442a8921d023b9f704e318bc8"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"79a9333aa228724dd95610387a9852b9d8a6321e","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        For example, this method converts"},{"line_number":90,"context_line":"        openstacktrove/db-backup-mariadb:1.0.0 to"},{"line_number":91,"context_line":"        openstacktrove/db-backup-mariadb10.7:1.0.0"},{"line_number":92,"context_line":"        \"\"\""},{"line_number":93,"context_line":"        image \u003d cfg.get_configuration_property(\u0027backup_docker_image\u0027)"},{"line_number":94,"context_line":"        name, tag \u003d image.rsplit(\u0027:\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7225ebe9_b88d1870","line":91,"in_reply_to":"29cce94b_7ebbb025","updated":"2023-08-29 07:00:48.000000000","message":"Done","commit_id":"c6bf801f8ffa747442a8921d023b9f704e318bc8"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"baf4127c148ecefbfab28a8fb3f3d0745a10f8da","unresolved":true,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        For example, this method converts"},{"line_number":91,"context_line":"        openstacktrove/db-backup-mariadb:1.0.0 to"},{"line_number":92,"context_line":"        openstacktrove/db-backup-mariadb10.7:1.0.0"},{"line_number":93,"context_line":"        \"\"\""},{"line_number":94,"context_line":"        image \u003d cfg.get_configuration_property(\u0027backup_docker_image\u0027)"},{"line_number":95,"context_line":"        name, tag \u003d image.rsplit(\u0027:\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":22,"id":"f743a342_8dfd5ac1","line":92,"updated":"2023-08-29 13:26:44.000000000","message":"as we don\u0027t have the mariadb CI test, i think this may break the backward compatibility, the previous user should config image like:openstacktrove/db-backup-mariadb:1.0.0, but for now, this should not work.\n\ni prefer to remove this part as there is anther commit doing this thing for all datastore","commit_id":"68e211f02212b0852e938718bdbbf31b612ae947"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"fb2eb9b0250bfae3ad4950ae6387405ae89d6e98","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        For example, this method converts"},{"line_number":91,"context_line":"        openstacktrove/db-backup-mariadb:1.0.0 to"},{"line_number":92,"context_line":"        openstacktrove/db-backup-mariadb10.7:1.0.0"},{"line_number":93,"context_line":"        \"\"\""},{"line_number":94,"context_line":"        image \u003d cfg.get_configuration_property(\u0027backup_docker_image\u0027)"},{"line_number":95,"context_line":"        name, tag \u003d image.rsplit(\u0027:\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":22,"id":"6e3a88c1_0de45b66","line":92,"in_reply_to":"f743a342_8dfd5ac1","updated":"2023-09-11 13:53:17.000000000","message":"Thanks for the comment, Fixed.\n\n\u003e i prefer to remove this part as there is anther commit doing this thing for all datastore","commit_id":"68e211f02212b0852e938718bdbbf31b612ae947"}]}